GNU bug report logs - #67034
30.0.50; Make `derived-mode-p` take a single arg

Previous Next

Package: emacs;

Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>

Date: Fri, 10 Nov 2023 04:00:02 UTC

Severity: normal

Found in version 30.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 67034 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 67034 <at> debbugs.gnu.org
Subject: Re: 30.0.50; Make `derived-mode-p` take a single arg
Date: Fri, 10 Nov 2023 13:18:32 +0100

This change would affect many packages. I grepped through my elpa
directory and found multiple uses of derived-mode-p and
provided-mode-derived-p with multiple arguments as shortcuts:

(derived-mode-p 'mode1 'mode2) instead of (or (derived-mode-p 'mode1)
(derived-mode-p 'mode2)

There are also multiple call sites with apply, but these would be
arguably nicer if derived-mode-p takes a list argument as proposed.
Still, do the benefits of this change outweigh the required changes?
This bug report was last modified 1 year and 182 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.