GNU bug report logs - #67034
30.0.50; Make `derived-mode-p` take a single arg

Previous Next

Package: emacs;

Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>

Date: Fri, 10 Nov 2023 04:00:02 UTC

Severity: normal

Found in version 30.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 67034 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Daniel Mendler <mail <at> daniel-mendler.de>, 67034 <at> debbugs.gnu.org
Subject: Re: bug#67034: 30.0.50; Make `derived-mode-p` take a single arg
Date: Sat, 11 Nov 2023 02:04:29 +0200

On 10/11/2023 14:18, Daniel Mendler wrote:
> There are also multiple call sites with apply, but these would be
> arguably nicer if derived-mode-p takes a list argument as proposed.
> Still, do the benefits of this change outweigh the required changes?

I've also found some call sites with multiple arguments (one of them 
being sml-mode 6.12) and also uses with (apply #'derived-mode-p 
some-user-option-list-of-modes). But those are indeed in the minority.

I wonder if this extra allocation of &rest makes any difference in any 
benchmark, though.
This bug report was last modified 1 year and 182 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.