GNU bug report logs - #67032
30.0.50; ERC 5.6-git: Treat erc-send-message more responsibly

Previous Next

Package: emacs;

Reported by: "J.P." <jp <at> neverwas.me>

Date: Fri, 10 Nov 2023 02:29:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: "J.P." <jp <at> neverwas.me>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "J.P." <jp <at> neverwas.me>
To: 67032 <at> debbugs.gnu.org
Cc: emacs-erc <at> gnu.org
Subject: bug#67032: 30.0.50; ERC 5.6-git: Treat erc-send-message more responsibly
Date: Thu, 28 Mar 2024 10:34:50 -0700
"J.P." <jp <at> neverwas.me> writes:

> One aspect this change should've addressed but didn't was using the
> revived `command-indicator' facility in `erc-load-irc-script-lines' to
> make its output more predictable and consistent with other displayed
> messages. While leaving it to rot would of course be safer, I suspect
> it's rarely used enough to warrant the risk. An ancillary benefit of
> fixing this is that it helps clarify the role of boolean return values
> for `erc-process-input-line', `erc-send-input-line-function',
> `erc-message', and the various `erc-cmd-FOO' slash-command handlers.
> See second patch (lacks tests).

This has been installed as

  a46789b56af * Reuse command-indicator code for script lines in ERC

This bug is already closed.




This bug report was last modified 1 year and 52 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.