GNU bug report logs - #67031
[PATCH] Fix typescript-ts-mode indentation in unbracketed statements

Previous Next

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: noah.v.peart <at> gmail.com, 67031 <at> debbugs.gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>
Subject: bug#67031: [PATCH] Fix typescript-ts-mode indentation in unbracketed statements
Date: Sat, 18 Nov 2023 20:26:36 -0800

> On Nov 18, 2023, at 2:05 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Date: Thu, 16 Nov 2023 03:18:44 +0200
>> Cc: 67031 <at> debbugs.gnu.org
>> From: Dmitry Gutov <dmitry <at> gutov.dev>
>> 
>> On 15/11/2023 15:40, Eli Zaretskii wrote:
>>>> From: nvp<noah.v.peart <at> gmail.com>
>>>> Date: Thu, 9 Nov 2023 17:29:21 -0800
>>>> 
>>>> Tags: patch
>>>> 
>>>> * lisp/progmodes/typescript-ts-mode.el
>>>> (typescript-ts-mode--indent-rules): fix indentation after statements
>>>> without brackets
>>>> 
>>>> Bug: There are no indentation rules for statement bodies following
>>>> if/for/for_in/do/while statements without brackets.
>>>> 
>>>> Recipe to reproduce:
>>>> In a `typescript-ts-mode` buffer with the following code,
>>>> 
>>>>     if (true)
>>>>     console.log('No indent here')
>>>> 
>>>> Try to indent the second line.
>>> Dmitry, Yuan: any comments?
>> 
>> I think it would be cool if the patch added a corresponding new case or 
>> two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts
> 
> Noah, would you please add such tests?
> 
> Yuan, any comments or suggestions?

LGTM, I’ll also add else_clause too, like

((parent-is ,(rx (or (seq (or "if" "for" "for_in" "while" "do") "_statement")
                     "else_clause")))
 parent-bol typescript-ts-mode-indent-offset)

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.