GNU bug report logs - #67031
[PATCH] Fix typescript-ts-mode indentation in unbracketed statements

Previous Next

Full log

Message #14 received at 67031 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: casouri <at> gmail.com, noah.v.peart <at> gmail.com, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 67031 <at> debbugs.gnu.org
Subject: Re: bug#67031: [PATCH] Fix typescript-ts-mode indentation in
 unbracketed statements
Date: Sat, 18 Nov 2023 12:05:43 +0200

> Date: Thu, 16 Nov 2023 03:18:44 +0200
> Cc: 67031 <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 15/11/2023 15:40, Eli Zaretskii wrote:
> >> From: nvp<noah.v.peart <at> gmail.com>
> >> Date: Thu, 9 Nov 2023 17:29:21 -0800
> >>
> >> Tags: patch
> >>
> >> * lisp/progmodes/typescript-ts-mode.el
> >> (typescript-ts-mode--indent-rules): fix indentation after statements
> >> without brackets
> >>
> >> Bug: There are no indentation rules for statement bodies following
> >> if/for/for_in/do/while statements without brackets.
> >>
> >> Recipe to reproduce:
> >> In a `typescript-ts-mode` buffer with the following code,
> >>
> >>      if (true)
> >>      console.log('No indent here')
> >>
> >> Try to indent the second line.
> > Dmitry, Yuan: any comments?
> 
> I think it would be cool if the patch added a corresponding new case or 
> two in test/lisp/progmodes/typescript-ts-mode-resources/indent.erts

Noah, would you please add such tests?

Yuan, any comments or suggestions?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.