GNU bug report logs - #67019
[PATCH 00/16] gnu: Add KaTeX, lessc, and flow-remove-types.

Previous Next

Full log

View this message in rfc822 format

From: Philip McGrath <philip <at> philipmcgrath.com>
To: 67019 <at> debbugs.gnu.org
Cc: Philip McGrath <philip <at> philipmcgrath.com>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: [bug#67019] [PATCH v2 13/16] gnu: js-commander: Install as a node module.
Date: Thu, 16 Nov 2023 14:15:51 -0500

Previously, NPM would not find 'commander' when resolving dependencies.

In case anyone is using it, keep building the bundled version at
'share/javascript/commander/index.min.js', too.

* gnu/packages/javascript.scm (js-commander)[build-system]: Use
'node-build-system'.
[arguments]: Delete unpackaged 'devDependencies'.  Build bundle for
compatibility.
---
 gnu/packages/javascript.scm | 52 ++++++++++++++++++++++++++-----------
 1 file changed, 37 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/javascript.scm b/gnu/packages/javascript.scm
index c62b23a4c4..97cb3b6270 100644
--- a/gnu/packages/javascript.scm
+++ b/gnu/packages/javascript.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2021 Pierre Neidhardt <mail <at> ambrevar.xyz>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Frank Pursel <frank.pursel <at> gmail.com>
+;;; Copyright © 2023 Philip McGrath <philip <at> philipmcgrath.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -42,6 +43,7 @@ (define-module (gnu packages javascript)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system minify)
+  #:use-module (guix build-system node)
   #:use-module (guix build-system trivial)
   #:use-module (guix utils))
 
@@ -384,22 +386,42 @@ (define-public js-commander
        (sha256
         (base32
          "1xwh85kbxj76ni41r2h0apl8mjbfcnmxzzp3vlspq30w8kwfckni"))))
-    (build-system trivial-build-system)
+    (build-system node-build-system)
     (arguments
-     `(#:modules ((guix build utils))
-       #:builder
-       (begin
-         (use-modules (guix build utils))
-         (chdir (assoc-ref %build-inputs "source"))
-         (let ((esbuild (search-input-file %build-inputs "/bin/esbuild"))
-               (target (string-append %output "/share/javascript/commander")))
-           (invoke esbuild
-                   "--bundle"
-                   "--minify"
-                   "--tsconfig=tsconfig.json"
-                   "--platform=node"
-                   (string-append "--outfile=" target "/index.min.js")
-                   "index.js")))))
+     (list
+      #:tests? #f ; many more dependencies
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'patch-dependencies 'delete-dependencies
+            (lambda args
+              (delete-dependencies `(;; devDependencies
+                                     "@types/jest"
+                                     "@types/node"
+                                     "@typescript-eslint/eslint-plugin"
+                                     "@typescript-eslint/parser"
+                                     "eslint"
+                                     "eslint-config-standard"
+                                     "eslint-config-standard-with-typescript"
+                                     "eslint-plugin-import"
+                                     "eslint-plugin-jest"
+                                     "eslint-plugin-n"
+                                     "eslint-plugin-promise"
+                                     "jest"
+                                     "ts-jest"
+                                     "tsd"
+                                     "typescript"))))
+          (add-after 'install 'install-compat
+            (lambda args
+              ;; This is what this package built before adopting
+              ;; node-build-system.  Does anything use it?
+              (invoke "esbuild"
+                      "--bundle"
+                      "--minify"
+                      "--platform=node"
+                      (string-append "--outfile="
+                                     #$output
+                                     "/share/javascript/commander/index.min.js")
+                      "index.js"))))))
     (native-inputs
      (list esbuild))
     (home-page "https://github.com/tj/commander.js")
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.