From unknown Sat Aug 09 22:40:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#67018 <67018@debbugs.gnu.org> To: bug#67018 <67018@debbugs.gnu.org> Subject: Status: [PATCH] Add autoload cookie to vc-git-grep Reply-To: bug#67018 <67018@debbugs.gnu.org> Date: Sun, 10 Aug 2025 05:40:56 +0000 retitle 67018 [PATCH] Add autoload cookie to vc-git-grep reassign 67018 emacs submitter 67018 Alyssa Ross severity 67018 wishlist tag 67018 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 09:47:42 2023 Received: (at submit) by debbugs.gnu.org; 9 Nov 2023 14:47:43 +0000 Received: from localhost ([127.0.0.1]:47151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16Jq-0004zA-Lm for submit@debbugs.gnu.org; Thu, 09 Nov 2023 09:47:42 -0500 Received: from lists.gnu.org ([2001:470:142::17]:33040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16Jl-0004yu-TA for submit@debbugs.gnu.org; Thu, 09 Nov 2023 09:47:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r16J2-0001q3-MF for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 09:46:52 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r16Iy-00017i-I9 for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 09:46:51 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1DFE65C068C for ; Thu, 9 Nov 2023 09:46:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 Nov 2023 09:46:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1699541201; x=1699627601; bh=OWQjAy92LV sNCuoaNdjLR3SmbZI9bM4Vt2ZKzhUqnGg=; b=WTfeO1r+ZJKuzvFDAEPscvC8WI Ngg/n1lNXNsZwVef9CCjTWErwjpWZJBD+eOC3vz2vHfG51r198FarFMRprHdBFCb GLTY6NXL4Hed15R/NlQAA/1XnbSgjvvfbtAOae8HZ8CsxEKGg+FazYugyeLnv5t1 TH+78939ILkYbt6BKt5RFG2zqDurFDFi5XW+SQDj1fpIOR3JnOoJBI+WcGpoJSzf kMfIVJzcbfXqwb7FOh5AUieHzoJSv2taRdAdXv2W28CYs789NINGErE0F12GqF6Y diWCdRJea/+K4XyYT24hND5+wYOaMLhI9Qr7ErILa/yLEjWJ2qZDVW3raW1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1699541201; x=1699627601; bh=OWQjAy92LVsNCuoaNdjLR3SmbZI9 bM4Vt2ZKzhUqnGg=; b=B80RnjA0Gk9YBv6ilL3mscqretdbmTeOCKgkX8SImxRk PQ9ZBrds3nsM6GwgnZYOlbAZCN41tRms2GYI6xiYQP1svBXDRh9xvKtsVBKbtf6o PhcvPY1JFSBWs5kmCjL4FqDYPrW1AOs84zAUtk3wGFlBJ/cNMRmrPJXRL1DCX2/D MBiAjwwvxY0rZ0ey3+0L3zkruavQLs/bVS3ZaoxPETIFLNWePMdjAajqeiO8qKMo DqFBbd1cHQacG30egDV6xchDK61cjkD94bW7L5wzvYonFHQ6e1gh4G3ZaDOqldJE zGy/8+bAVJyMpqMZehGza9FtrmH93qg2SdO7h9O/5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvuddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhisheq necuggftrfgrthhtvghrnhephedvfffghfetieejgfetfedtgffhvdehueehvdejudfgge fgleejgfelfeevgfefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhephhhisegrlhihshhsrgdrihhs X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 9 Nov 2023 09:46:40 -0500 (EST) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 851A93F0E; Thu, 9 Nov 2023 15:46:39 +0100 (CET) From: Alyssa Ross To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add autoload cookie to vc-git-grep Date: Thu, 9 Nov 2023 15:46:30 +0100 Message-ID: <20231109144630.111745-1-hi@alyssa.is> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.28; envelope-from=hi@alyssa.is; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --- lisp/vc/vc-git.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 707fc7cfc07..fe48d5fbd3d 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1930,6 +1930,7 @@ vc-git-prepare-patch (defvar compilation-environment) ;; Derived from `lgrep'. +;;;###autoload (defun vc-git-grep (regexp &optional files dir) "Run git grep, searching for REGEXP in FILES in directory DIR. The search is limited to file names matching shell pattern FILES. base-commit: 5d171d26c00aefaef1496dede69337946a1edb14 -- 2.42.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 09:59:59 2023 Received: (at 67018) by debbugs.gnu.org; 9 Nov 2023 14:59:59 +0000 Received: from localhost ([127.0.0.1]:48367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16Vi-0005ae-VJ for submit@debbugs.gnu.org; Thu, 09 Nov 2023 09:59:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16Vg-0005aP-Fi for 67018@debbugs.gnu.org; Thu, 09 Nov 2023 09:59:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r16Ux-0004G6-4j; Thu, 09 Nov 2023 09:59:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+TPCURhZQakmUx0R9UY+yX/EjhM5m7Cfn9oGnz/QofM=; b=VwFd1knUiTwH AKXuD2Kx/8pYWiqxBurzXVFBaeiuK3qdqzhd+exdpI7I1B0hr7XawEbT5qusBbfyNZUaujUwXD6BK VppuSngB+3vrfeSlP5yO19R5bCN+gTn5sccTPyHxNw9eo7VeerqlbsKZPVQjLBANvzQ/xJ8YGkLUh WYq1d2NQWODvScrClxXQG6cQi3YBz+Yc0PzsaoO3EAK1KowbMQaCT65EcxdL5Vlm9ve/+vqoD0sAN rbbHIZnn48fFj+p08fZUckETNlr8S4VSleKaQV8SbzvajKsua3rl1bUsa9HQ5DSLxj3C+iIYIwvTE e9UimK9w+8D1iw9YOJrDqQ==; Date: Thu, 09 Nov 2023 16:59:04 +0200 Message-Id: <83pm0jynuv.fsf@gnu.org> From: Eli Zaretskii To: Alyssa Ross In-Reply-To: <20231109144630.111745-1-hi@alyssa.is> (message from Alyssa Ross on Thu, 9 Nov 2023 15:46:30 +0100) Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep References: <20231109144630.111745-1-hi@alyssa.is> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 67018 Cc: 67018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alyssa Ross > Date: Thu, 9 Nov 2023 15:46:30 +0100 > > --- > lisp/vc/vc-git.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 707fc7cfc07..fe48d5fbd3d 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1930,6 +1930,7 @@ vc-git-prepare-patch > (defvar compilation-environment) > > ;; Derived from `lgrep'. > +;;;###autoload > (defun vc-git-grep (regexp &optional files dir) > "Run git grep, searching for REGEXP in FILES in directory DIR. > The search is limited to file names matching shell pattern FILES. Thanks, but please explain the motivation. Which package needs to autoload this function and why? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 10:06:25 2023 Received: (at 67018) by debbugs.gnu.org; 9 Nov 2023 15:06:25 +0000 Received: from localhost ([127.0.0.1]:48383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16bw-0005n5-W8 for submit@debbugs.gnu.org; Thu, 09 Nov 2023 10:06:25 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16bs-0005mm-Kf for 67018@debbugs.gnu.org; Thu, 09 Nov 2023 10:06:24 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 459AB5C0735; Thu, 9 Nov 2023 10:05:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 Nov 2023 10:05:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1699542336; x=1699628736; bh=PN 9aPS2dbsGw0SuisPwEHMJsNRTyC3tXDvCNYy6ItyI=; b=uk56mLbkRu6QUIL9FU EDwah7PHC3I+zMP7FiWVvuCg8misPG84wzmnvfGjkYU7AV3WJcjBLJdC8QoJgs2Y JpEwrZQUcXk2hERJWHEdb2DaXMefFzzdc1bkpTJfMD7u5kzRzDzfUwg9llMw+BKl hIrLRoRyIbI9h/BMmhnqhU8k/VDNIjRWwU1KatzIRmtPHPDhuB/LE7HKV2341mk+ R7Z3LYXMIrzZm3fPNemkRhy9tmht1jZPASq7x40UsuhF+TyHRfTmBOG1cHKVAFlJ xryLBw7cgM0vLR5+2Ci/nLOar8ATuqF64RfFNO4kSf80ce6Url6NXCi39ArZwxN+ l5CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1699542336; x=1699628736; bh=PN9aPS2dbsGw0 SuisPwEHMJsNRTyC3tXDvCNYy6ItyI=; b=KPqEPWHacLYVS8z1ZkjM/3gdUUVl8 I723Y2oJ3KtDh1Rmpteaey05CpcdC4YtdCAtBpgFSEeqzbWVZcSe6aPIp0Bci+F8 3BMMseVubNLl9JZJC9Akk4oVca0IYhcJQqcE9SPF2tJyjPUWphAclcVqsWG+GpID pSKtD0PsK6iTKLECk5fAxIbij+H71ad/ahXQtXUfG6wsBxzRvUKCjE5d0svuAt9y x8CpD00pC1+2j2Sa1kTi6yo04DKbHTaSVsyDtKjnM+1GT+CyxrF0J3NpHOW/S+iz BAvwz+EkuYdLExRn6QT82hlsQIAA+TqI2aeab2NLIeJqPCc0SbqQ/p4mA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvuddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttddtnecuhfhrohhmpeetlhihshhs rgcutfhoshhsuceohhhisegrlhihshhsrgdrihhsqeenucggtffrrghtthgvrhhnpeeiud ffueeilefgtefgtddttdekkeehkefgheekudefveetgeefiefftedvteeuveenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehhihesrghlhihssh grrdhish X-ME-Proxy: Feedback-ID: i12284293:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Nov 2023 10:05:35 -0500 (EST) Received: by mbp.qyliss.net (Postfix, from userid 1000) id 281973F12; Thu, 9 Nov 2023 16:05:34 +0100 (CET) From: Alyssa Ross To: Eli Zaretskii Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep In-Reply-To: <83pm0jynuv.fsf@gnu.org> References: <20231109144630.111745-1-hi@alyssa.is> <83pm0jynuv.fsf@gnu.org> Date: Thu, 09 Nov 2023 16:05:32 +0100 Message-ID: <87ttpv3r2b.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67018 Cc: 67018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Alyssa Ross >> Date: Thu, 9 Nov 2023 15:46:30 +0100 >>=20 >> --- >> lisp/vc/vc-git.el | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el >> index 707fc7cfc07..fe48d5fbd3d 100644 >> --- a/lisp/vc/vc-git.el >> +++ b/lisp/vc/vc-git.el >> @@ -1930,6 +1930,7 @@ vc-git-prepare-patch >> (defvar compilation-environment) >>=20=20 >> ;; Derived from `lgrep'. >> +;;;###autoload >> (defun vc-git-grep (regexp &optional files dir) >> "Run git grep, searching for REGEXP in FILES in directory DIR. >> The search is limited to file names matching shell pattern FILES. > > Thanks, but please explain the motivation. Which package needs to > autoload this function and why? Often running M-x vc-git-grep is the first thing I do after starting Emacs. I think it would be good if it was autoloaded, so I didn't have to M-x load-library vc-git first, or try to set up autoloading just for myself in my Emacs configuration. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmVM9TwACgkQ+dvtSFmy ccDjKQ/+JME6P+mv+d0NSIiv/OcKeuoaqG7SD3tbVZFEpKx++mjIoPJ51ssWZLV5 oiH5+MhhVLekDCrnghlEOWjm28R1bYYvEYg+2QzBGqb3PF3UaMmPvws0M75eHKqE IyrsMMiZmH2tf5dJPQV4Zyf4L8S/5haRWxjAxul7aTfSZ3cNol+fepLfSKaCfA/0 px9FTEFC70JlzjmWVzQ6dngUdYT1+7J1cZrMyU1ouSm1ImqAB2a4Kyw12WiJJYu+ GDPPpSzo2ZwoXQ9H/qNys+r+XoLnJvMo+d9dbvwB7dUX3INGqjQ71kow0KQjIsaM 0qR2k7D5uF74x7GHoT9MtDRfKND8t5PSz5uOht7B3gHpafT3MTijOx3d3Bl/70re eqvXZOZzatwnog0roxGlzRgvUXwUD7dBVPYNH6V/6VdhW1WUVnfqQtg/U3NQWJm6 q51VHEHzWRpRq2TZP9pb5A7VOYtLdjyIfNjOtNQgUvIdaSdPe61gu504m8SDbO+x U0UDSLRia1jsh4V+cXb5m7FYzJcQNrO6Gbi15Va3nR3MPYrAxEcgAeJGY2VzI/Iq 4mHt+z8iXys8WR9dWZXIXBxK5NwXk2FYKk3a6GHU91iGMVNRYIjxrmCdGFrNn3mM QhE11i3m4GYEFDQD3HAfBy2dttmFOgGyxz/9w1r3ZM+jdGmdjfk= =tXx8 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 10:14:51 2023 Received: (at 67018) by debbugs.gnu.org; 9 Nov 2023 15:14:51 +0000 Received: from localhost ([127.0.0.1]:48392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16k7-0005zI-93 for submit@debbugs.gnu.org; Thu, 09 Nov 2023 10:14:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r16k1-0005z1-Lm for 67018@debbugs.gnu.org; Thu, 09 Nov 2023 10:14:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r16jI-0007lu-JU; Thu, 09 Nov 2023 10:14:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=weAke2IYjTI8MpnvRipZIxocofNqk0Sss8fYvXanugQ=; b=NWlxjofe2KQT 7/5ghoE9ro47V0arTMXgR8hsfGmux2v/vpLtjG9w8kOWiEkpBFCo1HdKS9McQ2vcSgx2yFeW0W55D +Awv9+cTU8024d7lU4AKNnzUh2RMdQhTAcfPZTQAEuOB81dZZgI+6OH2FbxKDGGh8wKvJdyLhq9dP 4mkV7mAl2k/TmXwiYD70/pOUcEX0XEO/bTM7CWTAEZUh9KdW1ETNchsiWMnLDgD7afQhT6LA8tw0r vubSb0JWfD7jq883DuVwE7KkRSe7p5FgEbFBOGKVKmmK4MdZJMDfgfqAkkwzAg/uVqX49zj+umWa2 Kx+xs+ZCDifGvRWXSXgzHA==; Date: Thu, 09 Nov 2023 17:13:53 +0200 Message-Id: <83msvnyn66.fsf@gnu.org> From: Eli Zaretskii To: Alyssa Ross , Stefan Monnier In-Reply-To: <87ttpv3r2b.fsf@alyssa.is> (message from Alyssa Ross on Thu, 09 Nov 2023 16:05:32 +0100) Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep References: <20231109144630.111745-1-hi@alyssa.is> <83pm0jynuv.fsf@gnu.org> <87ttpv3r2b.fsf@alyssa.is> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67018 Cc: 67018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Alyssa Ross > Cc: 67018@debbugs.gnu.org > Date: Thu, 09 Nov 2023 16:05:32 +0100 > > Eli Zaretskii writes: > > >> +;;;###autoload > >> (defun vc-git-grep (regexp &optional files dir) > >> "Run git grep, searching for REGEXP in FILES in directory DIR. > >> The search is limited to file names matching shell pattern FILES. > > > > Thanks, but please explain the motivation. Which package needs to > > autoload this function and why? > > Often running M-x vc-git-grep is the first thing I do after starting > Emacs. I think it would be good if it was autoloaded, so I didn't have > to M-x load-library vc-git first, or try to set up autoloading just for > myself in my Emacs configuration. By the same token we should autoload every command in every Lisp package we have? Because there are a lot of commands that are not autoloaded, and you need to load their package to have them available. I wonder what Dmitry and Stefan (both of them) think about this. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 14:35:06 2023 Received: (at 67018) by debbugs.gnu.org; 9 Nov 2023 19:35:06 +0000 Received: from localhost ([127.0.0.1]:48781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1Anx-0006L8-J7 for submit@debbugs.gnu.org; Thu, 09 Nov 2023 14:35:05 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:34059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1Anu-0006KX-KB for 67018@debbugs.gnu.org; Thu, 09 Nov 2023 14:35:04 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E9C333200B4E; Thu, 9 Nov 2023 14:34:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 09 Nov 2023 14:34:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699558456; x=1699644856; bh=m5XcBYBzJ6y7U2JJRpomi863ZBaZ8N2ipuB i3AU0KCE=; b=X6Cub4x62ynWVyhmN+XMl6km2CTW732cmzE3tv/X3Vqo7WskbC1 e7NuEgowTJT+ScBoUCg0tConk+5DRoGkSaNxg4b3WTH/z7LJIQsZOk9ogGQPGpwE eDaAWswhswqhSxYrKDfUzu5pu1V0Tu573oE9LO48xX6l/356jPnb3qI/nagWR5Bt xXtERUtkWsYu5U006G9JQoiE/jMo/upRPIefahUoB7yhudfmZksTS0p92tQ28+jR Qz2qQoPtBLXvI1w/+5nu9lcy0ACjK7ilyq2hp8hc13CYbNi5pazKe5/HbOTcld3T mMD+vViDWQM/ndIynGhu21tjQzMQYtahiUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699558456; x=1699644856; bh=m5XcBYBzJ6y7U2JJRpomi863ZBaZ8N2ipuB i3AU0KCE=; b=XV4MZ8ZVd/CImLwU+c2qrKdG2tG6BPMUQIUZnLf3+7WtW1fIEIi MtVbFNiTl23L58sYdcboX6nwyH6qpJ8Qx4rTK1O7hiP2N3s7atDgNCdlGRSCI2ES 1pgNwrZDKaqwaAI1IRi3WqdkBmwMFr9UjXdeWd6i7tzfG6fLLSV8pE/ovEbr/zg3 IhkRX2WPp04eV6YTNRM4RY5GNIPT8GTVPvT9nKPyGyLZ3L8FV/DIxicgydYsIJhJ sym6MQ034XrHvOFZ9Nl1TREuUu2L1+OON3Woo9gaaHrpRXCxpGMfUPV2yomqfce6 fQ6me0VX3mjZNvdbB5GN6PPggJ5wgQdoa8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvuddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Nov 2023 14:34:13 -0500 (EST) Message-ID: Date: Thu, 9 Nov 2023 21:34:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep Content-Language: en-US To: Eli Zaretskii , Alyssa Ross , Stefan Monnier References: <20231109144630.111745-1-hi@alyssa.is> <83pm0jynuv.fsf@gnu.org> <87ttpv3r2b.fsf@alyssa.is> <83msvnyn66.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83msvnyn66.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 67018 Cc: 67018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 09/11/2023 17:13, Eli Zaretskii wrote: >> From: Alyssa Ross >> Cc:67018@debbugs.gnu.org >> Date: Thu, 09 Nov 2023 16:05:32 +0100 >> >> Eli Zaretskii writes: >> >>>> +;;;###autoload >>>> (defun vc-git-grep (regexp &optional files dir) >>>> "Run git grep, searching for REGEXP in FILES in directory DIR. >>>> The search is limited to file names matching shell pattern FILES. >>> Thanks, but please explain the motivation. Which package needs to >>> autoload this function and why? >> Often running M-x vc-git-grep is the first thing I do after starting >> Emacs. I think it would be good if it was autoloaded, so I didn't have >> to M-x load-library vc-git first, or try to set up autoloading just for >> myself in my Emacs configuration. > By the same token we should autoload every command in every Lisp > package we have? Because there are a lot of commands that are not > autoloaded, and you need to load their package to have them available. > I wonder what Dmitry and Stefan (both of them) think about this. A lot of commands don't make sense outside of major or minor mode, so we only have to autoload the modes in those cases. If 'vc-git-grep' is an independent entry point, it should make sense to autoload it. I suppose vc-git is not loaded at the beginning of the session because no [Git-controlled] file has been visited yet. I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x p g'). Just in case Alyssa was not aware of it. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 24 09:47:59 2023 Received: (at 67018) by debbugs.gnu.org; 24 Dec 2023 14:47:59 +0000 Received: from localhost ([127.0.0.1]:51882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHPlm-00025g-QK for submit@debbugs.gnu.org; Sun, 24 Dec 2023 09:47:59 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:61534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHPlk-00024s-II for 67018@debbugs.gnu.org; Sun, 24 Dec 2023 09:47:57 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-554dd0c95a4so66504a12.2 for <67018@debbugs.gnu.org>; Sun, 24 Dec 2023 06:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703429265; x=1704034065; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=qBeJDNwxUVXv06oO/Jiah76z9oUXEcuDSQM5LhGlFT8=; b=FrAUk2oABBJUyplARR4/sZWmxh2cPLczdbTxhsYGoEiW5pNVQFuH0nghY7S20McHr8 //iheAPQyl+dRWGUtjvhamiOM0FN5Ejf8QnC4LuEMND9rg8lcpLThFX27YhQFdloasnp GOtZbLozsmwcCOaGhdvngqHGBF5O9UAxoNTi9Sche71KZ6Fd27uCqRBEM6WHQwqr06wP zn9nM5viezthkuRV0fP23ec35D4oXXZomrMz0WP2rw4ObKVn2MrJursLZXdtXe4y43U6 Rtob9Z73OCb+PFolVC1PWicwXlo90mQg2RVuDFnUWrdLxes8gsGITOtEFB6aXOXvHDEQ cbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703429265; x=1704034065; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qBeJDNwxUVXv06oO/Jiah76z9oUXEcuDSQM5LhGlFT8=; b=RK9G2euMAD0M3jRVtjy4TUJdXb5+KqtovY3Iq31Rs2zt9/eCbL4YrD9BXYz9S1WTjh ivj3frWX3dXsrdR01iXdCkpJ25EMjGFUBqz29vWEB69ePVc5zotiNzp3fqP8ZtLnZf3t UmiWVk0rzjOHmurcCEduo0biQ7K1zB3Anr9Z5fUhmJlpKp/NynANlTPEMPULuMl32KyB 9QJ88JrZZyw76yOUWbv3cCSirZrvVDAp5jLb8tAZqvcw1KlLY3+iepg9/yltkztbsnQo 98EnV/yO0WF0SSV7kCw7fBBprTqqFC/kpXLS5vLJuWgMDtJIrbGk3B/ZJBNfP2HQ0abO rf2Q== X-Gm-Message-State: AOJu0Yxj7rol3oRr+Tu7VMy4xOLdXqdcmvDtRAWxVpviqzBNa5O3A4oL XKQ+bL/y6uPm7jCTfNoCAlQiQ9rZsf4hv2fkANWlkWE+RXE= X-Google-Smtp-Source: AGHT+IGWEOnTfkuuI0g5N4+JACFr+HO9d1n42SJZiloz/snaeEivwGek/+WACSYuptGLhfbTmz/nqCu/Qi4bIDKtElo= X-Received: by 2002:a50:ef18:0:b0:552:8a69:8100 with SMTP id m24-20020a50ef18000000b005528a698100mr3217627eds.77.1703429264845; Sun, 24 Dec 2023 06:47:44 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Dec 2023 06:47:44 -0800 From: Stefan Kangas In-Reply-To: References: <20231109144630.111745-1-hi@alyssa.is> <83pm0jynuv.fsf@gnu.org> <87ttpv3r2b.fsf@alyssa.is> <83msvnyn66.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 24 Dec 2023 06:47:44 -0800 Message-ID: Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep To: Dmitry Gutov , Eli Zaretskii , Alyssa Ross , Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67018 Cc: 67018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > If 'vc-git-grep' is an independent entry point, it should make sense to > autoload it. I suppose vc-git is not loaded at the beginning of the > session because no [Git-controlled] file has been visited yet. > > I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x > p g'). Just in case Alyssa was not aware of it. Makes sense to me. So should we install this change? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 24 11:37:52 2023 Received: (at 67018) by debbugs.gnu.org; 24 Dec 2023 16:37:52 +0000 Received: from localhost ([127.0.0.1]:53397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHRU8-0006tS-0H for submit@debbugs.gnu.org; Sun, 24 Dec 2023 11:37:52 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHRU5-0006tF-Df for 67018@debbugs.gnu.org; Sun, 24 Dec 2023 11:37:50 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 49ACE5C015A; Sun, 24 Dec 2023 11:37:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 24 Dec 2023 11:37:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1703435858; x=1703522258; bh=XTF4ZTMLjBuMfjv5OWWFlqq0ImRaR/LhQTWjnz3zLaQ=; b= o4A7jfEv6/fkfbVQpiGbrNhR3eaEmcROn/qdj11p5aJU6/PYEP8Lz2RzElBTrG5r pY1KzY21FPqANPrU2iVAYaHInglmEywnf782r1UT+fi0qJqwZviAqHMIk1GDgX+A 2ovHAhI2YGQcPb/DfavD7wJnEjH0CbrI20M23WJ2zebIrNzTj2yzlv2KqYP7A/+u SCq/EKG0TWEwh3vUwkNhBD2Ukb5wd/iA+u5YY8Y31Oau3vcURuDaotsZgVyBdD7X glGruwzJk+E7EdoQQ2jEK8KEm00h1dFzJTc79E1T9OSBCQQU7CZTlFmgXs7JPESr qrPGGxK3Nbygd4I6WuhC9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1703435858; x= 1703522258; bh=XTF4ZTMLjBuMfjv5OWWFlqq0ImRaR/LhQTWjnz3zLaQ=; b=f nMj/sU1m70CCbUgyERqVUwpjhmeOvv1x9LpdMgbUJnXdynM8YZGKuogBdChgcl+l POOmFZAZEAzqHju65oUyxMUtv9QW2iJCdCJpPl7QzkE0Ay35A69K361IAIFd+EgP y7VWn+TQXMrW7fDB0RPauRXYC2P3lNMLhHTIsA1c2dzBm66ZzmU8qPaj33qrZHrQ PyyM1F38MA67JiN5mI4gW0W1zJnpkFmqTmneNnyd5QiYLWxs292gk9hObVY1VPnZ 2sVPQUqhyh0U/jrd8XoEqxO3tvrpmBl+lL3dqLsmRALeP5/mVB0QAnf6xyD6Px7E o2IU6VKb3T+xdO2Vdbrxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddvuddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 24 Dec 2023 11:37:36 -0500 (EST) Message-ID: <44283042-3eca-452d-b37b-ba7f3749530b@gutov.dev> Date: Sun, 24 Dec 2023 18:37:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep Content-Language: en-US To: Stefan Kangas , Eli Zaretskii , Alyssa Ross , Stefan Monnier References: <20231109144630.111745-1-hi@alyssa.is> <83pm0jynuv.fsf@gnu.org> <87ttpv3r2b.fsf@alyssa.is> <83msvnyn66.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 67018 Cc: 67018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 24/12/2023 16:47, Stefan Kangas wrote: > Dmitry Gutov writes: > >> If 'vc-git-grep' is an independent entry point, it should make sense to >> autoload it. I suppose vc-git is not loaded at the beginning of the >> session because no [Git-controlled] file has been visited yet. >> >> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x >> p g'). Just in case Alyssa was not aware of it. > Makes sense to me. So should we install this change? My opinion is yes, in case that wasn't clear from the previous message. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:50:19 2024 Received: (at control) by debbugs.gnu.org; 10 Jan 2024 17:50:19 +0000 Received: from localhost ([127.0.0.1]:42912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNciZ-0002nB-3s for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:50:19 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:48487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNciX-0002mi-6D for control@debbugs.gnu.org; Wed, 10 Jan 2024 12:50:17 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-55719cdc0e1so5028020a12.1 for ; Wed, 10 Jan 2024 09:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704909013; x=1705513813; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=iTZKOK7xmqA0E/kCKWvLOzf57npmDVdB8EKjOplOApk=; b=b3I4RKKCambxA2NHnzIKcqX1VVlIPPFv1bz8wM8NUTtnUS61GFuaAUNeaC5T6e9mb2 BynJB2O2nTx2XAkytpzUepjM4LJyqZht4HGZlsiKQhRYkx2pBYhyBhfRgQS8vphZi25C 5AaK3uOXohgEi4me8z5eUBo3/R16kPdAgnYXJ+9r8xWHJEHuC5/xq6jteLMe7f6JDTc8 5HT+4iSZSIXz71LmJph8uQ4qUeYWjihSTQ/TdZ90xDBxbG8QXXd41y0v5YNnyaiJlAqe OKUGU1cWuM8VyIRyrWFiTIJy5OEQNAtHv6/LUtvqqWgVTS0EGemXaPdly4lQjp8oU/e9 vueg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704909013; x=1705513813; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iTZKOK7xmqA0E/kCKWvLOzf57npmDVdB8EKjOplOApk=; b=TpNsfCZkX4xrwbUBHWVC6wpN13rs7Mps17Ieom+RLwcU8v9U37bwzlhUwoa//D60To n3cAvwHve8itaD+Eack//OA0F5WRGzwYKpQgl6dHhDIk2hNLmbDwbv5rxZcuy7MIg0+I TGSgJXmaGvhbllvpiERngq9+rR5coY/JFNNINEJoccjH/KBWTNVKkqbiDWftrgJGogF1 3w9jFaf2O4OTrlaZ383SBCg55vfPRtuGbQ9eqKtUIdPA5RIotOL8G+2uj4ea+aUJijsb V56M/am5siLUTwToyEuMdk1kmR+0z4kniNg0MgRSmafZqan6LOjmZWHnD7Y9uRInBKGO oJgw== X-Gm-Message-State: AOJu0Ywyv+raZJhD6gvtpaigryclgNwO6K0S/0HEKIMd236IWE4uTMuX t0edr94BZ/oGISYD/64AaIMU+3Jyy7PvEmXKxlUhDraAdFrXeQ== X-Google-Smtp-Source: AGHT+IHP+tGRQrMRgHv2w4UOYpxDHFpOYerWNMnfwYmxylFycX7DAHLkk+nZZZyPN7a5ZTNFyhcxTXreHA4DFODSPvI= X-Received: by 2002:a50:950a:0:b0:554:c82e:a0f7 with SMTP id u10-20020a50950a000000b00554c82ea0f7mr571060eda.74.1704909012674; Wed, 10 Jan 2024 09:50:12 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 09:50:11 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 10 Jan 2024 09:50:11 -0800 Message-ID: Subject: control message for bug #67018 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 67018 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 16:18:18 2024 Received: (at control) by debbugs.gnu.org; 11 Jan 2024 21:18:19 +0000 Received: from localhost ([127.0.0.1]:34165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO2RO-0003Pl-Jx for submit@debbugs.gnu.org; Thu, 11 Jan 2024 16:18:18 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:45073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO2RL-0003PN-0l for control@debbugs.gnu.org; Thu, 11 Jan 2024 16:18:17 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5582796b85bso3042857a12.2 for ; Thu, 11 Jan 2024 13:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705007891; x=1705612691; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=0ykIgcM4bXXMagaStr9i5KwagtsqJMAS0tMnhLYtv1g=; b=dixAr0UTU2V4Ru9uPsGPIQynrgkb4PK0c5EWEwH+fx8mFYY4ThBe6vXkO9kIAbGtE5 bWYb15w11SXW3Jq/orjBIMjQQ/kmQkP/RdoER2IwKMAvqOXPlyy33L4NfEvDXA7X55MT rDzc27fFVy1JnNPBqLloZFaUd8uy2hAWaDWL/D86/9AUR/xYj9Dm2SGpCRLQ5viRZVWi 4zfLaD4++vpLcJez06DARGQEp7KaXryHMKNNpAVZlwmwKZICrAVhpkzuZzGs818i+dUU uDVclaxcKWNcKZBbZ2GECd0UOTo12/ELNb0ZRo8CG25d4J6dsFF7UgUMuULsrlnr6xm2 MrZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705007891; x=1705612691; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0ykIgcM4bXXMagaStr9i5KwagtsqJMAS0tMnhLYtv1g=; b=JJCjbISNYPBZuvw/blDROAYhGdd2Doz4QpFbBLzJFxIHvfOghyCxAT3TnyTXkOPF67 63DKru3vBGGJERqFUSo6Cb6FyvIIqQLPEw9cCZ6hdSBZBiTk+jtouNuTfaeK7qo0DPbb c3AJSwQACmmV849yGQbcAhDDLvdtX1iEQa5+jPeI6++9Qx/kSPMHu0NVGJhviP3vOWZI sp6Mkd0KXkOe3M/VmXhJijZ39ioEbjkNiG9rdhRvCiGcMgusjsmn2mtEzgSQx3fc9DOl Z7FmuOtsjDgdS+QikNxDSZPdEcCEIo9dHW/M3Fv0EczO1AsNzh5U7bm9jQRLI4XK80bp Ba8A== X-Gm-Message-State: AOJu0Yz/SxU2mDqf/+veyYU6e+sOrCB2IPHh9FZF9CiNwCTtusOzHnxL nXm8yqLcelJiMqsGbLBgwWe+3kAl+veGM+hbwGL4ZFNtnuo= X-Google-Smtp-Source: AGHT+IH4jLM40VIxsfNmEQlMrmdN+XOTknygk420mfZe7z9cci5Jw8oIZbZJVl8IFh2ZBigBV7YZNqmSw1yXGGfsNNU= X-Received: by 2002:a05:6402:1647:b0:558:a219:736 with SMTP id s7-20020a056402164700b00558a2190736mr145395edx.57.1705007891571; Thu, 11 Jan 2024 13:18:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 11 Jan 2024 13:18:11 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 11 Jan 2024 13:18:11 -0800 Message-ID: Subject: control message for bug #67018 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 67018 30.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 11 16:18:05 2024 Received: (at 67018-done) by debbugs.gnu.org; 11 Jan 2024 21:18:05 +0000 Received: from localhost ([127.0.0.1]:34162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO2RB-0003P9-7S for submit@debbugs.gnu.org; Thu, 11 Jan 2024 16:18:05 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:50524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO2R9-0003Od-71 for 67018-done@debbugs.gnu.org; Thu, 11 Jan 2024 16:18:04 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-55569b59f81so7154813a12.1 for <67018-done@debbugs.gnu.org>; Thu, 11 Jan 2024 13:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705007880; x=1705612680; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=j5Xlpyf9O/DyfEq6yzexaVykWEkR1OVX1B0YDfwRdJE=; b=ABOiZvpDSXgtACyqW5fl4FasqS3rASDH5HvQCoR1SeRIwd4sPqTaaw3TN5E35RMH0i iHwZaLERO0+/D8g7gnJkkTSXjbz42h31/QezhBKj7p7/13rhgW7T2fgMCP/m26eQFx2Q YRml1aS48sjyo0D5jbbYnNP3Q0rNhaDizrT1QofSa4sSBvha86PPeYWakzmyTSPcxZnN MOp8SJZ12Qfi2iC+iXMydSaFpwDhHUBo+CDnjwkuz3J6jPwNNE2ri1fQH76IiKBoNWXO Q1kRClMzylzXmKarLFlYL49zWu9CKyAxjMqOVc4DFAqJ9xwCipOp0IiQXQnfvph9Ebz6 1Elg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705007880; x=1705612680; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j5Xlpyf9O/DyfEq6yzexaVykWEkR1OVX1B0YDfwRdJE=; b=FgSqoMu4NCJKS8FxBFN3tGb8yJxQA/n/uxASBgoUH+CZx3I36NS81vdnVxQxwU3x8b GbsbhN397rfWb60/eX+6MsPCsClGJx0mWSGfcpg9rCdquVSlJvzCcBie5B9sZp2Tly3Z ok5mlVUXvpW57vWM6+odrEQ1HbZPLJP/wPsrOAdJNIzEF/YamqkxRzPjFMh1TxUqdjOB HeU+wT4K9FPzqIPZtCwfl3jaKbohihDHjkyaRWqMNp3TqrFDaQ1Ux+kUBN4LM/DRNw4O CDIK+t22g1voRoYvfI+Rj9wDaezocMgbRsRhyLYkqVwjvuwnEm2fiF5ILHdXQ1xud1xX KW6A== X-Gm-Message-State: AOJu0Yw+cdPW+ZigM4SrSyLTujLW+6erQu24nlRujmidSxOnayGhZ3bf M3yt4Oh2YoMvQKuxem5mjIVysFFTjlFvkJmiK+o= X-Google-Smtp-Source: AGHT+IG3FV+FUMkfOQfEQ4mYsmk1kgatyDkh6a3ElJ0SPnjMCx4jHB2J3QNmizjjoGMqfCJNf+pzsBLW7UbLvD6L8so= X-Received: by 2002:aa7:d88d:0:b0:557:2a57:9b10 with SMTP id u13-20020aa7d88d000000b005572a579b10mr134607edq.77.1705007879735; Thu, 11 Jan 2024 13:17:59 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 11 Jan 2024 13:17:59 -0800 From: Stefan Kangas In-Reply-To: <44283042-3eca-452d-b37b-ba7f3749530b@gutov.dev> (Dmitry Gutov's message of "Sun, 24 Dec 2023 18:37:32 +0200") References: <20231109144630.111745-1-hi@alyssa.is> <83pm0jynuv.fsf@gnu.org> <87ttpv3r2b.fsf@alyssa.is> <83msvnyn66.fsf@gnu.org> <44283042-3eca-452d-b37b-ba7f3749530b@gutov.dev> MIME-Version: 1.0 Date: Thu, 11 Jan 2024 13:17:59 -0800 Message-ID: Subject: Re: bug#67018: [PATCH] Add autoload cookie to vc-git-grep To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 67018-done Cc: Eli Zaretskii , 67018-done@debbugs.gnu.org, Alyssa Ross , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 24/12/2023 16:47, Stefan Kangas wrote: >> Dmitry Gutov writes: >> >>> If 'vc-git-grep' is an independent entry point, it should make sense to >>> autoload it. I suppose vc-git is not loaded at the beginning of the >>> session because no [Git-controlled] file has been visited yet. >>> >>> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x >>> p g'). Just in case Alyssa was not aware of it. >> Makes sense to me. So should we install this change? > > My opinion is yes, in case that wasn't clear from the previous message. Now done (commit e4e89e2cb66). Thanks for the patch, Alyssa. From unknown Sat Aug 09 22:40:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Feb 2024 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator