GNU bug report logs - #67000
30.0.50; [PATCH] Add support for reading/writing IELM input history

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> runbox.com>
Subject: bug#67000: closed (Re: bug#67000: 30.0.50; [PATCH] Add support
 for reading/writing IELM input history)
Date: Thu, 15 Feb 2024 07:56:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 67000 <at> debbugs.gnu.org.

-- 
67000: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67000
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 67000-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#67000: 30.0.50; [PATCH] Add support for reading/writing
 IELM input history
Date: Thu, 15 Feb 2024 08:53:00 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> LGTM, please install.

Done! Thanks again for reviewing.

>>>> +(defcustom ielm-history-file-name
>>>> +  (locate-user-emacs-file "ielm-history.eld")
>>>> +  "If non-nil, name of the file to read/write IELM input history."
>>>> +  :type '(choice (const :tag "nil" nil)
>>>
>>> The tag here should be "Disable input history" or something like that.
>>
>> Ok. Should it be updated for `comint-input-ring-file-name' too then (I
>> copied it from there)?
>
> Yes, that could be improved too.

Done.

>> From fe91c4f3aaefc109135c48ba26f8f21e87db465e Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg <at> runbox.com>
>> Date: Tue, 16 Jan 2024 08:21:41 +0100
>> Subject: [PATCH] Add support for reading/writing IELM input history
>>
>> * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for
>> reading/writing input history.
>
> How about:
>
>     "Add support for saving input history to a file"

Changed.

>> (ielm--history-file-name): Name of the file to read/write IELM input
>> history.
>
> Maybe:
>
>     "New variable indicating IELM input history file.

Changed.

>> +(defcustom ielm-history-file-name
>> +  (locate-user-emacs-file "ielm-history.eld")
>> +  "If non-nil, name of the file to read/write IELM input history."
>> +  :type '(choice (const :tag "Disable input history" nil)
>> +                 file)
>> +  :version "30.1")
>
> Maybe `file' should have a tag too?

The label in the Custom menu says "File", which seems fine to me? Though
I never use Custom, so I'm not sure what's customary here. I installed
the above without changes, but please feel free to change it.

-- Simen

[Message part 3 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Add support for reading/writing IELM input history
Date: Wed, 08 Nov 2023 16:11:25 +0100

[Message part 4 (text/plain, inline)]

Attached is a proposed patch that adds input history read/write
capabilities to IELM.

[0001-Add-support-for-reading-writing-IELM-input-history.patch (text/x-diff, attachment)]

[Message part 6 (text/plain, inline)]

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.