GNU bug report logs - #67000
30.0.50; [PATCH] Add support for reading/writing IELM input history

Previous Next

Full log

Message #31 received at 67000 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 67000 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#67000: 30.0.50; [PATCH] Add support for reading/writing
 IELM input history
Date: Fri, 19 Jan 2024 08:48:51 +0100

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

> I'm not against adding a hook to `kill-emacs-hook', but it should be
> added when you start IELM and not on top-level.  We want to avoid any
> side effects from merely loading a file.

Fixed.

> I don't think this will work in its current form either: AFAICT,
> `comint-write-input-ring' saves it for the current buffer, and that's
> not guaranteed to be the *ielm* buffer when `kill-emacs-hook' runs.
>
> So you'd want to first switch to that buffer, I think.  It could also
> have been renamed meanwhile, so I think you want to save the actual
> buffer and not it's name (i.e. use `get-buffer').

Right, good catch. New attempt in the attached patch!

[0001-Add-support-for-reading-writing-IELM-input-history.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.