GNU bug report logs - #66988
30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode

Previous Next

Full log

Message #47 received at 66988 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 66988 <at> debbugs.gnu.org,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 Theodor Thornhill <theo <at> thornhill.no>,
 Loïc Lemaître <loic.lemaitre <at> gmail.com>
Subject: Re: bug#66988: 30.0.50; treesit-forward-sexp not working properly in
 js-ts-mode and tsx-ts-mode
Date: Sat, 18 Nov 2023 22:19:15 -0800

> On Nov 18, 2023, at 9:48 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sat, 18 Nov 2023 10:57:56 -0800
>> Cc: Dmitry Gutov <dmitry <at> gutov.dev>,
>> Theodor Thornhill <theo <at> thornhill.no>,
>> 66988 <at> debbugs.gnu.org,
>> Loïc Lemaître <loic.lemaitre <at> gmail.com>,
>> Mattias Engdegård <mattias.engdegard <at> gmail.com>
>> 
>> 
>> 
>>> On Nov 15, 2023, at 4:19 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> 
>>>> From: Yuan Fu <casouri <at> gmail.com>
>>>> Date: Tue, 14 Nov 2023 22:28:34 -0800
>>>> Cc: Dmitry Gutov <dmitry <at> gutov.dev>,
>>>> Theodor Thornhill <theo <at> thornhill.no>,
>>>> 66988 <at> debbugs.gnu.org,
>>>> loic.lemaitre <at> gmail.com
>>>> 
>>>>> Is it feasible to have a variable that controls whether the full
>>>>> matches are implied in these APIs?  Then we could start by making it
>>>>> optional, and at some later time make it the default.
>>>> 
>>>> It’s feasible, but I don’t think it’s TRT. The major mode author should have the control over whether the full match is implied, not the user. It doesn’t make sense to toggle the variable either. If you change that variable, major mode code must also change to be correct.
>>> 
>>> So what do you suggest that we do about this issue?
>> 
>> We change every treesit function that takes a regexp for matching node type names to imply full match. I think most people wrote code as if these functions use full match, so the breakage should be small. And I can forecast this change in as many channels as I can.
> 
> Fine by me, so let's do it.

Ok, I’ll start preparing the patch and news. Meanwhile, folks, let me know if anyone has objections.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.