GNU bug report logs - #66988
30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode

Previous Next

Full log

Message #17 received at 66988 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: dmitry <at> gutov.dev, 66988 <at> debbugs.gnu.org, theo <at> thornhill.no,
 loic.lemaitre <at> gmail.com
Subject: Re: bug#66988: 30.0.50;
 treesit-forward-sexp not working properly in js-ts-mode and
 tsx-ts-mode
Date: Sat, 11 Nov 2023 09:35:56 +0200

> Cc: Theodor Thornhill <theo <at> thornhill.no>, 66988 <at> debbugs.gnu.org,
>  Loïc Lemaître <loic.lemaitre <at> gmail.com>
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Fri, 10 Nov 2023 18:41:20 -0800
> 
> > Alternatively, treesit-thing-settings could be interpreted to imply full matches, then the code using it should not only match against the regexps but also check that the entire string (type name) is matched.
> 
> I regret not doing this by default for treesit-indent-rules and traverse functions. Now it’s hard to change without creating confusion and breaking backward compatibility. I wonder if there are good way to smoothly transition to match full names by default…
> 
> Treesit-thing-settings can be changed to match full names, but only if we can change treesit-indent-rules and friends too. Otherwise it would be too confusing.

Is it feasible to have a variable that controls whether the full
matches are implied in these APIs?  Then we could start by making it
optional, and at some later time make it the default.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.