From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 14:16:23 2010 Received: (at submit) by debbugs.gnu.org; 21 Jul 2010 18:16:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obdq7-0007i1-5r for submit@debbugs.gnu.org; Wed, 21 Jul 2010 14:16:23 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obdq5-0007hs-5z for submit@debbugs.gnu.org; Wed, 21 Jul 2010 14:16:17 -0400 Received: from lists.gnu.org ([199.232.76.165]:33966) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ObdqW-00042v-9N for submit@debbugs.gnu.org; Wed, 21 Jul 2010 14:16:44 -0400 Received: from [140.186.70.92] (port=47508 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObdqU-00049G-AR for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 14:16:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObdqT-0000Sm-6K for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 14:16:42 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:47666) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObdqS-0000Sc-VT for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 14:16:41 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o6LIGcg2011411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Jul 2010 18:16:39 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o6LGlbSl016687 for ; Wed, 21 Jul 2010 18:16:30 GMT Received: from abhmt006.oracle.com by acsmt353.oracle.com with ESMTP id 424747431279736184; Wed, 21 Jul 2010 11:16:24 -0700 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 21 Jul 2010 11:16:23 -0700 From: "Drew Adams" To: Subject: 24.0.50; thing-at-point-url-at-point and ffap-guesser problem Date: Wed, 21 Jul 2010 11:16:25 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcspANTOhAAhUHlUQ0q1cLGazf6y3A== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4C47397F.002D:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) emacs -Q Load thingatpt.el and ffap.el. Use this test line of text: ;; c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf 1. Put the cursor on the g of Settings. M-: (thing-at-point-url-at-point) => "http://Settings/foobar/My" 2. Put the cursor on the S of MyStuff. M-: (thing-at-point-url-at-point) => "http://Documents/MyStuff/foo.pdf" Neither of those is remotely correct. 3. Put the cursor on the g of Settings. M-: (ffap-guesser) => nil Same thing with cursor *anywhere* on the absolute file name, except: If the cursor is on any character in this string: "c:/Documents" then (ffap-guesser) returns "c:/Documents and Settings/" (which is also wrong). What should happen: `ffap-guesser' should return "c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf" `thing-at-point-url-at-point should return "http://c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf" In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-07-19 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include' From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 10:02:25 2011 Received: (at 6695) by debbugs.gnu.org; 14 Jul 2011 14:02:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhMUf-00040v-45 for submit@debbugs.gnu.org; Thu, 14 Jul 2011 10:02:25 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhMUZ-00040S-Gv for 6695@debbugs.gnu.org; Thu, 14 Jul 2011 10:02:19 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QhMUO-00071T-2U; Thu, 14 Jul 2011 16:02:04 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 24.0.50; thing-at-point-url-at-point and ffap-guesser problem In-Reply-To: (Drew Adams's message of "Wed, 21 Jul 2010 11:16:25 -0700") Date: Thu, 14 Jul 2011 15:25:09 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Depeche Mode's _Black Celebration_ X-Hashcash: 1:23:110714:6695@debbugs.gnu.org::WEo1TVePx03LqOT4:00000000000000000000000000000000000000000u/pv X-Hashcash: 1:23:110714:drew.adams@oracle.com::QEBmBlo1jMbYew3d:0000000000000000000000000000000000000001pW1+ MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QhMUO-00071T-2U X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311256924.26677@eWMAfL5HLG4ehOJyjGk0yw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6695 Cc: 6695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > Load thingatpt.el and ffap.el. Use this test line of text: > > ;; c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf > > 1. Put the cursor on the g of Settings. > M-: (thing-at-point-url-at-point) => "http://Settings/foobar/My" > > 2. Put the cursor on the S of MyStuff. > M-: (thing-at-point-url-at-point) => > "http://Documents/MyStuff/foo.pdf" These both return nil for me in Emacs 24. > Neither of those is remotely correct. > > 3. Put the cursor on the g of Settings. > M-: (ffap-guesser) => nil [...] > What should happen: > > `ffap-guesser' should return > "c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf" > > `thing-at-point-url-at-point should return > "http://c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf" I don't really see how guessing that these things are file names is feasible. Unless one adds special matches for Windows where [letter]:/ matches stuff until the end of the line or something... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 12:29:36 2011 Received: (at 6695) by debbugs.gnu.org; 14 Jul 2011 16:29:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhOnA-0004He-Av for submit@debbugs.gnu.org; Thu, 14 Jul 2011 12:29:36 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhOn8-0004HQ-R4 for 6695@debbugs.gnu.org; Thu, 14 Jul 2011 12:29:35 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6EGTRc1025075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Jul 2011 16:29:28 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6EGTQgY009715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jul 2011 16:29:26 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6EGTLV8004678; Thu, 14 Jul 2011 11:29:21 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 14 Jul 2011 09:29:20 -0700 From: "Drew Adams" To: "'Lars Magne Ingebrigtsen'" References: Subject: RE: 24.0.50; thing-at-point-url-at-point and ffap-guesser problem Date: Thu, 14 Jul 2011 09:29:19 -0700 Message-ID: <0C6ECB66B9154AEFB52AD5EDD9B54E6F@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcxCLqTv5DBw8p8IQEGbO1riX5DNAwAE7qKg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4E1F1968.0111:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 6695 Cc: 6695@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) > These both return nil for me in Emacs 24. Yes. So it is still not fixed, but is broken in another way. Well, to be fair, punting and returning nil is not incorrect in the sense that it gives the wrong URL. It is incorrect in that it does not give the (correct) URL at all. It says, in effect, there is no URL at point, which is wrong. > > Neither of those is remotely correct. > > > > 3. Put the cursor on the g of Settings. > > M-: (ffap-guesser) => nil In the case of `ffap-guesser' it is perhaps too strong to say that a nil value indicates that there is no URL at point (as in the `thing-at-point' case). It is only claiming to "guess", whereas `thing-at-point' returning nil claims that there is no URL at point, and programs should be able to depend on that. > > What should happen: > > > > `ffap-guesser' should return > > "c:/Documents and Settings/foobar/My Documents/MyStuff/foo.pdf" > > > > `thing-at-point-url-at-point should return > > "http://c:/Documents and Settings/foobar/My > Documents/MyStuff/foo.pdf" > > I don't really see how guessing that these things are file names is > feasible. Why not? That's their job. > Unless one adds special matches for Windows where [letter]:/ matches > stuff until the end of the line or something... Maybe. Dunno. It would be good for someone knowledgable in thingatpt.el and ffap.el take a look and see how these cases can be improved. In the case of ffap.el, I guess you could call this an enhancement request, since returning `nil' is just giving up and saying it has no "guess". In the case of thingatpt.el, this is a bug: it claims incorrectly that there is no URL at point. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 08:42:54 2011 Received: (at control) by debbugs.gnu.org; 15 Jul 2011 12:42:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhhjK-0007g9-L5 for submit@debbugs.gnu.org; Fri, 15 Jul 2011 08:42:54 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhhjI-0007fx-NR for control@debbugs.gnu.org; Fri, 15 Jul 2011 08:42:53 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qhhj7-0000dR-UE for control@debbugs.gnu.org; Fri, 15 Jul 2011 14:42:41 +0200 Date: Fri, 15 Jul 2011 14:42:41 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #8439 X-MailScanner-ID: 1Qhhj7-0000dR-UE X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311338562.16544@EvbzyCvJ7x6sGGPlwX7t8w X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) forcemerge 8439 6695 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 16:03:41 2012 Received: (at control) by debbugs.gnu.org; 5 Dec 2012 21:03:41 +0000 Received: from localhost ([127.0.0.1]:55322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgM85-0001qn-5r for submit@debbugs.gnu.org; Wed, 05 Dec 2012 16:03:41 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:53525) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgM83-0001qg-CD for control@debbugs.gnu.org; Wed, 05 Dec 2012 16:03:40 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TgM7t-0000LR-Uq for control@debbugs.gnu.org; Wed, 05 Dec 2012 16:03:29 -0500 Date: Wed, 05 Dec 2012 16:03:29 -0500 Message-Id: Subject: control message for bug 13087 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) forcemerge 6695 13087 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 08:32:03 2019 Received: (at 6695) by debbugs.gnu.org; 23 Nov 2019 13:32:03 +0000 Received: from localhost ([127.0.0.1]:55981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVW4-0003yg-Dl for submit@debbugs.gnu.org; Sat, 23 Nov 2019 08:32:00 -0500 Received: from quimby.gnus.org ([95.216.78.240]:36150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVW2-0003tF-9G; Sat, 23 Nov 2019 08:31:58 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iYVVs-0005hy-GE; Sat, 23 Nov 2019 14:31:50 +0100 From: Lars Ingebrigtsen To: jari Subject: Re: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) References: <87pqoyaxu0.fsf@blue.sea.net> <87zk3i7tbu.fsf@picasso.cante.net> <20121020075601.GD29154@picasso.cante.net> <20121020084551.GE29154@picasso.cante.net> Date: Sat, 23 Nov 2019 14:31:47 +0100 In-Reply-To: <20121020084551.GE29154@picasso.cante.net> (jari's message of "Sat, 20 Oct 2012 11:45:51 +0300") Message-ID: <87mucmn2gs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: jari writes: > In this patch (compared to previous v3): > > - remove functions related to Cygwin and use cygwin-convert-path-from-windows > > - obey END parameter in ffap-search-backward-file-end as originally > i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6695 Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) jari writes: > In this patch (compared to previous v3): > > - remove functions related to Cygwin and use cygwin-convert-path-from-windows > > - obey END parameter in ffap-search-backward-file-end as originally > intended > > - correct "path-separator" term into "dir-separator" everywhere This was seven years ago, and not surprisingly, the patch doesn't apply any more. But I think the approach here seemed good -- going back in the buffer and check whether you find something that matches a file on the file system (if I understood the patch correctly). Is there still interest in making this work, or has everybody given up on using ffap with file names with spaces? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 09:09:02 2020 Received: (at 6695) by debbugs.gnu.org; 14 Aug 2020 13:09:02 +0000 Received: from localhost ([127.0.0.1]:52159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6ZSA-0004si-2H for submit@debbugs.gnu.org; Fri, 14 Aug 2020 09:09:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6ZS5-0004sG-GR; Fri, 14 Aug 2020 09:09:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D565X9EfVleF++1QbiQNyJaf431tQYuoV7MrNKpWaH0=; b=fsmMRThetE5xtIJvMZycE3vQGZ SmQZSni25T9WHpU7IDk6BXSmvhJLDPU1QNSm+6zxoDjM4alLb3iQr+zBGkFGjpH1NwyxDdo7/sN95 5rmAKGi6alAWFn6rr+Mb/OeSe5IJu9u0OwfaiN4uZCLPlhaD63jK1KgjMBcoEc4++qHM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6ZRv-00028Y-Ol; Fri, 14 Aug 2020 15:08:50 +0200 From: Lars Ingebrigtsen To: jari Subject: Re: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) References: <87pqoyaxu0.fsf@blue.sea.net> <87zk3i7tbu.fsf@picasso.cante.net> <20121020075601.GD29154@picasso.cante.net> <20121020084551.GE29154@picasso.cante.net> <87mucmn2gs.fsf@gnus.org> Date: Fri, 14 Aug 2020 15:08:45 +0200 In-Reply-To: <87mucmn2gs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 23 Nov 2019 14:31:47 +0100") Message-ID: <87tux574te.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > This was seven years ago, and not surprisingly, the patch doesn't apply > any more. I've respun the patch so that it now applies to Emacs 28, and the test cases seem to kinda work? The c: isn't included, but is that to be expected? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6695 Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > This was seven years ago, and not surprisingly, the patch doesn't apply > any more. I've respun the patch so that it now applies to Emacs 28, and the test cases seem to kinda work? The c: isn't included, but is that to be expected? I removed the Cygwin char translation stuff, because there was some discussion about whether that was needed. So what do people think? Good or bad? Does this work in any way sensibly for people? diff --git a/lisp/ffap.el b/lisp/ffap.el index 4a506207d5..6d40fa8c45 100644 --- a/lisp/ffap.el +++ b/lisp/ffap.el @@ -1109,6 +1109,123 @@ ffap-string-at-point ;; Added at suggestion of RHOGEE (for ff-paths), 7/24/95. "Last string returned by the function `ffap-string-at-point'.") +;; Test cases: (let ((ffap-file-name-with-spaces-flag t)) (ffap-string-at-point)) +;; +;; c:/Program Files/Open Text Evaluation Media/Open Text Exceed 14 x86/Program here.txt +;; c:/Program Files/Open Text Evaluation Media/Open Text Exceed 14 x86/Program Files/Hummingbird/ +;; c:\Program Files\Open Text Evaluation Media\Open Text Exceed 14 x86\Program Files\Hummingbird\ +;; c:\Program Files\Freescale\CW for MPC55xx and MPC56xx 2.10\PowerPC_EABI_Tools\Command_Line_Tools\CLT_Usage_Notes.txt +;; C:\temp\program.log on Windows or /var/log/program.log on Unix. + +(defvar ffap-file-name-with-spaces-flag (memq system-type '(ms-dos windows-nt)) + "If non-nil, enable looking for paths with spaces in `ffap-string-at-point'. +Enabled in W32 by default.") + +(defun ffap-search-backward-file-end (&optional dir-separator end) + "Search backward position point where file would probably end. +Optional DIR-SEPARATOR defaults to \"/\". The search maximum is +`line-end-position' or optional END point. + +Suppose the cursor is somewhere that might be near end of file, +the guessing would position point before punctuation (like comma) +after the file extension: + + C:\temp\file.log, which contain .... + =============================== (before) + ---------------- (after) + + + C:\temp\file.log on Windows or /tmp/file.log on Unix + =============================== (before) + ---------------- (after) + +The strategy is to search backward until DIR-SEPARATOR which defaults to +\"/\" and then take educated guesses. + +Move point and return point if an adjustment was done." + (unless dir-separator + (setq dir-separator "/")) + (let ((opoint (point)) + point punct end whitespace-p) + (when (re-search-backward + (regexp-quote dir-separator) (line-beginning-position) t) + ;; Move to the beginning of the match.. + (forward-char 1) + ;; ... until typical punctuation. + (when (re-search-forward "\\([][<>()\"'`,.:;]\\)" + (or end + (line-end-position)) + t) + (setq end (match-end 0)) + (setq punct (match-string 1)) + (setq whitespace-p (looking-at "[ \t\r\n]\\|$")) + (goto-char end) + (cond + ((and (string-equal punct ".") + whitespace-p) ;end of sentence + (setq point (1- (point)))) + ((and (string-equal punct ".") + (looking-at "[a-zA-Z0-9.]+")) ;possibly file extension + (setq point (match-end 0))) + (t + (setq point (point))))) + (goto-char opoint) + (when point + (goto-char point) + point)))) + +(defun ffap-search-forward-file-end (&optional dir-separator) + "Search DIR-SEPARATOR and position point at file's maximum ending. +This includes spaces. +Optional DIR-SEPARATOR defaults to \"/\". +Call `ffap-search-backward-file-end' to refine the ending point." + (unless dir-separator + (setq dir-separator "/")) + (let* ((chars ;expected chars in file name + (concat "[^][^<>()\"'`;,#*|" + ;; exclude the opposite as we know the separator + (if (string-equal dir-separator "/") + "\\\\" + "/") + "\t\r\n]")) + (re (concat + chars "*" + (if dir-separator + (regexp-quote dir-separator) + "/") + chars "*"))) + (when (looking-at re) + (goto-char (match-end 0))))) + +(defun ffap-dir-separator-near-point () + "Search backward and forward for closest slash or backlash in line. +Return string slash or backslash. Point is moved to closest position." + (let ((point (point)) + str pos) + (when (looking-at ".*?/") + (setq str "/" + pos (match-end 0))) + (when (and (looking-at ".*?\\\\") + (or (null pos) + (< (match-end 0) pos))) + (setq str "\\" + pos (match-end 0))) + (goto-char point) + (when (and (re-search-backward "/" (line-beginning-position) t) + (or (null pos) + (< (- point (point)) (- pos point)))) + (setq str "/" + pos (1+ (point)))) ;1+ to keep cursor at the end of char + (goto-char point) + (when (and (re-search-backward "\\\\" (line-beginning-position) t) + (or (null pos) + (< (- point (point)) (- pos point)))) + (setq str "\\" + pos (1+ (point)))) + (when pos + (goto-char pos)) + str)) + (defun ffap-string-at-point (&optional mode) "Return a string of characters from around point. @@ -1128,7 +1245,8 @@ ffap-string-at-point When the region is active and larger than `ffap-max-region-length', return an empty string, and set `ffap-string-at-point-region' to '(1 1)." - (let* ((args + (let* (dir-separator + (args (cdr (or (assq (or mode major-mode) ffap-string-at-point-mode-alist) (assq 'file ffap-string-at-point-mode-alist)))) @@ -1137,14 +1255,25 @@ ffap-string-at-point (beg (if region-selected (region-beginning) (save-excursion - (skip-chars-backward (car args)) - (skip-chars-forward (nth 1 args) pt) + (if (and ffap-file-name-with-spaces-flag + (memq mode '(nil file))) + (when (setq dir-separator (ffap-dir-separator-near-point)) + (while (re-search-backward + (regexp-quote dir-separator) + (line-beginning-position) t) + (goto-char (match-beginning 0)))) + (skip-chars-backward (car args)) + (skip-chars-forward (nth 1 args) pt)) (point)))) (end (if region-selected (region-end) (save-excursion (skip-chars-forward (car args)) (skip-chars-backward (nth 2 args) pt) + (when (and ffap-file-name-with-spaces-flag + (memq mode '(nil file))) + (ffap-search-forward-file-end dir-separator) + (ffap-search-backward-file-end dir-separator)) (point)))) (region-len (- (max beg end) (min beg end)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 05:08:08 2020 Received: (at 6695) by debbugs.gnu.org; 15 Aug 2020 09:08:08 +0000 Received: from localhost ([127.0.0.1]:54261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6sAZ-0000Uo-Tm for submit@debbugs.gnu.org; Sat, 15 Aug 2020 05:08:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6sAW-0000UF-DB; Sat, 15 Aug 2020 05:08:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47159) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6sAQ-0007VW-IC; Sat, 15 Aug 2020 05:07:58 -0400 Received: from [176.228.60.248] (port=4282 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6sAP-00082S-Vx; Sat, 15 Aug 2020 05:07:58 -0400 Date: Sat, 15 Aug 2020 12:07:52 +0300 Message-Id: <83v9hkjmzb.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87tux574te.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 14 Aug 2020 15:08:45 +0200) Subject: Re: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) References: <87pqoyaxu0.fsf@blue.sea.net> <87zk3i7tbu.fsf@picasso.cante.net> <20121020075601.GD29154@picasso.cante.net> <20121020084551.GE29154@picasso.cante.net> <87mucmn2gs.fsf@gnus.org> <87tux574te.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 6695 Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, Eli Zaretskii > Date: Fri, 14 Aug 2020 15:08:45 +0200 > > I've respun the patch so that it now applies to Emacs 28, and the test > cases seem to kinda work? Thanks. > The c: isn't included, but is that to be expected? Is it? I thought the intent was to include the full file name, which means the drive letter should be included. Otherwise the file will not be found. > So what do people think? Good or bad? Does this work in any way > sensibly for people? Since the heuristic only covers some use cases, I think we should have it off by default, and we should document its potential pitfalls in the doc string. With those qualifications, I'm okay with adding this optional feature. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 06:13:18 2020 Received: (at 6695) by debbugs.gnu.org; 15 Aug 2020 10:13:18 +0000 Received: from localhost ([127.0.0.1]:54279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tBe-000262-Cw for submit@debbugs.gnu.org; Sat, 15 Aug 2020 06:13:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tBa-00025h-DK; Sat, 15 Aug 2020 06:13:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uNbvnUnG7w6NOrkUyn7aSXZQOxhoyQnUZY4bkaQeKzQ=; b=eaxi4hfXpuEEBcbpPDqPeq/7Je 7WCQ6ETecdfHi6rDKZ6/8EmnlkvTdOAeXxMQ3iI0+XR29hSkD+12PLFwkOSiJRBPS4WGGYUR4apQR i6zF1cyXM/BNMnNMPcRiiFx66EBkbE2oWboiOUZ8rs1xEIfrpVFojrEnbj3ulWlJHB6k=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tBR-0006TE-3p; Sat, 15 Aug 2020 12:13:07 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) References: <87pqoyaxu0.fsf@blue.sea.net> <87zk3i7tbu.fsf@picasso.cante.net> <20121020075601.GD29154@picasso.cante.net> <20121020084551.GE29154@picasso.cante.net> <87mucmn2gs.fsf@gnus.org> <87tux574te.fsf@gnus.org> <83v9hkjmzb.fsf@gnu.org> Date: Sat, 15 Aug 2020 12:13:04 +0200 In-Reply-To: <83v9hkjmzb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Aug 2020 12:07:52 +0300") Message-ID: <87o8nc1akv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> The c: isn't included, but is that to be expected? > > Is it? I thought the intent was to include the full file name, which > means the drive letter should be included. Otherwise the file will > no [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6695 Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> The c: isn't included, but is that to be expected? > > Is it? I thought the intent was to include the full file name, which > means the drive letter should be included. Otherwise the file will > not be found. I don't have a Windows system to test with... it's possible that the functions return the file name including the c: on a Windows machine? >> So what do people think? Good or bad? Does this work in any way >> sensibly for people? > > Since the heuristic only covers some use cases, I think we should have > it off by default, and we should document its potential pitfalls in > the doc string. With those qualifications, I'm okay with adding this > optional feature. OK, I've added some tests and pushed it to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 06:13:24 2020 Received: (at control) by debbugs.gnu.org; 15 Aug 2020 10:13:24 +0000 Received: from localhost ([127.0.0.1]:54284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tBj-00026R-Su for submit@debbugs.gnu.org; Sat, 15 Aug 2020 06:13:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tBg-00025q-3H for control@debbugs.gnu.org; Sat, 15 Aug 2020 06:13:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uctZcPPi8+VWsWwJ5qHxrJmCTvoiVSAOR3wuxqx0Ex4=; b=A6Vi9wjf6gqSwDVWmt3yPwxBJ4 KYUxqtK8belP42tiaOdvP9JOUNyLrhZeFJRenCeDjf9iaI6Yk1NxXkEJCNR1plP3wDGkI+4rJbIdJ uZ7GLwMQamr9qrvzM5pVtVcalQy3qHYpF8an9lAa6egG8maWRLaSyZAdqHVwyWzE6tDI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tBY-0006TL-5B for control@debbugs.gnu.org; Sat, 15 Aug 2020 12:13:14 +0200 Date: Sat, 15 Aug 2020 12:13:11 +0200 Message-Id: <87mu2w1ako.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #8439 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 8439 fixed close 8439 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 8439 fixed close 8439 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 15:34:06 2020 Received: (at 6695) by debbugs.gnu.org; 15 Aug 2020 19:34:06 +0000 Received: from localhost ([127.0.0.1]:56481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k71wM-0000kZ-J0 for submit@debbugs.gnu.org; Sat, 15 Aug 2020 15:34:06 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:38322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k71wJ-0000jw-Ei; Sat, 15 Aug 2020 15:34:05 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07FJXbiV005121; Sat, 15 Aug 2020 19:33:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=sCIfUF2CmXIwIJ++7msCsZEbclCKOcFIUajXC0sG95Q=; b=pY1bWYAMBDmFZ/F0TeBPPEYlKjlfvehH8hYUVwJsQN3zro8vHHyWFRXeBsRPqN7wZ7Yc gmJkVdex8YFZr/C3kZyrZVLmc3ffRENWSJH8we6OX+RomiAzcAUtMHdm4lC5u9tlrtLU dFaEaGjrww+Jgd5o80f5uBIhlFBOFxmLJWK8fhWX4LLijg+dLI5lRwokn6oLWr64BfAp mCgEG8/GgYvqhZtoIHhclasjK0cVJQ3r+uxxDEu8hWc2MWP500biqYnWQ889yGIXVAXe HKG3zkVX8YqhVFNnLGdMtI7Mn68hCNPHrbJOpaFYDbEEKzoNyX6+i9EWpCY4/80FX34L ZA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 32x7nm1h2q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 15 Aug 2020 19:33:51 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07FJReZm105891; Sat, 15 Aug 2020 19:33:51 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 32x7h1ker2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Aug 2020 19:33:51 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07FJXnEN003127; Sat, 15 Aug 2020 19:33:49 GMT MIME-Version: 1.0 Message-ID: <80adac77-abed-48dd-81df-653100abcdd0@default> Date: Sat, 15 Aug 2020 12:33:48 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , Lars Ingebrigtsen Subject: RE: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) References: <<87pqoyaxu0.fsf@blue.sea.net>> <<87zk3i7tbu.fsf@picasso.cante.net>> <> <<20121020075601.GD29154@picasso.cante.net>> <<20121020084551.GE29154@picasso.cante.net>> <<87mucmn2gs.fsf@gnus.org>> <<87tux574te.fsf@gnus.org>> <<83v9hkjmzb.fsf@gnu.org>> In-Reply-To: <<83v9hkjmzb.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5017.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9714 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008150154 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9714 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008150154 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 6695 Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > The c: isn't included, but is that to be expected? >=20 > Is it? I thought the intent was to include the full file name, which > means the drive letter should be included. Otherwise the file will > not be found. >=20 > > So what do people think? Good or bad? Does this work in any way > > sensibly for people? >=20 > Since the heuristic only covers some use cases, I think we should have > it off by default, and we should document its potential pitfalls in > the doc string. With those qualifications, I'm okay with adding this > optional feature. FWIW: As the submitter of the original bug report (#6695), I'd say this shouldn't be marked "fixed" if the drive letter part (e.g. c:/) isn't included on MS Windows. It sounds like it represents some progress, but it sounds like it's not fixed yet. From unknown Tue Jun 24 19:12:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Sep 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator