GNU bug report logs - #66928
[PATCH 2/2] Update names to match the docstring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jeremy Bryant <jb <at> jeremybryant.net>
Subject: bug#66928: closed (Re: bug#66928: [PATCH 2/2] Update names to
 match the docstring)
Date: Sun, 12 Nov 2023 20:56:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#66928: [PATCH 2/2] Update names to match the docstring

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66928 <at> debbugs.gnu.org.

-- 
66928: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66928
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: 66928-done <at> debbugs.gnu.org
Subject: Re: bug#66928: [PATCH 2/2] Update names to match the docstring
Date: Sun, 12 Nov 2023 15:54:24 -0500

> I noticed that for the function below the docstring doesn't match the
> arg names.  I've chosen to keep the docstring on the basis that it may

This is now fixed, closing,


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: bug-gnu-emacs <at> gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: [PATCH 2/2] Update names to match the docstring
Date: Sat, 04 Nov 2023 12:49:27 +0000

[Message part 4 (text/plain, inline)]

Tags: patch

Hello

I noticed that for the function below the docstring doesn't match the
arg names.  I've chosen to keep the docstring on the basis that it may
be what has been the most visible for a time, and update the names in
the code.

In general, is it TRT?  Do we have a convention to keep names or the
docstring.  Please let me know if this patch is useful in its current
form or a change is needed.

thanks
Jeremy 

[0002-Update-names-to-match-the-docstring.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.