From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 11:04:59 2010 Received: (at submit) by debbugs.gnu.org; 21 Jul 2010 15:05:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obaqw-0006D8-B4 for submit@debbugs.gnu.org; Wed, 21 Jul 2010 11:04:59 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObZn7-0005iV-5f for submit@debbugs.gnu.org; Wed, 21 Jul 2010 09:56:58 -0400 Received: from lists.gnu.org ([199.232.76.165]:51054) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ObZnX-0007cz-Ux for submit@debbugs.gnu.org; Wed, 21 Jul 2010 09:57:23 -0400 Received: from [140.186.70.92] (port=45008 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObZnT-0002vT-JI for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 09:57:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObZnP-00033u-T1 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 09:57:19 -0400 Received: from mx2.imag.fr ([129.88.30.17]:37221 helo=rominette.imag.fr) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObZnP-00031d-LM for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 09:57:15 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id o6LDVhth031371 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Wed, 21 Jul 2010 15:31:43 +0200 Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1ObZQ3-0008SJ-Bn for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 15:33:07 +0200 Received: from moy by bauges.imag.fr with local (Exim 4.69) (envelope-from ) id 1ObZQ3-0005Bq-80 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2010 15:33:07 +0200 From: Matthieu Moy To: bug-gnu-emacs@gnu.org Subject: 23.2; Auto-fill broken in C/C++ modes. Date: Wed, 21 Jul 2010 15:33:07 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Wed, 21 Jul 2010 15:31:43 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: o6LDVhth031371 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr MailScanner-NULL-Check: 1280323903.59283@aMKzmESwpng25FKL1/t15w X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 21 Jul 2010 11:04:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Hi, I've had problems with auto-fill-mode in C and C++ comments for a while, I finally managed to find a small test-case: let this be a C program. /* Test */ #include #include If I put my cursor on the blank line below "Test", activate M-x auto-fill-mode RET (other than that, it's a plain "emacs -Q") and type SPC, I get this: /* Test *include #include with my cursor in the middle of the "*include". I can't reproduce on Emacs 22. Thanks, In GNU Emacs 23.2.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12) of 2010-05-10 on thabor Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--prefix=/usr/local/soft/emacs23/23.2' 'LDFLAGS=-L/local/berthier/usr/lib -L/usr/lib' 'CPPFLAGS=-I/local/berthier/usr/include -I/usr/include '' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: C/l Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: M-x a u t o - c i f i C-n C-n SPC C-_ M-x r e p o r t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Undo! Load-path shadows: None found. Features: (shadow sort mail-extr message sendmail ecomplete rfc822 mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils emacsbug cc-mode cc-fonts easymenu cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process font-render-setting gtk x-toolkit x multi-tty emacs) -- Matthieu From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 13:27:18 2010 Received: (at 6688) by debbugs.gnu.org; 21 Jul 2010 17:27:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obd4g-0007LR-8j for submit@debbugs.gnu.org; Wed, 21 Jul 2010 13:27:18 -0400 Received: from mx1.imag.fr ([129.88.30.5] helo=shiva.imag.fr) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obd4d-0007LL-PA for 6688@debbugs.gnu.org; Wed, 21 Jul 2010 13:27:17 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id o6LHHl3s030027 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 21 Jul 2010 19:17:47 +0200 Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtp (Exim 4.69) (envelope-from ) id 1Obd4z-0003Uu-9E; Wed, 21 Jul 2010 19:27:37 +0200 To: 6688@debbugs.gnu.org Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) References: From: Matthieu Moy Date: Wed, 21 Jul 2010 19:27:37 +0200 In-Reply-To: (GNU bug Tracking System's message of "Wed\, 21 Jul 2010 15\:05\:02 +0000") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Wed, 21 Jul 2010 19:17:47 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: o6LHHl3s030027 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1280337472.12313@lsZqqV/NUqYzZE2riM+9gw X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 6688 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Digging a bit further, I found out in this example: /* Test */ * The problems seems to be that the last */ is at the beginning of line. If I add a space before, the problem disapears. It seems to be a problem with `c-mask-paragraph', around this (let* ((ender-start (save-excursion (goto-char (cdr c-lit-limits)) (skip-syntax-backward "^w ") (point))) since the skip-syntax-backward will skip the newline and move out of the line of the */. * If I download version 5.31.3 of cc-mode and install it, the problem goes away. Hope this helps, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 16:15:07 2010 Received: (at 6688) by debbugs.gnu.org; 24 Jul 2010 20:15:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocl7j-0000qj-2r for submit@debbugs.gnu.org; Sat, 24 Jul 2010 16:15:07 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocl7f-0000q8-Hm for 6688@debbugs.gnu.org; Sat, 24 Jul 2010 16:15:04 -0400 Received: (qmail 67943 invoked by uid 3782); 24 Jul 2010 20:15:03 -0000 Received: from acm.muc.de (pD9E23917.dip.t-dialin.net [217.226.57.23]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sat, 24 Jul 2010 22:15:01 +0200 Received: (qmail 5067 invoked by uid 1000); 24 Jul 2010 20:26:05 -0000 Date: Sat, 24 Jul 2010 20:26:05 +0000 To: Matthieu Moy , martin rudalics Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) Message-ID: <20100724202605.GA4406@muc.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Hi, Matthieu, thanks for such a wonderfully helpful bug report! On Wed, Jul 21, 2010 at 07:27:37PM +0200, Matthieu Moy wrote: > Digging a bit further, I found out in this example: > /* > Test > */ > * The problems seems to be that the last */ is at the beginning of > line. If I add a space before, the problem disapears. It seems to be > a problem with `c-mask-paragraph', around this > (let* ((ender-start (save-excursion > (goto-char (cdr c-lit-limits)) > (skip-syntax-backward "^w ") > (point))) The problem is indeed nearby, in c-mask-paragraph. Would you please try out the patch below, indeed please test it as intensively as possible and let me know if there are any remaining problems. The code here is complicated enough for me not to be totally confident about the patch. > since the skip-syntax-backward will skip the newline and move out of > the line of the */. > * If I download version 5.31.3 of cc-mode and install it, the problem > goes away. > Hope this helps, Very much so! ######################################################################### Hi, Martin, would you please try this patch out on the test case for which you committed change 83096, and let me know if that bug remains fixed. 83096 is this one: ------------------------------------------------------------ revno: 83096 committer: Martin Rudalics timestamp: Sat 2007-12-08 09:55:18 +0000 message: (c-mask-paragraph): Avoid invalid search bound error in block comment branch. Thanks! ######################################################################### > -- > Matthieu Moy > http://www-verimag.imag.fr/~moy/ -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 05:50:46 2010 Received: (at 6688) by debbugs.gnu.org; 25 Jul 2010 09:50:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocxr4-0006U7-Jz for submit@debbugs.gnu.org; Sun, 25 Jul 2010 05:50:46 -0400 Received: from mail.gmx.net ([213.165.64.20]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Ocxr1-0006U1-3L for 6688@debbugs.gnu.org; Sun, 25 Jul 2010 05:50:44 -0400 Received: (qmail invoked by alias); 25 Jul 2010 09:50:43 -0000 Received: from 62-47-47-27.adsl.highway.telekom.at (EHLO [62.47.47.27]) [62.47.47.27] by mail.gmx.net (mp053) with SMTP; 25 Jul 2010 11:50:43 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1//zcBgru//TfMadzqEZPyGTzVGW8IPB70InGq+Ol wKHFzsPLE6FILd Message-ID: <4C4C08E8.1050306@gmx.at> Date: Sun, 25 Jul 2010 11:50:32 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Alan Mackenzie Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) References: <20100724202605.GA4406@muc.de> In-Reply-To: <20100724202605.GA4406@muc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org, Matthieu Moy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Hi, Alan! > Hi, Martin, > > would you please try this patch out on the test case for which you > committed change 83096, and let me know if that bug remains fixed. > 83096 is this one: What is "this patch"? I didn't receive any attachment and I see no patch of you in rev 100893. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 09:35:17 2010 Received: (at 6688) by debbugs.gnu.org; 25 Jul 2010 13:35:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od1MK-0000KM-S1 for submit@debbugs.gnu.org; Sun, 25 Jul 2010 09:35:17 -0400 Received: from mail.gmx.net ([213.165.64.20]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Od1MI-0000KG-3G for 6688@debbugs.gnu.org; Sun, 25 Jul 2010 09:35:15 -0400 Received: (qmail invoked by alias); 25 Jul 2010 13:35:15 -0000 Received: from 62-47-47-27.adsl.highway.telekom.at (EHLO [62.47.47.27]) [62.47.47.27] by mail.gmx.net (mp042) with SMTP; 25 Jul 2010 15:35:15 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/qxrQezqTqJoBAHTVPKkx10BL2tQXfY946bGEUyt mAg1uH7eG241lh Message-ID: <4C4C3D8E.5000101@gmx.at> Date: Sun, 25 Jul 2010 15:35:10 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Alan Mackenzie Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) References: <20100725130939.GA1141@muc.de> In-Reply-To: <20100725130939.GA1141@muc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org, Matthieu Moy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > Apologies for omitting the patch. Here it is: Thank you, applied. Is it sufficient to just recompile cc-cmds.el or do we have to recompile all cc-*.el files? martin From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 12:07:54 2010 Received: (at 6688) by debbugs.gnu.org; 25 Jul 2010 16:07:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od3k2-0001PL-ET for submit@debbugs.gnu.org; Sun, 25 Jul 2010 12:07:54 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Od3k0-0001PF-E0 for 6688@debbugs.gnu.org; Sun, 25 Jul 2010 12:07:53 -0400 Received: (qmail 66529 invoked by uid 3782); 25 Jul 2010 16:07:54 -0000 Received: from acm.muc.de (pD9E22C10.dip.t-dialin.net [217.226.44.16]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sun, 25 Jul 2010 18:07:52 +0200 Received: (qmail 1776 invoked by uid 1000); 25 Jul 2010 16:18:56 -0000 Date: Sun, 25 Jul 2010 16:18:56 +0000 To: martin rudalics Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) Message-ID: <20100725161856.GA1648@muc.de> References: <20100725130939.GA1141@muc.de> <4C4C3D8E.5000101@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C4C3D8E.5000101@gmx.at> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org, Matthieu Moy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) Hi, Martin, On Sun, Jul 25, 2010 at 03:35:10PM +0200, martin rudalics wrote: > > Apologies for omitting the patch. Here it is: > Thank you, applied. Is it sufficient to just recompile cc-cmds.el or > do we have to recompile all cc-*.el files? No, just compiling cc-cmds.el should do, since it's a "top level" file which doesn't suply macros etc. to the rest of cc-*.el. > martin -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 26 01:51:00 2010 Received: (at 6688) by debbugs.gnu.org; 26 Jul 2010 05:51:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdGaa-0007IV-MD for submit@debbugs.gnu.org; Mon, 26 Jul 2010 01:51:00 -0400 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OdGaY-0007IQ-AY for 6688@debbugs.gnu.org; Mon, 26 Jul 2010 01:51:00 -0400 Received: (qmail invoked by alias); 26 Jul 2010 05:51:01 -0000 Received: from 62-47-41-211.adsl.highway.telekom.at (EHLO [62.47.41.211]) [62.47.41.211] by mail.gmx.net (mp017) with SMTP; 26 Jul 2010 07:51:01 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19pGm86qA5pekY7vsN2mGeZuVSktezharHwr/ySEd qzxW4Kyifd+aMk Message-ID: <4C4D2242.1070809@gmx.at> Date: Mon, 26 Jul 2010 07:50:58 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Alan Mackenzie Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) References: <20100725130939.GA1141@muc.de> <4C4C3D8E.5000101@gmx.at> <20100725161856.GA1648@muc.de> In-Reply-To: <20100725161856.GA1648@muc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org, Matthieu Moy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Morning, Alan > No, just compiling cc-cmds.el should do, since it's a "top level" file > which doesn't suply macros etc. to the rest of cc-*.el. OK. So the warnings ... In toplevel form: C:/emacs/trunk/lisp/progmodes/cc-langs.el:135:1:Warning: cl package required at runtime In c-before-change-check-<>-operators: C:/emacs/trunk/lisp/progmodes/cc-engine.el:5076:25:Warning: reference to free variable `c-new-BEG' C:/emacs/trunk/lisp/progmodes/cc-engine.el:5076:42:Warning: assignment to free variable `c-new-BEG' C:/emacs/trunk/lisp/progmodes/cc-engine.el:5079:42:Warning: reference to free variable `c-new-END' C:/emacs/trunk/lisp/progmodes/cc-engine.el:5079:42:Warning: assignment to free variable `c-new-END' In c-common-init: C:/emacs/trunk/lisp/progmodes/cc-mode.el:643:11:Warning: assignment to free variable `c-new-BEG' C:/emacs/trunk/lisp/progmodes/cc-mode.el:644:11:Warning: assignment to free variable `c-new-END' ... I currently see are due to something else. How can I get rid of them? martin From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 26 04:27:20 2010 Received: (at 6688) by debbugs.gnu.org; 26 Jul 2010 08:27:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdJ1s-0008Lg-GP for submit@debbugs.gnu.org; Mon, 26 Jul 2010 04:27:20 -0400 Received: from mx1.imag.fr ([129.88.30.5] helo=shiva.imag.fr) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdJ1q-0008LZ-Eq for 6688@debbugs.gnu.org; Mon, 26 Jul 2010 04:27:19 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id o6Q8HG85002302 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 26 Jul 2010 10:17:16 +0200 Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtp (Exim 4.69) (envelope-from ) id 1OdJ1s-0003JT-LE; Mon, 26 Jul 2010 10:27:20 +0200 To: Alan Mackenzie Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) References: <20100725130939.GA1141@muc.de> From: Matthieu Moy Date: Mon, 26 Jul 2010 10:27:20 +0200 In-Reply-To: <20100725130939.GA1141@muc.de> (Alan Mackenzie's message of "Sun\, 25 Jul 2010 13\:09\:40 +0000") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Mon, 26 Jul 2010 10:17:16 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: o6Q8HG85002302 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1280737038.56295@LE9JQ6y06fgIkDnOXkSKyA X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 6688 Cc: martin rudalics , 6688@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Alan Mackenzie writes: > Hi, M & M, > > Apologies for omitting the patch. Here it is: That works for me, yes. Thanks, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 26 15:23:28 2010 Received: (at 6688) by debbugs.gnu.org; 26 Jul 2010 19:23:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdTGq-0005uJ-5s for submit@debbugs.gnu.org; Mon, 26 Jul 2010 15:23:28 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdTGn-0005uE-50 for 6688@debbugs.gnu.org; Mon, 26 Jul 2010 15:23:26 -0400 Received: (qmail 59245 invoked by uid 3782); 26 Jul 2010 19:23:29 -0000 Received: from acm.muc.de (pD9E51BFA.dip.t-dialin.net [217.229.27.250]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Mon, 26 Jul 2010 21:23:28 +0200 Received: (qmail 3713 invoked by uid 1000); 26 Jul 2010 19:34:35 -0000 Date: Mon, 26 Jul 2010 19:34:35 +0000 To: martin rudalics Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) Message-ID: <20100726193435.GA2993@muc.de> References: <20100725130939.GA1141@muc.de> <4C4C3D8E.5000101@gmx.at> <20100725161856.GA1648@muc.de> <4C4D2242.1070809@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C4D2242.1070809@gmx.at> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org, Matthieu Moy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) And a jolly evening to you too, Martin! On Mon, Jul 26, 2010 at 07:50:58AM +0200, martin rudalics wrote: > Morning, Alan > > No, just compiling cc-cmds.el should do, since it's a "top level" file > > which doesn't suply macros etc. to the rest of cc-*.el. > OK. So the warnings ... Hey, stop turning up the guilt machine! They suddenly "appeared" with either Emacs 22 or Emacs 23 (I can't remember any more) because of more rigorous checking by the byte compiler. > In toplevel form: > C:/emacs/trunk/lisp/progmodes/cc-langs.el:135:1:Warning: cl package required > at runtime That's an awkward one. I'm not sure I quite believe it, but I'm almost sure. > In c-before-change-check-<>-operators: > C:/emacs/trunk/lisp/progmodes/cc-engine.el:5076:25:Warning: reference to > free > variable `c-new-BEG' > C:/emacs/trunk/lisp/progmodes/cc-engine.el:5076:42:Warning: assignment to > free > variable `c-new-BEG' > C:/emacs/trunk/lisp/progmodes/cc-engine.el:5079:42:Warning: reference to > free > variable `c-new-END' > C:/emacs/trunk/lisp/progmodes/cc-engine.el:5079:42:Warning: assignment to > free > variable `c-new-END' > In c-common-init: > C:/emacs/trunk/lisp/progmodes/cc-mode.el:643:11:Warning: assignment to free > variable `c-new-BEG' > C:/emacs/trunk/lisp/progmodes/cc-mode.el:644:11:Warning: assignment to free > variable `c-new-END' These are working variables, properly declared "in the right place", until I found I needed to use them in initialisation routines too. There're quite a few variables like this. > ... I currently see are due to something else. How can I get rid of > them? Ask me nicely? ;-) They're the sort of problem which never seems high priority to fix, yet definitely needs doing. All together there are about 55 warning messages to fix. It would probably take an evening to do so. Give me a few days! > martin -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 27 03:23:08 2010 Received: (at 6688) by debbugs.gnu.org; 27 Jul 2010 07:23:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdeVI-0002V9-Gj for submit@debbugs.gnu.org; Tue, 27 Jul 2010 03:23:08 -0400 Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OdeVF-0002Um-DX for 6688@debbugs.gnu.org; Tue, 27 Jul 2010 03:23:07 -0400 Received: (qmail invoked by alias); 27 Jul 2010 07:23:11 -0000 Received: from 62-47-38-33.adsl.highway.telekom.at (EHLO [62.47.38.33]) [62.47.38.33] by mail.gmx.net (mp058) with SMTP; 27 Jul 2010 09:23:11 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/QTlscCgzQ2tgdLB1McpOCa9suCRefabwTmY7U6b jwEWN8XNQZbVlt Message-ID: <4C4E895C.3020208@gmx.at> Date: Tue, 27 Jul 2010 09:23:08 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Alan Mackenzie Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) References: <20100725130939.GA1141@muc.de> <4C4C3D8E.5000101@gmx.at> <20100725161856.GA1648@muc.de> <4C4D2242.1070809@gmx.at> <20100726193435.GA2993@muc.de> In-Reply-To: <20100726193435.GA2993@muc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org, Matthieu Moy X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) >> OK. So the warnings ... > > Hey, stop turning up the guilt machine! They suddenly "appeared" with > either Emacs 22 or Emacs 23 (I can't remember any more) because of more > rigorous checking by the byte compiler. [...] > Ask me nicely? ;-) They're the sort of problem which never seems high > priority to fix, yet definitely needs doing. All together there are > about 55 warning messages to fix. It would probably take an evening to > do so. Give me a few days! Sorry. It's the first time I had a closer look into compiler warnings for some time and I thought they might be related to the change at hand. Looking at compile logs is currently much too confusing for me with all the save-excursion/set-buffer warnings. The only thing about cc-* that really annoys me is an "old-style backquotes detected!" warning I get when I load cc-menus.el (don't ask me why I load it, I need the functionality somewhere). In any case I think you can check in the fix for 6688 now ;-) martin From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 31 05:38:28 2010 Received: (at 6688) by debbugs.gnu.org; 31 Jul 2010 09:38:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Of8WR-0006Cw-TL for submit@debbugs.gnu.org; Sat, 31 Jul 2010 05:38:28 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Of8WP-0006Cq-CT for 6688@debbugs.gnu.org; Sat, 31 Jul 2010 05:38:26 -0400 Received: (qmail 6396 invoked by uid 3782); 31 Jul 2010 09:38:42 -0000 Received: from acm.muc.de (pD9E52E2C.dip.t-dialin.net [217.229.46.44]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sat, 31 Jul 2010 11:38:41 +0200 Received: (qmail 2833 invoked by uid 1000); 31 Jul 2010 09:49:54 -0000 Date: Sat, 31 Jul 2010 09:49:54 +0000 To: Matthieu Moy , martin rudalics Subject: Re: bug#6688: Acknowledgement (23.2; Auto-fill broken in C/C++ modes.) Message-ID: <20100731094954.GA2769@muc.de> References: <20100725130939.GA1141@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100725130939.GA1141@muc.de> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 6688 Cc: 6688@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Hi, Matthieu and Martin, I've applied this patch to the Bazaar head at savannah. That should fix the bug. Thanks once again for such a high quality bug report. On Sun, Jul 25, 2010 at 01:09:39PM +0000, Alan Mackenzie wrote: > === modified file 'lisp/progmodes/cc-cmds.el' > *** lisp/progmodes/cc-cmds.el 2010-05-12 11:06:12 +0000 > --- lisp/progmodes/cc-cmds.el 2010-07-23 21:27:24 +0000 > *************** > *** 3974,3989 **** > ;; "Invalid search bound (wrong side of point)" > ;; error in the subsequent re-search. Maybe > ;; another fix would be needed (2007-12-08). > ! (and (> (- (cdr c-lit-limits) 2) (point)) > (search-forward-regexp > (concat "\\=[ \t]*\\(" c-current-comment-prefix "\\)") > (- (cdr c-lit-limits) 2) t) > (not (search-forward-regexp > "\\(\\s \\|\\sw\\)" > (- (cdr c-lit-limits) 2) 'limit)) > ! ;; The comment ender IS on its own line. Exclude > ! ;; this line from the filling. > ! (set-marker end (c-point 'bol)))) > > ;; The comment ender is hanging. Replace all space between it > ;; and the last word either by one or two 'x's (when > --- 3974,3990 ---- > ;; "Invalid search bound (wrong side of point)" > ;; error in the subsequent re-search. Maybe > ;; another fix would be needed (2007-12-08). > ! (or (<= (- (cdr c-lit-limits) 2) (point)) > ! (and > (search-forward-regexp > (concat "\\=[ \t]*\\(" c-current-comment-prefix "\\)") > (- (cdr c-lit-limits) 2) t) > (not (search-forward-regexp > "\\(\\s \\|\\sw\\)" > (- (cdr c-lit-limits) 2) 'limit)) > ! ;; The comment ender IS on its own line. Exclude > ! ;; this line from the filling. > ! (set-marker end (c-point 'bol))))) > > ;; The comment ender is hanging. Replace all space between it > ;; and the last word either by one or two 'x's (when > > ######################################################################### > > http://www-verimag.imag.fr/~moy/ -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 04 16:07:59 2010 Received: (at 6688-done) by debbugs.gnu.org; 4 Aug 2010 20:07:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OgkFr-0002vl-6e for submit@debbugs.gnu.org; Wed, 04 Aug 2010 16:07:59 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OgkFo-0002vg-6z for 6688-done@debbugs.gnu.org; Wed, 04 Aug 2010 16:07:57 -0400 Received: (qmail 94015 invoked by uid 3782); 4 Aug 2010 20:08:24 -0000 Received: from acm.muc.de (pD9E50AB9.dip.t-dialin.net [217.229.10.185]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Wed, 04 Aug 2010 22:08:22 +0200 Received: (qmail 2224 invoked by uid 1000); 4 Aug 2010 20:19:42 -0000 Date: Wed, 4 Aug 2010 20:19:42 +0000 To: 6688-done@debbugs.gnu.org Subject: bug #6688 fixed Message-ID: <20100804201942.GA2108@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6688-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Bug fixed. From unknown Tue Jun 17 01:31:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Sep 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator