GNU bug report logs - #66851
30.0.50; Building emacs with native compilation fails

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66851 in the body.
You can then email your comments to 66851 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nikos Patikas <nik.patik <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Building emacs with native compilation fails
Date: Tue, 31 Oct 2023 14:36:22 -0400

Hi,

I am having trouble to build emacs with the native-compilation flag.

I am using the following build options on the current master:

commit 5f371ca07be891cc41e8e80b8a1bc9ffcc909363 (HEAD -> master, origin/master, origin/HEAD)
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Tue Oct 31 12:24:51 2023 -0400

    * lisp/emacs-lisp/comp.el: Remove redundant requires


I build with the following options:

./configure --with-json \
            --with-imagemagick\
            --with-pgtk\
            --with-tree-sitter\
            --with-native-compilation


During make, I get a huge lisp code truncation followed by this error
message:

Symbol’s function definition is void: cl-find-class
make[3]: *** [Makefile:323: emacs-lisp/loaddefs-gen.elc] Error 255
Symbol’s function definition is void: cl-find-class
make[3]: *** [Makefile:323: emacs-lisp/radix-tree.elc] Error 255
make[3]: Leaving directory '/home/main/git/emacs/lisp'
make[2]: *** [Makefile:1015: bootstrap-emacs.pdmp] Error 2
make[2]: Leaving directory '/home/main/git/emacs/src'
make[1]: *** [Makefile:554: src] Error 2
make[1]: Leaving directory '/home/main/git/emacs'
make[1]: Entering directory '/home/main/git/emacs'
***
*** "make all" failed with exit status 2.

If remove the native comp flag then it builds fine.


Wondering if this affects only my system.

Best,
Nikos

Message #8 received at 66851 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Nikos Patikas <nik.patik <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 66851 <at> debbugs.gnu.org
Subject: Re: bug#66851: 30.0.50; Building emacs with native compilation fails
Date: Tue, 31 Oct 2023 20:59:06 +0200

> From: Nikos Patikas <nik.patik <at> gmail.com>
> Date: Tue, 31 Oct 2023 14:36:22 -0400
> 
> 
> Hi,
> 
> I am having trouble to build emacs with the native-compilation flag.
> 
> I am using the following build options on the current master:
> 
> commit 5f371ca07be891cc41e8e80b8a1bc9ffcc909363 (HEAD -> master, origin/master, origin/HEAD)
> Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date:   Tue Oct 31 12:24:51 2023 -0400
> 
>     * lisp/emacs-lisp/comp.el: Remove redundant requires
> 
> 
> I build with the following options:
> 
> ./configure --with-json \
>             --with-imagemagick\
>             --with-pgtk\
>             --with-tree-sitter\
>             --with-native-compilation
> 
> 
> During make, I get a huge lisp code truncation followed by this error
> message:
> 
> Symbol’s function definition is void: cl-find-class
> make[3]: *** [Makefile:323: emacs-lisp/loaddefs-gen.elc] Error 255
> Symbol’s function definition is void: cl-find-class
> make[3]: *** [Makefile:323: emacs-lisp/radix-tree.elc] Error 255
> make[3]: Leaving directory '/home/main/git/emacs/lisp'
> make[2]: *** [Makefile:1015: bootstrap-emacs.pdmp] Error 2
> make[2]: Leaving directory '/home/main/git/emacs/src'
> make[1]: *** [Makefile:554: src] Error 2
> make[1]: Leaving directory '/home/main/git/emacs'
> make[1]: Entering directory '/home/main/git/emacs'
> ***
> *** "make all" failed with exit status 2.
> 
> If remove the native comp flag then it builds fine.
> 
> 
> Wondering if this affects only my system.

Thanks, but please capture and post here the complete build log, from
its start till the last error message.  We need to see all of that to
understand what could cause the problem.

Adding Stefan who made that commit.

Message #11 received at 66851 <at> debbugs.gnu.org (full text, mbox):

From: Nikos Patikas <nik.patik <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 66851 <at> debbugs.gnu.org
Subject: Re: bug#66851: 30.0.50; Building emacs with native compilation fails
Date: Tue, 31 Oct 2023 15:12:35 -0400

[Message part 1 (text/plain, inline)]

> Thanks, but please capture and post here the complete build log, from
> its start till the last error message.  We need to see all of that to
> understand what could cause the problem.
>
> Adding Stefan who made that commit.


Looks pretty straightforward to me since cl-find-class is on cl-extra.el

https://github.com/emacs-mirror/emacs/blob/master/lisp/emacs-lisp/cl-extra.el#L738

which was removed by that commit:

$ git diff HEAD~1
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index bdc59703de9..7fd9543d2ba 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -29,10 +29,7 @@
 ;;; Code:

 (require 'bytecomp)
-(require 'cl-extra)
 (require 'cl-lib)
-(require 'cl-macs)
-(require 'cl-seq)
 (require 'gv)
 (require 'rx)
 (require 'subr-x)

Anyway, attached is the build log:

$ make -j 12 > build.txt 2>&1

[build.txt (text/plain, attachment)]

Message #14 received at 66851 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Nikos Patikas <nik.patik <at> gmail.com>, 66851 <at> debbugs.gnu.org
Subject: Re: bug#66851: 30.0.50; Building emacs with native compilation fails
Date: Tue, 31 Oct 2023 17:36:46 -0400

>> During make, I get a huge lisp code truncation followed by this error
>> message:
>> 
>> Symbol’s function definition is void: cl-find-class
> Thanks, but please capture and post here the complete build log, from
> its start till the last error message.  We need to see all of that to
> understand what could cause the problem.

Won't be necessary, I see the problem.
I'll commit a fix ASAP,


        Stefan

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Nikos Patikas <nik.patik <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, 66851-done <at> debbugs.gnu.org
Subject: Re: bug#66851: 30.0.50; Building emacs with native compilation fails
Date: Wed, 01 Nov 2023 04:35:03 -0400

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

>>> During make, I get a huge lisp code truncation followed by this error
>>> message:
>>> 
>>> Symbol’s function definition is void: cl-find-class
>> Thanks, but please capture and post here the complete build log, from
>> its start till the last error message.  We need to see all of that to
>> understand what could cause the problem.
>
> Won't be necessary, I see the problem.
> I'll commit a fix ASAP,
>
>
>         Stefan

I confirm bootstrap works here with b93f931e9e9 so closing.

Everything in the native compiler is very senstitive, please remember to
try a bootstrap always when touching it.

Thanks

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.