GNU bug report logs - #66832
[PATCH] build-system: clojure: Use the standard error regarding cross builds.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66832: closed ([PATCH] build-system: clojure: Use the
 standard error regarding cross builds.)
Date: Mon, 20 Nov 2023 15:12:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 20 Nov 2023 15:10:14 +0000
with message-id <878r6sfojh.fsf <at> cbaines.net>
and subject line Re: [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds.
has caused the debbugs.gnu.org bug report #66832,
regarding [PATCH] build-system: clojure: Use the standard error regarding cross builds.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66832: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66832
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] build-system: clojure: Use the standard error regarding cross
 builds.
Date: Mon, 30 Oct 2023 08:43:34 +0000

Rather than raising an error in the build system.

* guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
than calling error.

Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
---
 guix/build-system/clojure.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index fb897356bc..037fcaf21d 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -83,8 +83,8 @@ (define* (lower name
                             #:clojure #:jdk #:zip)))
 
     (if target
-        (error "No cross-compilation for clojure-build-system yet: LOWER"
-               target) ; FIXME
+        #f                              ; FIXME: No cross-compilation for
+                                        ; clojure-build-system yet
         (bag (name name)
              (system system)
              (host-inputs `(,@(if source

base-commit: 642769707c05dc1dd5674d60cd3b55d77b35c9d9
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 66832-done <at> debbugs.gnu.org
Subject: Re: [bug#66832] [PATCH] build-system: clojure: Use the standard
 error regarding cross builds.
Date: Mon, 20 Nov 2023 15:10:14 +0000

[Message part 4 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Rather than raising an error in the build system.
>>
>> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
>> than calling error.
>>
>> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
>
> LGTM!

Great, I've pushed this to master as
98ae8076435c74f90ad8ad30557963d2caa273c2.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.