Subject: bug#66832: closed (Re: [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 20 Nov 2023 15:12:02 +0000

Your bug report

#66832: [PATCH] build-system: clojure: Use the standard error regarding cross builds.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
66832: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66832
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#66832] [PATCH] build-system: clojure: Use the standard error regarding cross builds.
From: Christopher Baines <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Mon, 20 Nov 2023 15:10:14 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Christopher Baines <[email-masked]> skribis:
>
>> Rather than raising an error in the build system.
>>
>> * guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
>> than calling error.
>>
>> Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
>
> LGTM!

Great, I've pushed this to master as
98ae8076435c74f90ad8ad30557963d2caa273c2.

Chris

Subject: [PATCH] build-system: clojure: Use the standard error regarding cross builds.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Date: Mon, 30 Oct 2023 08:43:34 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Rather than raising an error in the build system.

* guix/build-system/clojure.scm (lower): Return #f for cross builds, rather
than calling error.

Change-Id: Id97c8f5140f55fe2c52ccb0db36fd993922c6a7e
---
 guix/build-system/clojure.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index fb897356bc..037fcaf21d 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -83,8 +83,8 @@ (define* (lower name
                             #:clojure #:jdk #:zip)))
 
     (if target
-        (error "No cross-compilation for clojure-build-system yet: LOWER"
-               target) ; FIXME
+        #f                              ; FIXME: No cross-compilation for
+                                        ; clojure-build-system yet
         (bag (name name)
              (system system)
              (host-inputs `(,@(if source

base-commit: 642769707c05dc1dd5674d60cd3b55d77b35c9d9
-- 
2.41.0