From unknown Tue Aug 19 14:48:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66828: [PATCH] Add docstrings in cl-lib.el Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 66828@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169861739320616 (code B ref -1); Sun, 29 Oct 2023 22:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Oct 2023 22:09:53 +0000 Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxDyi-0005MQ-OD for submit@debbugs.gnu.org; Sun, 29 Oct 2023 18:09:53 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxDyf-0005MA-C0 for submit@debbugs.gnu.org; Sun, 29 Oct 2023 18:09:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxDxy-0005WA-Tj for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:09:08 -0400 Received: from out-183.mta1.migadu.com ([95.215.58.183]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxDxv-0008Ra-PD for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:09:06 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1698617340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=ua0d1lvxtZoiipV5rt8qG8041FYzr1T4/LjB1y9Rvdw=; b=d0fNQwr6dR5JLnuBIW48hOkoPhbYztnnJHTYCr3c5CL45ufjQfwhHazCwd2CcCpiDd203A gnf3Djd+oU8OzUm4jqQcW+oZxEoQoyJsdjSQgA6VS0IES4aFGxttnrFfHQlKvb5oAcp0eg vAdwRZtiyNl+Ae3sqHdSlk6G5s3Ht2WfVu8M1brTs/fc7EsugnLL9Aec9DYNFD3wVG1Jk2 PYoW5VTgDtlRBHedGqVPAF4pIN6TEjxObr5GYe840dZcGVXK+haHLTFkTDxc9TqiNGCV63 JO25k1+Ec8+LkMydlI3b1uJmcIDQ07BJ0H+DkKFiBTdDYqC+gTHWX08xU3EEsg== From: Jeremy Bryant Date: Sun, 29 Oct 2023 22:07:13 +0000 Message-ID: <87fs1txerp.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.183; envelope-from=jb@jeremybryant.net; helo=out-183.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hello Emacs maintainers, Following recent discussions on documentation in cl-lib, I would like to submit a simple patch, creating docstrings where there were none previously. Feedback welcome on format, conventions and any other aspects. Best, Jeremy --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-docstrings-in-cl-lib.el.patch >From 02e487816f5542d30b8cdf0e3f748926f9b7cf2e Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Sun, 29 Oct 2023 21:56:54 +0000 Subject: [PATCH] Add docstrings in cl-lib.el * lisp/emacs-lisp/cl-lib.el (cl--set-buffer-substring): Add docstring (cl--defalias): Add docstring --- lisp/emacs-lisp/cl-lib.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index f4c1ac85b13..29b6c2f3545 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -157,6 +157,7 @@ cl-pushnew `(cl-callf2 cl-adjoin ,x ,place ,@keys))) (defun cl--set-buffer-substring (start end val) + "Delete region from START to END and insert VAL." (save-excursion (delete-region start end) (goto-char start) (insert val) @@ -194,6 +195,9 @@ 'cl--block-throw ;; the target form to return the values as a list. (defun cl--defalias (cl-f el-f &optional doc) + "Define function CL-F as definition EL-F. + +For example, (cl--defalias 'cl-first 'car)." (defalias cl-f el-f doc) (put cl-f 'byte-optimizer 'byte-compile-inline-expand)) -- 2.40.1 --=-=-=-- From unknown Tue Aug 19 14:48:11 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jeremy Bryant Subject: bug#66828: closed (Re: bug#66828: [PATCH] Add docstrings in cl-lib.el) Message-ID: References: <831qdcbak5.fsf@gnu.org> <87fs1txerp.fsf@jeremybryant.net> X-Gnu-PR-Message: they-closed 66828 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 66828@debbugs.gnu.org Date: Mon, 30 Oct 2023 11:45:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1698666302-28858-1" This is a multi-part message in MIME format... ------------=_1698666302-28858-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66828: [PATCH] Add docstrings in cl-lib.el which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66828@debbugs.gnu.org. --=20 66828: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66828 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1698666302-28858-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66828-done) by debbugs.gnu.org; 30 Oct 2023 11:44:24 +0000 Received: from localhost ([127.0.0.1]:44425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxQgy-0007UQ-3F for submit@debbugs.gnu.org; Mon, 30 Oct 2023 07:44:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxQgv-0007UC-BB for 66828-done@debbugs.gnu.org; Mon, 30 Oct 2023 07:44:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxQgI-0006SH-OT; Mon, 30 Oct 2023 07:43:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UakoVqL9Rp9jbDWF/otuwVFRFdmN+HtNGiMVEFv0T4U=; b=m0ACqhOMPvZV 6qA2MIVSGFimmTvlGmoFupoUHDe9CSSR+IPD3pMbcttl7qXdipZwbKrYTKVzkThMsCgdog1gVUYCf /+IlOV/OnJMsW/aTf+wxNs2KxZD3mMJ7Kk0DhOEBR5akVsNnE/TxaJ6uMFj7C9aXWuJUtZ6PQLl0g lkYwgvep5ql/2eJJBC/WPhE4t3TDK0VQLHejt5Fb+Dnxg31E1YhuxHP0J23sXdxl9j0u81H2u4YFg J4VHbK1kbTlPqmGFYDor0BVXs21ugpemu53/gL7vmLigqn8MVOPSvdogm7vdl86AuFGPNUXoNFL0X ltYswiePLHBOfVGxcv59IQ==; Date: Mon, 30 Oct 2023 13:43:06 +0200 Message-Id: <831qdcbak5.fsf@gnu.org> From: Eli Zaretskii To: Jeremy Bryant In-Reply-To: <87fs1txerp.fsf@jeremybryant.net> (bug-gnu-emacs@gnu.org) Subject: Re: bug#66828: [PATCH] Add docstrings in cl-lib.el References: <87fs1txerp.fsf@jeremybryant.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66828-done Cc: 66828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 29 Oct 2023 22:07:13 +0000 > From: Jeremy Bryant via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Following recent discussions on documentation in cl-lib, I would like to > submit a simple patch, creating docstrings where there were none > previously. Thanks, installed on the emacs-29 branch. > Feedback welcome on format, conventions and any other aspects. About this: see how I modified the commit log message. ------------=_1698666302-28858-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Oct 2023 22:09:53 +0000 Received: from localhost ([127.0.0.1]:43695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxDyi-0005MQ-OD for submit@debbugs.gnu.org; Sun, 29 Oct 2023 18:09:53 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxDyf-0005MA-C0 for submit@debbugs.gnu.org; Sun, 29 Oct 2023 18:09:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxDxy-0005WA-Tj for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:09:08 -0400 Received: from out-183.mta1.migadu.com ([95.215.58.183]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxDxv-0008Ra-PD for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 18:09:06 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1698617340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=ua0d1lvxtZoiipV5rt8qG8041FYzr1T4/LjB1y9Rvdw=; b=d0fNQwr6dR5JLnuBIW48hOkoPhbYztnnJHTYCr3c5CL45ufjQfwhHazCwd2CcCpiDd203A gnf3Djd+oU8OzUm4jqQcW+oZxEoQoyJsdjSQgA6VS0IES4aFGxttnrFfHQlKvb5oAcp0eg vAdwRZtiyNl+Ae3sqHdSlk6G5s3Ht2WfVu8M1brTs/fc7EsugnLL9Aec9DYNFD3wVG1Jk2 PYoW5VTgDtlRBHedGqVPAF4pIN6TEjxObr5GYe840dZcGVXK+haHLTFkTDxc9TqiNGCV63 JO25k1+Ec8+LkMydlI3b1uJmcIDQ07BJ0H+DkKFiBTdDYqC+gTHWX08xU3EEsg== From: Jeremy Bryant To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add docstrings in cl-lib.el Date: Sun, 29 Oct 2023 22:07:13 +0000 Message-ID: <87fs1txerp.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.183; envelope-from=jb@jeremybryant.net; helo=out-183.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hello Emacs maintainers, Following recent discussions on documentation in cl-lib, I would like to submit a simple patch, creating docstrings where there were none previously. Feedback welcome on format, conventions and any other aspects. Best, Jeremy --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-docstrings-in-cl-lib.el.patch >From 02e487816f5542d30b8cdf0e3f748926f9b7cf2e Mon Sep 17 00:00:00 2001 From: Jeremy Bryant Date: Sun, 29 Oct 2023 21:56:54 +0000 Subject: [PATCH] Add docstrings in cl-lib.el * lisp/emacs-lisp/cl-lib.el (cl--set-buffer-substring): Add docstring (cl--defalias): Add docstring --- lisp/emacs-lisp/cl-lib.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index f4c1ac85b13..29b6c2f3545 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -157,6 +157,7 @@ cl-pushnew `(cl-callf2 cl-adjoin ,x ,place ,@keys))) (defun cl--set-buffer-substring (start end val) + "Delete region from START to END and insert VAL." (save-excursion (delete-region start end) (goto-char start) (insert val) @@ -194,6 +195,9 @@ 'cl--block-throw ;; the target form to return the values as a list. (defun cl--defalias (cl-f el-f &optional doc) + "Define function CL-F as definition EL-F. + +For example, (cl--defalias 'cl-first 'car)." (defalias cl-f el-f doc) (put cl-f 'byte-optimizer 'byte-compile-inline-expand)) -- 2.40.1 --=-=-=-- ------------=_1698666302-28858-1--