GNU bug report logs - #66806
30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program

Previous Next

Full log

Message #14 received at 66806 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: dmitry <at> gutov.dev, 66806 <at> debbugs.gnu.org
Subject: Re: bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git
 submodules to the search program
Date: Sun, 29 Oct 2023 21:22:54 +0200

> Date: Sun, 29 Oct 2023 10:54:28 -0700
> Cc: dmitry <at> gutov.dev, 66806 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> >> -              (project-files pr)
> >> +              ;; XXX: See the comment in project-query-replace-regexp.
> >> +              (cl-delete-if-not #'file-regular-p (project-files pr))
> >                    ^^^^^^^^^^^^^^^^
> > I think we want to prefer using seq.el functions, since seq.el is
> > nowadays preloaded.  Is there a good reason to use cl-delete-if-not
> > here?
> 
> Well, that's just copy-pasted from some other functions in project.el. 
> If we want to go the minimal route, I could update all those workarounds.
> 
> Or we could go the maximal route and fix it at its source. Here's an 
> updated patch for the maximal route that uses 'seq-difference'.

That's up to Dmitry; from my POV it is enough that new code prefers
seq.el.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.