Subject: bug#6679: closed (Re: bug#6679: locate-library does not provide a default when called interactively)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 03 Apr 2020 12:02:03 +0000

Your bug report

#6679: locate-library does not provide a default when called interactively

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
6679: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6679
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#6679: locate-library does not provide a default when called interactively
From: Eli Zaretskii <[email-masked]>
To: Štěpán Němec <[email-masked]>
Cc: [email-masked], [email-masked], [email-masked]
Date: Fri, 03 Apr 2020 15:01:08 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Štěpán Němec
>  <[email-masked]>
> Date: Sat, 28 Mar 2020 22:59:44 +0100
> Cc: [email-masked]
> 
> On Tue, 20 Jul 2010 21:14:09 -0600
> Kevin Rodgers wrote:
> 
> > Assuming that complexity is justified, it ought to be factored into a
> > read-library-name utility that both find-library and locate-library use.
> 
> The first part has since happened (`read-library-name'), all that is
> needed is the latter. Patch attached.
> 
> > `C-h a -library\'' returns apropos-library and load-library in addition to
> > find-library and locate-library, but it's not clear to me that they would
> > benefit from a default.
> 
> The patch also handles `load-library'. The set of arguments/completions
> expected/provided by `apropos-library' is slightly different and
> requires other validation, so `read-library-name' wouldn't really help
> there.

Thanks, pushed to the master branch.

Subject: locate-library does not provide a default when called interactively
From: Kevin Rodgers <[email-masked]>
To: [email-masked]
Date: Tue, 20 Jul 2010 07:53:32 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

See bug 6652 for a use case.

Here's a patch -- should the default be included in the prompt, or
is the user expected to know to try M-n?

2010-07-20  Kevin Rodgers  <[email-masked]>

	* subr.el (locate-library):  Provide a default LIBRARY
	when called interactively.

*** emacs-23.2/lisp/subr.el~	Sat Apr  3 16:26:12 2010
--- emacs-23.2/lisp/subr.el	Tue Jul 20 07:38:58 2010
***************
*** 1583,1589 ****
     (interactive (list (completing-read "Locate library: "
   				      (apply-partially
                                          'locate-file-completion-table
!                                        load-path (get-load-suffixes)))
   		     nil nil
   		     t))
     (let ((file (locate-file library
--- 1583,1594 ----
     (interactive (list (completing-read "Locate library: "
   				      (apply-partially
                                          'locate-file-completion-table
!                                        load-path (get-load-suffixes))
! 				      nil nil nil nil
! 				      ;; discard text props from default
! 				      ;; to avoid side-effects (visiting file):
! 				      (substring-no-properties
! 				       (thing-at-point 'filename)))
   		     nil nil
   		     t))
     (let ((file (locate-file library

-- 
Kevin Rodgers
Denver, Colorado, USA