Subject: Re: bug#66743: 30.0.50; Crash when dumping reftex

From: Ihor Radchenko <[email-masked]>
Date: Thu, 26 Oct 2023 13:48:47 +0000

Eli Zaretskii <[email-masked]> writes:

>> May you please point me to such higher-level facility?
>
> How about 'error'?

Thanks!

See the attached.

>From c6c2b5a2f02c508fad3255033589d788ed84b09f Mon Sep 17 00:00:00 2001
Message-ID: <[email-masked]>
From: Ihor Radchenko <[email-masked]>
Date: Thu, 26 Oct 2023 14:52:32 +0300
Subject: [PATCH v2] * src/pdumper.c (dump_buffer): Print message before
 aborting (bug#66743)

When the buffer contains overlays, it cannot be dumped.  Print a
message describing this fact before aborting Emacs.
---
 src/pdumper.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/pdumper.c b/src/pdumper.c
index 315a31e2bcb..62d4fbcd68b 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -2862,8 +2862,11 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer)
   DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p);
 
   if (!itree_empty_p (buffer->overlays))
-    /* We haven't implemented the code to dump overlays.  */
-    emacs_abort ();
+    {
+      /* We haven't implemented the code to dump overlays.  */
+      error ("Dumping overlays in buffers is not yet implemented.  Aborting...\n");
+      emacs_abort ();
+    }
   else
     out->overlays = NULL;
 
-- 
2.42.0

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>