From unknown Sun Jun 22 17:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled Resent-From: Mike Frysinger Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 20 Jul 2010 00:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6673 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 6673@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.127958728917757 (code B ref -1); Tue, 20 Jul 2010 00:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jul 2010 00:54:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob16e-0004cM-QZ for submit@debbugs.gnu.org; Mon, 19 Jul 2010 20:54:49 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob16c-0004cH-7c for submit@debbugs.gnu.org; Mon, 19 Jul 2010 20:54:46 -0400 Received: from lists.gnu.org ([199.232.76.165]:59578) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ob16y-0007gl-KJ for submit@debbugs.gnu.org; Mon, 19 Jul 2010 20:55:08 -0400 Received: from [140.186.70.92] (port=46517 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob16w-00051V-Uh for bug-coreutils@gnu.org; Mon, 19 Jul 2010 20:55:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ob16v-0006uL-LZ for bug-coreutils@gnu.org; Mon, 19 Jul 2010 20:55:06 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:46753) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob16v-0006uC-E0 for bug-coreutils@gnu.org; Mon, 19 Jul 2010 20:55:05 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D4CB51B4051 for ; Tue, 20 Jul 2010 00:55:03 +0000 (UTC) From: Mike Frysinger Date: Mon, 19 Jul 2010 20:51:38 -0400 Message-Id: <1279587098-21559-1-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: <201007191548.19452.vapier@gentoo.org> References: <201007191548.19452.vapier@gentoo.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Currently, only main programs (like stdbuf) can be disabled at configure time. Helper programs (like libstdbuf.so) do not have a configure option. Even if you disable stdbuf with the configure option, libstdbuf.so will still be compiled and installed. So delay the parsing of helper programs until after we know the final enable list, and then only build libstdbuf.so when stdbuf is also enabled. Signed-off-by: Mike Frysinger --- configure.ac | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index e7037a1..acd397e 100644 --- a/configure.ac +++ b/configure.ac @@ -332,7 +332,6 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then fi # Limit stdbuf to ELF systems with GCC -optional_pkglib_progs= AC_MSG_CHECKING([whether this is an ELF system]) AC_EGREP_CPP([yes], [#if __ELF__ yes @@ -341,7 +340,6 @@ AC_MSG_RESULT([$elf_sys]) if test "$elf_sys" = "yes" && \ test "$GCC" = "yes"; then gl_ADD_PROG([optional_bin_progs], [stdbuf]) - gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) fi ############################################################################ @@ -395,6 +393,13 @@ esac # corresponding ./configure option argument is comma-separated on input. gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su]) +# Now that we know which programs will actually be built up, figure out +# which optional helper progs should be compiled. +optional_pkglib_progs= +case " $optional_bin_progs " in + *' stdbuf '*) gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) ;; +esac + # Set INSTALL_SU if su installation has been requested via # --enable-install-program=su. AC_SUBST([INSTALL_SU]) -- 1.7.1.1 From unknown Sun Jun 22 17:11:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Tue, 20 Jul 2010 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6673 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Mike Frysinger Cc: 6673@debbugs.gnu.org Received: via spool by 6673-submit@debbugs.gnu.org id=B6673.12796313357709 (code B ref 6673); Tue, 20 Jul 2010 13:09:02 +0000 Received: (at 6673) by debbugs.gnu.org; 20 Jul 2010 13:08:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObCZ5-00020I-A8 for submit@debbugs.gnu.org; Tue, 20 Jul 2010 09:08:55 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1ObCZ2-00020D-6k for 6673@debbugs.gnu.org; Tue, 20 Jul 2010 09:08:53 -0400 Received: (qmail 19174 invoked from network); 20 Jul 2010 13:09:15 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 20 Jul 2010 13:09:15 -0000 Message-ID: <4C459FE7.2050201@draigBrady.com> Date: Tue, 20 Jul 2010 14:08:55 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 References: <201007191548.19452.vapier@gentoo.org> <1279587098-21559-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1279587098-21559-1-git-send-email-vapier@gentoo.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On 20/07/10 01:51, Mike Frysinger wrote: > Currently, only main programs (like stdbuf) can be disabled at configure > time. Helper programs (like libstdbuf.so) do not have a configure option. > > Even if you disable stdbuf with the configure option, libstdbuf.so will > still be compiled and installed. So delay the parsing of helper programs > until after we know the final enable list, and then only build libstdbuf.so > when stdbuf is also enabled. > > Signed-off-by: Mike Frysinger > --- > configure.ac | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index e7037a1..acd397e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -332,7 +332,6 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then > fi > > # Limit stdbuf to ELF systems with GCC > -optional_pkglib_progs= > AC_MSG_CHECKING([whether this is an ELF system]) > AC_EGREP_CPP([yes], [#if __ELF__ > yes > @@ -341,7 +340,6 @@ AC_MSG_RESULT([$elf_sys]) > if test "$elf_sys" = "yes" && \ > test "$GCC" = "yes"; then > gl_ADD_PROG([optional_bin_progs], [stdbuf]) > - gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) > fi > > ############################################################################ > @@ -395,6 +393,13 @@ esac > # corresponding ./configure option argument is comma-separated on input. > gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su]) > > +# Now that we know which programs will actually be built up, figure out > +# which optional helper progs should be compiled. > +optional_pkglib_progs= > +case " $optional_bin_progs " in > + *' stdbuf '*) gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) ;; > +esac > + > # Set INSTALL_SU if su installation has been requested via > # --enable-install-program=su. > AC_SUBST([INSTALL_SU]) Looks good Mike. I'll apply that soon. cheers, Pádraig. From unknown Sun Jun 22 17:11:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mike Frysinger Subject: bug#6673: closed (Re: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled) Message-ID: References: <87mxjpb5ni.fsf@rho.meyering.net> <1279587098-21559-1-git-send-email-vapier@gentoo.org> X-Gnu-PR-Message: they-closed 6673 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 6673@debbugs.gnu.org Date: Sun, 17 Apr 2011 09:16:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1303031761-6130-1" This is a multi-part message in MIME format... ------------=_1303031761-6130-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6673: [PATCH] only build libstdbuf.so when stdbuf is enabled which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6673@debbugs.gnu.org. --=20 6673: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6673 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1303031761-6130-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6673-done) by debbugs.gnu.org; 17 Apr 2011 09:15:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBO4f-0001Zy-FT for submit@debbugs.gnu.org; Sun, 17 Apr 2011 05:15:21 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QBO4d-0001Zm-35 for 6673-done@debbugs.gnu.org; Sun, 17 Apr 2011 05:15:19 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 8D0B460110; Sun, 17 Apr 2011 11:15:13 +0200 (CEST) From: Jim Meyering To: 6673-done@debbugs.gnu.org Subject: Re: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled In-Reply-To: <4C459FE7.2050201@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?= =?iso-8859-1?Q?g?= Brady"'s message of "Tue, 20 Jul 2010 14:08:55 +0100") References: <201007191548.19452.vapier@gentoo.org> <1279587098-21559-1-git-send-email-vapier@gentoo.org> <4C459FE7.2050201@draigBrady.com> Date: Sun, 17 Apr 2011 11:15:13 +0200 Message-ID: <87mxjpb5ni.fsf@rho.meyering.net> Lines: 17 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: 6673-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) P=E1draig Brady wrote: > On 20/07/10 01:51, Mike Frysinger wrote: >> Currently, only main programs (like stdbuf) can be disabled at configure >> time. Helper programs (like libstdbuf.so) do not have a configure optio= n. >> >> Even if you disable stdbuf with the configure option, libstdbuf.so will >> still be compiled and installed. So delay the parsing of helper programs >> until after we know the final enable list, and then only build libstdbuf= .so >> when stdbuf is also enabled. >> >> Signed-off-by: Mike Frysinger ... > Looks good Mike. > I'll apply that soon. Applied nearly a year ago. Thanks. Closing. ------------=_1303031761-6130-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Jul 2010 00:54:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob16e-0004cM-QZ for submit@debbugs.gnu.org; Mon, 19 Jul 2010 20:54:49 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob16c-0004cH-7c for submit@debbugs.gnu.org; Mon, 19 Jul 2010 20:54:46 -0400 Received: from lists.gnu.org ([199.232.76.165]:59578) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ob16y-0007gl-KJ for submit@debbugs.gnu.org; Mon, 19 Jul 2010 20:55:08 -0400 Received: from [140.186.70.92] (port=46517 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ob16w-00051V-Uh for bug-coreutils@gnu.org; Mon, 19 Jul 2010 20:55:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ob16v-0006uL-LZ for bug-coreutils@gnu.org; Mon, 19 Jul 2010 20:55:06 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:46753) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ob16v-0006uC-E0 for bug-coreutils@gnu.org; Mon, 19 Jul 2010 20:55:05 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D4CB51B4051 for ; Tue, 20 Jul 2010 00:55:03 +0000 (UTC) From: Mike Frysinger To: bug-coreutils@gnu.org Subject: [PATCH] only build libstdbuf.so when stdbuf is enabled Date: Mon, 19 Jul 2010 20:51:38 -0400 Message-Id: <1279587098-21559-1-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: <201007191548.19452.vapier@gentoo.org> References: <201007191548.19452.vapier@gentoo.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Currently, only main programs (like stdbuf) can be disabled at configure time. Helper programs (like libstdbuf.so) do not have a configure option. Even if you disable stdbuf with the configure option, libstdbuf.so will still be compiled and installed. So delay the parsing of helper programs until after we know the final enable list, and then only build libstdbuf.so when stdbuf is also enabled. Signed-off-by: Mike Frysinger --- configure.ac | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index e7037a1..acd397e 100644 --- a/configure.ac +++ b/configure.ac @@ -332,7 +332,6 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then fi # Limit stdbuf to ELF systems with GCC -optional_pkglib_progs= AC_MSG_CHECKING([whether this is an ELF system]) AC_EGREP_CPP([yes], [#if __ELF__ yes @@ -341,7 +340,6 @@ AC_MSG_RESULT([$elf_sys]) if test "$elf_sys" = "yes" && \ test "$GCC" = "yes"; then gl_ADD_PROG([optional_bin_progs], [stdbuf]) - gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) fi ############################################################################ @@ -395,6 +393,13 @@ esac # corresponding ./configure option argument is comma-separated on input. gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su]) +# Now that we know which programs will actually be built up, figure out +# which optional helper progs should be compiled. +optional_pkglib_progs= +case " $optional_bin_progs " in + *' stdbuf '*) gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) ;; +esac + # Set INSTALL_SU if su installation has been requested via # --enable-install-program=su. AC_SUBST([INSTALL_SU]) -- 1.7.1.1 ------------=_1303031761-6130-1--