GNU bug report logs - #66720
[PATCH] gnu: icecat: honor parallel-job-count.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eric Bavier <bavier <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66720: closed ([PATCH] gnu: icecat: honor parallel-job-count.)
Date: Tue, 14 Nov 2023 05:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 14 Nov 2023 05:15:05 +0000
with message-id <dcde9492fa44bec523eb4c2a9dd945176d70a95f.camel <at> posteo.net>
and subject line Re: [bug#66720] [PATCH] gnu: icecat: honor parallel-job-count.
has caused the debbugs.gnu.org bug report #66720,
regarding [PATCH] gnu: icecat: honor parallel-job-count.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66720: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66720
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Bavier <bavier <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> posteo.net>
Subject: [PATCH] gnu: icecat: honor parallel-job-count.
Date: Tue, 24 Oct 2023 03:26:08 +0000

* gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Pass the value
of (parallel-job-count) to `mach` if a parallel build is requested.

Change-Id: Idce40ec895bdfbaa284009f8a9ef2770bc05082c
---
 gnu/packages/gnuzilla.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 1817dd44d1..a22592538c 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1057,10 +1057,12 @@ (define-public icecat-minimal
             (lambda* (#:key (make-flags '()) (parallel-build? #t)
                       #:allow-other-keys)
               (apply invoke "./mach" "build"
-                     ;; mach will use parallel build if possible by default
-                     `(,@(if parallel-build?
-                             '()
-                             '("-j1"))
+                     ;; mach will use a wide parallel build if possible by
+                     ;; default, so reign it in if requested.
+                     `(,(string-append
+                         "-j" (number->string (if parallel-build?
+                                                  (parallel-job-count)
+                                                  1)))
                        ,@make-flags))))
           (add-after 'build 'neutralise-store-references
             (lambda _

base-commit: cbd20d627497053871db863970c07d93c7081786
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Eric Bavier <bavier <at> posteo.net>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>,
 66720-done <at> debbugs.gnu.org
Subject: Re: [bug#66720] [PATCH] gnu: icecat: honor parallel-job-count.
Date: Tue, 14 Nov 2023 05:15:05 +0000

On Sat, 2023-11-04 at 01:17 +0100, Clément Lassieur wrote:
> On Tue, Oct 24 2023, Eric Bavier wrote:
> 
> > * gnu/packages/gnuzilla.scm (icecat-minimal)[arguments]: Pass the value
> > of (parallel-job-count) to `mach` if a parallel build is requested.
> > 
> > Change-Id: Idce40ec895bdfbaa284009f8a9ef2770bc05082c
> 
> It looks good to me anyway.

Pushed in d2b118e23c32ea2711ceea4ef6c510ce12b1e5f5

Thanks for the review,
`~Eric

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.