GNU bug report logs - #66716
Reconcile display-fill-column-indicator-character behavior and customization description

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66716 in the body.
You can then email your comments to 66716 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: bug-gnu-emacs <at> gnu.org
Subject: Reconcile display-fill-column-indicator-character behavior and
 customization description
Date: Mon, 23 Oct 2023 14:23:06 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Tags: patch

Tags: patch

AFAICT, setting display-fill-column-indicator-character to nil means
that no fill indicator is displayed. This patch changes the
customization description to match the current behavior.

However, I like the behavior that's currently described in the
customization option:

"If possible, use U+2502 to indicate fill column, otherwise use |"

What do folks think about changing the behavior of
display-fill-column-indicator-character to match this description?

Thank you!!

Joseph

[0001-Fix-customization-description-display-fill-column-in.patch (text/patch, attachment)]

Message #8 received at 66716 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 66716 <at> debbugs.gnu.org
Subject: Re: bug#66716: Reconcile display-fill-column-indicator-character
 behavior and customization description
Date: Tue, 24 Oct 2023 15:31:21 +0300

> Date: Mon, 23 Oct 2023 14:23:06 -0700
> From:  Joseph Turner via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> AFAICT, setting display-fill-column-indicator-character to nil means
> that no fill indicator is displayed.

That's not true, AFAICT.  The default value is nil, but when you turn
on the mode, it modifies the value of the character to be either
U+2502 or '|'.

> This patch changes the customization description to match the
> current behavior.

I don't think the patch is correct.

> However, I like the behavior that's currently described in the
> customization option:
> 
> "If possible, use U+2502 to indicate fill column, otherwise use |"
> 
> What do folks think about changing the behavior of
> display-fill-column-indicator-character to match this description?

I don't understand the proposal.  We don't use U+2502 by default
because not all terminals support it.

Message #11 received at 66716 <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66716 <at> debbugs.gnu.org
Subject: Re: bug#66716: Reconcile display-fill-column-indicator-character
 behavior and customization description
Date: Tue, 24 Oct 2023 12:46:11 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Mon, 23 Oct 2023 14:23:06 -0700
>> From:  Joseph Turner via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>
>> AFAICT, setting display-fill-column-indicator-character to nil means
>> that no fill indicator is displayed.
>
> That's not true, AFAICT.  The default value is nil, but when you turn
> on the mode, it modifies the value of the character to be either
> U+2502 or '|'.
>
>> This patch changes the customization description to match the
>> current behavior.
>
> I don't think the patch is correct.

Indeed, the patch is incorrect.  I misunderstood the behavior of
display-fill-column-indicator-mode when
display-fill-column-indicator-character is nil.

>> However, I like the behavior that's currently described in the
>> customization option:
>>
>> "If possible, use U+2502 to indicate fill column, otherwise use |"
>>
>> What do folks think about changing the behavior of
>> display-fill-column-indicator-character to match this description?
>
> I don't understand the proposal.  We don't use U+2502 by default
> because not all terminals support it.

When enabling display-fill-column-indicator in .dir-locals.el, is it
possible to dynamically set display-fill-column-indicator-character
according to what characters are displayable without using eval?

Currently in my project, I have:

((emacs-lisp-mode . ((display-fill-column-indicator . t)
                     ;; This won't work on some terminals
                     (display-fill-column-indicator-character . ?\u2502)
                     (fill-column . 80))))

Please let me know if you have suggestions for improvement!

Thank you!!!

Joseph

Message #14 received at 66716 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 66716 <at> debbugs.gnu.org
Subject: Re: bug#66716: Reconcile display-fill-column-indicator-character
 behavior and customization description
Date: Wed, 25 Oct 2023 05:29:06 +0300

> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
> Cc: 66716 <at> debbugs.gnu.org
> Date: Tue, 24 Oct 2023 12:46:11 -0700
> 
> >> What do folks think about changing the behavior of
> >> display-fill-column-indicator-character to match this description?
> >
> > I don't understand the proposal.  We don't use U+2502 by default
> > because not all terminals support it.
> 
> When enabling display-fill-column-indicator in .dir-locals.el, is it
> possible to dynamically set display-fill-column-indicator-character
> according to what characters are displayable without using eval?

I don't think so.

Message #19 received at 66716-done <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66716-done <at> debbugs.gnu.org
Subject: Re: bug#66716: Reconcile display-fill-column-indicator-character
 behavior and customization description
Date: Tue, 24 Oct 2023 20:11:53 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
>> Cc: 66716 <at> debbugs.gnu.org
>> Date: Tue, 24 Oct 2023 12:46:11 -0700
>>
>> >> What do folks think about changing the behavior of
>> >> display-fill-column-indicator-character to match this description?
>> >
>> > I don't understand the proposal.  We don't use U+2502 by default
>> > because not all terminals support it.
>>
>> When enabling display-fill-column-indicator in .dir-locals.el, is it
>> possible to dynamically set display-fill-column-indicator-character
>> according to what characters are displayable without using eval?
>
> I don't think so.

Thank you!!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.