From unknown Fri Jun 13 10:02:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66700 <66700@debbugs.gnu.org> To: bug#66700 <66700@debbugs.gnu.org> Subject: Status: 30.0.50; Some history is missing with multiple eshell buffers Reply-To: bug#66700 <66700@debbugs.gnu.org> Date: Fri, 13 Jun 2025 17:02:22 +0000 retitle 66700 30.0.50; Some history is missing with multiple eshell buffers reassign 66700 emacs submitter 66700 Liu Hui severity 66700 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 08:15:19 2023 Received: (at submit) by debbugs.gnu.org; 23 Oct 2023 12:15:19 +0000 Received: from localhost ([127.0.0.1]:49261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutq3-0006gF-5P for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:15:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutpz-0006fu-Bv for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qutpQ-0008Pd-TN for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 08:14:40 -0400 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qutpP-0004UF-GE for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 08:14:40 -0400 Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-49d39f07066so1425318e0c.0 for ; Mon, 23 Oct 2023 05:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698063278; x=1698668078; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8g/e0ufrKXSQKTzOS/NbDgWfdPP9o/txSjOInJgp7Cw=; b=BHe+jOuLr+O78ZLPnN+cDsOklae0ieFJuHJ0kowRhPK1uxRRqKg0mQqGIl5af4RQ3s D/rQh2LsLcvEzYnYoYjwHgvXsomPwdSqL1xc5yLHv8IYyDm9ipv6jMUa500UyxO6s6p2 dCFidNcTrwDEy6oP7qU8WbAePDSnq4J7SvJxmZeIluZG5L9y+DH00nkP5iUPnrBpu//N Su0CnOEGs47fPptGRtfi1HxqqH7QqgdPqUhW/SAMgYQG1cknDV0MdrMt67gDSXhMYUBi f9flIykhKQEYz8gosr99MaPmapqgTu7AK/e7sniY2Fg6YzhqgfPhwjHJHXFkiyRNx43M CJLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698063278; x=1698668078; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8g/e0ufrKXSQKTzOS/NbDgWfdPP9o/txSjOInJgp7Cw=; b=fjEJqberMG8b4qh+tdvyrkqKi61LMhAwho+YBLdWH/aiVyVUrR0o2+0auwQXnyv+Bp YXmPD2rtqjuOchc4dEcgG0R5ol8Jmad0Be/YM1v9hxGfxgj+jkaVcbvTUUVWO879rx7R 2Vdk+I286iSNnwhimIPeL0ueUb/9QvHiUm+u0hWCePROi6ZT34FoSIN7P7zO+uAvtsz5 ZuQrivdZuKLAeXuhT1ZGPVSPjuVvH+WJQ+NfC56m2WzyVSUHHDTVsxMgVqQmi+2cOMK0 zPs/ogUeJY3oD5GYNJiGiWITtIp9h5fMUQJqPDyp/1ERhwV5JATM6kSRS2fZIPoQildi 2vxA== X-Gm-Message-State: AOJu0YyFd8JR9FFvGbTKlChizQ9vxyYOZSyoswxe/4rkLymr8FibC8Az 6C/K/QX6sxPbzpV1QbmrLHS4ScA4yG4XdJzRmmzVz3hoJkk= X-Google-Smtp-Source: AGHT+IES1UCLvu+PHwgbEScoIrLnj1CHYEZo4Bq5teLEjN1dJuUObr9Tbbxocj49DBiTmpqKGWte4QxWE654i8lDYvU= X-Received: by 2002:a05:6122:ca8:b0:496:248e:43fc with SMTP id ba40-20020a0561220ca800b00496248e43fcmr9138913vkb.8.1698063278071; Mon, 23 Oct 2023 05:14:38 -0700 (PDT) MIME-Version: 1.0 From: Liu Hui Date: Mon, 23 Oct 2023 20:14:27 +0800 Message-ID: Subject: 30.0.50; Some history is missing with multiple eshell buffers To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::a32; envelope-from=liuhui1610@gmail.com; helo=mail-vk1-xa32.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Eshell saves history by default when quitting the buffer or emacs, but some history is missing when there are multiple eshell buffers. For example, 1. emacs -Q 2. M-x eshell, and type foo 3. C-u M-x eshell, and type bar 4. quit emacs Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liuhui1610[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (liuhui1610[at]gmail.com) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hi, Eshell saves history by default when quitting the buffer or emacs, but some history is missing when there are multiple eshell buffers. For example, 1. emacs -Q 2. M-x eshell, and type foo 3. C-u M-x eshell, and type bar 4. quit emacs I would expect both commands are saved, but in fact only one command is saved in the file eshell-history-file-name. I think the reason is the history file is always overwritten when an eshell buffer tries to save the history, so maybe eshell should save commands by appending to the file? Best -- Liu Hui From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 23:41:04 2023 Received: (at submit) by debbugs.gnu.org; 14 Nov 2023 04:41:04 +0000 Received: from localhost ([127.0.0.1]:59779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2lEW-0007FL-Hh for submit@debbugs.gnu.org; Mon, 13 Nov 2023 23:41:04 -0500 Received: from lists.gnu.org ([2001:470:142::17]:36948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2lEU-0007Eh-QH for submit@debbugs.gnu.org; Mon, 13 Nov 2023 23:41:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2lDj-0002kx-BZ for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 23:40:15 -0500 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2lDh-0000CH-QJ for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 23:40:15 -0500 Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-4ac2c1a4b87so2114994e0c.0 for ; Mon, 13 Nov 2023 20:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699936812; x=1700541612; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gZrihQELT0w0kxefobxEXWOREa/2LML5ETDJ/HcwnHQ=; b=B4yk1cc8NzWVeHtECr4VbpEF3YI9hWJjTaoaEMRuFNYCjqzWY/2tDiDd0nYI5ZQsDK xsK/OCgQssK8A/t1RDXMCW1MHkr5GrXSmARTVNS02k3YH93pZj6/pVHiPLNnkHRhb87p i7MZRX9xMFh2bjdBBP+FkZ7lvQltYfxjJqNf3ZC17Qs2EJBOhh3aIm70jKMUZ25lIqrs 5Gvt7q0/rp2TH6NAZIiWeAJug6NUVWM79SiE20A6O4aqxpluOKyxpD7eXskgeK6+Lrve lQYCkBlTYNwp9UsKGThBPy9igB//ni9duLbLV1WhNhaQqDGMH7NBBZti65cQnWtM5IYO 9WIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699936812; x=1700541612; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gZrihQELT0w0kxefobxEXWOREa/2LML5ETDJ/HcwnHQ=; b=LZX67HZo0qbn7Byv9bSG/uJcx0mLTaylvfjnSwWJfeP4T7A+jtmj+UHO4AEvbsXo1M 7qU6kU/n5Cl0UX2RddQgQTAckFAMIEXSsKS3TrMc1JOs4Aja7WNb1pWqhMkh5cXxV+wO JaeCiSISNTg5/B9eByzm3r7MFRJBw/oIygAj2BYuTNBnC7lE/WkdSsgA/SG+QH8nqzob KRhvQRDjQNDjLkzHsu7sCw3Doyo4AXq8GxNS22x37HhoqkLukv7B4rMgLx4jG0X2suFv P4x5iZTKavfhlGGqtgdJ3RXt+n2qEzJa2TS42HV5LRZoSFqq5S/28ofcqqVZV6iqDSBf UUwg== X-Gm-Message-State: AOJu0Ywcw4rkUYjdls2ugaqjVlzav21rmUtAEr+vJmHGrqvORsnAS5nj VTns92LNZxY/H7ARWpUbYvJNiIf9JdHMzEhb2zbHX4gnoWICaw== X-Google-Smtp-Source: AGHT+IHcDlyKWZFFD1GwIZNgaFm8sRC+zJyGrt8xuXZywr5ed+IUn6Hm06Hsh4wgR9aD6kT7W6YUxDS+qPGXhTbMhoU= X-Received: by 2002:a05:6122:3bd0:b0:4ab:f4e6:7d7 with SMTP id ft16-20020a0561223bd000b004abf4e607d7mr10308128vkb.0.1699936812120; Mon, 13 Nov 2023 20:40:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Liu Hui Date: Tue, 14 Nov 2023 12:40:00 +0800 Message-ID: Subject: Re: 30.0.50; Some history is missing with multiple eshell buffers To: Jim Porter Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::a32; envelope-from=liuhui1610@gmail.com; helo=mail-vk1-xa32.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Jim, > Eshell saves history by default when quitting the buffer or emacs, but > some history is missing when there are multiple eshell buffers. For > example, > > 1. emacs -Q > 2. M-x eshell, and type foo [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liuhui1610[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (liuhui1610[at]gmail.com) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hi Jim, > Eshell saves history by default when quitting the buffer or emacs, but > some history is missing when there are multiple eshell buffers. For > example, > > 1. emacs -Q > 2. M-x eshell, and type foo > 3. C-u M-x eshell, and type bar > 4. quit emacs > > I would expect both commands are saved, but in fact only one command > is saved in the file eshell-history-file-name. I think the reason is > the history file is always overwritten when an eshell buffer tries to > save the history, so maybe eshell should save commands by appending > to the file? Since Eshell can append new history now, I think it makes sense to change the default behavior from overwriting to appending, i.e., using '(eshell-write-history nil t)' in eshell-exit-hook and eshell-save-some-history. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 07:33:21 2023 Received: (at 66700) by debbugs.gnu.org; 14 Nov 2023 12:33:21 +0000 Received: from localhost ([127.0.0.1]:60232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2sbZ-0002oD-1K for submit@debbugs.gnu.org; Tue, 14 Nov 2023 07:33:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2sbX-0002o1-PK for 66700@debbugs.gnu.org; Tue, 14 Nov 2023 07:33:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2sam-0007eN-9i; Tue, 14 Nov 2023 07:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3qOalijknQW6orgUiRkyQDw0c9YtN+BSzEZHTrJz2kE=; b=p0zGXqFdaXGj jXoG3BNL5QikgRHhEpjk8qNdgXz2h33cgT4q/hfs2ta5mPhN1tFZzQ6DJA1vwI93JeE2Jmuagcut9 v+0PhKvaD9ue7z8snAXxl5p2Kb//41f5y3DNAK3kdt5LA3sQxhUX5a/PlPtr1Yd5piJvnIkQOmftv cjsZgXJFBvgRCHPIelZp3OLKuvEcrQdwDxmaMKxo2Djvr9vrkDdG+3Egh11HZhcVL1QzGLgrNbEp/ YZ2twnR5herxSgJA7miVqhQl1/+ZmulGeLu4fcJ/uIym8grSH6HpCjSQTO05ri34H4dltV0f1ICdl p/zNtsewQhZ/m1Y0n0tfSw==; Date: Tue, 14 Nov 2023 14:32:10 +0200 Message-Id: <838r70tt11.fsf@gnu.org> From: Eli Zaretskii To: Liu Hui In-Reply-To: (message from Liu Hui on Tue, 14 Nov 2023 12:40:00 +0800) Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66700 Cc: jporterbugs@gmail.com, 66700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66700@debbugs.gnu.org > From: Liu Hui > Date: Tue, 14 Nov 2023 12:40:00 +0800 > > Since Eshell can append new history now, I think it makes sense to > change the default behavior from overwriting to appending, i.e., using > '(eshell-write-history nil t)' in eshell-exit-hook and > eshell-save-some-history. WDYT? IMO, this is too soon to change the default behavior in incompatible ways. We need to wait for a while, perhaps at least one major release, before we do that. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 07:44:42 2023 Received: (at 66700) by debbugs.gnu.org; 14 Nov 2023 12:44:42 +0000 Received: from localhost ([127.0.0.1]:60315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2smX-000387-PT for submit@debbugs.gnu.org; Tue, 14 Nov 2023 07:44:42 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2smV-00037v-N5 for 66700@debbugs.gnu.org; Tue, 14 Nov 2023 07:44:40 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 65ECC5C025B; Tue, 14 Nov 2023 07:43:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 14 Nov 2023 07:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1699965832; x=1700052232; bh=fS X23U2gOm3VZoLVFUOHa2KHt2Yk44DTDF3nE6wJRIg=; b=l3vL1SvKcEPISCpUQo 2U3PZSrGvkwOZgSSpNBQhyUA5VyZMznEEyffLtdGiVDvyDT6o2Yk1qaXaFk7Uq5O IucaZL4bktNLB7bskKDt1qqcVpTSJvm5lLaRGu6lNZYSVBXUl2o4wNqiFF/nI91a wRzUN1BTIwgTsX1nB672MlFZnGYPe0wqr3TaGxaTlrlCQc7MsycMy/2D5W8v3tx6 5C54n2Wn02hSVkjghi8tnIQ6HCFwEUuJPDvOLqQEMhuqrfkxCpdyQg65/RObZ4Fz mcOhagKMeWg1o2n/gR1oAKYz2b2cTp0LCjEdKyCo//cv/cbPXqUsVTPnMhDLadXB cpag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1699965832; x=1700052232; bh=fSX23U2gOm3VZ oLVFUOHa2KHt2Yk44DTDF3nE6wJRIg=; b=rNbk57Si2zo60NB0kJ9swSPdTQs7h Dgr+K71R74nmIHLt42daNUo3pVvsEnC8Ppv9Ax+ZbXhILboJeR2rt73rj0vURJw1 HgSJNAtq8+WC0Uac7WMeWSHcMhQ5Bj+rbbduZbGMtAuBj4AABfL8cQB2BOxGxHiv +KFrlaU9+l7+IbCadHiEbmy5TQ7zhwWjrkF2UY9PUH5HpAHCLOEpKkSycAw7h1Yt nOBFqYWTLU1blDFn2scMVd3LOBZiMFbQQB4n3zo4vTo0VSOIT4YqXC0uUjMjBUwC R6XzY00Nv9zZOjearRbBadlrEmyNSME5DIRXiMXNh0CF2eR7MygMkZ7vw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefvddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Nov 2023 07:43:51 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 4EB4A7E045D; Tue, 14 Nov 2023 12:43:45 +0000 (GMT) From: Sean Whitton To: Eli Zaretskii , Liu Hui , jporterbugs@gmail.com, 66700@debbugs.gnu.org Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers In-Reply-To: <838r70tt11.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Nov 2023 14:32:10 +0200") References: <838r70tt11.fsf@gnu.org> Date: Tue, 14 Nov 2023 12:43:45 +0000 Message-ID: <878r70ec8u.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66700 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote: >> Cc: 66700@debbugs.gnu.org >> From: Liu Hui >> Date: Tue, 14 Nov 2023 12:40:00 +0800 >> >> Since Eshell can append new history now, I think it makes sense to >> change the default behavior from overwriting to appending, i.e., using >> '(eshell-write-history nil t)' in eshell-exit-hook and >> eshell-save-some-history. WDYT? > > IMO, this is too soon to change the default behavior in incompatible > ways. We need to wait for a while, perhaps at least one major > release, before we do that. This is fair enough. It would be really useful to have the default behaviour now for those of used to it from other shells, though -- Liu, perhaps you would be interested in adding a defcustom? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 14 12:15:59 2023 Received: (at 66700) by debbugs.gnu.org; 14 Nov 2023 17:15:59 +0000 Received: from localhost ([127.0.0.1]:34108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2x15-0002Fc-ED for submit@debbugs.gnu.org; Tue, 14 Nov 2023 12:15:59 -0500 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:55599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2x13-0002FM-Fd for 66700@debbugs.gnu.org; Tue, 14 Nov 2023 12:15:58 -0500 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-28019b66ad5so5302537a91.3 for <66700@debbugs.gnu.org>; Tue, 14 Nov 2023 09:15:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699982109; x=1700586909; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=kL75qryCKj0b5AWVwnasc8mIOe+MAFM+bdHvksLmU54=; b=AbAuAiNcFg07HVu/5hnSGj0j3uCU2TFf+6rbj6pEwTXLwXZV51DG8jXRhuqE20fJ6V Rb+D7SAyT1Jk9PQ47rZsEIMID+zQNcPuFo4WLndQMdB1cnVGVnvwz56a0cvh4t1mRnxs XOgewQ/kJWHn0dJFKrtg6BLmq0gN4y1+KN5XmXAYy5y5qVoFRwRx1b2epu5AiKdERIUt 9bU5t2MBlkt3DuMayQtgbCMpOW2kJVyNGSiSPhNf0WRJvspTw2OQyOYHor9LwO+WWxdT BYouEjHEd5WEs86MqE/CebTi+qIBrtNA/6a+NuyKPnCsLPRZbWoToxdBaU/LW542z7FI 3V2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699982109; x=1700586909; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kL75qryCKj0b5AWVwnasc8mIOe+MAFM+bdHvksLmU54=; b=s/n0powJlzhCMYz2LmDVrwLWBLegzFoUS0moxB0Uue/8nQuFgXvIpgeeieCuc8w+ni 5Z9JHlj51KNt+CDWab97uesrWy09j+lOsqd1NgLJPfrg4QkTXAkk68DWiAAeeWugOrEp PTL5R/x6ScN4uHOg75hOtjPw6guOrOYrUn/sPwOPcYPLun/M9I0P1kg7a6z+cEgzDUy3 6UE+dip46g3B2vYfkOL8DzCzisNYrFubVl7EUQGsmG//+7pP2eY1wZMVHbRHn5y8EcdJ 2bFMemLjSbVjvq/VGOGPs7cjQTIBOfX/ZC5MZiBPnVyrSkR8H2BXkS5JpOE5fNXUqM4x 0/tA== X-Gm-Message-State: AOJu0YxXC3D3rieFXvEBQ6t1TNC3DnF7QwUkGZRyg7QNXG+7aCR6EbBb IKOKuPnii1Q5s2kpoYOsANY= X-Google-Smtp-Source: AGHT+IFa/NKmv45f8/Dj/cLgdl2yrCvECqRvHAbGfBE/vIvMurc7ZtPt+lJy3Tyg1xn1Xv2cLNgPFw== X-Received: by 2002:a17:90b:4a90:b0:280:c98f:2090 with SMTP id lp16-20020a17090b4a9000b00280c98f2090mr11385725pjb.32.1699982109088; Tue, 14 Nov 2023 09:15:09 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c3-20020a17090ad90300b002805740d668sm7397611pjv.4.2023.11.14.09.15.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 09:15:08 -0800 (PST) Message-ID: <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> Date: Tue, 14 Nov 2023 09:15:07 -0800 MIME-Version: 1.0 Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers To: Sean Whitton , Eli Zaretskii , Liu Hui , 66700@debbugs.gnu.org References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> Content-Language: en-US From: Jim Porter In-Reply-To: <878r70ec8u.fsf@melete.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66700 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/14/2023 4:43 AM, Sean Whitton wrote: > On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote: >> >> IMO, this is too soon to change the default behavior in incompatible >> ways. We need to wait for a while, perhaps at least one major >> release, before we do that. > > This is fair enough. It would be really useful to have the default > behaviour now for those of used to it from other shells, though -- Liu, > perhaps you would be interested in adding a defcustom? Yeah, I think a defcustom would be good here. That would also make it easier for us to test out the new code and find any bugs. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:03:53 2023 Received: (at 66700) by debbugs.gnu.org; 15 Nov 2023 16:03:53 +0000 Received: from localhost ([127.0.0.1]:52978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IMr-0001KK-8C for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:03:53 -0500 Received: from mail-vs1-xe31.google.com ([2607:f8b0:4864:20::e31]:52711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IMm-0001K4-Ao for 66700@debbugs.gnu.org; Wed, 15 Nov 2023 11:03:52 -0500 Received: by mail-vs1-xe31.google.com with SMTP id ada2fe7eead31-45fb946612bso2137806137.1 for <66700@debbugs.gnu.org>; Wed, 15 Nov 2023 08:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700064223; x=1700669023; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jBHmdolKqm6sL9YnjLj63t1WuFzOO9gXHWmBDqk4k78=; b=ii4QesvrAVDjIVJTnnIDdC+il6q6EVbsvUrnv4/C4j1DFS4ctuYUrOHAP0JpuupV0C tNPe28dO3uwVwvZVu7P5tjv6iUvgsAADFTGkeT71GyqmsM8MzruvqpgMIZqLBYUDMq2B KrqxQkpe9YTR8+Uwja4FRok1BKTTbyis/RjeRZn8GbOnVB4cUEBIPIzw2M+ywwmTcM0b fEAnI+/RBVJX/AQDwzDHT/d6aD6GN+tZbR1hHzKwmVETH6hbuoVDZ0hw6LhnG2wzc+Em 992+6n9bU9UdwXOTJ9tiZ7HyuqACJMVptRxqFZnx4ZwB2cUT9pYhDHO9HD4eWEOLMPJQ Kdjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700064223; x=1700669023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jBHmdolKqm6sL9YnjLj63t1WuFzOO9gXHWmBDqk4k78=; b=vTO8M0vUan7uoWpwPIAcsuaq2Q9ghObdVWE3h3USSriTB74lsJPgpv/bWUjIf+MWRN /AwOqI7ZQG41ECyXYwPZu4467DI+svaCrPVIFCsvaOK5VmCbbgJUiVN+ApA5BMO/rXis K8TIlUJ4qA1b7gJdtvw2N68j9FhFOxLn2PiESch7M2AmLZT+qr/FlH1IQdZuYAD60zI5 53YOJjzQRAMq7OzMk2C20oS6Kagu1XeC1uz+KxjB/piQz35epZVOtj/G2miy0D/MB28X tvHLNVLjWIRpYQERrbCk9ePRcFpT59bq66Bggo+1VN2uD/1bVA2ULXXGXqFAEStCLhza dfJQ== X-Gm-Message-State: AOJu0Yy0UYuGAmnXUa2lsmRg3akwLNNbXW7jwUlgQEWgxxuShWReKJZC b4PhfCMAbEJMl8NSgn6Qn0uQrMisSYTuvhMPua+QwayZtjDLFw== X-Google-Smtp-Source: AGHT+IFa7DaAXjAZ7V1BvC7ZqZkImb9Gg+8X4cQvDxGUCNOnzCAh2t4YpzAyhl9pLb/Goe8q0XpuISNW5mDeeb5vOX4= X-Received: by 2002:a05:6102:2455:b0:45f:398:aba5 with SMTP id g21-20020a056102245500b0045f0398aba5mr11277882vss.32.1700042375301; Wed, 15 Nov 2023 01:59:35 -0800 (PST) MIME-Version: 1.0 References: <838r70tt11.fsf@gnu.org> In-Reply-To: <838r70tt11.fsf@gnu.org> From: Liu Hui Date: Wed, 15 Nov 2023 17:59:23 +0800 Message-ID: Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Eli, Eli Zaretskii 于2023年11月14日周二 20:32写道： > > Since Eshell can append new history now, I think it makes sense to > > change the default behavior from overwriting to appending, i.e., using > > '(eshell-write-history nil t)' in eshell-exit-hook [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.1 DATE_IN_PAST_06_12 Date: is 6 to 12 hours before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liuhui1610[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (liuhui1610[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:e31 listed in] [list.dnswl.org] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 66700 Cc: jporterbugs@gmail.com, 66700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hi Eli, Eli Zaretskii =E4=BA=8E2023=E5=B9=B411=E6=9C=8814=E6=97=A5= =E5=91=A8=E4=BA=8C 20:32=E5=86=99=E9=81=93=EF=BC=9A > > Since Eshell can append new history now, I think it makes sense to > > change the default behavior from overwriting to appending, i.e., using > > '(eshell-write-history nil t)' in eshell-exit-hook and > > eshell-save-some-history. WDYT? > > IMO, this is too soon to change the default behavior in incompatible > ways. We need to wait for a while, perhaps at least one major > release, before we do that. > > Thanks. It is not an incompatible change at the user level. It is actually a bug fix for people using multiple eshell sessions. For people using a single eshell buffer, the history inside eshell, when reading back from the file, is always same no matter how history is saved, and the only difference is the content of history file. As others have suggested, we could add an option to toggle the behavior with appending new history as the default. It allows more testing and users can easily revert back to old behavior. Do you think it is acceptable? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 11:28:08 2023 Received: (at 66700) by debbugs.gnu.org; 15 Nov 2023 16:28:08 +0000 Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IkK-00027v-2h for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:28:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IQh-0001QS-5b for 66700@debbugs.gnu.org; Wed, 15 Nov 2023 11:07:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3EvC-000720-0m; Wed, 15 Nov 2023 07:23:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rbtZq2geUY6Ui/UlW4OkId4fRKVC4ftMyfT4SuSeMPg=; b=lvwT06RtxxnoqKV+5vQY 4yLuSCGMN294qb7pDekqC481Owl8PFlBQDEvvAU1x3JI7qqEA6mtxCBUUYgdZmQ18o61xxWGXkkqL Ks+bnBqH6+BWCVHDbtE0Z6EIunYFQrm9ZGSNLEJK3G5DHnKsCEaWDErJgSj4ob2+ZJUFxANurqgGO 31fhUYaj9103Ay4BR2l6pCTDa3dNqoY0JsMvuubbdG/0CABm6Xm1E/WgXOsSPWXP1J+ZPPrstHIPA 5j1yWzQkxKqbXo7iQR1fv8mcocWZYj1H3oaq4IKjvEEUCJw6M62R3rN5JJrTnmxBnU1HMmOrIrotJ wr/2Q+xTAWlKiQ==; Date: Wed, 15 Nov 2023 14:22:56 +0200 Message-Id: <83bkbvrysf.fsf@gnu.org> From: Eli Zaretskii To: Liu Hui In-Reply-To: (message from Liu Hui on Wed, 15 Nov 2023 17:59:23 +0800) Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers References: <838r70tt11.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66700 Cc: jporterbugs@gmail.com, 66700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Liu Hui > Date: Wed, 15 Nov 2023 17:59:23 +0800 > Cc: jporterbugs@gmail.com, 66700@debbugs.gnu.org > > Eli Zaretskii 于2023年11月14日周二 20:32写道： > > > IMO, this is too soon to change the default behavior in incompatible > > ways. We need to wait for a while, perhaps at least one major > > release, before we do that. > > > > Thanks. > > It is not an incompatible change at the user level. It is actually a > bug fix for people using multiple eshell sessions. For people using a > single eshell buffer, the history inside eshell, when reading back > from the file, is always same no matter how history is saved, and the > only difference is the content of history file. > > As others have suggested, we could add an option to toggle the > behavior with appending new history as the default. It allows more > testing and users can easily revert back to old behavior. Do you think > it is acceptable? An option is, of course, acceptable, but its default should not change the previous behavior. We could consider changing the default later, after we have enough experience with this option, and can ask users whether they like the "append" behavior to be the default. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 04:48:03 2023 Received: (at 66700) by debbugs.gnu.org; 16 Nov 2023 09:48:04 +0000 Received: from localhost ([127.0.0.1]:54489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Yyh-0000AC-9W for submit@debbugs.gnu.org; Thu, 16 Nov 2023 04:48:03 -0500 Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]:53747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Yyd-00008v-Tx for 66700@debbugs.gnu.org; Thu, 16 Nov 2023 04:48:01 -0500 Received: by mail-vs1-xe35.google.com with SMTP id ada2fe7eead31-45d8c405696so229069137.3 for <66700@debbugs.gnu.org>; Thu, 16 Nov 2023 01:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700128074; x=1700732874; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lmWhdWxmYpLnsAYcvcWr7PmMvr3TuVSFyKjn9n0ao8o=; b=IWYgQ4JwJE6dIzM734rYdNtXY5symWvipdCKP+g2eQnO62YlwrSTMeoSHX0xWHZyM/ A7Mxv/VFWiO3kpGyJhkyG/a9XOrowjp5J9SkZLgY82vMGDKngWcd1HNx49K/zeQissCT 7GXOF/aUFCaBRpTuf5vAvGDg0F8ivwXjn9YulecsAjvuHTukErFfw6kctinC/8KlGdCI IALv25+7t5ENYpAqrbeEAE7+qW/MFVTMEbNrjSsH02vGhRfEwNhsTmJwWFKcOtmb/IWb q44z2J+/CPam5ZLhAmby6VPsz+IHtw1g6fC3Mu7UQ1dzMvFhcwxgAQOmZq5YrCAmk6zZ CYig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700128074; x=1700732874; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lmWhdWxmYpLnsAYcvcWr7PmMvr3TuVSFyKjn9n0ao8o=; b=RjSJs9oNBNqL7OxtwsliGbsCRuVef/yl6xcPLluhh9A96V6l7ZZun14rfatiVv4V4J SVHsf84RJlaMrG01oe5U/zFo/d+138zrNGsuJAZtDmScn/TfhE5b7wvBoa5zHopfyJAr XWCoc1CJSX5/qqq45RbpJSfKewrDbkD/XYXHCqXjuuisQkIlJbWs7GefdUL59T+Nu9Tg ns6P8uUrnQlMy8p4f2rrpXnE/dAZOi3eK9UtHcnfEufNKAtdE1ZUNOFStXpUAuA9cBgV FB8hv1j3MVGQFuYVkEGjfirIOWAfx5Vl31ENlUrO608m3+awf2Sl7O1U+ILrn9sesY/g IHrQ== X-Gm-Message-State: AOJu0Ywj6dvnjywFOlJChMYK49/TKr+1wvGc2n3PC2B61EU2U8rtPxGJ AgYNpPHr9ur+sndNhCapPFW94LvfHCqE2/F7jo0= X-Google-Smtp-Source: AGHT+IHQ1YxhQFTiu9TH9nSRZWL5dB60SOhaBstPQa2EHeNgNRtLYX55gXL19UnVEKYMpTd8iuRoPfS5ad96Qc/lKiQ= X-Received: by 2002:a05:6102:1625:b0:45f:654a:f3b with SMTP id cu37-20020a056102162500b0045f654a0f3bmr19413105vsb.19.1700128074512; Thu, 16 Nov 2023 01:47:54 -0800 (PST) MIME-Version: 1.0 References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> In-Reply-To: <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> From: Liu Hui Date: Thu, 16 Nov 2023 17:47:43 +0800 Message-ID: Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers To: Jim Porter Content-Type: multipart/mixed; boundary="000000000000f48a1c060a41e9f9" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 66700 Cc: Eli Zaretskii , 66700@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000f48a1c060a41e9f9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jim Porter =E4=BA=8E2023=E5=B9=B411=E6=9C=8815=E6= =97=A5=E5=91=A8=E4=B8=89 01:15=E5=86=99=E9=81=93=EF=BC=9A > > On 11/14/2023 4:43 AM, Sean Whitton wrote: > > On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote: > >> > >> IMO, this is too soon to change the default behavior in incompatible > >> ways. We need to wait for a while, perhaps at least one major > >> release, before we do that. > > > > This is fair enough. It would be really useful to have the default > > behaviour now for those of used to it from other shells, though -- Liu, > > perhaps you would be interested in adding a defcustom? > > Yeah, I think a defcustom would be good here. That would also make it > easier for us to test out the new code and find any bugs. Thank you all for your suggestions. A defcustom has been added in the attached patch without changing previous behavior. --000000000000f48a1c060a41e9f9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-option-eshell-history-append.patch" Content-Disposition: attachment; filename="0001-Add-option-eshell-history-append.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lp10b73q0 RnJvbSBlMmNkM2E5ZDI4YjM1ODA2ZDRlNmE4M2U5OGYwZGMyNTU1MDY1MWUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog VGh1LCAxNiBOb3YgMjAyMyAxMTo0NToyOCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp b24gYGVzaGVsbC1oaXN0b3J5LWFwcGVuZCcKCiogbGlzcC9lc2hlbGwvZW0taGlzdC5lbCAoZXNo ZWxsLWhpc3RvcnktYXBwZW5kKTogTmV3IG9wdGlvbi4KKGVzaGVsbC0tc2F2ZS1oaXN0b3J5KTog TmV3IGZ1bmN0aW9uLgooZXNoZWxsLWhpc3QtaW5pdGlhbGl6ZSk6Cihlc2hlbGwtc2F2ZS1zb21l LWhpc3RvcnkpOiBSZXBsYWNlIGVzaGVsbC13cml0ZS1oaXN0b3J5IHdpdGgKZXNoZWxsLS1zYXZl LWhpc3RvcnksIHdoaWNoIHJlc3BlY3RzIHRoZSBuZXcgb3B0aW9uLgotLS0KIGxpc3AvZXNoZWxs L2VtLWhpc3QuZWwgfCAxNiArKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1o aXN0LmVsIGIvbGlzcC9lc2hlbGwvZW0taGlzdC5lbAppbmRleCBjZjAzZjgzOTlhNi4uNzkzMzYy MDQ4NDcgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwKKysrIGIvbGlzcC9lc2hl bGwvZW0taGlzdC5lbApAQCAtMTE2LDYgKzExNiwxMiBAQCBlc2hlbGwtc2F2ZS1oaXN0b3J5LW9u LWV4aXQKIAkJIChjb25zdCA6dGFnICJBc2siIGFzaykKIAkJIChjb25zdCA6dGFnICJBbHdheXMg c2F2ZSIgdCkpKQogCisoZGVmY3VzdG9tIGVzaGVsbC1oaXN0b3J5LWFwcGVuZCBuaWwKKyAgIklm IG5vbi1uaWwsIGFwcGVuZCBuZXcgZW50cmllcyB0byB0aGUgaGlzdG9yeSBmaWxlIHdoZW4gc2F2 aW5nIGhpc3RvcnkuIgorICA6dHlwZSAnKGNob2ljZSAoY29uc3QgOnRhZyAiT3ZlcndyaXRlIGhp c3RvcnkgZmlsZSIgbmlsKQorCQkgKGNvbnN0IDp0YWcgIkFwcGVuZCBuZXcgZW50cmllcyB0byBm aWxlIiB0KSkKKyAgOnZlcnNpb24gIjMwLjEiKQorCiAoZGVmY3VzdG9tIGVzaGVsbC1pbnB1dC1m aWx0ZXIgJ2VzaGVsbC1pbnB1dC1maWx0ZXItZGVmYXVsdAogICAiUHJlZGljYXRlIGZvciBmaWx0 ZXJpbmcgYWRkaXRpb25zIHRvIGlucHV0IGhpc3RvcnkuCiBUYWtlcyBvbmUgYXJndW1lbnQsIHRo ZSBpbnB1dC4gIElmIG5vbi1uaWwsIHRoZSBpbnB1dCBtYXkgYmUgc2F2ZWQgb24KQEAgLTI5NCwx NyArMzAwLDIxIEBAIGVzaGVsbC1oaXN0LWluaXRpYWxpemUKICAgICAoaWYgZXNoZWxsLWhpc3Rv cnktZmlsZS1uYW1lCiAJKGVzaGVsbC1yZWFkLWhpc3RvcnkgbmlsIHQpKQogCi0gICAgKGFkZC1o b29rICdlc2hlbGwtZXhpdC1ob29rICMnZXNoZWxsLXdyaXRlLWhpc3RvcnkgbmlsIHQpKQorICAg IChhZGQtaG9vayAnZXNoZWxsLWV4aXQtaG9vayAjJ2VzaGVsbC0tc2F2ZS1oaXN0b3J5IG5pbCB0 KSkKIAogICAodW5sZXNzIGVzaGVsbC1oaXN0b3J5LXJpbmcKICAgICAoc2V0cSBlc2hlbGwtaGlz dG9yeS1yaW5nIChtYWtlLXJpbmcgZXNoZWxsLWhpc3Rvcnktc2l6ZSkpKQogCi0gIChhZGQtaG9v ayAnZXNoZWxsLWV4aXQtaG9vayAjJ2VzaGVsbC13cml0ZS1oaXN0b3J5IG5pbCB0KQorICAoYWRk LWhvb2sgJ2VzaGVsbC1leGl0LWhvb2sgIydlc2hlbGwtLXNhdmUtaGlzdG9yeSBuaWwgdCkKIAog ICAoYWRkLWhvb2sgJ2tpbGwtZW1hY3MtcXVlcnktZnVuY3Rpb25zICMnZXNoZWxsLXNhdmUtc29t ZS1oaXN0b3J5KQogCiAgIChhZGQtaG9vayAnZXNoZWxsLWlucHV0LWZpbHRlci1mdW5jdGlvbnMg Iydlc2hlbGwtYWRkLXRvLWhpc3RvcnkgbmlsIHQpKQogCisoZGVmdW4gZXNoZWxsLS1zYXZlLWhp c3RvcnkgKCkKKyAgIlNhdmUgdGhlIGhpc3RvcnkgZm9yIGN1cnJlbnQgRXNoZWxsIGJ1ZmZlci4i CisgIChlc2hlbGwtd3JpdGUtaGlzdG9yeSBuaWwgZXNoZWxsLWhpc3RvcnktYXBwZW5kKSkKKwog KGRlZnVuIGVzaGVsbC1zYXZlLXNvbWUtaGlzdG9yeSAoKQogICAiU2F2ZSB0aGUgaGlzdG9yeSBm b3IgYW55IG9wZW4gRXNoZWxsIGJ1ZmZlcnMuIgogICAoZG9saXN0IChidWYgKGJ1ZmZlci1saXN0 KSkKQEAgLTMxOCw3ICszMjgsNyBAQCBlc2hlbGwtc2F2ZS1zb21lLWhpc3RvcnkKIAkJCShmb3Jt YXQtbWVzc2FnZQogCQkJICJTYXZlIGlucHV0IGhpc3RvcnkgZm9yIEVzaGVsbCBidWZmZXIgYCVz Jz8gIgogCQkJIChidWZmZXItbmFtZSBidWYpKSkpKQotCSAgICAgIChlc2hlbGwtd3JpdGUtaGlz dG9yeSkpKSkpCisJICAgICAgKGVzaGVsbC0tc2F2ZS1oaXN0b3J5KSkpKSkKICAgdCkKIAogKGRl ZnVuIGVzaGVsbC9oaXN0b3J5ICgmcmVzdCBhcmdzKQotLSAKMi4yNS4xCgo= --000000000000f48a1c060a41e9f9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 06 10:33:28 2023 Received: (at 66700) by debbugs.gnu.org; 6 Dec 2023 15:33:28 +0000 Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAttw-0006tl-1h for submit@debbugs.gnu.org; Wed, 06 Dec 2023 10:33:28 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAttu-0006tY-1R for 66700@debbugs.gnu.org; Wed, 06 Dec 2023 10:33:26 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 16A3E5C0243; Wed, 6 Dec 2023 10:33:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 06 Dec 2023 10:33:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1701876789; x=1701963189; bh=DpB/SASCPVqcubl4ZxBmSFgNF ZMDVpbiP/1TDrXQhAw=; b=r1e8cCslQq+oQNCqXTOl6jvQXY41IUyKk+6KCCOMd Y8TH0t9W7tWsggBpaDxlMUtYXHB7aQd8QczAHESWN9t+bheGadsRQNNVGyTmNSEH 9AhxPozaRkLlvWaBh+znl94dIwbCrzgbjvC+jNIkY5IAy6CjjOEwuiS5BH+urBKy nmp5W6SKoT6/KvJVfN1p4IKgfH9Xlf1xcwz9XwCzehmqjrDTFgs+1eYt42nwwnqi dAReUDo1sFpqSkuvg9ik0CGiQhCVIub3pKpX7uITmfS+AqJ6/A9jiS1RiLykbGj4 g0DpIaG8fNT3doRByKYjPL64BKLJesrd0WQ0WKPXTtYOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701876789; x=1701963189; bh=DpB/SASCPVqcubl4ZxBmSFgNFZMDVpbiP/1 TDrXQhAw=; b=NTt/9ADE6f/vFOe6AxWLJLiDQS5Ke1C5l2/wxqSzyy61RDUBrQa ZaeIz2cKHLFXo0MQBMvmOrHXCVsoQDahaACJwuWOtBXCz0rHZ2w702pCnZiBHpYw fejd8o7XQzxEP8aZCaSPZIG1aJyKO8iWld9L5L1BekBw08VjayCLEg3oQanaZR8U VcGQiolmYdJvUcoHPyIZlEaBR5o8MGACEtlh7r3xAkYLEDqtJHpBGyME3KN6E7jd QZUMXOom33Wzewwp9qTz8KhifeJfBg3ktpPeALkN6BzG8S9jEaMMlAonYiangoGQ 9dHHdQLLoPzbKnQt21NZZ9JWy5N+cKehr7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudektddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepffefhfejudeguddtudekjeekueevvedvieeghfegleet uefhkeegkefhleejvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Dec 2023 10:33:08 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id C4AE47EDF76; Wed, 6 Dec 2023 15:33:07 +0000 (GMT) From: Sean Whitton To: Liu Hui Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers In-Reply-To: (Liu Hui's message of "Thu, 16 Nov 2023 17:47:43 +0800") References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> Date: Wed, 06 Dec 2023 15:33:07 +0000 Message-ID: <87jzpre47g.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66700 Cc: Jim Porter , Eli Zaretskii , 66700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu 16 Nov 2023 at 05:47pm +08, Liu Hui wrote: > Jim Porter =E4=BA=8E2023=E5=B9=B411=E6=9C=8815=E6= =97=A5=E5=91=A8=E4=B8=89 01:15=E5=86=99=E9=81=93=EF=BC=9A >> >> On 11/14/2023 4:43 AM, Sean Whitton wrote: >> > On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote: >> >> >> >> IMO, this is too soon to change the default behavior in incompatible >> >> ways. We need to wait for a while, perhaps at least one major >> >> release, before we do that. >> > >> > This is fair enough. It would be really useful to have the default >> > behaviour now for those of used to it from other shells, though -- Liu, >> > perhaps you would be interested in adding a defcustom? >> >> Yeah, I think a defcustom would be good here. That would also make it >> easier for us to test out the new code and find any bugs. > > Thank you all for your suggestions. A defcustom has been added in the > attached patch without changing previous behavior. Thanks. This looks good, but can you add a NEWS entry, please? Ideally it would also get documented in the Eshell manual. > From e2cd3a9d28b35806d4e6a83e98f0dc25550651e2 Mon Sep 17 00:00:00 2001 > From: Liu Hui > Date: Thu, 16 Nov 2023 11:45:28 +0800 > Subject: [PATCH] Add option `eshell-history-append' > > * lisp/eshell/em-hist.el (eshell-history-append): New option. > (eshell--save-history): New function. > (eshell-hist-initialize): > (eshell-save-some-history): Replace eshell-write-history with > eshell--save-history, which respects the new option. > --- > lisp/eshell/em-hist.el | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el > index cf03f8399a6..79336204847 100644 > --- a/lisp/eshell/em-hist.el > +++ b/lisp/eshell/em-hist.el > @@ -116,6 +116,12 @@ eshell-save-history-on-exit > (const :tag "Ask" ask) > (const :tag "Always save" t))) >=20=20 > +(defcustom eshell-history-append nil > + "If non-nil, append new entries to the history file when saving histor= y." > + :type '(choice (const :tag "Overwrite history file" nil) > + (const :tag "Append new entries to file" t)) > + :version "30.1") > + > (defcustom eshell-input-filter 'eshell-input-filter-default > "Predicate for filtering additions to input history. > Takes one argument, the input. If non-nil, the input may be saved on > @@ -294,17 +300,21 @@ eshell-hist-initialize > (if eshell-history-file-name > (eshell-read-history nil t)) >=20=20 > - (add-hook 'eshell-exit-hook #'eshell-write-history nil t)) > + (add-hook 'eshell-exit-hook #'eshell--save-history nil t)) >=20=20 > (unless eshell-history-ring > (setq eshell-history-ring (make-ring eshell-history-size))) >=20=20 > - (add-hook 'eshell-exit-hook #'eshell-write-history nil t) > + (add-hook 'eshell-exit-hook #'eshell--save-history nil t) >=20=20 > (add-hook 'kill-emacs-query-functions #'eshell-save-some-history) >=20=20 > (add-hook 'eshell-input-filter-functions #'eshell-add-to-history nil t= )) >=20=20 > +(defun eshell--save-history () > + "Save the history for current Eshell buffer." > + (eshell-write-history nil eshell-history-append)) > + > (defun eshell-save-some-history () > "Save the history for any open Eshell buffers." > (dolist (buf (buffer-list)) > @@ -318,7 +328,7 @@ eshell-save-some-history > (format-message > "Save input history for Eshell buffer `%s'? " > (buffer-name buf))))) > - (eshell-write-history))))) > + (eshell--save-history))))) > t) >=20=20 > (defun eshell/history (&rest args) --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 07 05:24:30 2023 Received: (at 66700) by debbugs.gnu.org; 7 Dec 2023 10:24:30 +0000 Received: from localhost ([127.0.0.1]:41153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBBYU-0005YL-2s for submit@debbugs.gnu.org; Thu, 07 Dec 2023 05:24:30 -0500 Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]:47149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBBYQ-0005Y6-P3 for 66700@debbugs.gnu.org; Thu, 07 Dec 2023 05:24:28 -0500 Received: by mail-ua1-x92a.google.com with SMTP id a1e0cc1a2514c-7c5ed425e8bso197234241.2 for <66700@debbugs.gnu.org>; Thu, 07 Dec 2023 02:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701944649; x=1702549449; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qvCrjZMb9cg99oe6iwSoNiGTyCDwAICmilM0Yxp255s=; b=biHhGADpTYjsN2EJRviU7E3FUClraovjUlz0NSjhUX7gqZD91F75TlwmMgxWxf1Z3r aO8/Fy3kcmmp2oVBwHWOATo3cOOKfVpiFOu77dmA0TNBCFQ6wriT8RsvO9gzWDaH0cJR i4oh3uDy0CBcM4Q+sM53K8xjd/W9kHqLdcsx4X8pxWlOMGIwCgDcOn6D4REM0aq3lyw4 vvpPniz04eykm5oY8FSbLUAnsay52Rb2QWzLl7/vxkMvn7S18N60Dp/mnsH/gISE6O5V m6Pnw64Rx8s57a8kl1+cIie75BXCGTgWOdU/0MTxWTATgDevDtPTaAfTC2dsvdIQgHqk oHBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701944649; x=1702549449; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qvCrjZMb9cg99oe6iwSoNiGTyCDwAICmilM0Yxp255s=; b=EgYACW+ZfUv17K/6yBgJkbBCa4K+rH6KbtGn7+qMLPR8U5WxCvXgbtCWi27SgmWz8m pT7eAWet6oZPhjQiJoe0KYhaoqnY3ztfgPLwMu4rXo5Ll61uPyGSKpsbHh+YZ+cHtCvz Gu0kcrdqbOU9b7VSn7TS8wlLT+bE9m1T2Fmwp1D08uQuetut5yPGY6+AAKE4ST/wqGjI QITpi0Lmr7obG2ZdzdOhE8ebuFMR7NDWV7h3HIi0Mj+NtTEsFz6lmDrFbArcDfRMemHL oZ91EVy4VuxrPRZ1jvVdi2prs09XgwWQX7oRgwrw9jsMl+1lZH+JsID1CSOJA8BosNKk TQNw== X-Gm-Message-State: AOJu0YzbjBKbJoRXEH+AtfwjNR0V0kWU7IXhBnI4aPqNgMnL9u3mw5qB kOHfu09/+/ZMlyngtu2gDn/vInCeU2thI6JTrBA= X-Google-Smtp-Source: AGHT+IGZrRrlZpvZv3s1fqc0fEaaXFaaU8jcRPALmGf3kSi/aNTZYKdoaKNHUtM5sw7EWZhE+wkW1v1dNusN3pT243A= X-Received: by 2002:a67:f047:0:b0:464:55d4:b41f with SMTP id q7-20020a67f047000000b0046455d4b41fmr2154452vsm.0.1701944648751; Thu, 07 Dec 2023 02:24:08 -0800 (PST) MIME-Version: 1.0 References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> <87jzpre47g.fsf@melete.silentflame.com> In-Reply-To: <87jzpre47g.fsf@melete.silentflame.com> From: Liu Hui Date: Thu, 7 Dec 2023 18:23:57 +0800 Message-ID: Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers To: Sean Whitton Content-Type: multipart/mixed; boundary="0000000000003773ba060be8def6" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 66700 Cc: Jim Porter , Eli Zaretskii , 66700@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000003773ba060be8def6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sean Whitton =E4=BA=8E2023=E5=B9=B412=E6=9C=886= =E6=97=A5=E5=91=A8=E4=B8=89 23:33=E5=86=99=E9=81=93=EF=BC=9A > > On Thu 16 Nov 2023 at 05:47pm +08, Liu Hui wrote: > > > Jim Porter =E4=BA=8E2023=E5=B9=B411=E6=9C=8815= =E6=97=A5=E5=91=A8=E4=B8=89 01:15=E5=86=99=E9=81=93=EF=BC=9A > >> > >> On 11/14/2023 4:43 AM, Sean Whitton wrote: > >> > On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote: > >> >> > >> >> IMO, this is too soon to change the default behavior in incompatibl= e > >> >> ways. We need to wait for a while, perhaps at least one major > >> >> release, before we do that. > >> > > >> > This is fair enough. It would be really useful to have the default > >> > behaviour now for those of used to it from other shells, though -- L= iu, > >> > perhaps you would be interested in adding a defcustom? > >> > >> Yeah, I think a defcustom would be good here. That would also make it > >> easier for us to test out the new code and find any bugs. > > > > Thank you all for your suggestions. A defcustom has been added in the > > attached patch without changing previous behavior. > > Thanks. This looks good, but can you add a NEWS entry, please? > > Ideally it would also get documented in the Eshell manual. Thanks for your feedback. I have updated the patch as suggested. --0000000000003773ba060be8def6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-option-eshell-history-append.patch" Content-Disposition: attachment; filename="0001-Add-option-eshell-history-append.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpv1kbh00 RnJvbSBhY2YwNTRkNDgzMmNlMjQ4ZDg0NDFkZmJiMDQxOGI2OWQ0ZWNmZTk4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog VGh1LCAxNiBOb3YgMjAyMyAxMTo0NToyOCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp b24gYGVzaGVsbC1oaXN0b3J5LWFwcGVuZCcKCiogbGlzcC9lc2hlbGwvZW0taGlzdC5lbCAoZXNo ZWxsLWhpc3RvcnktYXBwZW5kKTogTmV3IG9wdGlvbi4KKGVzaGVsbC0tc2F2ZS1oaXN0b3J5KTog TmV3IGZ1bmN0aW9uLgooZXNoZWxsLWhpc3QtaW5pdGlhbGl6ZSk6Cihlc2hlbGwtc2F2ZS1zb21l LWhpc3RvcnkpOiBSZXBsYWNlIGVzaGVsbC13cml0ZS1oaXN0b3J5IHdpdGgKZXNoZWxsLS1zYXZl LWhpc3RvcnksIHdoaWNoIHJlc3BlY3RzIHRoZSBuZXcgb3B0aW9uLgoqIGRvYy9taXNjL2VzaGVs bC50ZXhpIChIaXN0b3J5KTogVXBkYXRlLgoqIGV0Yy9ORVdTOiBBbm5vdW5jZSB0aGUgY2hhbmdl LiAgKEJ1ZyM2NjcwMCkKLS0tCiBkb2MvbWlzYy9lc2hlbGwudGV4aSAgIHwgMTggKysrKysrKysr KysrKy0tLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwgIDYgKysrKysrCiBsaXNwL2VzaGVs bC9lbS1oaXN0LmVsIHwgMTYgKysrKysrKysrKysrKy0tLQogMyBmaWxlcyBjaGFuZ2VkLCAzMiBp bnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9taXNjL2VzaGVs bC50ZXhpIGIvZG9jL21pc2MvZXNoZWxsLnRleGkKaW5kZXggZThhYThjZGM2YTMuLjM4OWI0Y2Ji YzIxIDEwMDY0NAotLS0gYS9kb2MvbWlzYy9lc2hlbGwudGV4aQorKysgYi9kb2MvbWlzYy9lc2hl bGwudGV4aQpAQCAtMTIzNywxMSArMTIzNywxOSBAQCBIaXN0b3J5CiBiZWdpbm5pbmcgd2l0aCBA Y29kZXtmb299IGlzIGFjY2Vzc2libGUgYnkgQGNvZGV7IWZvbzpufS4KIAogQHZpbmRleCBlc2hl bGwtaGlzdG9yeS1maWxlLW5hbWUKLVRoZSBoaXN0b3J5IHJpbmcgaXMgbG9hZGVkIGZyb20gYSBm aWxlIGF0IHRoZSBzdGFydCBvZiBldmVyeSBzZXNzaW9uLAotYW5kIHdyaXR0ZW4gYmFjayB0byB0 aGUgZmlsZSBhdCB0aGUgZW5kIG9mIGV2ZXJ5IHNlc3Npb24uICBUaGUgZmlsZSBwYXRoCi1pcyBz cGVjaWZpZWQgaW4gQGNvZGV7ZXNoZWxsLWhpc3RvcnktZmlsZS1uYW1lfS4gIFVubGlrZSBvdGhl ciBzaGVsbHMsCi1zdWNoIGFzIEJhc2gsIEVzaGVsbCBjYW4gbm90IGJlIGNvbmZpZ3VyZWQgdG8g a2VlcCBhIGhpc3RvcnkgcmluZyBvZiBhCi1kaWZmZXJlbnQgc2l6ZSB0aGFuIHRoYXQgb2YgdGhl IGhpc3RvcnkgZmlsZS4KK0B2aW5kZXggZXNoZWxsLWhpc3RvcnktYXBwZW5kCitUaGUgaGlzdG9y eSBpcyBsb2FkZWQgdG8gdGhlIGhpc3RvcnkgcmluZyBmcm9tIGEgZmlsZSBhdCB0aGUgc3RhcnQg b2YKK2V2ZXJ5IHNlc3Npb24sIGFuZCBzYXZlZCB0byB0aGUgZmlsZSBhdCB0aGUgZW5kIG9mIGV2 ZXJ5IHNlc3Npb24uICBUaGUKK2RlZmF1bHQgaGlzdG9yeSBzYXZpbmcgYmVoYXZpb3IgaXMgb3Zl cndyaXRpbmcgdGhlIGZpbGUgd2l0aCB0aGUgd2hvbGUKK2hpc3RvcnkgcmluZyBvZiB0aGUgc2Vz c2lvbi4gIEJ5IHNldHRpbmcgQGNvZGV7ZXNoZWxsLWhpc3RvcnktYXBwZW5kfQordG8gbm9uLUBj b2Rle25pbH0sIHRoZSBoaXN0b3J5IHdpbGwgYmUgc2F2ZWQgYnkgYXBwZW5kaW5nIG5ldyBlbnRy aWVzCitvZiB0aGF0IHNlc3Npb24gdG8gdGhlIGZpbGUsIHdoaWNoIGNvdWxkIHByZXZlbnQgcG90 ZW50aWFsIGhpc3RvcnkKK2xvc3Mgd2l0aCBtdWx0aXBsZSBFc2hlbGwgc2Vzc2lvbnMuICBUaGUg ZmlsZSBwYXRoIGlzIHNwZWNpZmllZCBpbgorQGNvZGV7ZXNoZWxsLWhpc3RvcnktZmlsZS1uYW1l fS4gIFVubGlrZSBvdGhlciBzaGVsbHMsIHN1Y2ggYXMgQmFzaCwKK0VzaGVsbCBjYW4gbm90IGJl IGNvbmZpZ3VyZWQgdG8gY29udHJvbCB0aGUgc2l6ZSBvZiB0aGUgaGlzdG9yeSBmaWxlLgorRXNw ZWNpYWxseSwgd2hlbiBAY29kZXtlc2hlbGwtaGlzdG9yeS1hcHBlbmR9IGlzIG5vbi1AY29kZXtu aWx9LCB0aGUKK3NpemUgb2YgZmlsZSB3aWxsIGtlZXAgaW5jcmVhc2luZyBhbmQgdGhlIHJlY29t bWVuZGVkIHdheSB0byB0cnVuY2F0ZQordGhlIGZpbGUgaXMgdG8gcnVuIHRoZSBAc2FtcHtoaXN0 b3J5IC13fSBjb21tYW5kIGluIGFuIEVzaGVsbCBzZXNzaW9uLgogCiBTaW5jZSB0aGUgZGVmYXVs dCBidWZmZXIgbmF2aWdhdGlvbiBhbmQgc2VhcmNoaW5nIGtleS1iaW5kaW5ncyBhcmUKIHN0aWxs IHByZXNlbnQgaW4gdGhlIEVzaGVsbCBidWZmZXIsIHRoZSBjb21tYW5kcyBmb3IgaGlzdG9yeQpk aWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBjNTU3MTk0MTZkMy4uZTE0YWI0 YWVkMjcgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC02MTcsNiArNjE3 LDEyIEBAIGNhbGxpbmcgZXh0ZXJuYWwgcmdyZXAuCiArKysKICoqKiBJZiBhIGNvbW1hbmQgZXhp dHMgYWJub3JtYWxseSwgdGhlIEVzaGVsbCBwcm9tcHQgbm93IHNob3dzIGl0cyBleGl0IGNvZGUu CiAKKysrKworKioqIE5ldyB1c2VyIG9wdGlvbiAnZXNoZWxsLWhpc3RvcnktYXBwZW5kJy4KK0lm IG5vbi1uaWwsIGVhY2ggRXNoZWxsIHNlc3Npb24gd2lsbCBzYXZlIGhpc3RvcnkgYnkgYXBwZW5k aW5nIG5ldworZW50cmllcyBvZiB0aGF0IHNlc3Npb24gdG8gdGhlIGhpc3RvcnkgZmlsZSByYXRo ZXIgdGhhbiBvdmVyd3JpdGluZwordGhlIGZpbGUgd2l0aCB0aGUgd2hvbGUgaGlzdG9yeSBvZiB0 aGUgc2Vzc2lvbi4gIFRoZSBkZWZhdWx0IGlzIG5pbC4KKwogKiogTWluaWJ1ZmZlciBhbmQgQ29t cGxldGlvbnMKIAogKioqIE5ldyBjb21tYW5kcyAncHJldmlvdXMtbGluZS1jb21wbGV0aW9uJyBh bmQgJ25leHQtbGluZS1jb21wbGV0aW9uJy4KZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWhp c3QuZWwgYi9saXNwL2VzaGVsbC9lbS1oaXN0LmVsCmluZGV4IGNmMDNmODM5OWE2Li43OTMzNjIw NDg0NyAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZW0taGlzdC5lbAorKysgYi9saXNwL2VzaGVs bC9lbS1oaXN0LmVsCkBAIC0xMTYsNiArMTE2LDEyIEBAIGVzaGVsbC1zYXZlLWhpc3Rvcnktb24t ZXhpdAogCQkgKGNvbnN0IDp0YWcgIkFzayIgYXNrKQogCQkgKGNvbnN0IDp0YWcgIkFsd2F5cyBz YXZlIiB0KSkpCiAKKyhkZWZjdXN0b20gZXNoZWxsLWhpc3RvcnktYXBwZW5kIG5pbAorICAiSWYg bm9uLW5pbCwgYXBwZW5kIG5ldyBlbnRyaWVzIHRvIHRoZSBoaXN0b3J5IGZpbGUgd2hlbiBzYXZp bmcgaGlzdG9yeS4iCisgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJPdmVyd3JpdGUgaGlz dG9yeSBmaWxlIiBuaWwpCisJCSAoY29uc3QgOnRhZyAiQXBwZW5kIG5ldyBlbnRyaWVzIHRvIGZp bGUiIHQpKQorICA6dmVyc2lvbiAiMzAuMSIpCisKIChkZWZjdXN0b20gZXNoZWxsLWlucHV0LWZp bHRlciAnZXNoZWxsLWlucHV0LWZpbHRlci1kZWZhdWx0CiAgICJQcmVkaWNhdGUgZm9yIGZpbHRl cmluZyBhZGRpdGlvbnMgdG8gaW5wdXQgaGlzdG9yeS4KIFRha2VzIG9uZSBhcmd1bWVudCwgdGhl IGlucHV0LiAgSWYgbm9uLW5pbCwgdGhlIGlucHV0IG1heSBiZSBzYXZlZCBvbgpAQCAtMjk0LDE3 ICszMDAsMjEgQEAgZXNoZWxsLWhpc3QtaW5pdGlhbGl6ZQogICAgIChpZiBlc2hlbGwtaGlzdG9y eS1maWxlLW5hbWUKIAkoZXNoZWxsLXJlYWQtaGlzdG9yeSBuaWwgdCkpCiAKLSAgICAoYWRkLWhv b2sgJ2VzaGVsbC1leGl0LWhvb2sgIydlc2hlbGwtd3JpdGUtaGlzdG9yeSBuaWwgdCkpCisgICAg KGFkZC1ob29rICdlc2hlbGwtZXhpdC1ob29rICMnZXNoZWxsLS1zYXZlLWhpc3RvcnkgbmlsIHQp KQogCiAgICh1bmxlc3MgZXNoZWxsLWhpc3RvcnktcmluZwogICAgIChzZXRxIGVzaGVsbC1oaXN0 b3J5LXJpbmcgKG1ha2UtcmluZyBlc2hlbGwtaGlzdG9yeS1zaXplKSkpCiAKLSAgKGFkZC1ob29r ICdlc2hlbGwtZXhpdC1ob29rICMnZXNoZWxsLXdyaXRlLWhpc3RvcnkgbmlsIHQpCisgIChhZGQt aG9vayAnZXNoZWxsLWV4aXQtaG9vayAjJ2VzaGVsbC0tc2F2ZS1oaXN0b3J5IG5pbCB0KQogCiAg IChhZGQtaG9vayAna2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMgIydlc2hlbGwtc2F2ZS1zb21l LWhpc3RvcnkpCiAKICAgKGFkZC1ob29rICdlc2hlbGwtaW5wdXQtZmlsdGVyLWZ1bmN0aW9ucyAj J2VzaGVsbC1hZGQtdG8taGlzdG9yeSBuaWwgdCkpCiAKKyhkZWZ1biBlc2hlbGwtLXNhdmUtaGlz dG9yeSAoKQorICAiU2F2ZSB0aGUgaGlzdG9yeSBmb3IgY3VycmVudCBFc2hlbGwgYnVmZmVyLiIK KyAgKGVzaGVsbC13cml0ZS1oaXN0b3J5IG5pbCBlc2hlbGwtaGlzdG9yeS1hcHBlbmQpKQorCiAo ZGVmdW4gZXNoZWxsLXNhdmUtc29tZS1oaXN0b3J5ICgpCiAgICJTYXZlIHRoZSBoaXN0b3J5IGZv ciBhbnkgb3BlbiBFc2hlbGwgYnVmZmVycy4iCiAgIChkb2xpc3QgKGJ1ZiAoYnVmZmVyLWxpc3Qp KQpAQCAtMzE4LDcgKzMyOCw3IEBAIGVzaGVsbC1zYXZlLXNvbWUtaGlzdG9yeQogCQkJKGZvcm1h dC1tZXNzYWdlCiAJCQkgIlNhdmUgaW5wdXQgaGlzdG9yeSBmb3IgRXNoZWxsIGJ1ZmZlciBgJXMn PyAiCiAJCQkgKGJ1ZmZlci1uYW1lIGJ1ZikpKSkpCi0JICAgICAgKGVzaGVsbC13cml0ZS1oaXN0 b3J5KSkpKSkKKwkgICAgICAoZXNoZWxsLS1zYXZlLWhpc3RvcnkpKSkpKQogICB0KQogCiAoZGVm dW4gZXNoZWxsL2hpc3RvcnkgKCZyZXN0IGFyZ3MpCi0tIAoyLjI1LjEKCg== --0000000000003773ba060be8def6-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 07 06:34:09 2023 Received: (at 66700-done) by debbugs.gnu.org; 7 Dec 2023 11:34:09 +0000 Received: from localhost ([127.0.0.1]:41248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBCdt-0007ao-Fv for submit@debbugs.gnu.org; Thu, 07 Dec 2023 06:34:09 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:58091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBCdr-0007aI-53 for 66700-done@debbugs.gnu.org; Thu, 07 Dec 2023 06:34:08 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 497905C01DF; Thu, 7 Dec 2023 06:33:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 07 Dec 2023 06:33:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1701948829; x= 1702035229; bh=dfnFJjNP2u5TTs5W223KRqPp8i2fEHrZt6Pg6Z3Sq+8=; b=V xpCisoVYew5jt9Ju90H7P1IiwIeciZzPoFKhZl+ztgozy6tX/8cpXQ2japNnVfEr X9w7r3EVI8mGbOSdSkHX4Uv73lYQT2VTjL90RaDmKWCdRnrk8DxkXwVPYs6Gb1do IU40mG8LrITIy6cERj47u9OwF0FT2UmcaQ/UBHIGVDUN4K4jvGWWcA/NRNW5GyPt p+lErRLUGC70xKgsLE/47bQxWDA+C6/z7HAArVMWimOAv23Ix7jsSMCVkhKYEkKl OWmHYnDxe9wdI9CHq1JC9WSaD40B3vE0/M1gAHecbgVZJfqd0+kgQi12YRghPq/s PXlCrcYBa/03OZSc3a+fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701948829; x=1702035229; bh=dfnFJjNP2u5TT s5W223KRqPp8i2fEHrZt6Pg6Z3Sq+8=; b=sVrfMDr+rq9QIFiX7FXyJLVoOWq3b juCjQm5RArp2BrL45H8Zh6ngcFXL2T74h1ZTQaLIRwBXy3phYgzEDeDNYvYqA2ZI CSi7ojaHIXzu3n0z16+L6poJ5Yy8kY/Sm3kq5a/2w59IZVt1oV/+Vgt/asvC0Zjv S/dRgoOpu4v2goPxwsJFifdZpIQeHAhydb42p7k6FXM8+PUn7G5bSv/Qem0lRHeo 491yazg0/PNQuFphFyS9uCafZiIkO99ZpmzY0BaMWbuWTVAO4tgqH1ql/PLAtajP fZIpTHjkXwBw+QuTEHjIzLRdeJdQxxJCaNSDlcbVPIdvN9J2+6Cxm17Pw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekvddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Dec 2023 06:33:48 -0500 (EST) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 2321D9414DA; Thu, 7 Dec 2023 11:33:48 +0000 (GMT) From: Sean Whitton To: Liu Hui Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers In-Reply-To: (Liu Hui's message of "Thu, 7 Dec 2023 18:23:57 +0800") References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> <87jzpre47g.fsf@melete.silentflame.com> Date: Thu, 07 Dec 2023 11:33:48 +0000 Message-ID: <87plzi2qn7.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66700-done Cc: Jim Porter , Eli Zaretskii , 66700-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, I've installed the change, thank you again. I copy-edited your manual text a bit while doing so. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 17:53:29 2023 Received: (at 66700) by debbugs.gnu.org; 8 Dec 2023 22:53:29 +0000 Received: from localhost ([127.0.0.1]:46445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBjiq-0000mm-Ts for submit@debbugs.gnu.org; Fri, 08 Dec 2023 17:53:29 -0500 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:47243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBjip-0000mZ-16 for 66700@debbugs.gnu.org; Fri, 08 Dec 2023 17:53:27 -0500 Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7b6f2dd5633so101184039f.2 for <66700@debbugs.gnu.org>; Fri, 08 Dec 2023 14:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702075988; x=1702680788; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:newsgroups:to:subject:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=JCJvEe2sbAsPgZeQ5wu3fHOPyjye6v89E1mmwpbYCtk=; b=WjDp8QZHcj16POahYqlW4xv1tzAMll0BP+3PY8z90Z590ISjQDhbjaS47dd44E7g9K 7ndmsjT5uVG3GgFiG8xCXGc2I66sCctuWyVc1XRrrRsUpJC8dmy1CCY3vQgQXJvFhzkk IznfcnXNXvR0cBOIMvhUwyBgu0rQ4eOMOGMMIdz3J9KoXE0r7dRzQFM3vJmCl+twCYMQ KTUxUPQYY0gaaxA8HKEcYLTAGaCgdMbJlQyAwbnO3W142aI+Hxep7xqKBFxFmMt5M5Cp e2uv5HNLCHUoYxfMRr3YoTDh2TjUa9IColoWD1bxPbyhIL1wOijD8E+jpmvTR942ifRt NFbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702075988; x=1702680788; h=content-transfer-encoding:in-reply-to:from:content-language :references:newsgroups:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JCJvEe2sbAsPgZeQ5wu3fHOPyjye6v89E1mmwpbYCtk=; b=R8jQrohQwyKEEmncj71aofswyfH5g+hXdcpaagaAacljlZd/6sSj+QltNybuv8isZ0 gNtLpq7kgPdgqAQoYTK5AKXFmaxM1SdJZUpNIeMmEbZPvlv7fi4goSSZbNy8u1Q/cFxv h9PEZh0ydhnsKlJCRh6BC4im9RbslzrMOqq8zWgF6KV71+vl2p0QRqoFNJOETuZK+5Rb nD9iPL1bFKzjE0/HroTphGrjGYozt2uxvg8oZ47J+pg3Uw7+pAhZdr2xMaqzLgdsayWz zvgVjwmaMuYkvX0w+j4ViaaLnX42C0JBhmBm0LTOuODzP5fnLnGIP9PHFfmVJjyZfTbd TV0w== X-Gm-Message-State: AOJu0YytwUOKZcoUBmGUjL6apIj3VGeiYUdE78Q8KBYk3BWdLk2beUVm fTiVsac74y7tUJ9SJFZhBN3EmT2Njyw= X-Google-Smtp-Source: AGHT+IFo0KNfVr4+dKlIupZIe1D/Lohg7Fp5zEV9TridVBsxW76bvueWnhXC7fXEXnCW+Vlb7kx2Yg== X-Received: by 2002:a05:6e02:1a88:b0:35d:5543:45dd with SMTP id k8-20020a056e021a8800b0035d554345ddmr1088860ilv.22.1702075988104; Fri, 08 Dec 2023 14:53:08 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id w14-20020a1709027b8e00b001d0ced578aasm2220818pll.307.2023.12.08.14.53.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Dec 2023 14:53:07 -0800 (PST) Message-ID: Date: Fri, 8 Dec 2023 14:53:06 -0800 MIME-Version: 1.0 Subject: Re: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers To: 66700@debbugs.gnu.org, spwhitton@spwhitton.name, liuhui1610@gmail.com Newsgroups: gmane.emacs.bugs References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> <87jzpre47g.fsf@melete.silentflame.com> <87plzi2qn7.fsf@zephyr.silentflame.com> Content-Language: en-US From: Jim Porter In-Reply-To: <87plzi2qn7.fsf@zephyr.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66700 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/7/2023 3:33 AM, Sean Whitton wrote: > I've installed the change, thank you again. > > I copy-edited your manual text a bit while doing so. Thanks for merging. This fell off my radar. From unknown Fri Jun 13 10:02:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 06 Jan 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator