GNU bug report logs - #66697
30.0.50; [PATCH] desktop-save-mode with expiring remote buffers

Previous Next

Full log

Message #89 received at 66697 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: andrewjmoreton <at> gmail.com, 66697 <at> debbugs.gnu.org
Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring
 remote buffers
Date: Sat, 09 Dec 2023 12:06:13 +0200

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 66697 <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton <at> gmail.com>
> Date: Fri, 08 Dec 2023 15:22:54 +0100
> 
> Hi Andy,
> 
> Could you try the attached patch to see if it fixes your issue?  Thanks.
>  (defun dired-desktop-buffer-misc-data (dirname)
>    "Auxiliary information to be saved in desktop file."
> -  (when (and (stringp desktop-files-not-to-save)
> -             (dired-desktop-save-p))
> +  (when (or (null desktop-files-not-to-save)
> +            (and (stringp desktop-files-not-to-save)
> +                 (dired-desktop-save-p)))
>      (cons
>       ;; Value of `dired-directory'.
>       (if (consp dired-directory)

Thanks, but I wonder whether a better way would be to modify
dired-desktop-save-p such that it handled correctly non-string values
of desktop-files-not-to-save?  That would make the handling of this
variable more local, which is better for maintenance, I think.

WDYT?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.