From unknown Sun Jun 22 00:01:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66697 <66697@debbugs.gnu.org> To: bug#66697 <66697@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers Reply-To: bug#66697 <66697@debbugs.gnu.org> Date: Sun, 22 Jun 2025 07:01:06 +0000 retitle 66697 30.0.50; [PATCH] desktop-save-mode with expiring remote buffe= rs reassign 66697 emacs submitter 66697 Manuel Giraud severity 66697 normal tag 66697 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 05:22:38 2023 Received: (at submit) by debbugs.gnu.org; 23 Oct 2023 09:22:39 +0000 Received: from localhost ([127.0.0.1]:49047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qur8w-0004IY-2F for submit@debbugs.gnu.org; Mon, 23 Oct 2023 05:22:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qur8q-0004IB-KR for submit@debbugs.gnu.org; Mon, 23 Oct 2023 05:22:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qur8I-00082h-85 for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 05:21:58 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qur8C-0002Fv-Ql for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 05:21:55 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=avMdefKZ F2oFfcYhv8KXYqVIwtOXjnn/ddG2eSbYK0M=; h=date:subject:to:from; d=ledu-giraud.fr; b=P/LrMFHaxXZY1pZqJkch/B0/SbaLdG7US56U1jNyOyj+YZNVGr zZ9fIF+D5HfyP+QPufes3vHDAh2a85zPPcDQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=avMdefKZF2oFfcYh v8KXYqVIwtOXjnn/ddG2eSbYK0M=; h=date:subject:to:from; d=ledu-giraud.fr; b=Gp61706Tx3XgFzVQX2bNJfbW+5pETMd8XiZrebQwe3PxIsdR01 OgOwujM2ZHT0UdH+KXZeCNjnG59XxQBpTBKEXdwgyonAImOfHb0uPz87n41IDN97JixYSI mqW0eWpHeYA7EqGxjUasC+b17ZL33+DlDWvxbjNe8upuZtyJRu5u+OzGifSIX/gLqO8QoM yduzh5J0PxlP2hwaaVVHHPcl5rcMtEVkRQFGs1jSErDHNU+xYP3s+cL92tGxXmgVgRJpgS TFiE2ogYjKxcjt9BVQiUV+5K06ekDZqaFplV7lkefK3Du9Q24lNILtwYaTwndkZEs/BYIM LxgrNZ3luJ4Q== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id b59199b9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 11:21:48 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers Date: Mon, 23 Oct 2023 11:21:47 +0200 Message-ID: <875y2xelsk.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Hi, I'm using desktop-save-mode and regularly open files via Tramp with a method that asks for a password and that would eventually expire. By default 'desktop-files-not-to-save' is "\\(\\`/[^/:]*:\\|(ftp)\\'\\)" so I expect that those remote buffer are not saved by desktop-save. When such a remote buffer is opened (but not displayed nor used), Emacs will keep asking me for this password and I find it annoying. I try to track down this issue and found out that the call to 'desktop-buffer-info' on each buffer triggered this password prompt. The following patch tries to solve this. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Test-desktop-files-not-to-save-early.patch >From 5aa566db6214d61ebfad79a84ea8630e791aec33 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Mon, 23 Oct 2023 11:04:29 +0200 Subject: [PATCH] Test 'desktop-files-not-to-save' early * lisp/desktop.el (desktop-buffer-info): Replace 'set-buffer' with 'with-current-buffer' and fix docstring. (desktop-save-file-name-p): New function to isolate test on 'desktop-files-not-to-save'. (desktop-save-buffer-p): Use it. (desktop-save): Test wheter the buffer's filename should be saved before accessing its 'desktop-buffer-info'. --- lisp/desktop.el | 136 +++++++++++++++++++++++++----------------------- 1 file changed, 70 insertions(+), 66 deletions(-) diff --git a/lisp/desktop.el b/lisp/desktop.el index f096f13ab80..738a26a42af 100644 --- a/lisp/desktop.el +++ b/lisp/desktop.el @@ -843,8 +843,6 @@ desktop-list* ;; ---------------------------------------------------------------------------- (defun desktop-buffer-info (buffer) "Return information describing BUFFER. -This function is not pure, as BUFFER is made current with -`set-buffer'. Returns a list of all the necessary information to recreate the buffer, which is (in order): @@ -860,49 +858,49 @@ desktop-buffer-info auxiliary information given by `desktop-save-buffer'; local variables; auxiliary information given by `desktop-var-serdes-funs'." - (set-buffer buffer) - `( - ;; base name of the buffer; replaces the buffer name if managed by uniquify - ,(and (fboundp 'uniquify-buffer-base-name) (uniquify-buffer-base-name)) - ;; basic information - ,(desktop-file-name (buffer-file-name) desktop-dirname) - ,(buffer-name) - ,major-mode - ;; minor modes - ,(seq-filter - (lambda (minor-mode) - ;; Just two sanity checks. - (and (boundp minor-mode) - (symbol-value minor-mode) - (let ((special - (assq minor-mode desktop-minor-mode-table))) - (or (not special) - (cadr special))))) - local-minor-modes) - ;; point and mark, and read-only status - ,(point) - ,(list (mark t) mark-active) - ,buffer-read-only - ;; auxiliary information - ,(when (functionp desktop-save-buffer) - (funcall desktop-save-buffer desktop-dirname)) - ;; local variables - ,(let ((loclist (buffer-local-variables)) - (ll nil)) - (dolist (local desktop-locals-to-save) - (let ((here (assq local loclist))) - (cond (here - (push here ll)) - ((member local loclist) - (push local ll))))) - ll) - ,@(when (>= desktop-io-file-version 208) - (list - (mapcar (lambda (record) - (let ((var (car record))) - (list var - (funcall (cadr record) (symbol-value var))))) - desktop-var-serdes-funs))))) + (with-current-buffer buffer + `( + ;; base name of the buffer; replaces the buffer name if managed by uniquify + ,(and (fboundp 'uniquify-buffer-base-name) (uniquify-buffer-base-name)) + ;; basic information + ,(desktop-file-name (buffer-file-name) desktop-dirname) + ,(buffer-name) + ,major-mode + ;; minor modes + ,(seq-filter + (lambda (minor-mode) + ;; Just two sanity checks. + (and (boundp minor-mode) + (symbol-value minor-mode) + (let ((special + (assq minor-mode desktop-minor-mode-table))) + (or (not special) + (cadr special))))) + local-minor-modes) + ;; point and mark, and read-only status + ,(point) + ,(list (mark t) mark-active) + ,buffer-read-only + ;; auxiliary information + ,(when (functionp desktop-save-buffer) + (funcall desktop-save-buffer desktop-dirname)) + ;; local variables + ,(let ((loclist (buffer-local-variables)) + (ll nil)) + (dolist (local desktop-locals-to-save) + (let ((here (assq local loclist))) + (cond (here + (push here ll)) + ((member local loclist) + (push local ll))))) + ll) + ,@(when (>= desktop-io-file-version 208) + (list + (mapcar (lambda (record) + (let ((var (car record))) + (list var + (funcall (cadr record) (symbol-value var))))) + desktop-var-serdes-funs)))))) ;; ---------------------------------------------------------------------------- (defun desktop--v2s (value) @@ -1029,6 +1027,12 @@ desktop-buffers-not-to-save-function `desktop-save-buffer-p' and should return nil if buffer should not have its state saved in the desktop file.") +(defun desktop-save-file-name-p (filename) + "Return t if FILENAME should have its state saved." + (and filename + (or (not (stringp desktop-files-not-to-save)) + (not (string-match-p desktop-files-not-to-save filename))))) + (defun desktop-save-buffer-p (filename bufname mode &rest rest) "Return t if buffer should have its state saved in the desktop file. FILENAME is the visited file name, BUFNAME is the buffer name, and @@ -1041,9 +1045,7 @@ desktop-save-buffer-p (not (stringp desktop-buffers-not-to-save)) (not (string-match-p desktop-buffers-not-to-save bufname))) (not (memq mode desktop-modes-not-to-save)) - (or (and filename - (or no-regexp-to-check - (not (string-match-p desktop-files-not-to-save filename)))) + (or (desktop-save-file-name-p filename) (and (memq mode '(dired-mode vc-dir-mode)) (or no-regexp-to-check (not (setq dired-skip @@ -1204,24 +1206,26 @@ desktop-save " kill-ring))\n")) (insert "\n;; Buffer section -- buffers listed in same order as in buffer list:\n") - (dolist (l (mapcar #'desktop-buffer-info (buffer-list))) - (let ((base (pop l))) - (when (apply #'desktop-save-buffer-p l) - (insert "(" - (if (or (not (integerp eager)) - (if (zerop eager) - nil - (setq eager (1- eager)))) - "desktop-create-buffer" - "desktop-append-buffer-args") - " " - (format "%d" desktop-io-file-version)) - ;; If there's a non-empty base name, we save it instead of the buffer name - (when (and base (not (string= base ""))) - (setcar (nthcdr 1 l) base)) - (dolist (e l) - (insert "\n " (desktop-value-to-string e))) - (insert ")\n\n")))) + (dolist (buffer (buffer-list)) + (when (desktop-save-file-name-p (buffer-file-name buffer)) + (let* ((l (desktop-buffer-info buffer)) + (base (pop l))) + (when (apply #'desktop-save-buffer-p l) + (insert "(" + (if (or (not (integerp eager)) + (if (zerop eager) + nil + (setq eager (1- eager)))) + "desktop-create-buffer" + "desktop-append-buffer-args") + " " + (format "%d" desktop-io-file-version)) + ;; If there's a non-empty base name, we save it instead of the buffer name + (when (and base (not (string= base ""))) + (setcar (nthcdr 1 l) base)) + (dolist (e l) + (insert "\n " (desktop-value-to-string e))) + (insert ")\n\n"))))) (setq default-directory desktop-dirname) ;; When auto-saving, avoid writing if nothing has changed since the last write. -- 2.42.0 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.4) of 2023-10-23 built on computer Repository revision: 4ff0c738d050942932e73c627a7d6e31ca5c6244 Repository branch: mgi/auto-save-pred Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: OpenBSD computer 7.4 GENERIC.MP#1397 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --with-toolkit-scroll-bars=no --without-cairo --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: gnus-dired-mode: t server-mode: t override-global-mode: t repeat-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-1.3.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs Features: (shadow emacsbug pcmpl-git log-edit add-log shortdoc comp comp-cstr help-fns radix-tree descr-text sort gnus-cite flow-fill mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-cache qp utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss conf-mode tramp-cmds tramp-cache time-stamp tramp-sh smerge-mode diff whitespace dabbrev pulse ibuf-ext ibuffer ibuffer-loaddefs cus-start misearch multi-isearch org-duration org-agenda org-indent view pascal org-element org-persist org-id avl-tree oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util vc-hg sh-script smie treesit executable eww url-queue mm-url vc-dir ewoc mule-util on-screen texinfo texinfo-loaddefs emacs-news-mode gnus-dired vc autorevert filenotify vc-git diff-mode vc-dispatcher bug-reference paredit warnings time battery cus-load exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-summer-theme ef-themes zone speed-type url-http url-auth url-gw nsm compat ytdious mingus libmpdee reporter edebug debug backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base pcase timezone icalendar gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-x dired-aux dired dired-loaddefs notifications dbus xml cl-extra help-mode use-package-core repeat easy-mmode desktop frameset debbugs-autoloads ebdb-autoloads ef-themes-autoloads exwm-autoloads hyperbole-autoloads magit-autoloads git-commit-autoloads finder-inf magit-section-autoloads dash-autoloads on-screen-autoloads osm-autoloads paredit-autoloads request-autoloads rust-mode-autoloads s-autoloads speed-type-autoloads transmission-autoloads tree-mode-autoloads with-editor-autoloads info compat-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 1090540 641027) (symbols 48 72542 5) (strings 32 363748 18296) (string-bytes 1 11744990) (vectors 16 186883) (vector-slots 8 3624315 209906) (floats 8 645 1052) (intervals 56 38440 4146) (buffers 992 113)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 07:41:35 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 11:41:35 +0000 Received: from localhost ([127.0.0.1]:49237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutJP-0005bG-Ei for submit@debbugs.gnu.org; Mon, 23 Oct 2023 07:41:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutJM-0005b1-H7 for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 07:41:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qutIo-0005YB-6Q; Mon, 23 Oct 2023 07:40:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aRFGuztGL58sylcidw4OMv2NQeqW1eeX8B8YSESWrp4=; b=LbQVyi/GRxvS YDlb3zBCcxmYZ0X7X8nkOPGDt5PczqCmV3f0VP0Z1aW+m2HPlT1BBHj0M+KWVpgSoDcfFrMqV/I4j RkiHcgJueisozJrULEaQI9fz5JlKk1GdwQBrtpJ5bJent3CBMp36iqsaqWw9+zSAmyq7IL4MLDCle cOkjrO6+6a5Qn0JnzHdgqn4T7Um+JIOv0G6ET7QytGNpR388N4BgDxbTNofZTLN9Au/RJ8Uc4pTv4 yI6f5IQNX7QQl3XtFX6SFAP3pc4Q/noBmvW0OqHTbssbAWpRfnfDlosaofp1IkO3ugyRsXHnLwHYC 8hZNY+SAu/73sF2B7yBqhw==; Date: Mon, 23 Oct 2023 14:41:01 +0300 Message-Id: <83o7gpo9bm.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <875y2xelsk.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 23 Oct 2023 11:21:47 +0200 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I'm using desktop-save-mode and regularly open files via Tramp with a > method that asks for a password and that would eventually expire. By > default 'desktop-files-not-to-save' is "\\(\\`/[^/:]*:\\|(ftp)\\'\\)" so > I expect that those remote buffer are not saved by desktop-save. > > When such a remote buffer is opened (but not displayed nor used), Emacs > will keep asking me for this password and I find it annoying. Could you please clarify when does Emacs prompt you for a password? Is it when you restore desktop, save desktop, some other situation? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 08:35:09 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 12:35:09 +0000 Received: from localhost ([127.0.0.1]:49330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quu9E-0007NS-Nq for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:35:08 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:1842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quu9B-0007ND-Jj for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 08:35:07 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=pr5BXUav d7FLAxcL6f0CYj2Ow0Tzs17MWp4HFpSuuWM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=W1phyWJY8qyXrHaX/e3/eDgALWm18j BWENNkdGcNPfEAKr9K2fh0gCiFrDncyVmDCUs/fRMZi4HdxoOo27GaAQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=pr5BXUavd7FLAxcL 6f0CYj2Ow0Tzs17MWp4HFpSuuWM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=vede05Dp6wtQEt6Yem3nzCACuhP3wdWsa6Lv3f mNU89vvWJYG5SCLPDJ33gpfV4onqxIznLJ6sPExE7aMtIH2J74UI1dTEM61ZLUha2jYgxC iJgQ5/TWAZG5+zhbKSdcYkf6JTC1P9gEVVfUY01mdn0AoKvLf8f9gnFEVrQhY7VT3WmfOx 9AExQ30H8lxjpirUxWSLwbmAPCTp7RgcSR5eXVnlUByLitYb3h0+3n5GswegcQjiEALC+6 J3oPujgFQPC9mHIn7xXTK/YfankBFNfT4u1v67WorFuyNg5inkhREO68wGTItagW8/DCXM zsrT15yv/3YaLqejuA1bsqqQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 68f76c58 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 14:34:34 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83o7gpo9bm.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 14:41:01 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> Date: Mon, 23 Oct 2023 14:34:34 +0200 Message-ID: <87pm15h605.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Mon, 23 Oct 2023 11:21:47 +0200 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> I'm using desktop-save-mode and regularly open files via Tramp with a >> method that asks for a password and that would eventually expire. By >> default 'desktop-files-not-to-save' is "\\(\\`/[^/:]*:\\|(ftp)\\'\\)" so >> I expect that those remote buffer are not saved by desktop-save. >> >> When such a remote buffer is opened (but not displayed nor used), Emacs >> will keep asking me for this password and I find it annoying. > > Could you please clarify when does Emacs prompt you for a password? > Is it when you restore desktop, save desktop, some other situation? Hi Eli, It is when 'desktop-save' is called. So it is also called in the desktop-auto-save timer. And BTW, my patch is wrong because it currently bypasses dired buffers (and maybe others). -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 08:48:10 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 12:48:11 +0000 Received: from localhost ([127.0.0.1]:49427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quuLq-0007np-Ga for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quuLp-0007nB-0G for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 08:48:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quuLG-0003qH-HY; Mon, 23 Oct 2023 08:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FWvQasyIIvgum/vsh8Ozr9XXXdB6+m3ASJV94iEQ/lM=; b=jJ10sJkvvRXp qG+UB50Bu20WGvSF7RAuwlDddkuU/F9oINBZsDELB9UUrgV3ammODieKyVoYpZzRls+9/AeIEW2NO 0RZA3r1p4LylxbRyozP3IcJosNrhm/nQp3e0dGSeWp57cnizw/cG8/pOl/eSp0GubqbB27gbETfCS kqZMlBSdSsYqhde9GF/f93oR8sWt0j/4ZkOK/ZjlSJbtFkHJxyq0zsR2kolwwzCK+OFJCTE14aP3f Msq4yNTX710rxdf0aFi/lzOF9LCO+2JAUswSbDc+VPry7BzIg7Mp/q0RzK8gK775BEi8rv4O9ZhCw uzeCyZ2L8qFWdpXGYk7P4g==; Date: Mon, 23 Oct 2023 15:47:36 +0300 Message-Id: <83jzrdo68n.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87pm15h605.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 23 Oct 2023 14:34:34 +0200) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org > Date: Mon, 23 Oct 2023 14:34:34 +0200 > > Eli Zaretskii writes: > > >> Date: Mon, 23 Oct 2023 11:21:47 +0200 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> I'm using desktop-save-mode and regularly open files via Tramp with a > >> method that asks for a password and that would eventually expire. By > >> default 'desktop-files-not-to-save' is "\\(\\`/[^/:]*:\\|(ftp)\\'\\)" so > >> I expect that those remote buffer are not saved by desktop-save. > >> > >> When such a remote buffer is opened (but not displayed nor used), Emacs > >> will keep asking me for this password and I find it annoying. > > > > Could you please clarify when does Emacs prompt you for a password? > > Is it when you restore desktop, save desktop, some other situation? > > Hi Eli, > > It is when 'desktop-save' is called. So it is also called in the > desktop-auto-save timer. So you are saying that, even though these buffers are in desktop-files-not-to-save value, Emacs still asks for a password for them when desktop.el saves the desktop? If so, can you set debug-on-quit non-nil and when Emacs prompts for the password, type C-g and post the backtrace here? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 08:57:07 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 12:57:07 +0000 Received: from localhost ([127.0.0.1]:49447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quuUU-0008FY-SJ for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:57:07 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:17208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quuUS-0008FN-4N for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 08:57:05 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=3JmM8mGd xwTfLLcvbgTG1IcsBpGT0wQsbVbKUCg3ChI=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Kvl6vfxP5fvDvFbPrJOwSOJibDMFnE bl5bAhNvaVlyrAg4HM1xs90tPwRU96rANhcgvOnSD82sXHoO4ZPggVCQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=3JmM8mGdxwTfLLcv bgTG1IcsBpGT0wQsbVbKUCg3ChI=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=WBGUuJrzJQJg7x9QUElXHpVjHFbJp21ACp375Q yVzBd3EYIMx1vSrPOHTVxZfLCxFPdgZQVqZh699V+rS5LhYgJn4xqTOnW/ei7GuP5WIOsj 4q+xUhhFiukKogOhP6e44LJSqIyaIEP9d4TgZtrGgW7F5DfbZrWKGGuWUTO6TfJUF8hQ9g 13vwCSt9z4XKOL0ZK6XyM7ku13b2v+DC2FagML4cIRJNKAIO+5jvBOqAsHNrFdb99gtrVL lIfH3mPPwy3DIVcZzQnCM7WM2XUClo8T5tHlUxyPgd8QX4gELsvoBVygQG2MepXiU5aVcM H5dgQsClqid9RBLYodTWp3Dg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 689e39c4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 14:56:33 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83jzrdo68n.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 15:47:36 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> Date: Mon, 23 Oct 2023 14:56:33 +0200 Message-ID: <87lebth4zi.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > So you are saying that, even though these buffers are in > desktop-files-not-to-save value, Emacs still asks for a password for > them when desktop.el saves the desktop? Yes. > If so, can you set debug-on-quit non-nil and when Emacs prompts for > the password, type C-g and post the backtrace here? I have already (kind of) done that when trying to find out this issue: I've placed a 'debug' call into 'tramp-read-passwd'. Here is what I get: --8<---------------cut here---------------start------------->8--- Debugger entered: nil (let* ((default-directory tramp-compat-temporary-file-directory) (case-fo= ld-search t) (vec (tramp-get-connection-property proc "password-vector" (pr= ocess-get proc 'tramp-vector))) (key (tramp-make-tramp-file-name vec 'noloc= )) (method (let* ((cl-x vec)) (progn (or (let* (...) (progn ...)) (signal '= wrong-type-argument (list ... cl-x))) (nth 1 cl-x)))) (user (or (tramp-file= -name-user-domain vec) (tramp-get-connection-property key "login-as"))) (ho= st (tramp-file-name-host-port vec)) (pw-prompt (or prompt (save-current-buf= fer (set-buffer (process-buffer proc)) (tramp-check-for-regexp proc tramp-p= assword-prompt-regexp) (if (string-match-p "passphrase" (match-string 1)) (= match-string 0) (format "%s for %s " (capitalize ...) key))))) (auth-source= -creation-prompts (list (cons 'secret pw-prompt))) (auth-sources (buffer-lo= cal-value 'auth-sources (process-buffer proc))) auth-info auth-passwd tramp= -dont-suspend-timers) (debug) (unwind-protect (or (setq tramp-password-save= -function nil) (condition-case nil (progn (and (tramp-get-connection-proper= ty vec "first-password-request") (progn (setq auth-info ...) (setq tramp-pa= ssword-save-function ...) (setq auth-passwd ...)))) (error nil)) (if tramp-= dont-suspend-timers (progn (progn (setq auth-passwd (password-read pw-promp= t key)) (setq tramp-password-save-function #'...)) auth-passwd) (let ((stim= ers (with-timeout-suspend)) timer-list timer-idle-list) (unwind-protect (pr= ogn (progn ... ...) auth-passwd) (with-timeout-unsuspend stimers))))) (if (= tramp-string-empty-or-nil-p auth-passwd) (progn (setq tramp-password-save-f= unction nil))) (tramp-set-connection-property vec "first-password-request" = nil))) tramp-read-passwd(#) tramp-action-password(# (tramp-file-name "d= oas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil = "~/" nil)) tramp-process-one-action(# (tramp-file-name= "doas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) n= il "~/" nil) ((tramp-login-prompt-regexp tramp-action-login) (tramp-passwor= d-prompt-regexp tramp-action-password) (tramp-otp-password-prompt-regexp tr= amp-action-otp-password) (tramp-wrong-passwd-regexp tramp-action-permission= -denied) (shell-prompt-pattern tramp-action-succeed) (tramp-shell-prompt-pa= ttern tramp-action-succeed) (tramp-yesno-prompt-regexp tramp-action-yesno) = (tramp-yn-prompt-regexp tramp-action-yn) (tramp-terminal-prompt-regexp tram= p-action-terminal) (tramp-antispoof-regexp tramp-action-confirm-message) (t= ramp-security-key-confirm-regexp tramp-action-show-and-confirm-message) (tr= amp-process-alive-regexp tramp-action-process-alive))) tramp-process-actions(# (tramp-file-name "d= oas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil = "~/" nil) 1 ((tramp-login-prompt-regexp tramp-action-login) (tramp-password= -prompt-regexp tramp-action-password) (tramp-otp-password-prompt-regexp tra= mp-action-otp-password) (tramp-wrong-passwd-regexp tramp-action-permission-= denied) (shell-prompt-pattern tramp-action-succeed) (tramp-shell-prompt-pat= tern tramp-action-succeed) (tramp-yesno-prompt-regexp tramp-action-yesno) (= tramp-yn-prompt-regexp tramp-action-yn) (tramp-terminal-prompt-regexp tramp= -action-terminal) (tramp-antispoof-regexp tramp-action-confirm-message) (tr= amp-security-key-confirm-regexp tramp-action-show-and-confirm-message) (tra= mp-process-alive-regexp tramp-action-process-alive)) 10) tramp-maybe-open-connection((tramp-file-name "doas" #("root" 0 4 (tramp-d= efault t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil)) tramp-send-command((tramp-file-name "doas" #("root" 0 4 (tramp-default t)= ) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("echo ~root 2>/dev/null= ; echo tramp_exit_status $?" 6 10 (tramp-default t))) tramp-send-command-and-check((tramp-file-name "doas" #("root" 0 4 (tramp-= default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("echo ~root" = 6 10 (tramp-default t))) tramp-sh-handle-get-home-directory((tramp-file-name "doas" #("root" 0 4 (= tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("root" = 0 4 (tramp-default t))) apply(tramp-sh-handle-get-home-directory ((tramp-file-name "doas" #("root= " 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #(= "root" 0 4 (tramp-default t)))) tramp-sh-file-name-handler(tramp-get-home-directory (tramp-file-name "doa= s" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~= /" nil) #("root" 0 4 (tramp-default t))) apply(tramp-sh-file-name-handler tramp-get-home-directory ((tramp-file-na= me "doas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t))= nil "~/" nil) #("root" 0 4 (tramp-default t)))) tramp-file-name-handler(tramp-get-home-directory (tramp-file-name "doas" = #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" = nil) #("root" 0 4 (tramp-default t))) tramp-get-home-directory((tramp-file-name "doas" #("root" 0 4 (tramp-defa= ult t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("root" 0 4 (tramp= -default t))) tramp-sh-handle-expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default= t) 11 13 (tramp-default t)) nil) apply(tramp-sh-handle-expand-file-name (#("/doas:root@bb:~/" 6 10 (tramp-= default t) 11 13 (tramp-default t)) nil)) tramp-sh-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (tr= amp-default t) 11 13 (tramp-default t)) nil) apply(tramp-sh-file-name-handler expand-file-name (#("/doas:root@bb:~/" 6= 10 (tramp-default t) 11 13 (tramp-default t)) nil)) tramp-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (tramp= -default t) 11 13 (tramp-default t)) nil) expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp= -default t))) desktop-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tram= p-default t)) "/home/manuel/.emacs.d/") dired-desktop-buffer-misc-data("/home/manuel/.emacs.d/") desktop-buffer-info(#>) mapcar(desktop-buffer-info (# # # # #> # # # #> # #> # = # # #> #> # #> # # # # # # # # # # # # # # # # # # #> # # # # # #> # #> # # # # ...)) desktop-save("/home/manuel/.emacs.d/" nil t) desktop-auto-save() apply(desktop-auto-save nil) timer-event-handler([t 0 30 0 nil desktop-auto-save nil idle 0 nil]) --8<---------------cut here---------------end--------------->8--- --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 09:26:36 2023 Received: (at submit) by debbugs.gnu.org; 23 Oct 2023 13:26:36 +0000 Received: from localhost ([127.0.0.1]:49471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quux1-0000kE-Ry for submit@debbugs.gnu.org; Mon, 23 Oct 2023 09:26:36 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quuwz-0000ju-BC for submit@debbugs.gnu.org; Mon, 23 Oct 2023 09:26:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quuwM-00024O-V7 for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 09:25:55 -0400 Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quuwJ-0003zf-QP; Mon, 23 Oct 2023 09:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1698067541; x=1698672341; i=michael.albinus@gmx.de; bh=zRCMCP+uNFsh3TpYx0U1W7rd6Eb3BlevlUuPdgMedWo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=FZcgf2qL8Mk+NnDg9NXKWtn85HFC/b0ynGBGPD1F/jOdJ1sRxR/2OuUtOmL1cmBh c+cS6zZMcBl5DOsufx9dar/nyh6/AQTfpTcWwa09PxbIDtg7ZjfbKmkgm5ns9CrmW EEEHwpQsIfELgl3eQdYoagVRJMScML6lSkMvvPDmSIZ34A0Bg5dZVeAu7IztcANwN dgqNRyyQW5VDLNT2VKHGAV1y5wN07zvZjYcDesuvsJoDSXH19cl3ziWatB8thATO9 1su5UVT0IaCytVW668CYGx9N6tT5IxFhcQ7S3k5WeI6ehyUM2cFVCxJlo6md0cYQ3 3/joI8DMNwor0nGnFA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.30]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MCsU6-1qm5FV23fs-008q5d; Mon, 23 Oct 2023 15:25:41 +0200 From: Michael Albinus To: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <87lebth4zi.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Mon, 23 Oct 2023 14:56:33 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> Date: Mon, 23 Oct 2023 15:25:40 +0200 Message-ID: <87zg09fp2j.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TrCYSHjvFkkYphEHrYsVXikoWhWIwF0Vj+8dQ11AKgRWk+NZeb3 JH8BZF4flg9t7ovuMHGwLjir7iXUbTm/3/yu6947peHjSRYumW44k/sEBBaXRzMx9sDItoB QYbTXD8T/3h3hzROjTfMcP/r05rG/ZFF+slK6KakMOBfacFdQZP1VcReujQ3jHQnP+0Pnqe w7q+xYTYJip0wjW9BOZLQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xh5eYqD1tV8=;Uw6Gff9KUIkEiGBgPG5axf2Ov4j K8nsTHIg6FGOk1BAvONEszIRXKCWJGPIrBQV4Avc+Jof/5EVr/1GK5x9iOFjIrhaHzJJvIIsD An2g/bTC8Y4KX+Y/Sf59aqLnlp2mN2/3/qjfO+nvpejgTdPax4H3CurngSpmmuRt4rtYiHhJj 4Pp2jWq//mMTTwELwJtXnS+ChMAR/AceOMGqo0QoMXT/gYUFtsMnpDfex33NBVfqJgxCQ2Ob5 hwZdS29NmNNxrQ82o0EQiOb4vJ0/Aj7mS2/IyxiaMm80/wToEWIxdf9PQ8ivW0YDP7JtT+dGJ u/W4j2B0ATFAlL75iMdjb2FCNYeA7LgACKEQgKYnY4tlr2teOPl0R+EqZ2H365kWvGz3TQRtb Wu03VgmJgBepg2cCypzkcPxJHsJExAB3JGu2IfHDmJM0TQMZu/BzFJvPusP62ESLsV4kv1DxP S/ubvCRZDm6PPhIkfNDg2BuQjoUr6981LPBrI4xdIDQIPv2RtWhKRc1YIX5ueGN3ajQbZ+wgA TfEvjWPusBUY7H7VII95DMX1m5ruUNjxFPs4OKPS3jswADaKD0hNxy4mXAeGSuZ645QD1yiLU 30Jei7hwwQKzVhrQfUzwCsZPM+WY9o7FAzmcv8u+tSEJBwtB+u4C2iE+Q5RIIUF/rZsY5N2di EbrRaBngfCogJksQ+xlHMK7fcMQBJOzPEaXkDDOBHLsq7SmL7T86ngkDBSMA7YgbTJU0WxXw2 94Aiv8HU+vZjhQwMLINKPL3xGgbn2F9Voi4xlGNaFyrCSG4ENV/UKtT6QcMJDctdN3tILcZSR ctp69gvJ6sB6h9LWFNcuGIjL5xTrz4ZY1KD73VyH/2rZ4bfYa0YlYPQ4o314VSwteyFtEhnXB E/bsMFkb5wIVRFmTI98SoPGhVR7dwZzW+K7yvebGVySqoY6v8asQULI2PJR60/c01CIdjhcNm /xxm9A== Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii , 66697@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: Hi Manuel, >> If so, can you set debug-on-quit non-nil and when Emacs prompts for >> the password, type C-g and post the backtrace here? > > I have already (kind of) done that when trying to find out this issue: > I've placed a 'debug' call into 'tramp-read-passwd'. Here is what I > get: The relevant part is this: > tramp-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t)) nil) > expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t))) > desktop-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t)) "/home/manuel/.emacs.d/") desktop-file-name calls expand-file-name, which triggers Tramp actions. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 09:33:50 2023 Received: (at submit) by debbugs.gnu.org; 23 Oct 2023 13:33:50 +0000 Received: from localhost ([127.0.0.1]:49481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quv42-0000wW-3i for submit@debbugs.gnu.org; Mon, 23 Oct 2023 09:33:50 -0400 Received: from lists.gnu.org ([2001:470:142::17]:36092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quv40-0000wF-OH for submit@debbugs.gnu.org; Mon, 23 Oct 2023 09:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quv3Q-0006Yg-Uk for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 09:33:12 -0400 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quv3O-0005My-Sc; Mon, 23 Oct 2023 09:33:12 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=UDWuHLSb SV8pfE+j7SuqTSWX4o91kWaOYzZyQex0ob8=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=7qF7ZWBuP8k6PhSXpjZg23RoGChZcV lRRXtjHvlTXuHM70FLzRBcPXxWG99AA0p7qkkYCcwShxc6eMGVVetRCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=UDWuHLSbSV8pfE+j 7SuqTSWX4o91kWaOYzZyQex0ob8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=jaH73LJ6fODKRa3KVT3U9DHaTGlscrXlVgtJAe 14QeaZPDlcag5kpjFkSH2gdOd50DoXuSrkJ2suWd96KB+rDqFe8LqbNCI9Z6ZnA67HN9KQ DWHmtydUmERVAGVqoDTz9CwH1e3g+oILopcdPobCYjcQDEiLfJ34ez7tI/wnpnL9b0kr1H AkiLNXl9LOV6+I2XHrBWvw0D1mTsq9nf3gfy2m9NrsSLKs8k5/thQdm9Qv4pdvJKxYkXYp 2jM4Xci1z47nH1OUNjf4KZYKTaFddkL+7l8LeqzcxrOjRcu77nMNtr2qybSQmonQxCt1w7 ibrYVx1Td/jwrbXZhkEjD1Tw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 20055417 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 15:33:08 +0200 (CEST) From: Manuel Giraud To: Michael Albinus Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <87zg09fp2j.fsf@gmx.de> (Michael Albinus's message of "Mon, 23 Oct 2023 15:25:40 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <87zg09fp2j.fsf@gmx.de> Date: Mon, 23 Oct 2023 15:33:07 +0200 Message-ID: <87v8axzcoc.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: "Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Eli Zaretskii , 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Michael Albinus writes: Hi Michael, [...] > The relevant part is this: > >> tramp-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t)) nil) >> expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t))) >> desktop-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t)) "/home/manuel/.emacs.d/") > > desktop-file-name calls expand-file-name, which triggers Tramp > actions. So do you think it should be fixed into 'desktop-file-name'? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 10:07:59 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 14:07:59 +0000 Received: from localhost ([127.0.0.1]:51238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quvb3-0002NL-CQ for submit@debbugs.gnu.org; Mon, 23 Oct 2023 10:07:59 -0400 Received: from mout.gmx.net ([212.227.15.18]:51817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quvay-0002N4-0R for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 10:07:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1698070036; x=1698674836; i=michael.albinus@gmx.de; bh=g+iq0opSd6ikc2dHN0tggdqvYHpj6LIeBnB9zNbLZhI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=Nx9s9VTTFzPXZgmUz8RxtfQFOPm/1J0OlgUxkSovR1zKZFOMZ4NBnvQLPAFUY8eh 1YCL5H6HSPxSleVl3iJbeBQSVZIv1AkDQuYgzJ3ioNeMb35XfmJ4QasfdFarig3/2 ggitPdB25JOH/wBkeyBsDy02qCXmz//q/O5MFFWgvh9GwgKXqHwKYeTsVoGRE+pqm TsfEsuewMSRvV9ZEVSsPKSOt95Dpu28r4l3qJBrG9g7E1YbBZVvFGR0WMro0zMJra +JwpuOec3MFk8acOBHqBZzDYyeCiAZUoC5I4NBWPd11SBcXdIvp94fCpoWG6xtxfw W3/lpvAbAiJsrLL+lQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.30]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTABZ-1r4R471QGl-00UXV8; Mon, 23 Oct 2023 16:07:16 +0200 From: Michael Albinus To: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <87v8axzcoc.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Mon, 23 Oct 2023 15:33:07 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <87zg09fp2j.fsf@gmx.de> <87v8axzcoc.fsf@ledu-giraud.fr> Date: Mon, 23 Oct 2023 16:07:15 +0200 Message-ID: <87sf61fn58.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:qWnV95lLiLzcNAcVlY/oFo4EpJdcqQDB3JRXcp0ZufK0zomHh+7 whJmaFIb9QkuxgUCcFKwR+2k7fnRg4YExi0ND3kbUvmzkRuuOhcI0O4cO697SbozOjKxMZV MvjlDoawWN48a+HO3v8Gfggqpk9gMIq5wYqrVPNtev8QwD7E04aq2njAIpGxZ+WZ/kajZAd Toetikz7eRAoAJB7BN0Hg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Gzzg+o6XUKs=;zTPdNiWFZ7UH5w5hbGcf60nSNGW mW+CxdfZDjMypxqEZAiQDNJKGqVw7HJ8UXcgWk6g1YmvdsjA47Yykjs93/8XVwsVPipFSDc3W df4wTRXLQ1MGmuPvXlq6cCDwojZkkQYbtK9Hu/LSX1zvqFucm2pRW+Mu+knOR7oJaTqwm2lEr 9BLYxehHAGuWDSvizo/4ZmHsHsHpmLkiY4NYfRNku2ADMa7jCteOBhPryb+HJVU3YlRXLIvAz sg5s4ThcMcQuBngWJlY1zoMgaMvtZpNOnZrxP2F5YPyaSRkKImjafCArdQxqK/3ujnwD35XrR cznIxNokdKLZqlyav8TS+wh5RqzEv6IHqP19VA5gboHNd0UkNdnpoPKoR3o7JnOiX/fN6gXZN vI5WL9XpgRHIf0vp4lMyRJ+ILdwrq9nwlH0mZPxIu1Px+IPVoQtBag+2y5r3t0YnswpE1rSno Bvgr74d9VN9lIGQxefdcsRY347K8dQCVZEEFiGdGrnjrVrU0CrJ7gc1qFwWsxfeTJWaPtsD0V A7bbCEH6sQKESeEZqC7LNhEXOQMyjatGtuLTJGPrTNMLK8xUSog2ylO4R9B7suiAtbVbAyy/C sBCZ5WOideT5VznI7kOCPx15F55JxWM9oyZ1pz/ea5K0OLOKKDLbxV1dHAshBYq3cE8naZcPs XXg2NCVBR/cqS5NWEcI+H7PBkqB9XX8SabScCT6DlIRAYK0xoYTyVaHYHnCEGnlWBJuXlesyT yB+U6OC7AWWYfGMB0qwLQxp1OSxqArek7H2Uh9nb1yjwzFTY9FAjASGIgIQsjN7o+6veEMbl/ +/uoWh/etIrZc2LLp16uJ9/defCoDr6CTXaH/lEDiU3ilW8HR5TEv12zR9kDzsmEx63Nq0SCD od45uZaJuL5S7icSTTesS2WvoUMnfUIzzGZazHcGAAjCP0rklsNZaHy2Uxw24zh4RaHhqGEFW ZZ1GQkgw+srLENbBo8pUYDyMY9M= X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 66697 Cc: eliz@gnu.org, 66697@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Hi Michael, Hi Manuel, >>> tramp-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t)) nil) >>> expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t))) >>> desktop-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tramp-default t)) "/home/manuel/.emacs.d/") >> >> desktop-file-name calls expand-file-name, which triggers Tramp >> actions. > > So do you think it should be fixed into 'desktop-file-name'? I don't know desktop-file-name and its intention. If it shouldn't trigger remote actions, the function must let-bind non-essential to t. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 10:22:01 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 14:22:01 +0000 Received: from localhost ([127.0.0.1]:51256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quvoe-0002iz-EJ for submit@debbugs.gnu.org; Mon, 23 Oct 2023 10:22:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quvoc-0002im-D0 for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 10:21:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quvo2-0000Jp-Qx; Mon, 23 Oct 2023 10:21:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:Subject:In-Reply-To:To:From: Date; bh=3YcHPL36B1Rk4X16XjyOOCoYfMAK7upW3o1UFtOyYkU=; b=Z/A/eYFZoBujdWgaw1Yp W7DQZ7GLrM6I8DyxXmYHCwkGwM9Jb8XaTk6PFqCtvchzZVSvKWVJwINPNiWQ6+SltlpGUEkbgRIFG me73aE20ZcH95manfg30A5mWxYaCGxdLnjUQRgHCqa0Q0TvTXa3LQx1/wzenJVQdZyQlDNYgGNp+o 28hj7iqyqmm5nWjZR6f1A1WrR99flwlKm2s/xzxspVYZafUWIfzE7APTpdsZd66+u6vZaXOk6mttR s+rY1b2VJUMxY5SDXpKjv2ZDHSXsQACvo+jC6szbodKxIwc+JAqduNsqZWRoBerrM7c0ZqxjHCtG0 P9Nhjz+57xgZLA==; Date: Mon, 23 Oct 2023 17:21:25 +0300 Message-Id: <83a5s9o1wa.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87lebth4zi.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 23 Oct 2023 14:56:33 +0200) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org > Date: Mon, 23 Oct 2023 14:56:33 +0200 >=20 > Eli Zaretskii writes: >=20 > [...] >=20 > > So you are saying that, even though these buffers are in > > desktop-files-not-to-save value, Emacs still asks for a password for > > them when desktop.el saves the desktop? >=20 > Yes. >=20 > > If so, can you set debug-on-quit non-nil and when Emacs prompts for > > the password, type C-g and post the backtrace here? >=20 > I have already (kind of) done that when trying to find out this issue: > I've placed a 'debug' call into 'tramp-read-passwd'. Here is what I > get: >=20 > --8<---------------cut here---------------start------------->8--- > Debugger entered: nil > (let* ((default-directory tramp-compat-temporary-file-directory) (case-= fold-search t) (vec (tramp-get-connection-property proc "password-vector" (= process-get proc 'tramp-vector))) (key (tramp-make-tramp-file-name vec 'nol= oc)) (method (let* ((cl-x vec)) (progn (or (let* (...) (progn ...)) (signal= 'wrong-type-argument (list ... cl-x))) (nth 1 cl-x)))) (user (or (tramp-fi= le-name-user-domain vec) (tramp-get-connection-property key "login-as"))) (= host (tramp-file-name-host-port vec)) (pw-prompt (or prompt (save-current-b= uffer (set-buffer (process-buffer proc)) (tramp-check-for-regexp proc tramp= -password-prompt-regexp) (if (string-match-p "passphrase" (match-string 1))= (match-string 0) (format "%s for %s " (capitalize ...) key))))) (auth-sour= ce-creation-prompts (list (cons 'secret pw-prompt))) (auth-sources (buffer-= local-value 'auth-sources (process-buffer proc))) auth-info auth-passwd tra= mp-dont-suspend-timers) (debug) (unwind-protect (or (setq tramp-password-sa= ve-function nil) (condition-case nil (progn (and (tramp-get-connection-prop= erty vec "first-password-request") (progn (setq auth-info ...) (setq tramp-= password-save-function ...) (setq auth-passwd ...)))) (error nil)) (if tram= p-dont-suspend-timers (progn (progn (setq auth-passwd (password-read pw-pro= mpt key)) (setq tramp-password-save-function #'...)) auth-passwd) (let ((st= imers (with-timeout-suspend)) timer-list timer-idle-list) (unwind-protect (= progn (progn ... ...) auth-passwd) (with-timeout-unsuspend stimers))))) (if= (tramp-string-empty-or-nil-p auth-passwd) (progn (setq tramp-password-save= -function nil))) (tramp-set-connection-property vec "first-password-request= " nil))) > tramp-read-passwd(#) > tramp-action-password(# (tramp-file-name = "doas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) ni= l "~/" nil)) > tramp-process-one-action(# (tramp-file-na= me "doas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t))= nil "~/" nil) ((tramp-login-prompt-regexp tramp-action-login) (tramp-passw= ord-prompt-regexp tramp-action-password) (tramp-otp-password-prompt-regexp = tramp-action-otp-password) (tramp-wrong-passwd-regexp tramp-action-permissi= on-denied) (shell-prompt-pattern tramp-action-succeed) (tramp-shell-prompt-= pattern tramp-action-succeed) (tramp-yesno-prompt-regexp tramp-action-yesno= ) (tramp-yn-prompt-regexp tramp-action-yn) (tramp-terminal-prompt-regexp tr= amp-action-terminal) (tramp-antispoof-regexp tramp-action-confirm-message) = (tramp-security-key-confirm-regexp tramp-action-show-and-confirm-message) (= tramp-process-alive-regexp tramp-action-process-alive))) > tramp-process-actions(# (tramp-file-name = "doas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) ni= l "~/" nil) 1 ((tramp-login-prompt-regexp tramp-action-login) (tramp-passwo= rd-prompt-regexp tramp-action-password) (tramp-otp-password-prompt-regexp t= ramp-action-otp-password) (tramp-wrong-passwd-regexp tramp-action-permissio= n-denied) (shell-prompt-pattern tramp-action-succeed) (tramp-shell-prompt-p= attern tramp-action-succeed) (tramp-yesno-prompt-regexp tramp-action-yesno)= (tramp-yn-prompt-regexp tramp-action-yn) (tramp-terminal-prompt-regexp tra= mp-action-terminal) (tramp-antispoof-regexp tramp-action-confirm-message) (= tramp-security-key-confirm-regexp tramp-action-show-and-confirm-message) (t= ramp-process-alive-regexp tramp-action-process-alive)) 10) > tramp-maybe-open-connection((tramp-file-name "doas" #("root" 0 4 (tramp= -default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil)) > tramp-send-command((tramp-file-name "doas" #("root" 0 4 (tramp-default = t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("echo ~root 2>/dev/nu= ll; echo tramp_exit_status $?" 6 10 (tramp-default t))) > tramp-send-command-and-check((tramp-file-name "doas" #("root" 0 4 (tram= p-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("echo ~root= " 6 10 (tramp-default t))) > tramp-sh-handle-get-home-directory((tramp-file-name "doas" #("root" 0 4= (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("root= " 0 4 (tramp-default t))) > apply(tramp-sh-handle-get-home-directory ((tramp-file-name "doas" #("ro= ot" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) = #("root" 0 4 (tramp-default t)))) > tramp-sh-file-name-handler(tramp-get-home-directory (tramp-file-name "d= oas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil = "~/" nil) #("root" 0 4 (tramp-default t))) > apply(tramp-sh-file-name-handler tramp-get-home-directory ((tramp-file-= name "doas" #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t= )) nil "~/" nil) #("root" 0 4 (tramp-default t)))) > tramp-file-name-handler(tramp-get-home-directory (tramp-file-name "doas= " #("root" 0 4 (tramp-default t)) nil #("bb" 0 2 (tramp-default t)) nil "~/= " nil) #("root" 0 4 (tramp-default t))) > tramp-get-home-directory((tramp-file-name "doas" #("root" 0 4 (tramp-de= fault t)) nil #("bb" 0 2 (tramp-default t)) nil "~/" nil) #("root" 0 4 (tra= mp-default t))) > tramp-sh-handle-expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-defau= lt t) 11 13 (tramp-default t)) nil) > apply(tramp-sh-handle-expand-file-name (#("/doas:root@bb:~/" 6 10 (tram= p-default t) 11 13 (tramp-default t)) nil)) > tramp-sh-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (= tramp-default t) 11 13 (tramp-default t)) nil) > apply(tramp-sh-file-name-handler expand-file-name (#("/doas:root@bb:~/"= 6 10 (tramp-default t) 11 13 (tramp-default t)) nil)) > tramp-file-name-handler(expand-file-name #("/doas:root@bb:~/" 6 10 (tra= mp-default t) 11 13 (tramp-default t)) nil) > expand-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tra= mp-default t))) > desktop-file-name(#("/doas:root@bb:~/" 6 10 (tramp-default t) 11 13 (tr= amp-default t)) "/home/manuel/.emacs.d/") > dired-desktop-buffer-misc-data("/home/manuel/.emacs.d/") > desktop-buffer-info(#>) > mapcar(desktop-buffer-info (# # # # #> # # # #> # #> # # # #> #> # #> # # # # #<= buffer terminal.c> # # # # # # # # # # # # # #> # # # # # #<= buffer *vc-dir*> # #> # # # # ...)) > desktop-save("/home/manuel/.emacs.d/" nil t) > desktop-auto-save() > apply(desktop-auto-save nil) > timer-event-handler([t 0 30 0 nil desktop-auto-save nil idle 0 nil]) > --8<---------------cut here---------------end--------------->8--- Doesn't this tell that the problem is in dired.el, not in desktop.el? The problematic call comes from dired-desktop-buffer-misc-data, not from desktop.el. So it's dired-desktop-buffer-misc-data that needs to be fixed. Alternatively, we could refrain calling desktop-buffer-info on buffers for which desktop-save-buffer-p returns nil. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 10:56:33 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 14:56:33 +0000 Received: from localhost ([127.0.0.1]:51324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quwM5-0006G8-3L for submit@debbugs.gnu.org; Mon, 23 Oct 2023 10:56:33 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:36473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quwM2-0006Fz-03 for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 10:56:31 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=+28ZQfON j0uRMwJJBmvXtzRK3QUaQaQfgw0QKJ2ogoc=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=vllCuvBdd4B8fLt29wYzHIaEtU9mlf dxgwi+Hal80143l901GS80yUOZSc05n//R9yV7orgqWlb6LQKNqkLuDg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=+28ZQfONj0uRMwJJ BmvXtzRK3QUaQaQfgw0QKJ2ogoc=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=wj8Vko/5fQGLyZPxHloSdnmtmt4Oha3F6hR/go Ii30VScFbz/MLPbzg+LyVvw37EKQLLBYU6dEHQGlb6I5nE7utVli5SVZjVBSHdeBUjWhYx pOB/bq7TWlphUsZwG7x77/9SBGFIvF5jWEwSqBXf1AjDEWG0VTk5lAlIHWpa/WcB6l0n8J wNB41/fiE1LnTTJsGhHYsojdHOnPdZXNJIP/7QJ7Knbjzz+uk5Cg7UPNs+fX4fY7j8aHf7 LlFsNmDX0HgdT/zXhn2x2x9eKIk+4Eketo/saRQOXdHrYVfTqAXC59DtQxI04zsBdwMFn8 zbiRQhSa8mgaunnkdpeq3pwA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 66665fc6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 16:55:59 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83a5s9o1wa.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 17:21:25 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> Date: Mon, 23 Oct 2023 16:55:58 +0200 Message-ID: <87edhls801.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > Doesn't this tell that the problem is in dired.el, not in desktop.el? > The problematic call comes from dired-desktop-buffer-misc-data, not > from desktop.el. So it's dired-desktop-buffer-misc-data that needs to > be fixed. Ok, I'll investigate here then. > Alternatively, we could refrain calling desktop-buffer-info on buffers > for which desktop-save-buffer-p returns nil. That was kind of what my patch does=E2=80=A6 but it creates new issues beca= use 'desktop-save-buffer-p' handles many test cases against file-name, buffer-name and mode. And file-name, buffer-name and mode are all retrieved into 'desktop-buffer-info'. --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 11:22:29 2023 Received: (at submit) by debbugs.gnu.org; 23 Oct 2023 15:22:29 +0000 Received: from localhost ([127.0.0.1]:51358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quwlA-00017e-Sk for submit@debbugs.gnu.org; Mon, 23 Oct 2023 11:22:29 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quwl8-00017Q-OQ for submit@debbugs.gnu.org; Mon, 23 Oct 2023 11:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quwka-00042G-1E for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 11:21:52 -0400 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quwkX-0000L2-Tt; Mon, 23 Oct 2023 11:21:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1698074497; x=1698679297; i=michael.albinus@gmx.de; bh=TN6oG9923uxmoXP/0RqTaZ/N/TGICwnn6Oty8e4D4co=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=iXAa5NpKLd3lonFjVusYuh+z8klHlkpavM2iUFf2y5nk+/GbMSggxgW4xx6fgccO D0j34DJs+VUKbN8s+GmjxiNz9Dy+LaHexIFDGoGh5t1SXYjcSKMNrrrCQcL9q56+O G8TLcyoh0Nv7JHoHwY31P4Agr2ZpDlVGTCfiIctCgGmKkRnS/EuwiTkEXSzuo4AiP RTitwD4vrrzPQPY/faD605vdnz441VhD75Qp2LF51gkRqdShuG3ID+S0eSGTzm7cz Icf+1OtlR3/clhWZP12WkuBW4PijvG8bwZKrQCPHbBNum+5bP0RTn//VNybyZbzXG +jGwiQGLwXwUmGYzNw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.30]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MwfWa-1rivm726Be-00yDPF; Mon, 23 Oct 2023 17:21:37 +0200 From: Michael Albinus To: Manuel Giraud Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <87v8axzcoc.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Mon, 23 Oct 2023 15:33:07 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <87zg09fp2j.fsf@gmx.de> <87v8axzcoc.fsf@ledu-giraud.fr> Date: Mon, 23 Oct 2023 17:21:36 +0200 Message-ID: <87edhlfjpb.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:w+ctz1YZoOmNH2XGM4VvBwliACCDzYiV0iqtPzotSVDcYZ/FNmU WoP8Nfc1upcIXbGp+5vp/DPPsxAfVdgW5Cb9+NuI/iHyy5A9PSzcQFMvsaPcOVcZpUZXD61 YAQRf64rJ1mgG9IXLOmmHduQM39B5S+TjuB1KZVHCdvcEyXH1WgmVNC2DWpr3v9mQeEsJa3 3m9ADhUEGWvZwl1Jx90nw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:A4HWTkSyNek=;Rc7pusatuuuXp0ThA7Cq89GQp2N ltCqKp/Hh/sQhQLLm0cOrziCwP4QbolW+pX+LFXL8T7waYyjJCu71UF3/23fWHWNh4OUz+pgO DrSoaICe5ZserGlb0by1WzOFnaakGqdHi1SsoSRXr9sCIZ/MInBE3RGy4pXwP7C7zud+KGb0c WP8n1joVyOiB1h1HNoENv0G9FbytqMffDjBH780VPRsdPmWxFJuTG0fSrTwKAcfu0fhTZKLT7 WUbfIkwS60iLOy1YUrzs5YL6lc1Qdj/U6gdpp6Z5BTRrtm0VFxYwEPihJ/9fKUXhdb4B59XfX JOc66uXR14ekAuiMjkqk2Pk53ilesEolaa8ZBc3f6WKu29UfsaX7Y8/Q+wE1qYmoKSZF0eLgk AsrZGhvhWD2Ginu/6k7v8yukH6n47HPLqmN7uwUVFwxlIs+3coTPKxLGcli+PESTigEMKobRC scg+JdbHLFZptqllwFfWbWxIyfq0B0wSynN7uwn8mO19WEYRnseAwOIpLY7odLyIsH0T4H+rs 66MBKgnQmKvN49grsP9phKxVTKZ3BYn8a2/bdL8xNwmNm84ozrsjYzKH3wXY0DXSOMDVkKRTu 5hxWKPJCk/Jpr3GlUKEyXHZGI+slAsLls8pvHQp2TIF7Ps6W5IniZwY2Y8bD6h6vEW5XbP0Xu J2orvlRfOqJkro1dwbX9Lcxe5axk8vuqA2486um4ezFlRxNmNGIDOrYnXHVK1xKB0SXBIV+96 BbJaXxIeKJidP36pkBAY+MWrKV1re4ytBCUQHaw1CYwfXdZsSvzDZaeawcssoRRrYFL6xr/4v vmoTymq6oKVodPEJ18XtGPrdWEGldFCEvJ6eD0SVnF7WZwCEDDyUzYBCvSXW6pBjaZeXe/Shd wSKKCfhEBsJ1zWWmKOYqYKo7nxy9LmZ7F8sqzxGstQ8wTT0OOXThhdH0O1iZDceYCTOuRoVSH U+FcJA== Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: "Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Eli Zaretskii , 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Manuel Giraud writes: > Hi Michael, Hi Manual, >> desktop-file-name calls expand-file-name, which triggers Tramp >> actions. > > So do you think it should be fixed into 'desktop-file-name'? I don't know desktop.el, so I don't think anything where to fix ... Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 11:46:56 2023 Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 15:46:56 +0000 Received: from localhost ([127.0.0.1]:51380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qux8q-0001nJ-G1 for submit@debbugs.gnu.org; Mon, 23 Oct 2023 11:46:56 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:8173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qux8m-0001n6-UB for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 11:46:55 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=UIdIkrxz nFyrqqxcuI1l5vpy/Znyaet0M9UR89haaYA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=0Z2rvd2LXht67vAqFNDYJj8pTl7cn5 itjzhYd7Lmzmr6IX5UymJD+Q9PyCSdeQvFVhXnzqpde6VAeVxfkiNzBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=UIdIkrxznFyrqqxc uI1l5vpy/Znyaet0M9UR89haaYA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=I4EFFCVIsyC9g8PKGZFP3rGBvAOBGPRPDLTExS X7tmWPUZAL8SS4BhcG+5ZV6hN3t8oOkUyZeZ7Xd5J8j/GRlB4HsuB/yI3eJmSuaXlJNupQ 4iX5j9sEftImcbq7Y+UklsxbPDLWXNmSXHhAl9e4VR18x/Nr2aTnqytrVRGP87zh9CkBjc 0zt1fz/i/DKQ8HR9CR5Jl4yG2r4ssK6npm3n2jKpI2ppaVrxfBcuLmIg8qNKZwLj95K4ii UTQsezlDjMoFsR8GfT0o81Tx/OUr0mur+XLd9xgtXxKfZoSEILZH16tf2DCcLnnHPXZVet bhK6xTkbyDegxyLoCBipr06g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c3861864 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 17:46:22 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83a5s9o1wa.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 17:21:25 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> Date: Mon, 23 Oct 2023 17:46:21 +0200 Message-ID: <877cnd8hpu.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > Doesn't this tell that the problem is in dired.el, not in desktop.el? > The problematic call comes from dired-desktop-buffer-misc-data, not > from desktop.el. So it's dired-desktop-buffer-misc-data that needs to > be fixed. I just did another test that could confirm that dired is misbehaving here: Emacs does not ask for password if I just have a remote *file* opened. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 05:21:58 2023 Received: (at 66697) by debbugs.gnu.org; 24 Oct 2023 09:21:58 +0000 Received: from localhost ([127.0.0.1]:53141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDbq-0001jF-3V for submit@debbugs.gnu.org; Tue, 24 Oct 2023 05:21:58 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:4455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDbl-0001j5-73 for 66697@debbugs.gnu.org; Tue, 24 Oct 2023 05:21:55 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=iozka8+K QIvfRKERk0EwVyXKWRWrerUOISo3r+6OPIg=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=KJyqz44oE/bo4ZfA1XkpygcE+LKQ84 w3SryIViM1Kj+pcyzZ21xQXtS3MkvZzHRV4Bpq/drV7XsLJk6g1uCYAA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=iozka8+KQIvfRKER k0EwVyXKWRWrerUOISo3r+6OPIg=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=TbZ/SPJqas7JvnNrBGu0DoN8Li82VjJcSeCkSH zjL9DenAOuKFPV6mHEqd/+dObPu/0ZAC5qt8S4IIXcDI1lfTgDTYAjgXsE7Gy2nKCvES8g HOfXt4I/miJRgL8bN033EIfY9GyEn5aFh9P3FhBAXsBoFYQX7Wu0LevZFDKpN8i7BwJypI Rm/SKwVoQL5pPz+62MASkXDcTJsJKPM3NQpDeYSdi4vpGeJXbihiX6oLtecCllIxRSdLAq xgz/POF85nH/8+tAe9GHkj/2cOnVsk0stM/VlHLG9kI286aTzAQH6in1kNciRPaleHXtda bZgFjlpmMTGWzCC1gmxGbR6g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 430da498 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 24 Oct 2023 11:21:21 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83a5s9o1wa.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 17:21:25 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> Date: Tue, 24 Oct 2023 11:21:21 +0200 Message-ID: <87wmvc9y0e.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Doesn't this tell that the problem is in dired.el, not in desktop.el? > The problematic call comes from dired-desktop-buffer-misc-data, not > from desktop.el. So it's dired-desktop-buffer-misc-data that needs to > be fixed. So I work a bit on 'dired-desktop-buffer-misc-data' and have the following solution: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=dired.diff diff --git a/lisp/dired.el b/lisp/dired.el index cc8c74839b9..cae9f31010a 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -4875,22 +4875,30 @@ dired-dnd-handle-file (eval-when-compile (require 'desktop)) (declare-function desktop-file-name "desktop" (filename dirname)) +(defun dired-desktop-buffer-save-p (dired-directory) + "Should this DIRED-DIRECTORY desktop saved?" + (if (consp dired-directory) + (not (string-match-p desktop-files-not-to-save (car dired-directory))) + (not (string-match-p desktop-files-not-to-save dired-directory)))) + (defun dired-desktop-buffer-misc-data (dirname) "Auxiliary information to be saved in desktop file." - (cons - ;; Value of `dired-directory'. - (if (consp dired-directory) - ;; Directory name followed by list of files. - (cons (desktop-file-name (car dired-directory) dirname) - (cdr dired-directory)) - ;; Directory name, optionally with shell wildcard. - (desktop-file-name dired-directory dirname)) - ;; Subdirectories in `dired-subdir-alist'. - (cdr - (nreverse - (mapcar - (lambda (f) (desktop-file-name (car f) dirname)) - dired-subdir-alist))))) + (when (and (stringp desktop-files-not-to-save) + (dired-desktop-buffer-save-p dired-directory)) + (cons + ;; Value of `dired-directory'. + (if (consp dired-directory) + ;; Directory name followed by list of files. + (cons (desktop-file-name (car dired-directory) dirname) + (cdr dired-directory)) + ;; Directory name, optionally with shell wildcard. + (desktop-file-name dired-directory dirname)) + ;; Subdirectories in `dired-subdir-alist'. + (cdr + (nreverse + (mapcar + (lambda (f) (desktop-file-name (car f) dirname)) + dired-subdir-alist)))))) (defun dired-restore-desktop-buffer (_file-name _buffer-name --=-=-= Content-Type: text/plain WDYT? -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 07:57:12 2023 Received: (at 66697) by debbugs.gnu.org; 24 Oct 2023 11:57:12 +0000 Received: from localhost ([127.0.0.1]:53333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvG23-0000Ek-MX for submit@debbugs.gnu.org; Tue, 24 Oct 2023 07:57:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvG22-0000EX-4t for 66697@debbugs.gnu.org; Tue, 24 Oct 2023 07:57:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvG1Q-0008Q6-OD; Tue, 24 Oct 2023 07:56:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PTLpgsKFxsq3u8/u4b/HVjoHSev8h2SxYJON+RSxt4M=; b=dXdcSq7MOPSQ 9hQ17a0cYRM8ZTN9G+V/tzWo/3Y2MTPamXmQZl0q59Ye/JdD5JQruVKzHOP1L5W/7jQhDOisWxSos FTxFbhKMrRwuvH1wvdezSQq85oepjTKzY3n2nJ9BC1tFyI5R6a+mprFp0GRvo5UOIKdAIfK4nbWuT OZWR3GhofErtloeb3I61ULCLtJ30EQ4aSsGeidIH2UF9rO+dZYfohZGYmfb4RP8k2XP6DpmIrB//q kAywy+UVJkgOHkfMMCZR8MS0KPnhuzfXPegUfApeFvgDD2232UWzwsCd2ivT9CvuXLjPZ0Igra9OW CLtPSHQ+tNMxmlc88MYqbQ==; Date: Tue, 24 Oct 2023 14:56:37 +0300 Message-Id: <831qdkmdxm.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87wmvc9y0e.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 24 Oct 2023 11:21:21 +0200) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org > Date: Tue, 24 Oct 2023 11:21:21 +0200 > > Eli Zaretskii writes: > > > [...] > > > Doesn't this tell that the problem is in dired.el, not in desktop.el? > > The problematic call comes from dired-desktop-buffer-misc-data, not > > from desktop.el. So it's dired-desktop-buffer-misc-data that needs to > > be fixed. > > So I work a bit on 'dired-desktop-buffer-misc-data' and have the > following solution: Sounds right, but don't you get byte-compiler warnings about desktop-files-not-to-save not being known? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 08:01:12 2023 Received: (at 66697) by debbugs.gnu.org; 24 Oct 2023 12:01:12 +0000 Received: from localhost ([127.0.0.1]:53344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvG5w-0002x3-AI for submit@debbugs.gnu.org; Tue, 24 Oct 2023 08:01:12 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:6593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvG5t-0002wt-5N for 66697@debbugs.gnu.org; Tue, 24 Oct 2023 08:01:10 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=JT33cT4E 7f0UMHFy0YSSUMtgHyvJxE2rez7MCJW2PTA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=51E17o4bL+3qJOLlpzoOBIDWgvVRLH jUMy5do3PLm4LzeCRUREU5nc3OtwUwNt53EJqL7Sf0ScGAOPCzCi11BQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=JT33cT4E7f0UMHFy 0YSSUMtgHyvJxE2rez7MCJW2PTA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=xenIGz9Cm5FgjctFaxRoPdCVWYvoL+HlYLXdGf dutYMwzLX92+KN/Z0MAu0iK+2Dmqn16+wTACOAA1ZgNKtqk/dCVHGljjsYmq3ljLedw+YT GQfWPflfC/SO8A0Gvs/0/2SV1ljlJ9914Mh6v3uOmpVLjct8acDe5q/z+2qo5yXitw9I5K mHUaF5BC17hTBeDLOst/D1BtyF0vngCG+1ZHy47sPNsy8IytMMCprMODBpnNkC1KOOX/gM ZAOzy1jYo7LOKZeXqpwRkUFoV+vckf/vFrBracUPqcM2nMijzWgHrwiLfe1svzbmvy0piA XGO+qha711Q5GZg9Npq9FNlQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id a43c12ea (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 24 Oct 2023 14:00:37 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <831qdkmdxm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Oct 2023 14:56:37 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> Date: Tue, 24 Oct 2023 14:00:36 +0200 Message-ID: <87fs209qmz.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 66697@debbugs.gnu.org >> Date: Tue, 24 Oct 2023 11:21:21 +0200 >> >> Eli Zaretskii writes: >> >> >> [...] >> >> > Doesn't this tell that the problem is in dired.el, not in desktop.el? >> > The problematic call comes from dired-desktop-buffer-misc-data, not >> > from desktop.el. So it's dired-desktop-buffer-misc-data that needs to >> > be fixed. >> >> So I work a bit on 'dired-desktop-buffer-misc-data' and have the >> following solution: > > Sounds right, but don't you get byte-compiler warnings about > desktop-files-not-to-save not being known? I haven't properly built Emacs with this, yet. I'll try and report. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 09:19:22 2023 Received: (at 66697) by debbugs.gnu.org; 24 Oct 2023 13:19:22 +0000 Received: from localhost ([127.0.0.1]:53455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvHJa-0005EW-9I for submit@debbugs.gnu.org; Tue, 24 Oct 2023 09:19:22 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:8316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvHJY-0005EO-3t for 66697@debbugs.gnu.org; Tue, 24 Oct 2023 09:19:21 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=EntCOxv/ lGUTdPdhKvN7RUTUt+H9S6Pn6tkj9ruEuQY=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=4sdRxkt2fmOav4w4UKvLrYLzCVM98s HnX1hsKPO2ugMW8FbnpEdicfQmHUknrjlm94SqmXHkYTpNeP2EVeSSDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=EntCOxv/lGUTdPdh KvN7RUTUt+H9S6Pn6tkj9ruEuQY=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=hpSApbaLKar3huUFlJwKfqEJWXE0Ld02BzwetF 8U+n+v4Wvpuk8O1GDL2rXFllz0+Qyx5mCn39ob7v4ANcvSfQfWGX/gFpxJhf4pJVTbrunl akK0KQldcmIIvg086Re/Y420L3ujR1feC6uSFZLWGeCBLa56AAkoJ3EgNV8IQ1aCiqiGNq /tDFT4uIMpBB7oztbarYkvkRAZqhik/tWRnL8tv7yhQQGfMm8mONS+Ez6x4x/FOV+pYfs6 EOUogz3JY+s9PE2FMOvE51PVZ5XMV4shPkT0Pvi6CYPHZE1c8J8chWwdcbvpbbbdsvlniA iPya0TQej2hwOchuzQifNb5g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 73dae6b6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 24 Oct 2023 15:18:48 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <831qdkmdxm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Oct 2023 14:56:37 +0300") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> Date: Tue, 24 Oct 2023 15:18:47 +0200 Message-ID: <87zg0888g8.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Sounds right, but don't you get byte-compiler warnings about > desktop-files-not-to-save not being known? I did not get a warning about desktop-files-not-to-save but I get one about shadowing dired-directory. So I fixed the patch with this new one. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-desktop-save-on-remote-dired-bug-66697.patch >From 6c32d99a9f1e8c813550c5a2540ef41ea2d59844 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Tue, 24 Oct 2023 14:51:04 +0200 Subject: [PATCH] Fix desktop-save on remote dired (bug#66697) Do not gather "misc data" for dired buffer not meant to be desktop saved. lisp/dired.el (dired-desktop-save-p): New function to test if `dired-directory' should be desktop saved. (dired-desktop-buffer-misc-data): Use it. --- lisp/dired.el | 36 ++++++++++++++++++++++-------------- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/lisp/dired.el b/lisp/dired.el index cc8c74839b9..4337480e2b5 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -4875,22 +4875,30 @@ dired-dnd-handle-file (eval-when-compile (require 'desktop)) (declare-function desktop-file-name "desktop" (filename dirname)) +(defun dired-desktop-save-p () + "Should `dired-directory' be desktop saved?" + (if (consp dired-directory) + (not (string-match-p desktop-files-not-to-save (car dired-directory))) + (not (string-match-p desktop-files-not-to-save dired-directory)))) + (defun dired-desktop-buffer-misc-data (dirname) "Auxiliary information to be saved in desktop file." - (cons - ;; Value of `dired-directory'. - (if (consp dired-directory) - ;; Directory name followed by list of files. - (cons (desktop-file-name (car dired-directory) dirname) - (cdr dired-directory)) - ;; Directory name, optionally with shell wildcard. - (desktop-file-name dired-directory dirname)) - ;; Subdirectories in `dired-subdir-alist'. - (cdr - (nreverse - (mapcar - (lambda (f) (desktop-file-name (car f) dirname)) - dired-subdir-alist))))) + (when (and (stringp desktop-files-not-to-save) + (dired-desktop-save-p)) + (cons + ;; Value of `dired-directory'. + (if (consp dired-directory) + ;; Directory name followed by list of files. + (cons (desktop-file-name (car dired-directory) dirname) + (cdr dired-directory)) + ;; Directory name, optionally with shell wildcard. + (desktop-file-name dired-directory dirname)) + ;; Subdirectories in `dired-subdir-alist'. + (cdr + (nreverse + (mapcar + (lambda (f) (desktop-file-name (car f) dirname)) + dired-subdir-alist)))))) (defun dired-restore-desktop-buffer (_file-name _buffer-name -- 2.42.0 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 31 17:15:01 2023 Received: (at 66697) by debbugs.gnu.org; 31 Oct 2023 21:15:01 +0000 Received: from localhost ([127.0.0.1]:49407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxw4j-0007rJ-1s for submit@debbugs.gnu.org; Tue, 31 Oct 2023 17:15:01 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:44749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxw4e-0007r8-4U for 66697@debbugs.gnu.org; Tue, 31 Oct 2023 17:14:59 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=g8LxJwV9 UuNbByCrveRAVQnsy6skZXU13tKzn3IAZwk=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=vKQ2I8yT8L8z8L1AljbnRgWDMkFgKG 4ZGoLS0exZMTOyqpVAPogNPdfmxJobZm6gzE/hKyDQTGvxT4vBAWOXDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=g8LxJwV9UuNbByCr veRAVQnsy6skZXU13tKzn3IAZwk=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Ha/NmhfZwvAXexkdIHj3sdposRV47c/QxvLx3S 0Dyn52Allm/ejSv+4NsU0kEZYaskEF4DKbaiQPlKEwnBKmjIOhOGHAfiQp+GEGoXzmLzhS DEhqqyz1HQH2PEZO9/zzXxnGw9mNReWWTlLz5mG0LkYzKVc68AUqpwiO1C5Rx5Tqqzjj9+ rqZQIQczooR+2KzD0/BqCCUMytCbhfr1FVm37451EH86Ud0yz1insjXfzJxJ5s5mXwqJkD nZoXPTS9i2OMe2FghvOuNSKkeqnkKzSgtBLkPXnIG0mQWXthAYuJsw5y6wKUNgm9qn3fl0 g19xpHpdPbQzxvr7+YIio4qw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id a5f1b8d4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 31 Oct 2023 22:14:20 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <87zg0888g8.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 24 Oct 2023 15:18:47 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> Date: Tue, 31 Oct 2023 22:14:18 +0100 Message-ID: <87cywusded.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud writes: > Eli Zaretskii writes: > > [...] > >> Sounds right, but don't you get byte-compiler warnings about >> desktop-files-not-to-save not being known? > > I did not get a warning about desktop-files-not-to-save but I get one > about shadowing dired-directory. So I fixed the patch with this new > one. Hi Eli, Do you think you could commit it on master? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 31 23:29:30 2023 Received: (at 66697) by debbugs.gnu.org; 1 Nov 2023 03:29:30 +0000 Received: from localhost ([127.0.0.1]:49658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qy1v8-0000tQ-51 for submit@debbugs.gnu.org; Tue, 31 Oct 2023 23:29:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qy1v4-0000t8-9K for 66697@debbugs.gnu.org; Tue, 31 Oct 2023 23:29:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy1uQ-0000l9-Ni; Tue, 31 Oct 2023 23:28:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=321CcoxeE1elGgxk7lFAX9yqvKF7xhV5ZZWtuUtChtw=; b=pHvsmQnecjkf Z9BateB+aN9CyCFE7pK6QpD83UWIoJs+sgmNhB6E9AT/mNPTZgULVKZyr0MIdNNFfRuzgykz0F6J1 kxKiABTutzO324VpQR+kd8yQa/8W+FFPxkmxWecU6T7Q10FOCP6RtkTLNV/Y9YvNaYBjLJOsdC8Fz Va5aXKqKQQZ7KYhKJJm79agGjp/hnLnyLjd7F8pd5xTuU1fQmcAonAP48vO6CcFvsN4hgh9v+6jRF L7vWH5cuNK7qAkr1ViMrVB+hOIuAUb5mHcvWWJ8Qkqa6DLwOydeQFuFC7O72+W0CyuSXtVX/o+325 73rQZjo+N2d3V5OH8DraaA==; Date: Wed, 01 Nov 2023 05:28:37 +0200 Message-Id: <83fs1q9moq.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87cywusded.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 31 Oct 2023 22:14:18 +0100) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org > Date: Tue, 31 Oct 2023 22:14:18 +0100 > > Manuel Giraud writes: > > > Eli Zaretskii writes: > > > > [...] > > > >> Sounds right, but don't you get byte-compiler warnings about > >> desktop-files-not-to-save not being known? > > > > I did not get a warning about desktop-files-not-to-save but I get one > > about shadowing dired-directory. So I fixed the patch with this new > > one. > > Hi Eli, > > Do you think you could commit it on master? It's on my todo, waiting for possible comments by others. No need to ping me yet, since you posted your final version just a few days ago. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 06:21:27 2023 Received: (at 66697) by debbugs.gnu.org; 1 Nov 2023 10:21:27 +0000 Received: from localhost ([127.0.0.1]:50009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qy8Ln-0000bW-FJ for submit@debbugs.gnu.org; Wed, 01 Nov 2023 06:21:27 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:20507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qy8Ll-0000bL-5a for 66697@debbugs.gnu.org; Wed, 01 Nov 2023 06:21:26 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=NkbiLEBw N00Zm7Es1L1URTG2mKdAuXiVE6T8Lv6JBGo=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=b/A+qIXaoTz0crAOKIUwBZDcK1GOTz h8+dG+xSBjZHZJhQxwTcsdbg5ka+XIATk/WjF01fk6YqLiC/AXJUDmBw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=NkbiLEBwN00Zm7Es 1L1URTG2mKdAuXiVE6T8Lv6JBGo=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Af5ILqmH/s2uA6DJl31cmAR7wMiH3TH6xhKzj1 gXLLS64/mogNInwI4LHa8/Y/+gPb+NlyBe/tY7W/ES/ug8OcW0oCxx21mqfBnSkittxEKy aDxRmilYu9qnvXqy8+gbKnvCM9VOlNGkTWCjOVyHn/cNCVrGEOUm4LfHQnS/28aWAYmZjm ZHrAlXVUgjMhx9BVOtETWk/lREC4xni/xu8iq2llsxj63ZzbLlLRplC5BI3tgaYR0jIZBx UMCvVK7AVJzq+xZdjKLhA8PhRRkOe93bjqZbaQdjNbUEzQ64f6h4EjZj0MgFePPaizJge5 aglyqQxfDPa6v16WtnzDESjQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 51025f1a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 1 Nov 2023 11:20:49 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83fs1q9moq.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 01 Nov 2023 05:28:37 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> Date: Wed, 01 Nov 2023 11:20:47 +0100 Message-ID: <87wmv1g4g0.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > It's on my todo, waiting for possible comments by others. No need to > ping me yet, since you posted your final version just a few days ago. Alright and sorry for this. What would be a good ping delay? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 08:16:38 2023 Received: (at 66697) by debbugs.gnu.org; 1 Nov 2023 12:16:38 +0000 Received: from localhost ([127.0.0.1]:50100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyA9G-000664-EQ for submit@debbugs.gnu.org; Wed, 01 Nov 2023 08:16:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyA9D-00065f-Kj for 66697@debbugs.gnu.org; Wed, 01 Nov 2023 08:16:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qyA8Z-0008Mm-CW; Wed, 01 Nov 2023 08:15:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n616F8zLDf/3nCY5ALe+hgNscCX32T7xQ8ZJgjg2gNo=; b=nsINLOsEm1VO lqupRLbfG7HE+QVvxAH4iHSVnDuQ9eCN+CBkWOJ1jxZlaI8QYBpQxOM+JcadGlxDdyPp3ZRIdG5aX dgXLCrWtdn8R5bgYovyC+CQXakHzlkroe/pP1NEKQxWlYFoCOWOSR76SGzyJ9/afbm44zzBQjRkuS zESVYxOjSLYObXrD59dN3E9wpXllM+KWQF7HGxEXEEOs96A8H5SdBZuFvk3fqqMU9jrte5PyZemWG otqhzWIfcinTesDAg7ISlMV1w9wz6ct1ERa3M6xWbX4kEtWKqtpfyf4k8CtpJC01C4BKJXtDyubkS 7pcHZmTYt9IaMHOqEM1H9A==; Date: Wed, 01 Nov 2023 14:15:45 +0200 Message-Id: <83a5rxacum.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87wmv1g4g0.fsf@ledu-giraud.fr> (message from Manuel Giraud on Wed, 01 Nov 2023 11:20:47 +0100) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org > Date: Wed, 01 Nov 2023 11:20:47 +0100 > > Eli Zaretskii writes: > > [...] > > > It's on my todo, waiting for possible comments by others. No need to > > ping me yet, since you posted your final version just a few days ago. > > Alright and sorry for this. What would be a good ping delay? After at least two weeks have passed, or thereabouts. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 04 04:06:39 2023 Received: (at 66697-done) by debbugs.gnu.org; 4 Nov 2023 08:06:39 +0000 Received: from localhost ([127.0.0.1]:60391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzBfy-000707-WC for submit@debbugs.gnu.org; Sat, 04 Nov 2023 04:06:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzBfx-0006zo-Cn for 66697-done@debbugs.gnu.org; Sat, 04 Nov 2023 04:06:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzBfH-0000pn-HA; Sat, 04 Nov 2023 04:05:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=89G88njmXFoprxQ4L3kbG9ALF18AVGseooYZT/91cv0=; b=G0C+q1FJAj1w okwQwtk6lwVNY6v0FtHcYvuBY0iG/xRlN1361xcD2aIW9gOFYOXiN9FlMiHdNDIjoJCszSnBEBY07 9DVhB/kSwd4/M1XMcQ8Z4uJvMKz6gw0hDy2V4hOor/OIDeQ72BnrtkFQKZnFSvvYc2sHdC74igUJJ bGugrPwlYP3qVQP5Txct7o4bC7U3jPdxjgVqaUrWWtybi1hoddGiv7nLHWO4mH2rK/EuWs7ZB0I3I ny3G2Wm/YkH7F/jEv1ueQsXCPTXxa+P+CgdRa7fWMcSU5mMa+9FmX+UMt0+Fp/T2fRCa0mmgerQNy IoGI0s4MGwspnewC1lWUlQ==; Date: Sat, 04 Nov 2023 10:05:52 +0200 Message-Id: <83msvu54f3.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87zg0888g8.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 24 Oct 2023 15:18:47 +0200) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697-done Cc: 66697-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org > Date: Tue, 24 Oct 2023 15:18:47 +0200 > > Eli Zaretskii writes: > > [...] > > > Sounds right, but don't you get byte-compiler warnings about > > desktop-files-not-to-save not being known? > > I did not get a warning about desktop-files-not-to-save but I get one > about shadowing dired-directory. So I fixed the patch with this new > one. Thanks, installed on master, and closing the bug. From unknown Sun Jun 22 00:01:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Dec 2023 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 09:30:10 2023 Received: (at control) by debbugs.gnu.org; 8 Dec 2023 14:30:11 +0000 Received: from localhost ([127.0.0.1]:44238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBbrm-00055J-FG for submit@debbugs.gnu.org; Fri, 08 Dec 2023 09:30:10 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:4942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBbrj-000553-GC for control@debbugs.gnu.org; Fri, 08 Dec 2023 09:30:08 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=KjBWnP0I d32xBqeGGCC6R8YnrDfw+emYHNkuEPSNzj4=; h=date:subject:to:from; d=ledu-giraud.fr; b=yIb7EhQ/j8JKr32kwhM9DKcPBslwlTdSfiUWVCLHpUQ7QTgcn6 GdqqMf6t/PhqcEhEmOzdzxtcWeVjBGupF2AQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=KjBWnP0Id32xBqeG GCC6R8YnrDfw+emYHNkuEPSNzj4=; h=date:subject:to:from; d=ledu-giraud.fr; b=OF/dO8EbJgnnsrNombRYJyqbTqsHYKm0pPkQggKrG3STQdcthw U+hxQ7duB4KahdaQCBsLtWGqLOvMORDHaQ7fpf8JREBceNzVGYM4PIENaAB0LUHCkKszaK WEejwVFLDn2qs0/SpYvwtmap0tXlrFXgOpS3Rju5wDtPQgUfhKDxnCMmKxTAxDaedHHR3u aSYYv2Zn58+zs2a4/PEW9tyqVjZLXbUAOumpih/Fv218cm1xXoF8T86QIqantx6T+v7foX EjQiLgFn0m2CYIi+ijVxDRnDUR/We35Fv8QSuzw1qSbShzjCk4bu3/V0boizDYFHu+6mQf YizpVgXQNGIA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id dcbdea5c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 8 Dec 2023 15:29:53 +0100 (CET) From: Manuel Giraud To: control@debbugs.gnu.org Subject: unarchive 66697 Date: Fri, 08 Dec 2023 15:29:52 +0100 Message-ID: <87bkb0sr6n.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 66697 -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 08 11:02:54 2023 Received: (at 66697) by debbugs.gnu.org; 8 Dec 2023 16:02:54 +0000 Received: from localhost ([127.0.0.1]:45823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBdJW-00044T-4R for submit@debbugs.gnu.org; Fri, 08 Dec 2023 11:02:54 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:43150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBdJU-00044E-1L for 66697@debbugs.gnu.org; Fri, 08 Dec 2023 11:02:52 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3333a3a599fso1795367f8f.0 for <66697@debbugs.gnu.org>; Fri, 08 Dec 2023 08:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702051353; x=1702656153; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=reIyOnkAFGHPWGP1Mu4/CX3XC1tusF+1/vGtDdN6dss=; b=TcRWMtmZhsN7wSfoDBJjyd6StRCwtZ28dajbclOyLiUKac08DLswGcb2uoWj5XSCYj 5SJwtx0MCWgDwlAcPW5g1NQZjnlfRpAt8HnlicwEc3UDwZWPN5M92XzAvL+C2sXKtl59 EHxoWujveaYsUGkrFcll+42AV3GckjUEd0wJj86J1GlvsCxUc8XArGudkG2yfiThADlg HIAtW8jcfF2W//7/dWIG+2tNH+spz4biJplFbdISTFRU42uBwqfQXJcO1gtMHixIUBeE WtV1h7QcIrIzsGPmKQYKqOj4yymk474zk+5nAlpPC2K5anF2TIUkZj7zgJE6cxZiAjni 8H9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702051353; x=1702656153; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=reIyOnkAFGHPWGP1Mu4/CX3XC1tusF+1/vGtDdN6dss=; b=uX1HQV+HNs9jaojjDHGaEPI/KLNv8VhwyfHABbv24i9cHzO2Vcf0oQxLVG0Z5A6d9q WxrpVidFihWRW8iEPiXq8FUm/qUinSI+vQOlt67KZdr2+TnqehAPXusesqvF6KMf0SYT Xajhfe2A8GHcVDzLocy6r9OD43lAVOu1AKPmmqxc4Qczm34JK6fJZAUHkjKbKDCR8oWx rN7eUI8DVMyZ0sgdkxhuUdN7uX7lLzEJl5jQXdT6neuvqFzIpKueVB+G104q1XrvH7/k S8L0gb2y1ZV5t06YYIbit+/+TRyGqQRWftcaWDFw8PEzpP+qVNzEfBckQdbJe6yHRpKM c4Tw== X-Gm-Message-State: AOJu0YwSaDlfHj9k34CB+LwkmwGUBbluxFLg2g/zXJCJowMbgj2dxSwj ENiPovM23172Lx5xZSS/62c/aSjfBy/rxQ== X-Google-Smtp-Source: AGHT+IEIK67hFStPKmkLj2W2hWK8AfhojIEnQ/WH6hlV98Suk8WYv36iEsDS1lusGig2+UE/kJv9pA== X-Received: by 2002:adf:ed05:0:b0:333:949:9544 with SMTP id a5-20020adfed05000000b0033309499544mr186146wro.16.1702051352814; Fri, 08 Dec 2023 08:02:32 -0800 (PST) Received: from [192.168.0.3] (82-69-64-228.dsl.in-addr.zen.co.uk. [82.69.64.228]) by smtp.gmail.com with ESMTPSA id v8-20020adfe4c8000000b003333eadd206sm2302706wrm.27.2023.12.08.08.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Dec 2023 08:02:32 -0800 (PST) Message-ID: <340c7b65-c04a-4f21-9e26-eff4b8445f3b@gmail.com> Date: Fri, 8 Dec 2023 16:02:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers To: Manuel Giraud , Eli Zaretskii References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> Content-Language: en-US From: Andy Moreton In-Reply-To: <87fs0csri9.fsf@ledu-giraud.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 08/12/2023 14:22, Manuel Giraud wrote: > Hi Andy, > > Could you try the attached patch to see if it fixes your issue? Thanks. Yes, that works. Thanks for the fix.     AndyM From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 05:06:52 2023 Received: (at 66697) by debbugs.gnu.org; 9 Dec 2023 10:06:53 +0000 Received: from localhost ([127.0.0.1]:46843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBuEW-0005Fk-H3 for submit@debbugs.gnu.org; Sat, 09 Dec 2023 05:06:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBuEU-0005FW-BZ for 66697@debbugs.gnu.org; Sat, 09 Dec 2023 05:06:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBuEA-00051b-F9; Sat, 09 Dec 2023 05:06:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JylDzxAK9B6bvZ9ZIdb4JveZIfZcrOFLTM/HA1oi3sY=; b=j05bZl45r8Cn nSTF255cFaCc++1lekTeVvOFnPBNYSlgAqN7DWaWbkfLiL0WeIO8qoSUsMcM1S1bR1GlHuwLpzkBi mPgyQEsRTYfRFw0uQuBmHC9iiIEq8Yq8cY0OBLwssSzRU/hZsLaOXUGDneS7Gqf9GUAv8GN/bHiat 7cgeKqLvrRoEc9JU1eT5h2At7fRKa69mDXsRpgm4uJxEDHqAmlw7CYbgQTEB9cb8D+QVVJ0Q/oeyW H8FJ9ob67PdguHfpeI2W+LEzwkH2Dkj7au218NdqXilS3tTbyPJIj5wXxorF0GvriKPOUmbH1fnr3 L5SFoddaOTPGm2Z/dGZZNg==; Date: Sat, 09 Dec 2023 12:06:13 +0200 Message-Id: <83edfvy9ka.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87fs0csri9.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 08 Dec 2023 15:22:54 +0100) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: andrewjmoreton@gmail.com, 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org, Andy Moreton > Date: Fri, 08 Dec 2023 15:22:54 +0100 > > Hi Andy, > > Could you try the attached patch to see if it fixes your issue? Thanks. > (defun dired-desktop-buffer-misc-data (dirname) > "Auxiliary information to be saved in desktop file." > - (when (and (stringp desktop-files-not-to-save) > - (dired-desktop-save-p)) > + (when (or (null desktop-files-not-to-save) > + (and (stringp desktop-files-not-to-save) > + (dired-desktop-save-p))) > (cons > ;; Value of `dired-directory'. > (if (consp dired-directory) Thanks, but I wonder whether a better way would be to modify dired-desktop-save-p such that it handled correctly non-string values of desktop-files-not-to-save? That would make the handling of this variable more local, which is better for maintenance, I think. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 07:05:46 2023 Received: (at 66697) by debbugs.gnu.org; 9 Dec 2023 12:05:46 +0000 Received: from localhost ([127.0.0.1]:46932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBw5a-00035H-6l for submit@debbugs.gnu.org; Sat, 09 Dec 2023 07:05:46 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:37238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBw5W-000357-UT for 66697@debbugs.gnu.org; Sat, 09 Dec 2023 07:05:44 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=2Cyt4yK6 KwH+E4uUJDeX/wEPbRM106GNqrZjaswThLM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=QrRC5CyKyGICVFqwExiEaAFz9YrT5V e4TaCk30tr+gQzktbS8XJrsQ9EaisLZeGdIflC1GnznKHlEGZhvplZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=2Cyt4yK6KwH+E4uU JDeX/wEPbRM106GNqrZjaswThLM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=AV5E4qL0K985d08uxRlSjkFpsb1lxD3pIWa5Vg QKQwKANDCF3KXWxY9NJ1MRkmYcAuDw06I/o0dotcULxWyvOaC6rHLfp9rTxZHItlOje1TY PiPP3RPAGnecG8Pncuz3OKfsxNL3j2de6xntpD97zVtkvpPz2Wr2A6lhzVlkJq+9EtAyeT 5uQpQhE6I+Jn6MDYU7njya0B8XvibdcxljOlGRcfDmaQ6cc6wdYajvtMwT1enliRVlZh0a CH2WLjKmBJkXY1HUGpPElHsLrwsotZO3g6rR6gCCOofGvqRRuhPidBzE5/U8iO+PD24A9M 3JadH8GMe5FQR8eO9M6/PhsQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 91035507 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 9 Dec 2023 13:05:27 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers In-Reply-To: <83edfvy9ka.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Dec 2023 12:06:13 +0200") References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> <83edfvy9ka.fsf@gnu.org> Date: Sat, 09 Dec 2023 13:05:24 +0100 Message-ID: <877clneg3f.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: andrewjmoreton@gmail.com, 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Thanks, but I wonder whether a better way would be to modify > dired-desktop-save-p such that it handled correctly non-string values > of desktop-files-not-to-save? That would make the handling of this > variable more local, which is better for maintenance, I think. > > WDYT? Sure. Good idea. Here is a new version. -- Manuel Giraud --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-desktop-save-for-dired-buffers-bug-66697.patch >From b421faf27c38d7ce8d3c4f39df68f21d2eccc735 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sat, 9 Dec 2023 13:02:19 +0100 Subject: [PATCH] Fix desktop-save for dired buffers (bug#66697) * lisp/dired.el (dired-desktop-save-p): Move all logic here. Carry on when 'desktop-files-not-to-save' is nil. (dired-desktop-buffer-misc-data): Use it. --- lisp/dired.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lisp/dired.el b/lisp/dired.el index 7f4b96353ee..36ca54efc37 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -4989,14 +4989,15 @@ dired-dnd-handle-file (defun dired-desktop-save-p () "Should `dired-directory' be desktop saved?" - (if (consp dired-directory) - (not (string-match-p desktop-files-not-to-save (car dired-directory))) - (not (string-match-p desktop-files-not-to-save dired-directory)))) + (or (null desktop-files-not-to-save) + (and (stringp desktop-files-not-to-save) + (if (consp dired-directory) + (not (string-match-p desktop-files-not-to-save (car dired-directory))) + (not (string-match-p desktop-files-not-to-save dired-directory)))))) (defun dired-desktop-buffer-misc-data (dirname) "Auxiliary information to be saved in desktop file." - (when (and (stringp desktop-files-not-to-save) - (dired-desktop-save-p)) + (when (dired-desktop-save-p) (cons ;; Value of `dired-directory'. (if (consp dired-directory) -- 2.43.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 08:17:30 2023 Received: (at 66697) by debbugs.gnu.org; 9 Dec 2023 13:17:30 +0000 Received: from localhost ([127.0.0.1]:46979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBxD0-0007mF-0G for submit@debbugs.gnu.org; Sat, 09 Dec 2023 08:17:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBxCw-0007m0-4b for 66697@debbugs.gnu.org; Sat, 09 Dec 2023 08:17:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBxCc-0003UF-PY; Sat, 09 Dec 2023 08:17:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xodHtQtNZH/OL1LOyO6I2NEfPorienUGZbFbcwNi17k=; b=NiZ1v2I0jFPv gEd03pcCKM08+vBaLeVQYXykI/1cTQ7vlnsAyoTSQiRtdoRomObfkIQw5QsNHI1PhcnbzDIpXPJt1 03qM75prf0+9FiIOWoLRoDQlra8n435kfV5bhbx0FkuRcb7MJHPuF/yRw/qWAvZCQdz7o2BB6gybr JgW0SDgVc3I80ABMxbm+OrwMZPqV1luwfpwT0bVb6E73WhEvEcNCnPYmAfgNKXRJax9Cw+6zr11uT hWiCbkrZc+XKXkg8Yjiekvbo5Wp/Znb9lSDrajucO16GU50cnupSh2Npp3TmB+a+dC0AW+M7HG2IN LapYeHAMXGP9OPwfLt0P2w==; Date: Sat, 09 Dec 2023 15:16:50 +0200 Message-Id: <834jgry0ql.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <877clneg3f.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 09 Dec 2023 13:05:24 +0100) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> <83edfvy9ka.fsf@gnu.org> <877clneg3f.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697 Cc: andrewjmoreton@gmail.com, 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 66697@debbugs.gnu.org, andrewjmoreton@gmail.com > Date: Sat, 09 Dec 2023 13:05:24 +0100 > > Eli Zaretskii writes: > > [...] > > > Thanks, but I wonder whether a better way would be to modify > > dired-desktop-save-p such that it handled correctly non-string values > > of desktop-files-not-to-save? That would make the handling of this > > variable more local, which is better for maintenance, I think. > > > > WDYT? > > Sure. Good idea. Here is a new version. Thanks, installed. Andy, please test. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 10:25:18 2023 Received: (at 66697) by debbugs.gnu.org; 9 Dec 2023 15:25:18 +0000 Received: from localhost ([127.0.0.1]:48761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzCf-0005rT-Px for submit@debbugs.gnu.org; Sat, 09 Dec 2023 10:25:18 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:42441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzCe-0005rC-31 for 66697@debbugs.gnu.org; Sat, 09 Dec 2023 10:25:16 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3334254cfa3so1688420f8f.1 for <66697@debbugs.gnu.org>; Sat, 09 Dec 2023 07:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702135496; x=1702740296; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NQ4UW1konx4tW0B/J8m0wj3+3wsq/yvIvt8kMRKoDmM=; b=AESwY2leuY0veOZvoXGOTlcAUwmgiJcFC5s8eZuAsNP2rGBsiXKgwoEe2myAmd8jp/ UBYHG5I6bOz7/k8o4ySXNvFBOhxtY7fhMJhyGJy6Fq8gkuebNFBIe7GUOFICnT6au4ap 5HaujtuHO9lkOhen4sBCYuDc3XonzOlffDf9qwioouYHdyLLZB6v0uLqIq+MXmXDRwcI FAhMZNTDqKk2UE9Dp9eKUJOE9JseZmWiyK+OUXGzpYAHDRilckRiq5GR9DU0sRWNI2rX SdFYhDPK0uk7ayHUIOM7aPO4Kn0t9Ggxwkj7MvLyWCzi2rxqiXjk0Gk6qGJZxoxCAPUx qcYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702135496; x=1702740296; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NQ4UW1konx4tW0B/J8m0wj3+3wsq/yvIvt8kMRKoDmM=; b=TlVzebOJDOXmUaiy4VBQmw8COe+pACjMACy5y7kFD0Ey7CBzHgW/3kR5iE+NfL87AJ LTyR4CuC/Uq55HNGh6xU7R4suJ3XbRLk+qrT1Mcw2hurUNJi3dtlVRlhjCVuQKIL8nAs tgdNuzBZEMFMZRBZzbx8kYcWP9EP6zPWNSH9UbKdVbKIfkGnhml97OOXge0xt6FJwYun X34bp3+edM5NuPJAVa3pStakC6GEpLncBTHvxxyUsulDE+t+4bomdt9Q8hm92yLZ/sqq KSSAFI1ixeF821jPkdjz2a798Xf7anoJW/eesJhqNqRjzTbA97NP/+hDU6QokLdHQkBw RrEA== X-Gm-Message-State: AOJu0Yx8K4z/6F4o4TsV+FMwFtJYfUhMl6x3H36k0LnQPXYQrrsEts1M BtlBqnkus7rQdW3R9Xb3Bg8= X-Google-Smtp-Source: AGHT+IEXBR+Qf4Zu2eXwG8keBMgAbUrVVjuK1vQH3xmT8afKqNtgCrI0aOY456wvfXwdAS/mgQuKzw== X-Received: by 2002:adf:e94e:0:b0:333:5428:c4b2 with SMTP id m14-20020adfe94e000000b003335428c4b2mr928759wrn.62.1702135496377; Sat, 09 Dec 2023 07:24:56 -0800 (PST) Received: from [192.168.0.3] (82-69-64-228.dsl.in-addr.zen.co.uk. [82.69.64.228]) by smtp.gmail.com with ESMTPSA id h14-20020a5d548e000000b003333fbb68c7sm4498278wrv.112.2023.12.09.07.24.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Dec 2023 07:24:55 -0800 (PST) Message-ID: Date: Sat, 9 Dec 2023 15:24:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers To: Eli Zaretskii , Manuel Giraud References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> <83edfvy9ka.fsf@gnu.org> <877clneg3f.fsf@ledu-giraud.fr> <834jgry0ql.fsf@gnu.org> Content-Language: en-US From: Andy Moreton In-Reply-To: <834jgry0ql.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66697 Cc: 66697@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 09/12/2023 13:16, Eli Zaretskii wrote: >> From: Manuel Giraud >> Cc: 66697@debbugs.gnu.org, andrewjmoreton@gmail.com >> Date: Sat, 09 Dec 2023 13:05:24 +0100 >> >> Eli Zaretskii writes: >> >> [...] >> >>> Thanks, but I wonder whether a better way would be to modify >>> dired-desktop-save-p such that it handled correctly non-string values >>> of desktop-files-not-to-save? That would make the handling of this >>> variable more local, which is better for maintenance, I think. >>> >>> WDYT? >> Sure. Good idea. Here is a new version. > Thanks, installed. > > Andy, please test. All good, and the new patch is a cleaner fix. Thanks,     AndyM From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 10:46:13 2023 Received: (at 66697-done) by debbugs.gnu.org; 9 Dec 2023 15:46:13 +0000 Received: from localhost ([127.0.0.1]:48775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzWv-0006Lf-5b for submit@debbugs.gnu.org; Sat, 09 Dec 2023 10:46:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBzWq-0006LO-2y for 66697-done@debbugs.gnu.org; Sat, 09 Dec 2023 10:46:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBzWW-0002gY-NM; Sat, 09 Dec 2023 10:45:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YOImXPMUeSvUNf4zAAkr+Kg4LE2KbaaJjjUSnZ29bJ4=; b=j4nXD3ODXFqZ VcH+8W4j38xzhX2swJuyfbg5s+ASOLOw1soG+1dCCJ8U6MTLGvkrHNvZJE5lS7oc7vNikyphqYlbD glmq0bLy+8LU2a0/PdMhRi/aPuFKkxAQ1lqalK+qYtJAYih88Hd0pLaxvCIi+U/rLLXxRT+YRAtir oLpCC/E2LKb27g//REFjV8gba4cvp02Lv9yHtiRTBAlaNKJ/c1TJOGLIqdIUNZgjRVH0BKqVOOtXI /mLJvy+ndEjLDNtrqaIYllmKBtxhlY+MUuI6KzhjQt0/R4dEcTd41nm4ArrNHCi69M95Ouh+VECER ZvmJRdDX5mUQJ3rSUALAug==; Date: Sat, 09 Dec 2023 17:45:33 +0200 Message-Id: <83wmtnwfaa.fsf@gnu.org> From: Eli Zaretskii To: Andy Moreton In-Reply-To: (message from Andy Moreton on Sat, 9 Dec 2023 15:24:54 +0000) Subject: Re: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> <87wmvc9y0e.fsf@ledu-giraud.fr> <831qdkmdxm.fsf@gnu.org> <87zg0888g8.fsf@ledu-giraud.fr> <87cywusded.fsf@ledu-giraud.fr> <83fs1q9moq.fsf@gnu.org> <87wmv1g4g0.fsf@ledu-giraud.fr> <83a5rxacum.fsf@gnu.org> <87fs0csri9.fsf@ledu-giraud.fr> <83edfvy9ka.fsf@gnu.org> <877clneg3f.fsf@ledu-giraud.fr> <834jgry0ql.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66697-done Cc: manuel@ledu-giraud.fr, 66697-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 9 Dec 2023 15:24:54 +0000 > Cc: 66697@debbugs.gnu.org > From: Andy Moreton > > On 09/12/2023 13:16, Eli Zaretskii wrote: > >> From: Manuel Giraud > >> Cc: 66697@debbugs.gnu.org, andrewjmoreton@gmail.com > >> Date: Sat, 09 Dec 2023 13:05:24 +0100 > >> > >> Eli Zaretskii writes: > >> > >> [...] > >> > >>> Thanks, but I wonder whether a better way would be to modify > >>> dired-desktop-save-p such that it handled correctly non-string values > >>> of desktop-files-not-to-save? That would make the handling of this > >>> variable more local, which is better for maintenance, I think. > >>> > >>> WDYT? > >> Sure. Good idea. Here is a new version. > > Thanks, installed. > > > > Andy, please test. > > All good, and the new patch is a cleaner fix. Thanks, closing. From unknown Sun Jun 22 00:01:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Jan 2024 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator