From unknown Sun Jun 22 07:31:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66686 <66686@debbugs.gnu.org> To: bug#66686 <66686@debbugs.gnu.org> Subject: Status: 29.1.90; Bug in log-view-mode-menu Reply-To: bug#66686 <66686@debbugs.gnu.org> Date: Sun, 22 Jun 2025 14:31:04 +0000 retitle 66686 29.1.90; Bug in log-view-mode-menu reassign 66686 emacs submitter 66686 Juri Linkov severity 66686 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 13:51:01 2023 Received: (at submit) by debbugs.gnu.org; 22 Oct 2023 17:51:01 +0000 Received: from localhost ([127.0.0.1]:48038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qucbN-0003Vg-2D for submit@debbugs.gnu.org; Sun, 22 Oct 2023 13:51:01 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qucbI-0003VP-E5 for submit@debbugs.gnu.org; Sun, 22 Oct 2023 13:50:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qucaj-0006vU-OY for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:50:21 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qucah-0004vw-D4 for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:50:21 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id C6BD31C0002 for ; Sun, 22 Oct 2023 17:50:15 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 29.1.90; Bug in log-view-mode-menu Organization: LINKOV.NET Date: Sun, 22 Oct 2023 20:48:14 +0300 Message-ID: <86y1futuox.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Eli, is it ok to install this bug fix on the emacs-29 branch? It fails when using the context menu in a log-view buffer, but doesn't fail when using it on the main menu bar (maybe because it catches errors in the menu). --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=log-view-mode-menu.patch diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e6eb6a5b973..af24fcfd398 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -163,14 +163,14 @@ log-view-mode-menu :help "Go to the previous count'th log message"] ["Next File" log-view-file-next :help "Go to the next count'th file" - :active (derived-mode-p vc-cvs-log-view-mode - vc-rcs-log-view-mode - vc-sccs-log-view-mode)] + :active (derived-mode-p 'vc-cvs-log-view-mode + 'vc-rcs-log-view-mode + 'vc-sccs-log-view-mode)] ["Previous File" log-view-file-prev :help "Go to the previous count'th file" - :active (derived-mode-p vc-cvs-log-view-mode - vc-rcs-log-view-mode - vc-sccs-log-view-mode)])) + :active (derived-mode-p 'vc-cvs-log-view-mode + 'vc-rcs-log-view-mode + 'vc-sccs-log-view-mode)])) (defvar log-view-mode-hook nil "Hook run at the end of `log-view-mode'.") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 13:55:51 2023 Received: (at 66686) by debbugs.gnu.org; 22 Oct 2023 17:55:51 +0000 Received: from localhost ([127.0.0.1]:48044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qucg2-0003cv-OV for submit@debbugs.gnu.org; Sun, 22 Oct 2023 13:55:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qucg0-0003ci-Qc for 66686@debbugs.gnu.org; Sun, 22 Oct 2023 13:55:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qucfS-0005cK-4p; Sun, 22 Oct 2023 13:55:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hGfSSP6MGmEMykWI3Lb5TQkdL1Tu/p3TjgJOtgMh7TE=; b=HylSoHOTsN7n SjCmjFZHSibG8QzaV0obgD20x5iLeEwzdM6654/4YWQPyJqaP+a47+qepfpp0087CiQZ6DMZCe6Cy JxIR8UEpIrs0TM1ytV5XzUODdeyyfyBrdicvr1rbee8OG5muHuY1ruW68U/enYHhBoqzirDVDt2d+ IGupipGOano9iZDM5PI1BBsHP/QH58WLyBt331JyzEjxKix6mOwqblfjrHxK5aLRZteAOHHRIepBN G+kgEt+Z4d/W//kIuq3vWzhQVZaszTXNUe3X83z6Qz5VwsA9F54fSh25YeiwgMAbRutLRP5icc0l7 r+Jgwjg+mtlP4GsOK/FiZQ==; Date: Sun, 22 Oct 2023 20:55:07 +0300 Message-Id: <83a5sapmo4.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86y1futuox.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 22 Oct 2023 20:48:14 +0300) Subject: Re: bug#66686: 29.1.90; Bug in log-view-mode-menu References: <86y1futuox.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66686 Cc: 66686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Sun, 22 Oct 2023 20:48:14 +0300 > > Eli, is it ok to install this bug fix on the emacs-29 branch? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 14:01:39 2023 Received: (at 66686) by debbugs.gnu.org; 22 Oct 2023 18:01:39 +0000 Received: from localhost ([127.0.0.1]:48057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quclf-0006Mh-5i for submit@debbugs.gnu.org; Sun, 22 Oct 2023 14:01:39 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quclc-0006ML-Qq; Sun, 22 Oct 2023 14:01:37 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B2EB4E0004; Sun, 22 Oct 2023 18:01:01 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#66686: 29.1.90; Bug in log-view-mode-menu In-Reply-To: <83a5sapmo4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Oct 2023 20:55:07 +0300") Organization: LINKOV.NET References: <86y1futuox.fsf@mail.linkov.net> <83a5sapmo4.fsf@gnu.org> Date: Sun, 22 Oct 2023 20:59:56 +0300 Message-ID: <86il6ytu5f.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66686 Cc: 66686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 66686 29.1.90 quit >> Eli, is it ok to install this bug fix on the emacs-29 branch? > > Yes, thanks. Ok, pushed. From unknown Sun Jun 22 07:31:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Nov 2023 12:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator