GNU bug report logs - #66686
29.1.90; Bug in log-view-mode-menu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66686 in the body.
You can then email your comments to 66686 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1.90; Bug in log-view-mode-menu
Date: Sun, 22 Oct 2023 20:48:14 +0300

[Message part 1 (text/plain, inline)]

Eli, is it ok to install this bug fix on the emacs-29 branch?

It fails when using the context menu in a log-view buffer,
but doesn't fail when using it on the main menu bar
(maybe because it catches errors in the menu).

[log-view-mode-menu.patch (text/x-diff, inline)]

diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index e6eb6a5b973..af24fcfd398 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -163,14 +163,14 @@ log-view-mode-menu
      :help "Go to the previous count'th log message"]
     ["Next File"  log-view-file-next
      :help "Go to the next count'th file"
-     :active (derived-mode-p vc-cvs-log-view-mode
-                             vc-rcs-log-view-mode
-                             vc-sccs-log-view-mode)]
+     :active (derived-mode-p 'vc-cvs-log-view-mode
+                             'vc-rcs-log-view-mode
+                             'vc-sccs-log-view-mode)]
     ["Previous File"  log-view-file-prev
      :help "Go to the previous count'th file"
-     :active (derived-mode-p vc-cvs-log-view-mode
-                             vc-rcs-log-view-mode
-                             vc-sccs-log-view-mode)]))
+     :active (derived-mode-p 'vc-cvs-log-view-mode
+                             'vc-rcs-log-view-mode
+                             'vc-sccs-log-view-mode)]))
 
 (defvar log-view-mode-hook nil
   "Hook run at the end of `log-view-mode'.")

Message #8 received at 66686 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 66686 <at> debbugs.gnu.org
Subject: Re: bug#66686: 29.1.90; Bug in log-view-mode-menu
Date: Sun, 22 Oct 2023 20:55:07 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Date: Sun, 22 Oct 2023 20:48:14 +0300
> 
> Eli, is it ok to install this bug fix on the emacs-29 branch?

Yes, thanks.

Message #11 received at 66686 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66686 <at> debbugs.gnu.org
Subject: Re: bug#66686: 29.1.90; Bug in log-view-mode-menu
Date: Sun, 22 Oct 2023 20:59:56 +0300

close 66686 29.1.90
quit

>> Eli, is it ok to install this bug fix on the emacs-29 branch?
>
> Yes, thanks.

Ok, pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.