GNU bug report logs - #66676
29.1; Should some aspects of shr rendering be configurable

Previous Next

Package: emacs;

Reported by: Rahguzar <rahguzar <at> zohomail.eu>

Date: Sun, 22 Oct 2023 08:12:02 UTC

Severity: wishlist

Found in version 29.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Rahguzar <rahguzar <at> zohomail.eu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 66676 <at> debbugs.gnu.org
Subject: bug#66676: 29.1; Should some aspects of shr rendering be configurable
Date: Sat, 04 Nov 2023 10:06:54 +0100

Please note that there is bug in `shr--inline-image-p` defined in one of
the patches. Fixing it amounts too:

       (unless (integerp max-width)
 	(setq max-width (* max-width (window-width nil t))))
       (unless (integerp max-height)
-	(setq max-width (* max-width (frame-char-height))))
+	(setq max-height (* max-height (frame-char-height))))
       (and (< (car size) max-width)
-	   (< (cdr size) max-width)))))
+	   (< (cdr size) max-height)))))

I will add it to the next revision of the patch along with any other
changes due to feedback.

Thanks,
Rahguzar
This bug report was last modified 1 year and 259 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.