From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 23:10:14 2023 Received: (at submit) by debbugs.gnu.org; 22 Oct 2023 03:10:15 +0000 Received: from localhost ([127.0.0.1]:45265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quOr0-0004eq-7D for submit@debbugs.gnu.org; Sat, 21 Oct 2023 23:10:14 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quOqv-0004eY-AK for submit@debbugs.gnu.org; Sat, 21 Oct 2023 23:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quOqN-0007LA-GH for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 23:09:35 -0400 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quOqL-0002gJ-PT for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 23:09:35 -0400 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1e59894d105so1546790fac.1 for ; Sat, 21 Oct 2023 20:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697944172; x=1698548972; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Ob4taD5V0o1lE1eD+lsBSCtQCjh9RnxuUb/Rd2V3oP8=; b=JVYk3+NgrCY+JarKzefv6cXdLtBOhTvg2yGKBpHtrXiKkdTk/IE9wQeCftpBrAFXmd boJOLvO2ZSzMaDb0xXyh/KOQOOWVwxWubZdnivMb70+k95hZMWk/bk2eSoL4gebu5/EV oFEbYqRSBGvOmr7SOtOqmKh1hNrxqTwUvh3zbeIkl21ndUxzVmooM/U5Sz1p+ahcJdXX ww86lV4xoENzQJ/208yZQDzsnHbmySam+3vCUwNa/jZgvkBjr6uxCIAeidl+F7o6+q6Y QKja/JaDVUkiZz4NBPsVEIc2zg+yeN4YmClHTdF9riAnD6wlLZkNogV0oT0DmM340I3o OuDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697944172; x=1698548972; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ob4taD5V0o1lE1eD+lsBSCtQCjh9RnxuUb/Rd2V3oP8=; b=RNjnPARUUmXap+geoO+px5rVBiyzzOlYSIeo8Abe+nZ3jM7yVu/KuZWiudfFUGT4Ba vosRditlN+cz5IKnaFNiYtfNjj7IMcMhaMZhs9na5+5I2sCJKyldRH0gCtp+Kfue4yF4 vay4NV6qnsfyVXnipm67JElEzylW8cFKSJjDhqzfGphatFI4kdNQvGo6nEzwZA2JQzmt sZ21S22cLEiTlAocLdAezviNGA1ZacsCimfN9i1W4le0cLAM/1EAiR2oOjocbYhtGSRi 85csiUKo89l8zwN96QYU6wBmOdrUhTiB51DDTyllpjENtDYWM9C4Hw3LX+eR/gZM7+f/ jyWQ== X-Gm-Message-State: AOJu0Yzt8wICrfERCC+Urlj+qODHENXqDrbLxWwbyQHoVOFWrWVB3Uod n4kDNbLjBD4glqTfPMMItzIojth4CGN9qlt/OmG9oswMmd711sUS X-Google-Smtp-Source: AGHT+IEaVlO4ZY97mldtko2wgqHmy+pH83oTzRjidldix1m0s3me1lSMoV1tNoVjBb0I9n1qCQ6dDuMfG+m+WZh6j8w= X-Received: by 2002:a05:6870:a108:b0:1b0:2f63:4ff6 with SMTP id m8-20020a056870a10800b001b02f634ff6mr7324772oae.1.1697944172293; Sat, 21 Oct 2023 20:09:32 -0700 (PDT) MIME-Version: 1.0 From: nvp Date: Sat, 21 Oct 2023 20:09:21 -0700 Message-ID: Subject: [PATCH] Fix treesit-install-language-grammar recipe addition To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000003d03560608456f0e" Received-SPF: pass client-ip=2001:4860:4864:20::2c; envelope-from=noah.v.peart@gmail.com; helo=mail-oa1-x2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000003d03560608456f0e Content-Type: multipart/alternative; boundary="0000000000003d03550608456f0c" --0000000000003d03550608456f0c Content-Type: text/plain; charset="UTF-8" Tags: patch * lisp/treesit.el (treesit-install-language-grammar): fix recipe addition to `treesit-language-source-alist` Bug: `treesit-install-language-grammar` adds repeated language entry to `treesit-language-source-alist` causing circular list. Recipe to reproduce: 1. `M-x treesit-install-language-grammar` `bash` (enter all defaults) 2. `M-x treesit-install-language-grammar` `bash` In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-10-21 built on noah-X580VD Repository revision: 6f87ee0e3a0727e16079778a4264e6e35cd7f3a8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --0000000000003d03550608456f0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch


* lisp/treesit.el (= treesit-install-language-grammar): fix recipe
addition to `treesit-langu= age-source-alist`

Bug: `treesit-install-language-grammar` adds repea= ted language
entry to `treesit-language-source-alist` causing circular l= ist.

Recipe to reproduce:
1. `M-x treesit-install-language-gramma= r` `bash` (enter all defaults)
2. `M-x treesit-install-language-grammar`= `bash`

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Ver= sion
3.24.33, cairo version 1.16.0) of 2023-10-21 built on noah-X580VDRepository revision: 6f87ee0e3a0727e16079778a4264e6e35cd7f3a8
Reposito= ry branch: master
Windowing system distributor 'The X.Org Foundation= ', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS
<= br>Configured using:
=C2=A0'configure --prefix=3D/usr/local --with-m= odules --with-tree-sitter
--with-threads --with-x-toolkit=3Dgtk3 --with-= xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-p= ng --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC= =3Dgcc-12
CXX=3Dgcc-12'
--0000000000003d03550608456f0c-- --0000000000003d03560608456f0e Content-Type: text/x-patch; charset="US-ASCII"; name="fix-treesit-install.patch" Content-Disposition: attachment; filename="fix-treesit-install.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lo0w3eqt0 RnJvbSA5OTY4YWI0YzIyM2UxZjY1YWI2OTg0NTQzY2I2M2QzYzlkNjI4NjBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IFNhdCwgMjEgT2N0IDIwMjMgMTk6NTQ6MTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXggdHJl ZXNpdC1pbnN0YWxsLWxhbmd1YWdlLWdyYW1tYXIgcmVjaXBlIGFkZGl0aW9uCgotLS0KIGxpc3Av dHJlZXNpdC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdHJlZXNpdC5lbCBiL2xpc3AvdHJlZXNpdC5lbApp bmRleCA4MGJkZjE2NGIwNy4uODEwMGU0MTgzMDMgMTAwNjQ0Ci0tLSBhL2xpc3AvdHJlZXNpdC5l bAorKysgYi9saXNwL3RyZWVzaXQuZWwKQEAgLTMzNTQsNyArMzM1NCw3IEBAIHRyZWVzaXQtaW5z dGFsbC1sYW5ndWFnZS1ncmFtbWFyCiAgICAgICAgICAgICAgICAgICAgICAgICAgICIgIikpKQog ICAgICAgICAgICAgICA7OyBJZiBzdWNjZXNzLCBTYXZlIHRoZSByZWNpcGUgZm9yIHRoZSBjdXJy ZW50IHNlc3Npb24uCiAgICAgICAgICAgICAgIChzZXRmIChhbGlzdC1nZXQgbGFuZyB0cmVlc2l0 LWxhbmd1YWdlLXNvdXJjZS1hbGlzdCkKLSAgICAgICAgICAgICAgICAgICAgcmVjaXBlKSkpKQor ICAgICAgICAgICAgICAgICAgICAoY2RyIHJlY2lwZSkpKSkpCiAgICAgICAoZXJyb3IKICAgICAg ICAoZGlzcGxheS13YXJuaW5nCiAgICAgICAgICd0cmVlc2l0Ci0tIAoyLjM0LjEKCg== --0000000000003d03560608456f0e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 23:41:42 2023 Received: (at 66673-done) by debbugs.gnu.org; 22 Oct 2023 03:41:42 +0000 Received: from localhost ([127.0.0.1]:45288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quPLR-0005ed-NI for submit@debbugs.gnu.org; Sat, 21 Oct 2023 23:41:42 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:42194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quPLQ-0005e2-3S for 66673-done@debbugs.gnu.org; Sat, 21 Oct 2023 23:41:40 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1c9e95aa02dso15770325ad.0 for <66673-done@debbugs.gnu.org>; Sat, 21 Oct 2023 20:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697946066; x=1698550866; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YLXuDoLWrT6wdSW9zRhiyhb8yfvGsrbEFfq9syUqmHc=; b=GmvI/FUEuiwY91fGNryV0CEvblNrWdydmg5dMOrIOjJeHgaN9cutmQK8FHXaU+3PEy v87bG1IfO/1CVgfGZlCiOLbkZgZ4ZUQNzqmND5pLCM8bMxh6bi+EnVzuaalBzHcbBvX7 OBVTdPO/xroAhYSHHzdGmxD/oF0gNw+xs5cv0Me+sQeVZLtFELc9ATU3lIN9u/g8CQsm cl4FABXLyiqwSdPAP42z/VFvoy0DD1mwVuv61r1ZT1Vd7FthQnW74q4YtRI175o6LsN1 AR6hfCcquRVHqX+2rwoSNep0WvW0hdHbE8amB4+uHsPtTZEd/exTwRxxxzN0RBa3ZDop OOTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697946066; x=1698550866; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YLXuDoLWrT6wdSW9zRhiyhb8yfvGsrbEFfq9syUqmHc=; b=TR+rcC4psgDMkOXROpEdWLalbTM3FIHdQkX2NoQijct/NkM0OyDADJig9vJqRuoVqH gAqyV7802Lp3AvjQ+RShVNndfg9rjjlqTuGsbMYBnEF9MuMleaJoIYvn1lsQ/qhu75iI MPTXXKJbUWQqwsj8Pi34zRUaBfAT6oCFZlUP8ze8uPDS4CUa1jlL3jxiOJ4ItEE9gOqZ d0c5DJ6E3XDCfpxkXC4aazR20+xAsmDzUC5hmYU0LKgXB1t3gJmCjAfQZhunWbYfqkN8 WQ4JPSt60tBGPj2BMrZl5vytd1LayjWsjUXNik2Zv1RHL689WsjgnOpogYhaf8D9d1US ISqg== X-Gm-Message-State: AOJu0Yy3rLxfpT1644WaD21NqBcSu/Eofde2ZSRCbUkRBf1M3UKIELyY AAxSwVrNwPQRxoqDfMDPMXE= X-Google-Smtp-Source: AGHT+IEsAaV6+Ci7xp10ygWY/v1Zcn/n0aRkFO4/l7fFrufH/cgOLE/VqQvwZmLvb2LZDv0vJmWbGQ== X-Received: by 2002:a17:902:d4c6:b0:1ca:71:ea41 with SMTP id o6-20020a170902d4c600b001ca0071ea41mr13109017plg.22.1697946063911; Sat, 21 Oct 2023 20:41:03 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z16-20020a170903019000b001c60635c13esm3791250plg.115.2023.10.21.20.41.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Oct 2023 20:41:03 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#66673: [PATCH] Fix treesit-install-language-grammar recipe addition From: Yuan Fu In-Reply-To: Date: Sat, 21 Oct 2023 20:40:52 -0700 Content-Transfer-Encoding: 7bit Message-Id: References: To: nvp X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66673-done Cc: 66673-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 21, 2023, at 8:09 PM, nvp wrote: > > > > * lisp/treesit.el (treesit-install-language-grammar): fix recipe > addition to `treesit-language-source-alist` > > Bug: `treesit-install-language-grammar` adds repeated language > entry to `treesit-language-source-alist` causing circular list. Thank you! I applied the path on emacs-29. Yuan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 01:15:43 2023 Received: (at 66673) by debbugs.gnu.org; 22 Oct 2023 05:15:43 +0000 Received: from localhost ([127.0.0.1]:45367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quQoR-0000Pt-4D for submit@debbugs.gnu.org; Sun, 22 Oct 2023 01:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quQoL-0000PZ-IF for 66673@debbugs.gnu.org; Sun, 22 Oct 2023 01:15:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quQno-00080u-1t; Sun, 22 Oct 2023 01:15:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XiftXF3XjIb+mGeSH40WVAVlf6uaYnNFuIOKYHn/Cbw=; b=M2eNifxBmu4v ZFPG9U1s6jYpYdMO8kxqsjzp1vgNBMGQfZcJHIXwp7NgvuuqDl5e9I1agOLGhOu82dan4/2LWhHx0 FioizoTRMKHa/oWLq6s4+Ute90U3lw/WNfZDe66CrekMYa9wZr4Jao0ttYqeWRADIaBt3XDzXvUZJ s+2Wfa+/XmGyKSoAPn7hVKYcfOlhTkDCpu8kThXkEj6PnRBccxmbnxB60+P44bcFwW5HzAghPhIjH Ira2xG/92NieaD1ZdS2tImeweAmt9mke+FxC8XvpPB4dkifcCLhl3vfoEqI8XyTgVs10tVr6wiGYD gATDAmhnG4x1GE6yeXvBDg==; Date: Sun, 22 Oct 2023 08:15:02 +0300 Message-Id: <83zg0bp7ah.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Sat, 21 Oct 2023 20:40:52 -0700) Subject: Re: bug#66673: [PATCH] Fix treesit-install-language-grammar recipe addition References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66673 Cc: noah.v.peart@gmail.com, 66673@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-To: bug-gnu-emacs@gnu.org > Cc: 66673-done@debbugs.gnu.org > From: Yuan Fu > Date: Sat, 21 Oct 2023 20:40:52 -0700 > > > > > On Oct 21, 2023, at 8:09 PM, nvp wrote: > > > > > > > > * lisp/treesit.el (treesit-install-language-grammar): fix recipe > > addition to `treesit-language-source-alist` > > > > Bug: `treesit-install-language-grammar` adds repeated language > > entry to `treesit-language-source-alist` causing circular list. > > Thank you! I applied the path on emacs-29. Thanks. Yuan, if we are fixing treesit-install-language-grammar, I think it lacks the "-ltree-sitter" command-line option for the link command. At least on MS-Windows, this is required, as the link command will fail if we don't supply that option: the linker _must_ scan the tree-sitter library when generating the shared library for the grammar. From unknown Fri Sep 05 20:55:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Nov 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator