GNU bug report logs - #66668
[PATCH] Teach ffap to look for paths under the root of project

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66668: closed ([PATCH] Teach ffap to look for paths under the
 root of project)
Date: Mon, 30 Oct 2023 01:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 30 Oct 2023 02:59:28 +0200
with message-id <c73a4fdb-0b8f-3400-031b-03d4d9fe8d8e <at> gutov.dev>
and subject line Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project
has caused the debbugs.gnu.org bug report #66668,
regarding [PATCH] Teach ffap to look for paths under the root of project
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66668: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66668
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Dmitry Gutov <dmitry <at> gutov.dev>
Subject: [PATCH] Teach ffap to look for paths under the root of project
Date: Sat, 21 Oct 2023 14:37:45 -0400

[Message part 3 (text/plain, inline)]

Tags: patch


This is a nice little quality of life feature.

In GNU Emacs 29.1.50 (build 12, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-10-19 built on
 igm-qws-u22796a
Repository revision: 9163e634e296435aa7a78bc6b77b4ee90666d2ac
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.8 (Green Obsidian)

Configured using:
 'configure --config-cache --with-x-toolkit=lucid
 --with-gif=ifavailable'

[0001-Teach-ffap-to-look-for-paths-under-the-root-of-proje.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: sbaugh <at> janestreet.com, 66668-done <at> debbugs.gnu.org
Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of
 project
Date: Mon, 30 Oct 2023 02:59:28 +0200

Version: 30.1

On 29/10/2023 14:56, Eli Zaretskii wrote:
>> Date: Sun, 29 Oct 2023 14:43:32 +0200
>> Cc: 66668 <at> debbugs.gnu.org
>> From: Dmitry Gutov <dmitry <at> gutov.dev>
>>
>> On 29/10/2023 14:23, Eli Zaretskii wrote:
>>>> From: Spencer Baugh<sbaugh <at> janestreet.com>
>>>> Cc:dmitry <at> gutov.dev,66668 <at> debbugs.gnu.org
>>>> Date: Wed, 25 Oct 2023 11:08:12 -0400
>>>>
>>>> Eli Zaretskii<eliz <at> gnu.org>  writes:
>>>>>> Cc: Dmitry Gutov<dmitry <at> gutov.dev>
>>>>>> From: Spencer Baugh<sbaugh <at> janestreet.com>
>>>>>> Date: Sat, 21 Oct 2023 14:37:45 -0400
>>>>>>
>>>>>> Subject: [PATCH] Teach ffap to look for paths under the root of project
>>>>> Please don't use "path" when you mean "file name".  The GNU Coding
>>>>> Standards frown on such uses of "path".
>>>> Oops, fixed.
>>>>
>>>> (Also fixed a byte-compiler warning from not declaring project-root)
>>> Dmitry, any comments?
>>
>> If the way it works is useful for people (probably will be), I'm good
>> with it.
>>
>> Ideally, it possibly would check whether the file belongs to the
>> project-files fileset, but that's going to be slower, and thus probably
>> not worth the marginal improvement.
> 
> Then I guess we should install this?

Sure, installed.

Thanks, and closing!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.