From unknown Sun Aug 10 16:49:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66668 <66668@debbugs.gnu.org> To: bug#66668 <66668@debbugs.gnu.org> Subject: Status: [PATCH] Teach ffap to look for paths under the root of project Reply-To: bug#66668 <66668@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:49:52 +0000 retitle 66668 [PATCH] Teach ffap to look for paths under the root of project reassign 66668 emacs submitter 66668 Spencer Baugh severity 66668 wishlist tag 66668 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 14:38:33 2023 Received: (at submit) by debbugs.gnu.org; 21 Oct 2023 18:38:33 +0000 Received: from localhost ([127.0.0.1]:45031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quGrm-0007oL-2n for submit@debbugs.gnu.org; Sat, 21 Oct 2023 14:38:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quGrf-0007nx-Uq for submit@debbugs.gnu.org; Sat, 21 Oct 2023 14:38:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quGr6-0002DO-Kb for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 14:37:49 -0400 Received: from mxout6.mail.janestreet.com ([64.215.233.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quGr5-0006hs-0m for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 14:37:48 -0400 From: Spencer Baugh To: bug-gnu-emacs@gnu.org Subject: [PATCH] Teach ffap to look for paths under the root of project Date: Sat, 21 Oct 2023 14:37:45 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.215.233.21; envelope-from=sbaugh@janestreet.com; helo=mxout6.mail.janestreet.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch This is a nice little quality of life feature. In GNU Emacs 29.1.50 (build 12, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-10-19 built on igm-qws-u22796a Repository revision: 9163e634e296435aa7a78bc6b77b4ee90666d2ac Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Rocky Linux 8.8 (Green Obsidian) Configured using: 'configure --config-cache --with-x-toolkit=lucid --with-gif=ifavailable' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Teach-ffap-to-look-for-paths-under-the-root-of-proje.patch >From 521116073821c5259130c415640265cb25c03ef3 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sat, 21 Oct 2023 14:35:53 -0400 Subject: [PATCH] Teach ffap to look for paths under the root of project Now file-name-at-point-functions, which runs ffap-guess-file-name-at-point, will pick up on a file name at point if that file name is a path starting from the root of the project. For example, in test/lisp/progmodes/eglot-tests.el there is the string lisp/progmodes/eglot.el; if you put point on that and C-x C-f, lisp/progmodes/eglot.el under the root of the Emacs repo will now be part of future history. * lisp/ffap.el (ffap-alist): Add entry for ffap-in-project. (ffap-in-project): Add. --- lisp/ffap.el | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lisp/ffap.el b/lisp/ffap.el index 2c99f88d505..fe0aa16c22f 100644 --- a/lisp/ffap.el +++ b/lisp/ffap.el @@ -734,6 +734,7 @@ ffap-locate-file (defvar ffap-alist '( ("" . ffap-completable) ; completion, slow on some systems + ("" . ffap-in-project) ; maybe in the root of the project ("\\.info\\'" . ffap-info) ; gzip.info ("\\`info/" . ffap-info-2) ; info/emacs ("\\`[-[:lower:]]+\\'" . ffap-info-3) ; (emacs)Top [only in the parentheses] @@ -797,6 +798,10 @@ ffap-completable (cmp (file-name-completion (file-name-nondirectory name) dir))) (and cmp (concat dir cmp)))) +(defun ffap-in-project (name) + (when-let (project (project-current)) + (file-name-concat (project-root project) name))) + (defun ffap-home (name) (ffap-locate-file name t '("~"))) (defun ffap-info (name) -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 15:07:02 2023 Received: (at 66668) by debbugs.gnu.org; 21 Oct 2023 19:07:02 +0000 Received: from localhost ([127.0.0.1]:45068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quHJO-0000WE-26 for submit@debbugs.gnu.org; Sat, 21 Oct 2023 15:07:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quHJM-0000Vj-5l for 66668@debbugs.gnu.org; Sat, 21 Oct 2023 15:07:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quHIo-0003qw-MO; Sat, 21 Oct 2023 15:06:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+OYs0gfdjuduFinhOyOpUNkbrvSGerNIZO3cwR/YiI4=; b=GwyMpfWouZXv L+o+jxT3W0/bjMIKY+/fjXO2HTtZuyIdDIHPwdcrIbYeuZdch7DRKcp8cbILcEbhtF8q8NRQ+9QLi bLccFn0NJVBWdbC2SC5w5wVp+VntxTHMCiO7Jrn6kg0IqGDSn95Lj4J8JToZaQCanXlTO2iNWmhh2 9PnbnKYCuLARsSSPSCfaWUa+ybPmzlYbRK/EVktp/8rjEFWAouKjlyhHqvzDp6UIwPXlJ7ccFKPSc 45NRSHeF4yCC+PLH9s3n0vk+9WGt4L6X6W7BRs8By2okxUw7sixAwlyaq5qpDDH4QO8wslRQES9pr wVn+r4M0LOSIrphxFqOH0g==; Date: Sat, 21 Oct 2023 22:06:25 +0300 Message-Id: <838r7vre1a.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Sat, 21 Oct 2023 14:37:45 -0400) Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66668 Cc: dmitry@gutov.dev, 66668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Dmitry Gutov > From: Spencer Baugh > Date: Sat, 21 Oct 2023 14:37:45 -0400 > > Subject: [PATCH] Teach ffap to look for paths under the root of project Please don't use "path" when you mean "file name". The GNU Coding Standards frown on such uses of "path". From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 15:41:58 2023 Received: (at control) by debbugs.gnu.org; 22 Oct 2023 19:41:58 +0000 Received: from localhost ([127.0.0.1]:48143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queKk-0003g6-Hs for submit@debbugs.gnu.org; Sun, 22 Oct 2023 15:41:58 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:43080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queKh-0003fr-KD for control@debbugs.gnu.org; Sun, 22 Oct 2023 15:41:56 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c51f5a1ecdso41267181fa.0 for ; Sun, 22 Oct 2023 12:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698003681; x=1698608481; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=3K4vODVYCftakFAy3ORPkPQFYn3Z9/XInkXEVltcV+o=; b=f1GotX4ZxEKqAgZpfcdPi3bgO75O3oZqS9vnQPt1zm0h71LAHWMEDdNHndyiBtCVMe rJI0lnyd11G0vhqsNTU6xX/FOkf3NjHmyle1L9M73XaFWAS9ZP2eYUfHFnEvkPl3fCQp LhJ9LjzhoSSb6LhZV2P2/xzJtHBwdV+Yk1BghU4Rtfocj1fiyoCV5snwl5t6TFkhLnJN O8v8UMCKNaAZXHaCASeDHhxPfC1NBn2ZxU6IjDcY9JPCes+ARYyzj0v+wCNWn/z7ncQg D4J2V+x2UChcVrMY9BG9402mHkcQ48Fpqg+0n1pb+odyhAlesqsdcs+avlqPEYGyLeH5 A34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698003681; x=1698608481; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3K4vODVYCftakFAy3ORPkPQFYn3Z9/XInkXEVltcV+o=; b=tQL1y61oSuYypu+VvF53TXfrLOaQgltcE0CmmHsaJVtKxHbssSr+laFiEmYKkV7mh5 v4j9AtWmxkBLOvHGjKk11cWyt1pWGllVYYigWlhY9DhDFlpAxV15BKpPKkdWHE4E7FNY mMp0HjbDPc8OtZKAaL988I+QpU+YqQcvKiXuKqHIwh8uWuK75GexTpdUKtVaAVHVIv/M YwMjIgkiISNJr7VHPpV0C37KYPiqpX3wJABf/dmXWBFreMO7IM+BV1/PSMOP14PEMt4Q +W1SjVmYBHw2uAkQF8UJIk8ckXW2DsOxahNYfpm7UwuEUFr9sQnOXCcUQTY0PWYU9sCv P9KQ== X-Gm-Message-State: AOJu0YxhAaiHgCCVwHI4pxjeRykn/R+kxyVrqi75ZMVupOP+rzliXv8n KbHsGot90//DkyEqUUEDHPg0ZMUzDhYZtqCiAmc0vyY8Tw4= X-Google-Smtp-Source: AGHT+IGDHuZhrK9Wc60FwW1cdzTkvJ5Rty3/X1maQPSWF5Rk1k23TQ1RzBZUta3E4PNVQuMEEUaS+GaBokcHTLT/Q7Q= X-Received: by 2002:a05:651c:154a:b0:2c5:70b:2c21 with SMTP id y10-20020a05651c154a00b002c5070b2c21mr2512151ljp.22.1698003680983; Sun, 22 Oct 2023 12:41:20 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 22 Oct 2023 12:41:20 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 22 Oct 2023 12:41:20 -0700 Message-ID: Subject: control message for bug #66668 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 66668 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 25 11:08:54 2023 Received: (at 66668) by debbugs.gnu.org; 25 Oct 2023 15:08:54 +0000 Received: from localhost ([127.0.0.1]:59776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvfV7-0002KK-6E for submit@debbugs.gnu.org; Wed, 25 Oct 2023 11:08:53 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:40275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvfV2-0002K0-8n for 66668@debbugs.gnu.org; Wed, 25 Oct 2023 11:08:51 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project In-Reply-To: <838r7vre1a.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Oct 2023 22:06:25 +0300") References: <838r7vre1a.fsf@gnu.org> Date: Wed, 25 Oct 2023 11:08:12 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66668 Cc: dmitry@gutov.dev, 66668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Cc: Dmitry Gutov >> From: Spencer Baugh >> Date: Sat, 21 Oct 2023 14:37:45 -0400 >> >> Subject: [PATCH] Teach ffap to look for paths under the root of project > > Please don't use "path" when you mean "file name". The GNU Coding > Standards frown on such uses of "path". Oops, fixed. (Also fixed a byte-compiler warning from not declaring project-root) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Teach-ffap-to-look-for-relative-file-names-under-pro.patch >From 4423e8eb9b54652c114bb9d6b6b3b873a15a24a9 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sat, 21 Oct 2023 14:35:53 -0400 Subject: [PATCH] Teach ffap to look for relative file names under project-root Now file-name-at-point-functions, which runs ffap-guess-file-name-at-point, will pick up on a file name at point if that file name is a relative file name which exists when looked up from the root of the project. For example, in test/lisp/progmodes/eglot-tests.el there is the string lisp/progmodes/eglot.el; if you put point on that and C-x C-f, lisp/progmodes/eglot.el under the root of the Emacs repo will now be part of future history. * lisp/ffap.el (ffap-alist): Add entry for ffap-in-project. (ffap-in-project): Add. (bug#66668) --- lisp/ffap.el | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lisp/ffap.el b/lisp/ffap.el index 2c99f88d505..0c9ff8617d6 100644 --- a/lisp/ffap.el +++ b/lisp/ffap.el @@ -734,6 +734,7 @@ ffap-locate-file (defvar ffap-alist '( ("" . ffap-completable) ; completion, slow on some systems + ("" . ffap-in-project) ; maybe in the root of the project ("\\.info\\'" . ffap-info) ; gzip.info ("\\`info/" . ffap-info-2) ; info/emacs ("\\`[-[:lower:]]+\\'" . ffap-info-3) ; (emacs)Top [only in the parentheses] @@ -797,6 +798,11 @@ ffap-completable (cmp (file-name-completion (file-name-nondirectory name) dir))) (and cmp (concat dir cmp)))) +(declare-function project-root "project" (project)) +(defun ffap-in-project (name) + (when-let (project (project-current)) + (file-name-concat (project-root project) name))) + (defun ffap-home (name) (ffap-locate-file name t '("~"))) (defun ffap-info (name) -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 08:24:42 2023 Received: (at 66668) by debbugs.gnu.org; 29 Oct 2023 12:24:42 +0000 Received: from localhost ([127.0.0.1]:40664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx4qQ-0000x8-FW for submit@debbugs.gnu.org; Sun, 29 Oct 2023 08:24:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx4qO-0000ws-4R for 66668@debbugs.gnu.org; Sun, 29 Oct 2023 08:24:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx4pm-0007sj-4B; Sun, 29 Oct 2023 08:24:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=51L6jMvLRn/WaDya4/S6QJJrC3M1q39zYPYqndNCFQQ=; b=E6HA6to4a73d Qi2kr01ukxS2VeKt52nzzoC82prtjr2xaSfI2gskKO9/CKK27xqrB5i7dtJ90eaBLFijGEVgoGcbL SYikkyfHvufIQN5wYhsAuY2uewEsF3fRLV42XueADxYJZ+m43OBSdJIvcIvqC3uianfe8fA9VWDl8 0KIgK/tWPsfLJDQ3hCzTwQOX9IBXpT5C/BSgiwG2h+Kw8XX52/lwalEmV/Oc7I3cOdCc2TlQogIA/ 6N3IoogRNmaycVIrm2zhlpOmIQkOWpMwnM4mY+NwiQe4pZtoAXTB/xeV0O6m6KZVRjsQNDwvlzyb8 vC7oQb6WAU91Q7gCtpUqPg==; Date: Sun, 29 Oct 2023 14:23:46 +0200 Message-Id: <83edhdborx.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Wed, 25 Oct 2023 11:08:12 -0400) Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project References: <838r7vre1a.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66668 Cc: dmitry@gutov.dev, 66668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: dmitry@gutov.dev, 66668@debbugs.gnu.org > Date: Wed, 25 Oct 2023 11:08:12 -0400 > > Eli Zaretskii writes: > >> Cc: Dmitry Gutov > >> From: Spencer Baugh > >> Date: Sat, 21 Oct 2023 14:37:45 -0400 > >> > >> Subject: [PATCH] Teach ffap to look for paths under the root of project > > > > Please don't use "path" when you mean "file name". The GNU Coding > > Standards frown on such uses of "path". > > Oops, fixed. > > (Also fixed a byte-compiler warning from not declaring project-root) Dmitry, any comments? From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 08:44:17 2023 Received: (at 66668) by debbugs.gnu.org; 29 Oct 2023 12:44:17 +0000 Received: from localhost ([127.0.0.1]:40677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx59M-0001Qk-Po for submit@debbugs.gnu.org; Sun, 29 Oct 2023 08:44:17 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx59K-0001QX-Ip for 66668@debbugs.gnu.org; Sun, 29 Oct 2023 08:44:15 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 98F645C00C0; Sun, 29 Oct 2023 08:43:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 29 Oct 2023 08:43:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698583416; x=1698669816; bh=uZg/s5q51nu43eknLYxwWDBbPjmtMbXZ4NR sq1bAICg=; b=cgooCJX2BMnoCJxoxa7yvmTpMIW44w9B2lGeJLnTp5EUPpGNYgF YU9N+OLesUQiqqyqhdLpVzmqF9hLM/x2v9i/0XtUwNORzlYhjHHhzJCRm25pmOUZ AOfa4TlFeH3sU07GrDTm0DQa+Z0xjqm1XbF4KAtB9AYtQxjsx0fghrjZRSwCimdK FelGEAg9K402PPX6Ko0Yfa5dLmaotmsCnkXx2eNI69rCvhumx+d5U+blc+6CunR5 Xp5MoeF+auceyObg9DK12eZYS3SZQ7B0jYI1JwmNssHzIUbgc68O35eDYDM3zVgd Pb/iUNe4G5qHftu/jNvPLPSeWNUwBLPN+dQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698583416; x=1698669816; bh=uZg/s5q51nu43eknLYxwWDBbPjmtMbXZ4NR sq1bAICg=; b=WQzb5K7ZHIQRkbYwLvQ/vEk6xemfWZIqcrngbfGQ6pcLcEGGki9 FCk4g/zkEqzVuG4zmZYggHGKdK8RtpeuiFX3DwwW6O8iUb79uDoGeNjVwOGzkB4T DIDmxt+gsGcYfPuVuwYjARyy3gNs1s6nojEmrixSNv4JQ2vOFl1dbjG1aZlCs5yi uLPnU4e2wjUtwSRRNm9IEIlZaOy+gJeazfcBhfRBZnd0yMSsbjrIc20ZDa9Ml6tM nMniZJG4gs8w+8t2i1zPqj42H76W0e0SLNB1P/jPXYQPEmj7PMrkWPixXgSXH0FM DevrtTti2HkEpwdWZR92YII1ah4FJs4e+kQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrleekgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 Oct 2023 08:43:35 -0400 (EDT) Message-ID: <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> Date: Sun, 29 Oct 2023 14:43:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project Content-Language: en-US To: Eli Zaretskii , Spencer Baugh References: <838r7vre1a.fsf@gnu.org> <83edhdborx.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83edhdborx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 66668 Cc: 66668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 29/10/2023 14:23, Eli Zaretskii wrote: >> From: Spencer Baugh >> Cc:dmitry@gutov.dev,66668@debbugs.gnu.org >> Date: Wed, 25 Oct 2023 11:08:12 -0400 >> >> Eli Zaretskii writes: >>>> Cc: Dmitry Gutov >>>> From: Spencer Baugh >>>> Date: Sat, 21 Oct 2023 14:37:45 -0400 >>>> >>>> Subject: [PATCH] Teach ffap to look for paths under the root of project >>> Please don't use "path" when you mean "file name". The GNU Coding >>> Standards frown on such uses of "path". >> Oops, fixed. >> >> (Also fixed a byte-compiler warning from not declaring project-root) > Dmitry, any comments? If the way it works is useful for people (probably will be), I'm good with it. Ideally, it possibly would check whether the file belongs to the project-files fileset, but that's going to be slower, and thus probably not worth the marginal improvement. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 08:57:37 2023 Received: (at 66668) by debbugs.gnu.org; 29 Oct 2023 12:57:37 +0000 Received: from localhost ([127.0.0.1]:40698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx5MH-0001q4-Aj for submit@debbugs.gnu.org; Sun, 29 Oct 2023 08:57:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx5MC-0001pk-Pq for 66668@debbugs.gnu.org; Sun, 29 Oct 2023 08:57:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx5LZ-0005po-C3; Sun, 29 Oct 2023 08:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KuwWwxZgD0c/zznWPhqcQ0VrLAvixDT1E1zFigbGWG4=; b=VUcaJMSTXoXu +icNkMMhmSUle2HbjWcOEBNtLh+59MT2hLon/5nHgUFmxg9t0kY1AirA7UHiSXFFwHyu9zQDr5J6q QZGuhP4hM1aAxrs7lynDeTqasoBDPDgr58IgQCQQDdAoKmILQQ3+OG7u9wOOxz5Df0DILnhO8lyxk qzizOm05BE/s8iz05NQifR+dRAt5k/tHZoLIborAbh3PS86X6rzpiiYUzOx5mb6hjzularN5XtsNt KTzEJp3/v5tala1CvolgGl4xpl+26qzN9Bqfl6Oao+SV+/A8j4mgRKFg5hdVo72dZQJJRDXbK/80H +jRqQFD6GeQWYr1GxiUo3g==; Date: Sun, 29 Oct 2023 14:56:32 +0200 Message-Id: <83a5s1bn9b.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> (message from Dmitry Gutov on Sun, 29 Oct 2023 14:43:32 +0200) Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project References: <838r7vre1a.fsf@gnu.org> <83edhdborx.fsf@gnu.org> <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66668 Cc: sbaugh@janestreet.com, 66668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 29 Oct 2023 14:43:32 +0200 > Cc: 66668@debbugs.gnu.org > From: Dmitry Gutov > > On 29/10/2023 14:23, Eli Zaretskii wrote: > >> From: Spencer Baugh > >> Cc:dmitry@gutov.dev,66668@debbugs.gnu.org > >> Date: Wed, 25 Oct 2023 11:08:12 -0400 > >> > >> Eli Zaretskii writes: > >>>> Cc: Dmitry Gutov > >>>> From: Spencer Baugh > >>>> Date: Sat, 21 Oct 2023 14:37:45 -0400 > >>>> > >>>> Subject: [PATCH] Teach ffap to look for paths under the root of project > >>> Please don't use "path" when you mean "file name". The GNU Coding > >>> Standards frown on such uses of "path". > >> Oops, fixed. > >> > >> (Also fixed a byte-compiler warning from not declaring project-root) > > Dmitry, any comments? > > If the way it works is useful for people (probably will be), I'm good > with it. > > Ideally, it possibly would check whether the file belongs to the > project-files fileset, but that's going to be slower, and thus probably > not worth the marginal improvement. Then I guess we should install this? From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 21:00:15 2023 Received: (at 66668-done) by debbugs.gnu.org; 30 Oct 2023 01:00:15 +0000 Received: from localhost ([127.0.0.1]:44046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxGda-0001nO-Pv for submit@debbugs.gnu.org; Sun, 29 Oct 2023 21:00:15 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:36117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxGdY-0001m1-0p for 66668-done@debbugs.gnu.org; Sun, 29 Oct 2023 21:00:13 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 17B683200942; Sun, 29 Oct 2023 20:59:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 29 Oct 2023 20:59:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698627572; x=1698713972; bh=8vERxXY+vsnWKgDa8Iv1sYZpPGiQWyDvCtI +J2Rgt8w=; b=mro+6KI6aLqq6lfnAlKxbb3WQw3RiUbirk+HatqI3A20B4csKUr 4/wsw6+O4KJf7TYst9Dzi/D3BZkuapDGVT4gkAPzrJVo99CltBQ5qxVXzRL8j5Oz rDZKOBXhXUKXZ2+o9NAIQemUd+OQAiO4F3B7PrDoMGXPxe79zghKukL4tYbPW3RC RI9f57dY5sKQWPkygpvN7Lpiu+5Q20KXbkc6VA8sOrZHDxK+IMuo5DtOS8isgB13 MWP3gIbWMTzv2Jvs1JSaa+saiior9wBdt5Qedl1We372zEOLlkcSskC4Y7IEs0SW wBRqP3fSS6OXHmlWp1mEc8lAR275fs4LdjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698627572; x=1698713972; bh=8vERxXY+vsnWKgDa8Iv1sYZpPGiQWyDvCtI +J2Rgt8w=; b=ZIB8IleldzQOUOLeu5lmILJCTIM15Y+RARnXirhC8MN7bMH75mf 0UXdgejI5BfpTq0KukfrTZMLPSRXb/Wm/HQiHDgz+4La7MIlg+GvZ7Wf9qgs1chr UKnVNTf9ZpdO/iQhMVdkeCpwoOBToJSakcNGEbaZfD+wK5xhdEfJJktcne+GlA8s MaEWdOrCydZtoU0RVJiu/pO3QhnEW3UZeFEgx8F7icSAYB+fR9VvRqwYU04rnoDz DnyLagSfICLJq0DA7TiFjqB1lc+CUDK+Mdnou3URZqmZH980/O4tWfE9pKxP0IV5 zMMP702ocYkoLG7ighczhLkwPIYBY04PFPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrleelgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 Oct 2023 20:59:31 -0400 (EDT) Message-ID: Date: Mon, 30 Oct 2023 02:59:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#66668: [PATCH] Teach ffap to look for paths under the root of project Content-Language: en-US To: Eli Zaretskii References: <838r7vre1a.fsf@gnu.org> <83edhdborx.fsf@gnu.org> <271bf6ef-4470-69f7-0892-ee7c95d56fe2@gutov.dev> <83a5s1bn9b.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83a5s1bn9b.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 66668-done Cc: sbaugh@janestreet.com, 66668-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) Version: 30.1 On 29/10/2023 14:56, Eli Zaretskii wrote: >> Date: Sun, 29 Oct 2023 14:43:32 +0200 >> Cc: 66668@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 29/10/2023 14:23, Eli Zaretskii wrote: >>>> From: Spencer Baugh >>>> Cc:dmitry@gutov.dev,66668@debbugs.gnu.org >>>> Date: Wed, 25 Oct 2023 11:08:12 -0400 >>>> >>>> Eli Zaretskii writes: >>>>>> Cc: Dmitry Gutov >>>>>> From: Spencer Baugh >>>>>> Date: Sat, 21 Oct 2023 14:37:45 -0400 >>>>>> >>>>>> Subject: [PATCH] Teach ffap to look for paths under the root of project >>>>> Please don't use "path" when you mean "file name". The GNU Coding >>>>> Standards frown on such uses of "path". >>>> Oops, fixed. >>>> >>>> (Also fixed a byte-compiler warning from not declaring project-root) >>> Dmitry, any comments? >> >> If the way it works is useful for people (probably will be), I'm good >> with it. >> >> Ideally, it possibly would check whether the file belongs to the >> project-files fileset, but that's going to be slower, and thus probably >> not worth the marginal improvement. > > Then I guess we should install this? Sure, installed. Thanks, and closing! From unknown Sun Aug 10 16:49:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Nov 2023 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator