From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 10:16:55 2023 Received: (at submit) by debbugs.gnu.org; 21 Oct 2023 14:16:55 +0000 Received: from localhost ([127.0.0.1]:44790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quCmd-00056y-CA for submit@debbugs.gnu.org; Sat, 21 Oct 2023 10:16:55 -0400 Received: from lists.gnu.org ([2001:470:142::17]:36726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quCmZ-00056d-OC for submit@debbugs.gnu.org; Sat, 21 Oct 2023 10:16:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quCm2-0008RE-Gr for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 10:16:18 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quCm0-0008La-D5 for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 10:16:18 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-98377c5d53eso262698366b.0 for ; Sat, 21 Oct 2023 07:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697897773; x=1698502573; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=+W46Vs+Yl6698+yX4fEU46xjkgC+8txv80yh2oekmGg=; b=ipcES6Ewa9Oq92590lsgXNTvRczMo+5C6kEYCaTVr3vwRHLFTz87pZm6iRGS/CpH9M ahl8kV4CpGUZYbIfKLNq/RNGCg9aC6gZuSeA1/tCuNm/o7uHBToPnz353dK5kNYshMIa ZeG4tJLnH4m35ao2kOrYJyxBLLQAOw5t4uYHtHiG0EtsKJUCYECcptQU0rEcbUNvG65G qjtG82hUxVlykS2+SLK02KajTKCks+iQk+k1XZbQ0uaz/OaMFVaSV9BMwXgTuZLa80rS mvuSY+VFemgMXVnqi+TdD4BEC8dDuGyeZzq9sUHJQTy+biJSmYFnBtGBhovhP4FToR9p 3IDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697897773; x=1698502573; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+W46Vs+Yl6698+yX4fEU46xjkgC+8txv80yh2oekmGg=; b=sMgi5osAyI1JdrvsFuVSJJDgDOxKssYTU1HHmeqEj/7PoHsYlNC5yQngAwjOlmrjys ya4H5Q7p+bRP5dDb9T+27rxaTpnJCCc/JnBO1mXkJXHXEF0s6BafAAQJx+jL3/Xp9g7p gFE6u2qqLO1HPgNP6Iz64J5HZTO3NKagXWHgcVjA5k99W6v1W5E/SZahO5EZmcrr77Iq T/mDbWMMs5L4D2GFYOiOSyjbYKgLutt0AhLQOLIBy1/Hgui6DVe8u7a2dEQxjHTzalup h+QJIP8HpG1soI1BpbbxITzsyu1gsToANXOPqrrBGR6PKPQDcpzt7PT4ZxnpeL9xjgwa bKTA== X-Gm-Message-State: AOJu0Yy9UkvqrI5VZ6CvfPFIVXuSri0YeB9XRPahUzBSLWBqeL4O0g5N PWBJJufcboguRY344pBAYqqA87J8sQ0= X-Google-Smtp-Source: AGHT+IFNx2vrPrJK6JJ6aahL9NOCcW8bHOX4e5u99VfObLXhwtz7r4Q2rpgGVM11qcSiId+G26+07Q== X-Received: by 2002:a17:907:3d94:b0:9ba:fe6:225 with SMTP id he20-20020a1709073d9400b009ba0fe60225mr3544031ejc.55.1697897773475; Sat, 21 Oct 2023 07:16:13 -0700 (PDT) Received: from ars3 ([2a02:8109:8ace:5100::e57c]) by smtp.gmail.com with ESMTPSA id m19-20020a1709066d1300b0099bd453357esm3627057ejr.41.2023.10.21.07.16.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 07:16:12 -0700 (PDT) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Feedback on treesit-font-lock-level X-Debbugs-Cc: Yuan Fu Date: Sat, 21 Oct 2023 16:16:11 +0200 Message-ID: <87il70vz6c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The docstring of treesit-font-lock-level says: Level 1 usually contains only comments and definitions. As a user of minimal fontification, I don't find this very appealing. IMO, the lowest fontification level should allow distinguishing code from non-code, and therefore fontify comments and strings, and nothing else. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 14:19:44 2023 Received: (at 66666) by debbugs.gnu.org; 21 Oct 2023 18:19:44 +0000 Received: from localhost ([127.0.0.1]:45000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quGZc-0007Cb-Fx for submit@debbugs.gnu.org; Sat, 21 Oct 2023 14:19:44 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:45338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quGZZ-0007CL-LL for 66666@debbugs.gnu.org; Sat, 21 Oct 2023 14:19:43 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6b36e1fcee9so1700308b3a.3 for <66666@debbugs.gnu.org>; Sat, 21 Oct 2023 11:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697912348; x=1698517148; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xPX93ViIMDvof7+jk0UxcXN8XUSEV5kSrZ5PKkJxPIM=; b=lWAaeHf8ZWxcopUAy0SLw0IEMn1Ezslom6gSr2LASNx7xUvs4rimIMN+LpbPe0lpVB MH/Mv5zm/2q2Ex9SiKV+FG1LBGQ6Yd6AeLkHTlgBlWPxYFse9KR6Oxaf2/hGB4DlnuOb TgkY10zNB7l35Jq7AN5nTxCBz4vugtwlP5Qd2s0OOmJE4InCNp0YimrBGNFHRg5M10bO r2K0YQ874WTykBfxeH4CSowyoVg0TlnuXD2sNX/3K0kkWaH6/EttbwThZ7oJoIBT5jUC UEDqrJCRIJA0X3FBMuJod3nwxkzqUAdeP58T8ktZUjemHq7goRRpCq0FZqKY0NmmM/og B84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697912348; x=1698517148; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xPX93ViIMDvof7+jk0UxcXN8XUSEV5kSrZ5PKkJxPIM=; b=bVHVQ/MOyPDBJVnog0ELCHwsr8+9OafyCdTQ/PVKHeBEnkBJbpOz+RMkkonw1DeLNj 6cU6JNi5KbisWxnDtFgquzCOXuXI/lYCiWQXBOxzGP3iXevzqZUAnfXGvDaHT+ODonph Jd/kLJbnE44MjpN0ih8adN8XaxFZaCigxI379VGYHVN/WnWKpe7ddyZFPR1axFK2YO2r Nlb0cXqTo+/UnzkcBvsouCFhx81OMx2ghzVUgdJfmSbyizvnV4LpMlz3MEDajjsPlZy7 deA9/JhcGZtrXoIaiP3i0KQUq4B2I8OUZBbcHBMk+1M5ZPPY5S6fZcBsqfFKFbEQy6O6 Fd0Q== X-Gm-Message-State: AOJu0YwTJAyXnG33IXOLjSB1k6V+ru6aXRZFWMSXggjhYduac0z2SrhA 8KRqK3SakNzZor74LTol0XM= X-Google-Smtp-Source: AGHT+IFYLivVHsiShZ1+nhYrutxP8SKrjIdnHHbgZpSzY8OBfOhWiEbSO+K9X21VVk5pTu3gILOmKg== X-Received: by 2002:a05:6a00:194c:b0:6bb:8982:411c with SMTP id s12-20020a056a00194c00b006bb8982411cmr4422340pfk.8.1697912347732; Sat, 21 Oct 2023 11:19:07 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id w5-20020a626205000000b0066a31111cc5sm3679884pfb.152.2023.10.21.11.19.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Oct 2023 11:19:07 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#66666: 30.0.50; Feedback on treesit-font-lock-level From: Yuan Fu In-Reply-To: <87il70vz6c.fsf@gmail.com> Date: Sat, 21 Oct 2023 11:18:56 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87il70vz6c.fsf@gmail.com> To: Augusto Stoffel X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66666 Cc: 66666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 21, 2023, at 7:16 AM, Augusto Stoffel = wrote: >=20 > The docstring of treesit-font-lock-level says: >=20 > Level 1 usually contains only comments and definitions. >=20 > As a user of minimal fontification, I don't find this very appealing. > IMO, the lowest fontification level should allow distinguishing code > from non-code, and therefore fontify comments and strings, and nothing > else. That=E2=80=99s a fair point, and I don=E2=80=99t have strong opinions of = what minimal level of font-lock should include. The default value is = derived from my observation of the (few) existing major modes that = support font-lock levels. Since this isn=E2=80=99t a technical issue but rather a subjective one, = perhaps you can bring it up to emacs-devel and have a discussion there. = If the consensus agrees with you, then we can change the default value. If you just want to make it work for yourself, you can use = treesit-font-lock-recompute-features to add/remove features you desire. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 15:42:22 2023 Received: (at control) by debbugs.gnu.org; 22 Oct 2023 19:42:22 +0000 Received: from localhost ([127.0.0.1]:48160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queL8-0003hx-EY for submit@debbugs.gnu.org; Sun, 22 Oct 2023 15:42:22 -0400 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:60737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queL6-0003hk-El for control@debbugs.gnu.org; Sun, 22 Oct 2023 15:42:21 -0400 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2bfed7c4e6dso38833261fa.1 for ; Sun, 22 Oct 2023 12:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698003706; x=1698608506; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Cs+xANy4Eo5ngwcjLZNM5iVSgYCx29KkBkU9xPwXvxA=; b=Pdax0xCFuDLupaMFzW7BgpOwx9BVSxPqf5gqN3ssnKP1LA1AlBkanlBlUnuwFhBUA4 IpZU0X/xi/OTC5CA7jENtv5jhIeJn/rKciF2MwWWIuaw2lEcqo0rTNGITAurXyHBCxAt 17SMgaMvnBBkCDP4khmoHzteJ/2EGeLpKtKAmY8yC0RUs9EUqgAKDuhvMHM2sChQVgeg LvsvuPiHYiSEojeMtYX1cLR3RtUcwb89NoH5XEarcABOfBA6YsbDu7l5bUQp6LzYQyUB gC4VMBfFt0NHhz84s3WafrelVPG7MVsatqpVuUveRmP3tkPGNl9TkhCQ6P5hBX6MnVnM v1lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698003706; x=1698608506; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Cs+xANy4Eo5ngwcjLZNM5iVSgYCx29KkBkU9xPwXvxA=; b=l7NJwJ6hHXzhWFZLpCsheih80BGPrGaG23/S/6sQ267fVoxe5YX8Ret5KBYryvw885 3RrleR6JBGABBYdNITLyVETu4rg8EQJa56RD5B+XocMHWgbscoxmxGbL8aSLS1AOb9gk qH/lypkQ02XKyhnSm0YrekpqaNi8OANldb2p+MzANb0wEMpO8G2Pi/5tu28Kjf9noZvy 8NLrTbj/+1aYDy8hz9JGc/uVWwoHXbEyQEHI5umEAZCZ5csp0TPRKHPs2Re//FctD8Ka uIuCP/4Qk5vf8mPv8KWt7gFysNfct1QDHr2ivw/TOPqgIx4firXcbcM/JoVM8BjM34iB gohw== X-Gm-Message-State: AOJu0Yy8jURM3WRdd40JxHuQVAMk7yiC4YAtg6k8WWJ+VUs3gLsL+OxD /73O0ScuKAD1odV7aDe7B8LS+9UM9hGVaMqs8n1VlEWc6nE= X-Google-Smtp-Source: AGHT+IEXLXhEfRByMWS/VujKBfoboeW4RBZ2T4n2E+YoUkdz7yzIGpUh1qQzG9dEXaRa3bdpzKd0QjOacWK54OZd9us= X-Received: by 2002:a2e:a589:0:b0:2c5:1a8e:e4c9 with SMTP id m9-20020a2ea589000000b002c51a8ee4c9mr5226563ljp.31.1698003705942; Sun, 22 Oct 2023 12:41:45 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 22 Oct 2023 12:41:45 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 22 Oct 2023 12:41:45 -0700 Message-ID: Subject: control message for bug #66666 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 66666 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 16:48:27 2023 Received: (at 66666) by debbugs.gnu.org; 22 Oct 2023 20:48:28 +0000 Received: from localhost ([127.0.0.1]:48411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qufN5-0002oS-KZ for submit@debbugs.gnu.org; Sun, 22 Oct 2023 16:48:27 -0400 Received: from planete-kraus.eu ([89.234.140.182]:50064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qufN4-0002o9-1w for 66666@debbugs.gnu.org; Sun, 22 Oct 2023 16:48:26 -0400 Received: from planete-kraus.eu (localhost.lan [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 3799353b for <66666@debbugs.gnu.org>; Sun, 22 Oct 2023 20:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:subject:from:to:date:content-type :content-transfer-encoding:mime-version; s=albinoniB; bh=ZRIirIV 3g5BLxCMPE+Ju6jFvfQg=; b=XKVwqWjki2W/Yv3Boy+q9nt/9fKr/J0zBeMiOkM rDmA+ESUePEn2ryG+YGOGuwhPqPFGvMjp1dgMJDi0MxiUdlVncLkfN3QPQ+u+EJV Y0SfghTolfYyOE5tuX6FiDF9xnLuYp5zaNCIJh0c4RU9i4F6tEvi4H3xFVv/J0zZ AsfFpsn7nEnDAXmM9pkPjyO8cPMz7RAtXQpzr14SKYQfvgQ2u8TxSTu2LylR/tUS KCCOZWR9geK2IZhLvndaWH6rOrr9KyBDdUDHXNT7F0f9uKYIM2RdHc2/HDUcrwmK LFLLCu3FbjGTwq0V4tRTjEksrLwcLvpBw1Ac2UZf0NJCQuA== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 90d93fef (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <66666@debbugs.gnu.org>; Sun, 22 Oct 2023 20:47:56 +0000 (UTC) Message-ID: Subject: control message for bug #66666 From: Vivien Kraus To: 66666@debbugs.gnu.org Date: Sun, 22 Oct 2023 22:47:54 +0200 Content-Type: text/plain Content-Transfer-Encoding: 7bit User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66666 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 66666 devilish quit