GNU bug report logs - #66646
29.1.90; No tsx syntax highlithting in typescript-ts-mode

Previous Next

Package: emacs;

Reported by: rrudakov <at> fastmail.com

Date: Fri, 20 Oct 2023 10:15:01 UTC

Severity: normal

Found in version 29.1.90

Fixed in version 29.2

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Roman Rudakov <rrudakov <at> fastmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66646 <at> debbugs.gnu.org
Subject: bug#66646: 29.1.90; No tsx syntax highlithting in typescript-ts-mode
Date: Fri, 20 Oct 2023 15:17:01 +0200
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Roman Rudakov <rrudakov <at> fastmail.com>
>> Date: Fri, 20 Oct 2023 12:13:15 +0200
>>
>>
>> - install the latest typescript/tsx grammar.
>> - open a .tsx source file
>>
>> I'm getting the following error in the *Messages* buffer:
>>
>> Error during redisplay: (jit-lock-function 1) signaled
>> (treesit-query-error "Structure error at" 22 "(jsx_opening_element
>> [(nested_identifier (identifier)) (identifier)]
>> @typescript-ts-jsx-tag-face) (jsx_closing_element 
>> [(nested_identifier
>> (identifier)) (identifier)] @typescript-ts-jsx-tag-face)
>> (jsx_self_closing_element [(nested_identifier (identifier))
>> (identifier)] @typescript-ts-jsx-tag-face) (jsx_attribute
>> (property_identifier) @typescript-ts-jsx-attribute-face)" "Debug 
>> the
>> query with `treesit-query-validate'")
>
> I cannot reproduce this.  I used a random *.tsx file on my system, 
> and
> didn't get any error.  So please post the file you used, and also
> describe step by step what to do to reproduce the problem starting
> from "emacs -Q".
>
> Thanks.

After some debugging I figured out that it can be only reproduced when 
`eglot-ensure` is added to `typescript-ts-mode-hook` and 
`tsx-ts-mode-hook`. So, steps to reproduce are the following:
- Optionally install `typescript-language-server` (if it's not 
 installed there will be eglot error, but the original issue will 
 still be reproducible).
- `emacs -Q`
- evaluate the following:

(require 'typescript-ts-mode)
(require 'eglot)
(add-hook 'typescript-ts-mode-hook #'eglot-ensure)
(add-hook 'tsx-ts-mode-hook #'eglot-ensure)

- open attached tsx file.

[Button.tsx (text/plain, attachment)]
[Message part 3 (text/plain, inline)]

--
Best regards, Roman

This bug report was last modified 1 year and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.