From unknown Sat Sep 06 02:32:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program. Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Oct 2023 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66643@debbugs.gnu.org Cc: ivan-p-sokolov@ya.ru X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169774645923527 (code B ref -1); Thu, 19 Oct 2023 20:15:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Oct 2023 20:14:19 +0000 Received: from localhost ([127.0.0.1]:37906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtZPO-00067O-Gz for submit@debbugs.gnu.org; Thu, 19 Oct 2023 16:14:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtZPK-000674-GO for submit@debbugs.gnu.org; Thu, 19 Oct 2023 16:14:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtZOn-0006jm-Rr for guix-patches@gnu.org; Thu, 19 Oct 2023 16:13:41 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtZOl-0005xY-TE for guix-patches@gnu.org; Thu, 19 Oct 2023 16:13:41 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507c91582fdso56983e87.2 for ; Thu, 19 Oct 2023 13:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697746417; x=1698351217; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9xJPD8YfM96d5X2gKD+IXWVfs7Buv4vF4Ad8bGkkbdw=; b=BAa796FO5cVM5K0rxBv1LfwmxSXE4WAvpiNCSomIMBuRk9Fnlw0fqrVP+neFWmScmC 01VEh8AbvPQsrF5zwth3vR5+5rflh2U3aNmJ5iA4B0Af/t2V2zDNSK+ff7QDVX5ROrVu JmPepgbu9cXTV8GmONgfc4ihIOf9tss6sETGVJOAnXuS2yUI5idFdvibmJh1u/E9hkbH TBqxOJJGvdJTf31dw2FaCH6f7RCBS9bQiwagqRJ0QplTxwqzKR8tS1MFdrS7/lyjlBcV KzYVspq1FpZCNpAJqOZz3MQnfwdq+cP1W0b0Ugv+ZKLhUk5qaQPRIjRdVbtWA5B1ERc3 DRCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697746417; x=1698351217; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9xJPD8YfM96d5X2gKD+IXWVfs7Buv4vF4Ad8bGkkbdw=; b=GoVGsol3E5IulNervn6WrQ2KsqpuK05qBZWag033Y93Zb3nIWL/6JTWy3bb8PMoXQm VfCJm7fryZEuAZ1sfI0Y02EG6LbQqUSnRDhJ7SckCHyHeg6Zb4OQc0I71+lKWHq1oWzp r2wPcMhDZ9zGhszQevpRtpAQxMEm5J1e7RuuVULE5j+uqawUgCtpHv8s4GNx4x3JOMyy Hoo/1JBVsQOrDe/g3nDD8CHiftv+q/iFnP+EkRe1PJIAeut8S39NjYJevVTNqyDHy/zC Gd37Zekpls25wkNvGAl7AFGuvToI8h4egCvbMXsa4jH7dasr5Gp+4Vx/tJebPPZOmmnQ GhzQ== X-Gm-Message-State: AOJu0YyZRjp/a3lDgypYxMbQ8x21prel2YX838IWEqPee8+dPVjetatc zcqBGCDesn7tWvL+3G8BAMxSDnBKstk= X-Google-Smtp-Source: AGHT+IEbgtdXTlmazuT6AUUzLZd19GNCmPcjYkG9ewzGjy6ct2g9j1PGwOB3ULrt8w1F8wEGAYb/Eg== X-Received: by 2002:ac2:4c0e:0:b0:507:aa44:28fa with SMTP id t14-20020ac24c0e000000b00507aa4428famr2392765lfq.26.1697746416886; Thu, 19 Oct 2023 13:13:36 -0700 (PDT) Received: from magi ([176.59.3.85]) by smtp.gmail.com with ESMTPSA id g2-20020ac25382000000b00503189d8b8csm24286lfh.198.2023.10.19.13.13.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2023 13:13:36 -0700 (PDT) From: Aleksandr Vityazev Date: Thu, 19 Oct 2023 23:13:33 +0300 Message-ID: <87bkcugyky.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=avityazew@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, When $@ is used in a bash script without escaping, it causes files with spaces in the name to fail to open. This patch fixes this for icedove-wayland. You can also see this kind of thing in qemu. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (avityazew[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.0 FREEMAIL_REPLY From and body contain different freemails X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, When $@ is used in a bash script without escaping, it causes files with spaces in the name to fail to open. This patch fixes this for icedove-wayland. You can also see this kind of thing in qemu. https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/virtualization= .scm?h=3Dmaster#n417 I don't think you should use wrap-program there. WDYT? * gnu/packages/gnuzilla (icedove/wayland): Use wrap-program, since "$@" must be escaped. Thanks to ivan-p-sokolov@ya.ru for noticing the issue! --- gnu/packages/gnuzilla.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index a367d7a00f..7a71fc8cb9 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -20,6 +20,7 @@ ;;; Copyright =C2=A9 2021, 2022, 2023 Maxim Cournoyer ;;; Copyright =C2=A9 2021 Baptiste Strazzul ;;; Copyright =C2=A9 2022 SeerLite +;;; Copyright =C2=A9 2023 Aleksandr Vityazev ;;; ;;; This file is part of GNU Guix. ;;; @@ -2076,14 +2077,11 @@ (define-public icedove/wayland #~(begin (use-modules (guix build utils)) (let* ((exe (string-append #$output "/bin/icedove"))) - (mkdir-p (dirname exe)) - (call-with-output-file exe - (lambda (port) - (format port "#!~a - MOZ_ENABLE_WAYLAND=3D1 exec ~a $@" - #$(file-append bash-minimal "/bin/bash") - #$(file-append icedove "/bin/icedove")))) - (chmod exe #o555) + (install-file #$(file-append icedove "/bin/icedove") + (string-append #$output "/bin")) + (wrap-program exe + #:sh #$(file-append bash-minimal "/bin/bash") + '("MOZ_ENABLE_WAYLAND" "" =3D ("1"))) ;; Provide the manual and .desktop file. (copy-recursively (string-append #$icedove "/share") (string-append #$output "/share")) base-commit: c065da01ff956d3c2bdfc45a33d910e509a211d9 prerequisite-patch-id: ec4a09723b91089c8eb5b5269ae81272bb4d81b4 prerequisite-patch-id: 9680399593e3dcdb5b10ee646023efd1215942d9 prerequisite-patch-id: 66497a0079d0077e7b5001707d8211c525ea7193 prerequisite-patch-id: 4f512542ae5806d47054e063e3dd1df66258c530 prerequisite-patch-id: 48abb1e84ca8d85b23794222f8fa5b4d2dfa4699 prerequisite-patch-id: a7fdd2f87131ad73865389152d4a826df24fcae7 prerequisite-patch-id: 1600413a45a50114906f4390653c3fbb7f536a4c prerequisite-patch-id: 51e95882782a53eda933e884fb5e80487ba52b9f prerequisite-patch-id: 177b2873f4e77585c464ac3d24bec78d58f128bd prerequisite-patch-id: 631a6785018f999fcbf7e22fb8e2aae9329ced55 prerequisite-patch-id: 1bd1b328f9e3c7119fed731ffd7e7d87ac33f0c2 prerequisite-patch-id: 79105270952c22f07255cb315da1db44f505b07b prerequisite-patch-id: 9c5af3baa3dac6233837fb6eb0b7467b969caff4 prerequisite-patch-id: 1156b461c8622b5071656309b05c026abab0f277 prerequisite-patch-id: 8a5e3746b5092496884d50ef4359148ac9349a83 prerequisite-patch-id: 579e44cb67db2d0d3c6232c7c306457a0b5a1a27 prerequisite-patch-id: f5dc3c2782749512e23becb166db7aafacd0be1f prerequisite-patch-id: 41717fac7367d7e596c093548408ab4bb7d11575 prerequisite-patch-id: 82761b9bede107314f9e75282e1851da281e1d53 prerequisite-patch-id: 4eaffd8b1788833c76590916476337e55ae234b0 prerequisite-patch-id: b501999eff4662ed2917dba3b934abd1a5e2252a prerequisite-patch-id: d2b947c72b82c6366d8164f1d732a4d25c6cb4fa prerequisite-patch-id: e1df80a774d3de676f01f262c68f506b0bc1ed92 prerequisite-patch-id: 1e2e9dfb8051b74814d7711e0247674a20329b1e prerequisite-patch-id: 3dc346b9df988744c17f4c810753d8afcb00a642 prerequisite-patch-id: e2c517c1181b6b34eda2f660985dd6db280d886f prerequisite-patch-id: cf256fc20be65ced1f1486423f4bbea768d686ae prerequisite-patch-id: 4c8c9425dae8a721016c4e0e7ed9c2fbe3556d9e prerequisite-patch-id: fb5c2f33b0ee041a46c6025d04271c3dbdb53d15 prerequisite-patch-id: c9d2a6a24a622955395ad090a0eb22598c16b23d prerequisite-patch-id: eeeefc7040171849bdaa2c9cd9f47731c80287ea prerequisite-patch-id: 56c4e80a78ecd8514c5d96c4492925ad57d4dd14 prerequisite-patch-id: ebee5547a41485f7ca26f93609f53ade60601f3f prerequisite-patch-id: 9c816f74d4166f1be0964ea0ef27d602495cd9bb prerequisite-patch-id: faae90b478e36eb4f2f17bde8782032b30e2e4db prerequisite-patch-id: bf26fe3d5e2082445217490ec635e6e85b65247f prerequisite-patch-id: 1722a64febdad4cfaff4a22c44d9661fcf0b6a5a prerequisite-patch-id: a50461c3f84736992a9fdcc23c36920a6555d567 prerequisite-patch-id: 6dec4cc56ec808267f99ac5f1be941fabb28e126 prerequisite-patch-id: 741be4e6b815c817ceedff55ea6da159e5050524 --=20 2.41.0 --=20 Best regards, Aleksandr Vityazev From unknown Sat Sep 06 02:32:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program. Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Nov 2023 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66643@debbugs.gnu.org Received: via spool by 66643-submit@debbugs.gnu.org id=B66643.17012664437060 (code B ref 66643); Wed, 29 Nov 2023 14:01:02 +0000 Received: (at 66643) by debbugs.gnu.org; 29 Nov 2023 14:00:43 +0000 Received: from localhost ([127.0.0.1]:49164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8L7L-0001po-GZ for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:00:43 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:43221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8L7J-0001pY-7k for 66643@debbugs.gnu.org; Wed, 29 Nov 2023 09:00:41 -0500 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50bb8ff22e6so935237e87.0 for <66643@debbugs.gnu.org>; Wed, 29 Nov 2023 06:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701266427; x=1701871227; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TCa+oFBByN4u7awISZ5mygXsCO7mAOZPzEAMHuKq63g=; b=nM6iP4AE3wPkpGXRKGMTQqwx8llXyLYrLq0Zf+dykXitGK4XNsPko4F33Lt+Og/2fl j/2o7dYaQPdCyPBLIaQJOO50cdGkbJ6d1agzvzsO5ntu48PyqZ0fs+4j+y/Ik+6/xtAl IevV6R/fDiV3dAwByF9pgwMYzszC1/He4Pqk4Tb6FEDfozIEBzuo90OCrJx6h+cCzQe1 2IXpjMPTTwT6ZU+JJVAdmkoQEuD+AgB0gBFRDNas7ZNY0st1ZYQyxdJSw+5jxIvRvXHS U/gtQnXTitBMX2hf3xVwH7rS4MtL7pZB+HQoULqWVh6QGRZxDE4NhsFfnfyMRC1uSjeX plyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701266427; x=1701871227; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TCa+oFBByN4u7awISZ5mygXsCO7mAOZPzEAMHuKq63g=; b=A/5J8QqXtDhs/6iNgysEb2RSpmwq6oMyPh/x/QcenDjD4p0k0+kvkjP5rKpWE8FBh1 6CKQS2AZ+8de7lBbkRkc+S6FB70LJth/Apm0mJo0dm3MmhHJVa/YjYsBxo1dFZG5mweH Cdsfo5r8SGQr2NZLT0gCLnHXQRWYaljhGpuoAFCstPM0Y+CZcaCVN2mKyslI3TVBdMRU HUQLXwIm9LL3c2a7ZSIxM1YjfSoUwMynaZ2JT3gwnCe9eWYRJn1jL6pET6rY2pBHwmA8 a4qHAQ4Gn/V7kOJFkraiuxhqM22zwncfI5URTcMPnlirWaPFggqJeF6V7+s76k6JwpRf X2ow== X-Gm-Message-State: AOJu0Yy/p5PYMmVsg0AbUUTQ9WjT8Wd09CH+EyTpgasedeiyyELFfmN2 HDHEdtRA+VYMC2vp9M+Om7yxkhW4VZY= X-Google-Smtp-Source: AGHT+IEM6D4v1nM70cqfGReHsjIRr5b00FfXRsJK6nB7oMQGsF89UUg+zRpsGen7XvrKPeeBqYqwrw== X-Received: by 2002:ac2:4423:0:b0:50b:c343:7541 with SMTP id w3-20020ac24423000000b0050bc3437541mr734434lfl.32.1701266426897; Wed, 29 Nov 2023 06:00:26 -0800 (PST) Received: from magi ([176.59.1.227]) by smtp.gmail.com with ESMTPSA id v12-20020a056512048c00b0050bc7a472c4sm116417lfq.182.2023.11.29.06.00.26 for <66643@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Nov 2023 06:00:26 -0800 (PST) From: Aleksandr Vityazev In-Reply-To: <87bkcugyky.fsf@gmail.com> (Aleksandr Vityazev's message of "Thu, 19 Oct 2023 23:13:33 +0300") References: <87bkcugyky.fsf@gmail.com> Date: Wed, 29 Nov 2023 17:00:23 +0300 Message-ID: <87fs0oslqg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, just a gentle ping -- could anyone review this patch? If using wrap-program isn't quite appropriate, I can fix it another way. -- Best regards, Aleksandr Vityazev From unknown Sat Sep 06 02:32:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program. Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Jan 2024 23:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66643@debbugs.gnu.org Cc: jonathan.brielmaier@web.de, clement@lassieur.org Received: via spool by 66643-submit@debbugs.gnu.org id=B66643.170501432032243 (code B ref 66643); Thu, 11 Jan 2024 23:06:02 +0000 Received: (at 66643) by debbugs.gnu.org; 11 Jan 2024 23:05:20 +0000 Received: from localhost ([127.0.0.1]:34274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO46x-0008Nz-P2 for submit@debbugs.gnu.org; Thu, 11 Jan 2024 18:05:20 -0500 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:46280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO46u-0008Ne-9p for 66643@debbugs.gnu.org; Thu, 11 Jan 2024 18:05:18 -0500 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2cd8b661cb8so10915041fa.0 for <66643@debbugs.gnu.org>; Thu, 11 Jan 2024 15:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705014312; x=1705619112; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ws7MNoJfU8wPVup+LLx+0FkjHWU/OA8m8z/tiE9i5zU=; b=TI4rp6JkwJaeFz7HHJqgW3874D5UWgUGcdlWKtKFJr/JDtmslntfH3ZDxu2oz5dzmY K/ee8MCaxR/PBrnJ/IQKAlIB9bjhSmw1T3ReXz/wZp0NE6z3KaBv9Up0lG9nQ3yVee6Q GNgj8I19x1coejUGptcW20dCvgvIyG97MKZB/JN+/dNBRZrBHoD8uA1qlsu5M87GqCnG EU8zYGfcWFcjKdPWlll+t4VygVroOdR2ZKGpPxzJu8iArYQDsRSF9002fsGk+afu2WFY JKNmmLamQ5Twq2cZnejUCbYhmril0mQRX7MMsqsNSS52oZqpRrNXOKBbr+FW/1+B3tbp +B2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705014312; x=1705619112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ws7MNoJfU8wPVup+LLx+0FkjHWU/OA8m8z/tiE9i5zU=; b=hgOFvl0E2tDaS01VILowDYq/6UR/ahb2+hK1+vMQJwHcjzg79Cx00K3AbqvaV6v6y+ ecpySMKPktY1gy42Ti19J3jGVrynGp6yeQ0eG77h6mgUoPXyClFxe+uisOUSvhCRSDus WPtmDZnxPG7zSuIyOgS2fAIyLg8kjK/QvdunP1C2nMz9FfR/rLvkJRcc2kB8LMml09XA YCj91woZqeJniAwnxixgdqNbmcvpGNSBLyG+sNhsJ23cn7gBUk7PjC50mRZNdL4WZBE+ VLWFdESvOPN1n+q0CS47hVAqXo/WOPMctUi10IL5AUVGSsEoUSs1eJ3kbd2WAil4VgpS dUow== X-Gm-Message-State: AOJu0YxF1xpFFtLqpdVxqJZXg0OJvf0sl8rIvGEZLw4B1uTTgxP7ho55 XtM/eBaFZJexhLqgAvg712x/0eI9zDw= X-Google-Smtp-Source: AGHT+IE9CmARjJxFmV8pEXm+AV4rwPPz3U9W6lzp6CQV6zK2Ssmjpq5kt1iZU8COJ/ZSttlKDtO91A== X-Received: by 2002:a2e:a16a:0:b0:2cd:6fa:9ba8 with SMTP id u10-20020a2ea16a000000b002cd06fa9ba8mr162003ljl.42.1705014311771; Thu, 11 Jan 2024 15:05:11 -0800 (PST) Received: from localhost (host-143-154-66-217.spbmts.ru. [217.66.154.143]) by smtp.gmail.com with ESMTPSA id k4-20020a2e8884000000b002ccf5b756adsm276048lji.132.2024.01.11.15.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 15:05:11 -0800 (PST) From: Aleksandr Vityazev In-Reply-To: <87bkcugyky.fsf@gmail.com> (Aleksandr Vityazev's message of "Thu, 19 Oct 2023 23:13:33 +0300") References: <87bkcugyky.fsf@gmail.com> Date: Fri, 12 Jan 2024 02:05:09 +0300 Message-ID: <87ply7xyhm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Another month has passed since the last letter, I am sending another ping, this time I added members of the mozilla team to the CC. The patch is still working, but if it=E2=80=99s unnecessary, I can just close the thr= ead. =2D-=20 Best regards, Aleksandr Vityazev --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHQEARYKAB0WIQT/cod8TyH8TUZ9IMTcy1JVIJi2wQUCZaB0JQAKCRDcy1JVIJi2 wY9tAP0Z1zzZRX6QQCkxe6Iwj0sE9LvaFrDIkFPPUNgTDXsCPgD4hduUALO6/CD5 XdYJLvuoM56FLkOjtRhxr877DDP6DQ== =y44t -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 02:32:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jan 2024 00:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Aleksandr Vityazev Cc: 66643@debbugs.gnu.org, jonathan.brielmaier@web.de Received: via spool by 66643-submit@debbugs.gnu.org id=B66643.170502053317556 (code B ref 66643); Fri, 12 Jan 2024 00:49:02 +0000 Received: (at 66643) by debbugs.gnu.org; 12 Jan 2024 00:48:53 +0000 Received: from localhost ([127.0.0.1]:34398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO5jB-0004Z6-CV for submit@debbugs.gnu.org; Thu, 11 Jan 2024 19:48:53 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:58533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO5j9-0004Yg-Dm for 66643@debbugs.gnu.org; Thu, 11 Jan 2024 19:48:52 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 609D73200AB5; Thu, 11 Jan 2024 19:48:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 11 Jan 2024 19:48:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1705020525; x=1705106925; bh=eO2JZP12qAlLOwlTZHB5R3EX84sKX1jAccLCs+5N0Ms=; b= JoSOIVZicOMwrtt6vD1uTZDMQdfkklcxHov10pJ7q9efxdvjZzI83s/XF4ndcMxw J+H2uSk1MQzT1s59S48uKVeEXUFoBg8OozzUCTr+D/5RcIY4rsAdZyjq/NbfAio/ 0VAH44uW+ooP/gy6mHs1673EqYWoZsqyk6sxXUTiniJqZ6wbwnhV4YwLX66PTQp4 E7N9ZovlJiU7RfCzpOUvF+kVsN1TRdh1STdZ/frJHEQ9ORa5UOsjQCvC8Xw7lm9S qxaxr02mIhANnKEnTU+lrU5VRKvZhF+813m1q3yAGOEzguN//wlLAK7WY7OEM52h Oj0qGLG3T5D57uP41lwcNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1705020525; x= 1705106925; bh=eO2JZP12qAlLOwlTZHB5R3EX84sKX1jAccLCs+5N0Ms=; b=d 8ySgB8kD8apQizcrZZ6dRrYzb5eFV3MTPwr8u109RZvuUbRm9BoRX0DP8Z7b0xd4 Yxi+zwE8yt8K7NwI0hDQQyqekAggz+YMVes64iAiDJbCRdahYNHtR8JqcaFwDqJR 8Nxq/lsIWe48Icd9ScR6zi2I+yU3BZHLCvuS7ccoj6bKrlf4W6V2RighjSukf8Gg yJxBuVZT2lg/XOFE27fjlSu080sTzAXfw+CDgXMAaHN8vaFo8DQa3F5VlOe26UMH /DZxw2UNoZRDkSiLcOLNpsMXkm1aoE/pFM8Qi/ke+j9sJdC3CXn7pPUh4AnX5k4y LvTGmzkjj+oj/P45r6PCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeigedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtgfesth hqredttderjeenucfhrhhomhepvehlrohmvghnthcunfgrshhsihgvuhhruceotghlvghm vghntheslhgrshhsihgvuhhrrdhorhhgqeenucggtffrrghtthgvrhhnpeegkeehfefftd efffeuveekgfffhfdtudfgudegueegvefgudetffdugfefhfejudenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghssh hivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Jan 2024 19:48:44 -0500 (EST) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <87ply7xyhm.fsf@gmail.com> (Aleksandr Vityazev's message of "Fri, 12 Jan 2024 02:05:09 +0300") References: <87bkcugyky.fsf@gmail.com> <87ply7xyhm.fsf@gmail.com> Date: Fri, 12 Jan 2024 01:48:39 +0100 Message-ID: <87mstbxtp4.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Jan 12 2024, Aleksandr Vityazev wrote: > Hi, > > Another month has passed since the last letter, I am sending another > ping, this time I added members of the mozilla team to the CC. The patch > is still working, but if it=E2=80=99s unnecessary, I can just close the t= hread. Hey Aleksandr, Sorry for not replying earlier. Wouldn't putting quotes around $@ (like \"$@\") be enough? Thanks, Cl=C3=A9ment From unknown Sat Sep 06 02:32:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program. Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jan 2024 04:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66643@debbugs.gnu.org, jonathan.brielmaier@web.de Received: via spool by 66643-submit@debbugs.gnu.org id=B66643.170503294317116 (code B ref 66643); Fri, 12 Jan 2024 04:16:02 +0000 Received: (at 66643) by debbugs.gnu.org; 12 Jan 2024 04:15:43 +0000 Received: from localhost ([127.0.0.1]:34552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO8xH-0004L0-7g for submit@debbugs.gnu.org; Thu, 11 Jan 2024 23:15:43 -0500 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:60756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO8xB-000427-QZ for 66643@debbugs.gnu.org; Thu, 11 Jan 2024 23:15:38 -0500 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2cd7e429429so28355631fa.1 for <66643@debbugs.gnu.org>; Thu, 11 Jan 2024 20:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705032930; x=1705637730; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=neATmHiRTmnDCNElsIl8xk/Ov1jWdwniSqRLl2VR0dQ=; b=HksPd5JgxIy1Gkd2vs89FRqwxCXjlo0yvbFpEjcILxVhsdfND08dY1Zw0Z2ZL5tLqU acMouqzqhoGpr4uemTyKXU5UCvv6rXeXeskVlCwcyngzqxwEst6BzNOgjsgb3R7ZxWq+ OxGSqgpePwDEs+CHRXWrQg0TJavxG/7OHGZz9653qnodFivr4whwdc1kc7x1pVixtj9r l3H/6l6tPBRmHOo536dQtnH39NPTXgM+yVJhDErN6ZE6iwsZ4fs4p4uXq5R28T8qw/IH HNkj7Ct8KUxe3CL/vkVGVBUwiMfg5v48RXcVgZ9O1tfBNvGgkP2jCo7py/VQUmuyN+36 ARdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705032930; x=1705637730; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=neATmHiRTmnDCNElsIl8xk/Ov1jWdwniSqRLl2VR0dQ=; b=W/xVHhBU2VASCEOc2k6kjNTRgEnxMycOm7PqnWSrlQcgRJQ4M+FS7G5GQK865DFqqX t1eMRujGleWUZj7pfBtpk26bdjER4SkqMSfRCrY/AHVXtANCbbx7IgUIPNPLV8hE0rzR 3KS8TmqIx4tyozt1W4aslkpOPF7GF1eH5JWF50Tj9gUdGW5WPBa98DNwOgO3qrK/kRzH fNVpoS1KTVKscBPjKQFcnbTqMrnN2itC5o4rKubPw6wZt6jqmOB3uDecqIPErfmN70kx tr+WILNVZHDrly8O8s70IsIkyE9ZkfLroVcWiNgnIYE9xZqIAUBQPWZjhj52zhSp35F+ mCKg== X-Gm-Message-State: AOJu0YxicMTHxxfTjycKa4SkPIxxVLVftsoaoPAWXSCwWfL4Um7gZ/2x IcmSiUin/5fbuoYw0Cf43gQ= X-Google-Smtp-Source: AGHT+IF0U3+A3w4QOpwrgKbIsk4SS/uls6e+55BeugzB3KGR/SBAprx0584pYCminA5+1dG5lqgZSA== X-Received: by 2002:a2e:920f:0:b0:2cc:c794:57d0 with SMTP id k15-20020a2e920f000000b002ccc79457d0mr380890ljg.70.1705032929746; Thu, 11 Jan 2024 20:15:29 -0800 (PST) Received: from localhost (host-143-154-66-217.spbmts.ru. [217.66.154.143]) by smtp.gmail.com with ESMTPSA id r1-20020a2eb601000000b002ccb9f5ffcasm332464ljn.93.2024.01.11.20.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 20:15:29 -0800 (PST) From: Aleksandr Vityazev In-Reply-To: <87mstbxtp4.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Fri, 12 Jan 2024 01:48:39 +0100") References: <87bkcugyky.fsf@gmail.com> <87ply7xyhm.fsf@gmail.com> <87mstbxtp4.fsf@lassieur.org> Date: Fri, 12 Jan 2024 07:15:23 +0300 Message-ID: <87le8vxk4k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-01-12 01:48, Cl=C3=A9ment Lassieur wrote: > On Fri, Jan 12 2024, Aleksandr Vityazev wrote: > >> Hi, >> >> Another month has passed since the last letter, I am sending another >> ping, this time I added members of the mozilla team to the CC. The patch >> is still working, but if it=E2=80=99s unnecessary, I can just close the = thread. > > Hey Aleksandr, > > Sorry for not replying earlier. there's no need to apologize, it's okay. I often forget to add team members in the CC field of an email. > > Wouldn't putting quotes around $@ (like \"$@\") be enough? > both options solve the problem, the proposed one is simpler, so you can choose this one. I will send v2 patch in the next mail. --=20 Best regards, Aleksandr Vityazev From unknown Sat Sep 06 02:32:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66643] [PATCH v2] gnu: icedove/wayland: Use escaped "$@" in the executable References: <87bkcugyky.fsf@gmail.com> In-Reply-To: <87bkcugyky.fsf@gmail.com> Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Jan 2024 04:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66643@debbugs.gnu.org Cc: jonathan.brielmaier@web.de, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66643-submit@debbugs.gnu.org id=B66643.17050339441930 (code B ref 66643); Fri, 12 Jan 2024 04:33:01 +0000 Received: (at 66643) by debbugs.gnu.org; 12 Jan 2024 04:32:24 +0000 Received: from localhost ([127.0.0.1]:34562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO9DU-0000V4-C5 for submit@debbugs.gnu.org; Thu, 11 Jan 2024 23:32:24 -0500 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:48617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO9DQ-0000Un-Vw for 66643@debbugs.gnu.org; Thu, 11 Jan 2024 23:32:23 -0500 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2cd65f803b7so45588981fa.1 for <66643@debbugs.gnu.org>; Thu, 11 Jan 2024 20:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705033937; x=1705638737; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=HkHriA+QIdkx/T3lx58XbAAFMUXN90KBtsugQcAqBUw=; b=nOaB161zmKUHthq95vcWtg6QF4PBAK1C0RaoJpZF7mltyDkvImqwuQFQYi0uCiQi9a etI5mHyAQOzje89vbVzd88WUb2tu3Dhrhn04lsVl1DbuERjzPrFrLzW6tcxgrYup167F qOFv6KWMx4KQZkBxve3I8nrywmPbWyVXdQhSIpxBHiyf1G9VRdQ22x0kCwot70ncIKV4 ussmHfKXH0hQu772l8xla9iSMu4TdezJpiEPz+p87iaPYE8Yc8bO1s7MYe/Kw2qkAx5e bAlwj3kPkIzR3UaSeYT1XbibSN5c6OWRSCgcIYPZDulW3NAidE87i/NA+D26T4bVxty9 we0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705033937; x=1705638737; h=mime-version:user-agent:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HkHriA+QIdkx/T3lx58XbAAFMUXN90KBtsugQcAqBUw=; b=un3GjZVswRgqlL9bNcrYLO6uleDHDuZEDaGnDLFRr2GPA1Q48zWD6nygdABNrc44cv NyGNqGgl94RUJBgbIKeC6Mc5Wsjk+p/z7n6pOEQyHchkZcnJS/JtK/25TrgXYLNtuVVv 64ZuT1H7cSkaSrO8f5m49fzf/8RFu9PWDTl4Jpxmz8dhsLAZOQ2qj2tWNRJZedR/4Pv8 mnh/bXAWhTEAmK9ob1/5lhEKeSnUOVtxmhtPoT8iR6BOaFKhjcqeyYTH2AVLpTl7bp+e w5eA7hhrKBHibhLTpYEEn6Zo7wewO/fHNr5MjRSetxIxBQsGtC/uA0Dvh+dUKboLGS3a E9+w== X-Gm-Message-State: AOJu0Yxk+8V6bgg1vwz0P2hCjp6Kxlk7ypGDwAUJIbYOlw9+/TR1HiDx hNbWYPlu8JOwEfAA8oRmB2IKtwcWts8= X-Google-Smtp-Source: AGHT+IFJZn3LzEE1bKjDdAxBQG7MZyIGt+G2IQtBKYI0Yw4R1plsrstlPycnRYaWSyfIE7+6YuvR7g== X-Received: by 2002:a19:8c58:0:b0:50e:812c:1acf with SMTP id i24-20020a198c58000000b0050e812c1acfmr302802lfj.113.1705033936955; Thu, 11 Jan 2024 20:32:16 -0800 (PST) Received: from localhost (host-143-154-66-217.spbmts.ru. [217.66.154.143]) by smtp.gmail.com with ESMTPSA id u10-20020ac258ca000000b0050e5ae6243dsm380002lfo.295.2024.01.11.20.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 20:32:16 -0800 (PST) From: Aleksandr Vityazev Date: Fri, 12 Jan 2024 07:32:05 +0300 Message-ID: <87h6jjxjcq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/gnuzilla (icedove/wayland): Use escaped "$@" in the executable script. --- gnu/packages/gnuzilla.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 188aa02293..7caa044f83 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -2091,7 +2091,7 @@ (define-public icedove/wayland (call-with-output-file exe (lambda (port) (format port "#!~a - MOZ_ENABLE_WAYLAND=1 exec ~a $@" +MOZ_ENABLE_WAYLAND=1 exec ~a \"$@\"" #$(file-append bash-minimal "/bin/bash") #$(file-append icedove "/bin/icedove")))) (chmod exe #o555) -- 2.41.0 -- Best regards, Aleksandr Vityazev From unknown Sat Sep 06 02:32:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Aleksandr Vityazev Subject: bug#66643: closed (Re: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program.) Message-ID: References: <87v87y3gp9.fsf@lassieur.org> <87bkcugyky.fsf@gmail.com> X-Gnu-PR-Message: they-closed 66643 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 66643@debbugs.gnu.org Date: Fri, 12 Jan 2024 12:01:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1705060862-8636-1" This is a multi-part message in MIME format... ------------=_1705060862-8636-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66643: [PATCH] gnu: icedove/wayland: Use wrap-program. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66643@debbugs.gnu.org. --=20 66643: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66643 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1705060862-8636-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66643-done) by debbugs.gnu.org; 12 Jan 2024 12:00:02 +0000 Received: from localhost ([127.0.0.1]:35062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOGCf-0000WG-U8 for submit@debbugs.gnu.org; Fri, 12 Jan 2024 07:00:02 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOGCc-0000VL-00 for 66643-done@debbugs.gnu.org; Fri, 12 Jan 2024 07:00:00 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 902BD5C01F0; Fri, 12 Jan 2024 06:59:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 12 Jan 2024 06:59:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1705060792; x=1705147192; bh=wSyCQw6nLZ1O27XsrXYpVq1RNBHPHJ0gzcCHCvkNHT4=; b= jYqmoQWFrlaRDXWKD6i085unHHGyOEjgZKDOCI8VBdgF1Sgbe3UU5h1JsDTLBu6/ l5J9Bz4v9FilGfJnqlDXLurV7FnTayDjVMCi9alVyTxvfK/8SJEMxsNt0pUYVnfW DjYzax5KV1Q/EVUFeZ55WIIhX3He5MjBDMrT3ty3NiBj/wRj5X59g+53jykqSHyA aG9WbTM447QgEuN4cIBg3kbv5JBltJK3JFpS+2HKjDzyaf2pcWmo1f9D671dS50I SSsioOmCm4Zcdpwv2a4uNgDsFggtZbeoiDmhB7/bCbTBqVyOqIE03XLgA8jAQmu+ leZS3Zs5394xfHKglo5SSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1705060792; x= 1705147192; bh=wSyCQw6nLZ1O27XsrXYpVq1RNBHPHJ0gzcCHCvkNHT4=; b=A gZIWKKSCcjZl1gkrOR4LJUYSGelMvXpL6b5Mct+wdczpD1Y/XaleNeA96Lze15Wo rITPOY7N9+jVCJ14Gvwz2HLtW/9BI5FG9mFlYhWwTo+Cpv7nVYcB988GufADfkka Zhz4VmJ33b7jsN7Eqrxf/h+QL/SDYezGcHuyeIDH8LmwQcSb6MNrWGyo97dZkBLN vtZCi+Joh63eMqPv/qPdDFLQfvTn8ss3dTlgwiiWVuvRs5jg8qL93H0bV0wNtAH3 XBiJG+1zN9mUMUxSrpm78G40t48EgWZW+AAJselUjAcAIQ87UdDWA6Dj9VN2gzlo Qtr1T66FjcQQC7pQk1eZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeihedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtgfesth hqredttderjeenucfhrhhomhepvehlrohmvghnthcunfgrshhsihgvuhhruceotghlvghm vghntheslhgrshhsihgvuhhrrdhorhhgqeenucggtffrrghtthgvrhhnpeegkeehfefftd efffeuveekgfffhfdtudfgudegueegvefgudetffdugfefhfejudenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghssh hivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Jan 2024 06:59:50 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Aleksandr Vityazev Subject: Re: [bug#66643] [PATCH] gnu: icedove/wayland: Use wrap-program. In-Reply-To: <87le8vxk4k.fsf@gmail.com> (Aleksandr Vityazev's message of "Fri, 12 Jan 2024 07:15:23 +0300") References: <87bkcugyky.fsf@gmail.com> <87ply7xyhm.fsf@gmail.com> <87mstbxtp4.fsf@lassieur.org> <87le8vxk4k.fsf@gmail.com> Date: Fri, 12 Jan 2024 12:59:46 +0100 Message-ID: <87v87y3gp9.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66643-done Cc: 66643-done@debbugs.gnu.org, jonathan.brielmaier@web.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Jan 12 2024, Aleksandr Vityazev wrote: > On 2024-01-12 01:48, Cl=C3=A9ment Lassieur wrote: > >> On Fri, Jan 12 2024, Aleksandr Vityazev wrote: >> >>> Hi, >>> >>> Another month has passed since the last letter, I am sending another >>> ping, this time I added members of the mozilla team to the CC. The patch >>> is still working, but if it=E2=80=99s unnecessary, I can just close the= thread. >> >> Hey Aleksandr, >> >> Sorry for not replying earlier. > > there's no need to apologize, it's okay. I often forget to add team > members in the CC field of an email. > >> >> Wouldn't putting quotes around $@ (like \"$@\") be enough? >> > > both options solve the problem, the proposed one is simpler, so you can > choose this one. I will send v2 patch in the next mail. Ok, the simpler the better! Pushed, thanks. ------------=_1705060862-8636-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Oct 2023 20:14:19 +0000 Received: from localhost ([127.0.0.1]:37906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtZPO-00067O-Gz for submit@debbugs.gnu.org; Thu, 19 Oct 2023 16:14:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtZPK-000674-GO for submit@debbugs.gnu.org; Thu, 19 Oct 2023 16:14:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtZOn-0006jm-Rr for guix-patches@gnu.org; Thu, 19 Oct 2023 16:13:41 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtZOl-0005xY-TE for guix-patches@gnu.org; Thu, 19 Oct 2023 16:13:41 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507c91582fdso56983e87.2 for ; Thu, 19 Oct 2023 13:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697746417; x=1698351217; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9xJPD8YfM96d5X2gKD+IXWVfs7Buv4vF4Ad8bGkkbdw=; b=BAa796FO5cVM5K0rxBv1LfwmxSXE4WAvpiNCSomIMBuRk9Fnlw0fqrVP+neFWmScmC 01VEh8AbvPQsrF5zwth3vR5+5rflh2U3aNmJ5iA4B0Af/t2V2zDNSK+ff7QDVX5ROrVu JmPepgbu9cXTV8GmONgfc4ihIOf9tss6sETGVJOAnXuS2yUI5idFdvibmJh1u/E9hkbH TBqxOJJGvdJTf31dw2FaCH6f7RCBS9bQiwagqRJ0QplTxwqzKR8tS1MFdrS7/lyjlBcV KzYVspq1FpZCNpAJqOZz3MQnfwdq+cP1W0b0Ugv+ZKLhUk5qaQPRIjRdVbtWA5B1ERc3 DRCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697746417; x=1698351217; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9xJPD8YfM96d5X2gKD+IXWVfs7Buv4vF4Ad8bGkkbdw=; b=GoVGsol3E5IulNervn6WrQ2KsqpuK05qBZWag033Y93Zb3nIWL/6JTWy3bb8PMoXQm VfCJm7fryZEuAZ1sfI0Y02EG6LbQqUSnRDhJ7SckCHyHeg6Zb4OQc0I71+lKWHq1oWzp r2wPcMhDZ9zGhszQevpRtpAQxMEm5J1e7RuuVULE5j+uqawUgCtpHv8s4GNx4x3JOMyy Hoo/1JBVsQOrDe/g3nDD8CHiftv+q/iFnP+EkRe1PJIAeut8S39NjYJevVTNqyDHy/zC Gd37Zekpls25wkNvGAl7AFGuvToI8h4egCvbMXsa4jH7dasr5Gp+4Vx/tJebPPZOmmnQ GhzQ== X-Gm-Message-State: AOJu0YyZRjp/a3lDgypYxMbQ8x21prel2YX838IWEqPee8+dPVjetatc zcqBGCDesn7tWvL+3G8BAMxSDnBKstk= X-Google-Smtp-Source: AGHT+IEbgtdXTlmazuT6AUUzLZd19GNCmPcjYkG9ewzGjy6ct2g9j1PGwOB3ULrt8w1F8wEGAYb/Eg== X-Received: by 2002:ac2:4c0e:0:b0:507:aa44:28fa with SMTP id t14-20020ac24c0e000000b00507aa4428famr2392765lfq.26.1697746416886; Thu, 19 Oct 2023 13:13:36 -0700 (PDT) Received: from magi ([176.59.3.85]) by smtp.gmail.com with ESMTPSA id g2-20020ac25382000000b00503189d8b8csm24286lfh.198.2023.10.19.13.13.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2023 13:13:36 -0700 (PDT) From: Aleksandr Vityazev To: guix-patches@gnu.org Subject: [PATCH] gnu: icedove/wayland: Use wrap-program. Date: Thu, 19 Oct 2023 23:13:33 +0300 Message-ID: <87bkcugyky.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=avityazew@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, When $@ is used in a bash script without escaping, it causes files with spaces in the name to fail to open. This patch fixes this for icedove-wayland. You can also see this kind of thing in qemu. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (avityazew[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: submit Cc: ivan-p-sokolov@ya.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, When $@ is used in a bash script without escaping, it causes files with spaces in the name to fail to open. This patch fixes this for icedove-wayland. You can also see this kind of thing in qemu. https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/virtualization= .scm?h=3Dmaster#n417 I don't think you should use wrap-program there. WDYT? * gnu/packages/gnuzilla (icedove/wayland): Use wrap-program, since "$@" must be escaped. Thanks to ivan-p-sokolov@ya.ru for noticing the issue! --- gnu/packages/gnuzilla.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index a367d7a00f..7a71fc8cb9 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -20,6 +20,7 @@ ;;; Copyright =C2=A9 2021, 2022, 2023 Maxim Cournoyer ;;; Copyright =C2=A9 2021 Baptiste Strazzul ;;; Copyright =C2=A9 2022 SeerLite +;;; Copyright =C2=A9 2023 Aleksandr Vityazev ;;; ;;; This file is part of GNU Guix. ;;; @@ -2076,14 +2077,11 @@ (define-public icedove/wayland #~(begin (use-modules (guix build utils)) (let* ((exe (string-append #$output "/bin/icedove"))) - (mkdir-p (dirname exe)) - (call-with-output-file exe - (lambda (port) - (format port "#!~a - MOZ_ENABLE_WAYLAND=3D1 exec ~a $@" - #$(file-append bash-minimal "/bin/bash") - #$(file-append icedove "/bin/icedove")))) - (chmod exe #o555) + (install-file #$(file-append icedove "/bin/icedove") + (string-append #$output "/bin")) + (wrap-program exe + #:sh #$(file-append bash-minimal "/bin/bash") + '("MOZ_ENABLE_WAYLAND" "" =3D ("1"))) ;; Provide the manual and .desktop file. (copy-recursively (string-append #$icedove "/share") (string-append #$output "/share")) base-commit: c065da01ff956d3c2bdfc45a33d910e509a211d9 prerequisite-patch-id: ec4a09723b91089c8eb5b5269ae81272bb4d81b4 prerequisite-patch-id: 9680399593e3dcdb5b10ee646023efd1215942d9 prerequisite-patch-id: 66497a0079d0077e7b5001707d8211c525ea7193 prerequisite-patch-id: 4f512542ae5806d47054e063e3dd1df66258c530 prerequisite-patch-id: 48abb1e84ca8d85b23794222f8fa5b4d2dfa4699 prerequisite-patch-id: a7fdd2f87131ad73865389152d4a826df24fcae7 prerequisite-patch-id: 1600413a45a50114906f4390653c3fbb7f536a4c prerequisite-patch-id: 51e95882782a53eda933e884fb5e80487ba52b9f prerequisite-patch-id: 177b2873f4e77585c464ac3d24bec78d58f128bd prerequisite-patch-id: 631a6785018f999fcbf7e22fb8e2aae9329ced55 prerequisite-patch-id: 1bd1b328f9e3c7119fed731ffd7e7d87ac33f0c2 prerequisite-patch-id: 79105270952c22f07255cb315da1db44f505b07b prerequisite-patch-id: 9c5af3baa3dac6233837fb6eb0b7467b969caff4 prerequisite-patch-id: 1156b461c8622b5071656309b05c026abab0f277 prerequisite-patch-id: 8a5e3746b5092496884d50ef4359148ac9349a83 prerequisite-patch-id: 579e44cb67db2d0d3c6232c7c306457a0b5a1a27 prerequisite-patch-id: f5dc3c2782749512e23becb166db7aafacd0be1f prerequisite-patch-id: 41717fac7367d7e596c093548408ab4bb7d11575 prerequisite-patch-id: 82761b9bede107314f9e75282e1851da281e1d53 prerequisite-patch-id: 4eaffd8b1788833c76590916476337e55ae234b0 prerequisite-patch-id: b501999eff4662ed2917dba3b934abd1a5e2252a prerequisite-patch-id: d2b947c72b82c6366d8164f1d732a4d25c6cb4fa prerequisite-patch-id: e1df80a774d3de676f01f262c68f506b0bc1ed92 prerequisite-patch-id: 1e2e9dfb8051b74814d7711e0247674a20329b1e prerequisite-patch-id: 3dc346b9df988744c17f4c810753d8afcb00a642 prerequisite-patch-id: e2c517c1181b6b34eda2f660985dd6db280d886f prerequisite-patch-id: cf256fc20be65ced1f1486423f4bbea768d686ae prerequisite-patch-id: 4c8c9425dae8a721016c4e0e7ed9c2fbe3556d9e prerequisite-patch-id: fb5c2f33b0ee041a46c6025d04271c3dbdb53d15 prerequisite-patch-id: c9d2a6a24a622955395ad090a0eb22598c16b23d prerequisite-patch-id: eeeefc7040171849bdaa2c9cd9f47731c80287ea prerequisite-patch-id: 56c4e80a78ecd8514c5d96c4492925ad57d4dd14 prerequisite-patch-id: ebee5547a41485f7ca26f93609f53ade60601f3f prerequisite-patch-id: 9c816f74d4166f1be0964ea0ef27d602495cd9bb prerequisite-patch-id: faae90b478e36eb4f2f17bde8782032b30e2e4db prerequisite-patch-id: bf26fe3d5e2082445217490ec635e6e85b65247f prerequisite-patch-id: 1722a64febdad4cfaff4a22c44d9661fcf0b6a5a prerequisite-patch-id: a50461c3f84736992a9fdcc23c36920a6555d567 prerequisite-patch-id: 6dec4cc56ec808267f99ac5f1be941fabb28e126 prerequisite-patch-id: 741be4e6b815c817ceedff55ea6da159e5050524 --=20 2.41.0 --=20 Best regards, Aleksandr Vityazev ------------=_1705060862-8636-1--