GNU bug report logs - #66636
Move lexical-binding warning from checkdoc to byte-compiler

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Date: Thu, 19 Oct 2023 11:50:01 UTC

Severity: normal

Done: Mattias Engdegård <mattias.engdegard <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66636: closed (Move lexical-binding warning from checkdoc to
 byte-compiler)
Date: Sat, 21 Oct 2023 13:19:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 21 Oct 2023 15:17:22 +0200
with message-id <A16FDF04-48A8-416A-8340-FEF96C524465 <at> gmail.com>
and subject line Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler
has caused the debbugs.gnu.org bug report #66636,
regarding Move lexical-binding warning from checkdoc to byte-compiler
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66636: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66636
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Subject: Move lexical-binding warning from checkdoc to byte-compiler
Date: Thu, 19 Oct 2023 13:48:21 +0200
[Message part 3 (text/plain, inline)]
The warning about a missing lexical-binding cookie rather belongs in the compiler than checkdoc, because it's not about documentation or style but code generation and ability to detect errors, both which are hindered by a missing cookie.

Moving the warning to the compiler also makes it more widely seen.

[0001-Move-lexical-binding-warning-from-checkdoc-to-byte-c.patch (application/octet-stream, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Po Lu <luangruo <at> yahoo.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 66636-done <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to
 byte-compiler
Date: Sat, 21 Oct 2023 15:17:22 +0200
21 okt. 2023 kl. 13.17 skrev Eli Zaretskii <eliz <at> gnu.org>:

> If specifying lexical-binding:nil in the first line is the solution
> for those who want to keep dynamically-bound code, then yes, it should
> be definitely in NEWS, and probably also in the ELisp manual.

Agreed on both points. The patch has been pushed with that change to NEWS, and Elisp manual revisions are upcoming.  We are a bit behind on lexical-binding in the manual so it could do with some more work.

Thanks to everyone who commented!



This bug report was last modified 1 year and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.