From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 07:49:11 2023 Received: (at submit) by debbugs.gnu.org; 19 Oct 2023 11:49:11 +0000 Received: from localhost ([127.0.0.1]:35955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtRWZ-0004Pp-Ai for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:49:11 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtRWV-0004Og-EH for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:49:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtRVu-0000oU-0N for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 07:48:32 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtRVs-0003Jp-3B for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 07:48:29 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507973f3b65so10138214e87.3 for ; Thu, 19 Oct 2023 04:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697716103; x=1698320903; darn=gnu.org; h=to:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=XZrHtNE2O7LuXE5T39T9MORhyBhl4EGmLyicKuWceSk=; b=Cd+7DGh13Fqz4k0GGvL8OPJnozyXugYetFoA/hrgf6vQWBudcoIiGpNrHr5lsVoGT3 pO0oj+x9Arb+29sD9PejEcrrhsnrla0gkzBIINy7RE3LlmEDVMAlOTbeHNdtiXhIyD5C byZBy7026JWuIblYB94fiCsSuYAVR5y31T0XXOxc9vpiuYXjjr0MLVOJ6MUnV3Srv2RY 5nKOVpZeiU1DIMEvh1xPYSLRaRRvDZF6pNc8vF0M+NmrieIXiDxh6mg/kGgot0KbWpAP 3Bw9IMeUBKUN77cC2zfpLJvoFlfe7rj2eZdbAJrgaU6ovyRa4TFpJYY2/viEiHn5Kaea AbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697716103; x=1698320903; h=to:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XZrHtNE2O7LuXE5T39T9MORhyBhl4EGmLyicKuWceSk=; b=eXDo8MenwsseYFOFq7DjgI5PBhgsJRkT3kmb4cKgSzem5oDs1WM4ysyDJWX+Fhx2/T FDnQVVa4Mgib9DUxCUNwVYhTpsrzfqFbALTwmMXOYz3bqfs/oW7Pbx/4a7tLG66YIy9Q WlgHBYtNiSNPzujuJtJl0a6y8HR7GeZkWerI0WzB5Jojt8CS1GANb3wUb+JpY2mj59hM YivmdhSQVe67h1IvMrOuNlIxRRN/yQg9gLviFGRkBZdAVCyDn6ki3xiVoE9cFZUGkVUy o7vfOVT88YbHAlLogQqjAN4RWc0k1IOFGlzGiikExFeVguUVDllSgIr+cQASN6L8qiUf liuQ== X-Gm-Message-State: AOJu0YzY5/qHnamqQnZP1H0SJumBKTVOUSZhyYuM5nhNzyQRkEh1SWli adGRrZn4MACTe4gNHrCuQo7HgaHm2jgqyg== X-Google-Smtp-Source: AGHT+IFMvydc7cBJRXZb1bqbo6FjNqIWAsMHgBSPTGKLdS/dRVmSvzNg5NUj0sYQTQUTFuUNXxR8Yw== X-Received: by 2002:a05:6512:159d:b0:507:b922:f920 with SMTP id bp29-20020a056512159d00b00507b922f920mr1505832lfb.8.1697716102790; Thu, 19 Oct 2023 04:48:22 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id e13-20020a05651236cd00b004ff973cb14esm1064375lfs.108.2023.10.19.04.48.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2023 04:48:22 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_1B23E174-97EC-4B15-B787-A6600272D218" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Move lexical-binding warning from checkdoc to byte-compiler Message-Id: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> Date: Thu, 19 Oct 2023 13:48:21 +0200 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_1B23E174-97EC-4B15-B787-A6600272D218 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The warning about a missing lexical-binding cookie rather belongs in the = compiler than checkdoc, because it's not about documentation or style = but code generation and ability to detect errors, both which are = hindered by a missing cookie. Moving the warning to the compiler also makes it more widely seen. --Apple-Mail=_1B23E174-97EC-4B15-B787-A6600272D218 Content-Disposition: attachment; filename=0001-Move-lexical-binding-warning-from-checkdoc-to-byte-c.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Move-lexical-binding-warning-from-checkdoc-to-byte-c.patch" Content-Transfer-Encoding: quoted-printable =46rom=206887fadd1c262954303d706d0d556bef4b5148c5=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2015=20Oct=202023=2022:01:06=20+0200=0A= Subject:=20[PATCH]=20Move=20lexical-binding=20warning=20from=20checkdoc=20= to=20byte-compiler=0A=0AThis=20warning=20is=20much=20more=20appropriate=20= for=20the=20compiler,=20since=20lexical=0Abinding=20affects=20what=20it=20= can=20reason=20and=20warn=20about,=20than=20for=20checkdoc=0Aas=20the=20= warning=20has=20no=20bearing=20to=20documentation=20at=20all.=0AThe=20= move=20also=20improves=20the=20reach=20of=20the=20warning.=0A=0A*=20= etc/NEWS:=20Update.=0A*=20lisp/emacs-lisp/checkdoc.el=20= (checkdoc-lexical-binding-flag)=0A(checkdoc-file-comments-engine):=20= Move=20warning=20from=20here....=0A*=20lisp/emacs-lisp/bytecomp.el=20= (byte-compile-file):=20...to=20here.=0A*=20= test/lisp/emacs-lisp/bytecomp-resources/no-byte-compile.el:=0A*=20= test/lisp/emacs-lisp/bytecomp-tests.el=0A= (bytecomp-tests--unescaped-char-literals)=0A= (bytecomp-tests-function-put,=20bytecomp-tests--not-writable-directory)=0A= (bytecomp-tests--target-file-no-directory):=0AUpdate=20tests.=0A= (bytecomp-tests--log-from-compilation)=0A= (bytecomp-tests--lexical-binding-cookie):=20New=20test.=0A---=0A=20= etc/NEWS=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=2025=20++++++++----=0A=20= lisp/emacs-lisp/bytecomp.el=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20|=20=204=20++=0A=20lisp/emacs-lisp/checkdoc.el=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20|=2039=20-------------------=0A=20= .../bytecomp-resources/no-byte-compile.el=20=20=20=20=20|=20=202=20+-=0A=20= test/lisp/emacs-lisp/bytecomp-tests.el=20=20=20=20=20=20=20=20|=2039=20= +++++++++++++++++--=0A=205=20files=20changed,=2057=20insertions(+),=2052=20= deletions(-)=0A=0Adiff=20--git=20a/etc/NEWS=20b/etc/NEWS=0Aindex=20= 02b794a2964..e7f51e1c6c4=20100644=0A---=20a/etc/NEWS=0A+++=20b/etc/NEWS=0A= @@=20-845,14=20+845,6=20@@=20This=20can=20help=20avoid=20some=20awkward=20= skip=20conditions.=20=20For=20example=0A=20'(skip-unless=20(not=20= noninteractive))'=20can=20be=20changed=20to=20the=20easier=0A=20to=20= read=20'(skip-when=20noninteractive)'.=0A=20=0A-**=20Checkdoc=0A-=0A----=0A= -***=20New=20checkdock=20warning=20if=20not=20using=20lexical-binding.=0A= -Checkdoc=20now=20warns=20if=20the=20first=20line=20of=20an=20Emacs=20= Lisp=20file=20does=20not=0A-end=20with=20a=20"-*-=20lexical-binding:=20t=20= -*-"=20cookie.=20=20Customize=20the=20user=0A-option=20= 'checkdoc-lexical-binding-flag'=20to=20nil=20to=20disable=20this=20= warning.=0A-=0A=20**=20URL=0A=20=0A=20+++=0A@@=20-1153,6=20+1145,23=20@@=20= sexp-related=20motion=20commands.=0A=20=0A=20**=20New=20or=20changed=20= byte-compilation=20warnings=0A=20=0A+---=0A+***=20Warn=20about=20missing=20= 'lexical-binding'=20directive.=0A+The=20compiler=20now=20warns=20if=20an=20= Elisp=20file=20lacks=20the=20standard=0A+'-*-=20lexical-binding:=20...=20= -*-'=20cookie=20on=20the=20first=20line.=0A+This=20line=20typically=20= looks=20something=20like=0A+=0A+=20=20=20=20;;;=20My=20little=20pony=20= mode=20=20-*-=20lexical-binding:=20t=20-*-=0A+=0A+It=20is=20needed=20to=20= inform=20the=20compiler=20about=20which=20dialect=20of=20ELisp=0A+your=20= code=20is=20using:=20the=20modern=20dialect=20with=20lexical=20binding=20= or=0A+the=20old=20dialect=20with=20only=20dynamic=20binding.=0A+=0A= +Lexical=20binding=20avoids=20some=20name=20conflicts=20and=20allows=20= the=20compiler=0A+to=20detect=20more=20mistakes=20and=20generate=20more=20= efficient=20code.=20=20To=20adapt=0A+your=20code=20to=20lexical=20= binding,=20see=20the=20"(elisp)=20Converting=20to=20Lexical=0A+Binding"=20= node=20in=20the=20manual.=0A+=0A=20---=0A=20***=20Warn=20about=20empty=20= bodies=20for=20more=20special=20forms=20and=20macros.=0A=20The=20= compiler=20now=20warns=20about=20an=20empty=20body=20argument=20to=20= 'when',=0Adiff=20--git=20a/lisp/emacs-lisp/bytecomp.el=20= b/lisp/emacs-lisp/bytecomp.el=0Aindex=2092abe6b4624..cc68db73c9f=20= 100644=0A---=20a/lisp/emacs-lisp/bytecomp.el=0A+++=20= b/lisp/emacs-lisp/bytecomp.el=0A@@=20-2201,6=20+2201,10=20@@=20= byte-compile-file=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= filename=20buffer-file-name))=0A=20=20=20=20=20=20=20;;=20Don't=20= inherit=20lexical-binding=20from=20caller=20(bug#12938).=0A=20=20=20=20=20= =20=20(unless=20(local-variable-p=20'lexical-binding)=0A+=20=20=20=20=20=20= =20=20(let=20((byte-compile-current-buffer=20(current-buffer)))=0A+=20=20= =20=20=20=20=20=20=20=20(byte-compile-warn-x=0A+=20=20=20=20=20=20=20=20=20= =20=20(position-symbol=20'a=20(point-min))=0A+=20=20=20=20=20=20=20=20=20= =20=20"file=20has=20no=20`lexical-binding'=20directive=20on=20its=20= first=20line"))=0A=20=20=20=20=20=20=20=20=20(setq-local=20= lexical-binding=20nil))=0A=20=20=20=20=20=20=20;;=20Set=20the=20default=20= directory,=20in=20case=20an=20eval-when-compile=20uses=20it.=0A=20=20=20=20= =20=20=20(setq=20default-directory=20(file-name-directory=20filename)))=0A= diff=20--git=20a/lisp/emacs-lisp/checkdoc.el=20= b/lisp/emacs-lisp/checkdoc.el=0Aindex=20440e133f44b..471a2fbdf48=20= 100644=0A---=20a/lisp/emacs-lisp/checkdoc.el=0A+++=20= b/lisp/emacs-lisp/checkdoc.el=0A@@=20-128,14=20+128,6=20@@=0A=20;;=20= simple=20style=20rules=20to=20follow=20which=20checkdoc=20will=20= auto-fix=20for=20you.=0A=20;;=20`y-or-n-p'=20and=20`yes-or-no-p'=20= should=20also=20end=20in=20"?".=0A=20;;=0A-;;=20Lexical=20binding:=0A-;;=0A= -;;=20=20=20We=20recommend=20always=20using=20lexical=20binding=20in=20= new=20code,=20and=0A-;;=20converting=20old=20code=20to=20use=20it.=20=20= Checkdoc=20warns=20if=20you=20don't=20have=0A-;;=20the=20recommended=20= string=20"-*-=20lexical-binding:=20t=20-*-"=20at=20the=20top=20of=0A-;;=20= the=20file.=20=20You=20can=20disable=20this=20check=20with=20the=20user=20= option=0A-;;=20`checkdoc-lexical-binding-flag'.=0A-;;=0A=20;;=20Adding=20= your=20own=20checks:=0A=20;;=0A=20;;=20=20=20You=20can=20experiment=20= with=20adding=20your=20own=20checks=20by=20setting=20the=0A@@=20-347,12=20= +339,6=20@@=20checkdoc-column-zero-backslash-before-paren=0A=20=20=20= :type=20'boolean=0A=20=20=20:version=20"28.1")=0A=20=0A-(defcustom=20= checkdoc-lexical-binding-flag=20t=0A-=20=20"Non-nil=20means=20generate=20= warnings=20if=20file=20is=20not=20using=20lexical=20binding.=0A-See=20= Info=20node=20`(elisp)=20Converting=20to=20Lexical=20Binding'=20for=20= more."=0A-=20=20:type=20'boolean=0A-=20=20:version=20"30.1")=0A-=0A=20;;=20= This=20is=20how=20you=20can=20use=20checkdoc=20to=20make=20mass=20fixes=20= on=20the=20Emacs=0A=20;;=20source=20tree:=0A=20;;=0A@@=20-2391,31=20= +2377,6=20@@=20checkdoc-file-comments-engine=0A=20=09=20=20=20=20=20=20= (point-min)=20(save-excursion=20(goto-char=20(point-min))=0A=20=09=09=09=09= =09=20=20(line-end-position))))=0A=20=09=20nil))=0A-=20=20=20=20=20=20= (when=20checkdoc-lexical-binding-flag=0A-=20=20=20=20=20=20=20=20(setq=0A= -=20=20=20=20=20=20=20=20=20err=0A-=20=20=20=20=20=20=20=20=20;;=20= Lexical=20binding=20cookie.=0A-=20=20=20=20=20=20=20=20=20(if=20(not=20= (save-excursion=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(save-restriction=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(goto-char=20(point-min))=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(narrow-to-region=20(point)=20= (pos-eol))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(re-search-forward=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(rx=20"-*-"=20(*=20(*=20nonl)=20";")=0A-=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (*=20space)=20"lexical-binding:"=20(*=20space)=20"t"=20(*=20space)=0A-=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(*=20";"=20(*=20nonl))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20"-*-")=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20nil=20t))))=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20(let=20((pos=20(save-excursion=20(goto-char=20= (point-min))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (goto-char=20(pos-eol))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (point))))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20= (checkdoc-y-or-n-p=20"There=20is=20no=20lexical-binding=20cookie!=20=20= Add=20one?")=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (progn=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (goto-char=20pos)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(insert=20"=20=20-*-=20lexical-binding:=20t=20-*-"))=0A-=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(checkdoc-create-error=0A-=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"The=20first=20line=20= should=20end=20with=20\"-*-=20lexical-binding:=20t=20-*-\""=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20pos=20(1+=20pos)=20t)))=0A-=20=20= =20=20=20=20=20=20=20=20=20nil)))=0A=20=20=20=20=20=20=20(setq=0A=20=20=20= =20=20=20=20=20err=0A=20=20=20=20=20=20=20=20(or=0Adiff=20--git=20= a/test/lisp/emacs-lisp/bytecomp-resources/no-byte-compile.el=20= b/test/lisp/emacs-lisp/bytecomp-resources/no-byte-compile.el=0Aindex=20= 00ad1947507..1de5cf66b66=20100644=0A---=20= a/test/lisp/emacs-lisp/bytecomp-resources/no-byte-compile.el=0A+++=20= b/test/lisp/emacs-lisp/bytecomp-resources/no-byte-compile.el=0A@@=20-1=20= +1=20@@=0A-;;=20-*-=20no-byte-compile:=20t;=20-*-=0A+;;=20-*-=20= no-byte-compile:=20t;=20lexical-binding:=20t;=20-*-=0Adiff=20--git=20= a/test/lisp/emacs-lisp/bytecomp-tests.el=20= b/test/lisp/emacs-lisp/bytecomp-tests.el=0Aindex=20= e644417c3d4..4aa555f1e92=20100644=0A---=20= a/test/lisp/emacs-lisp/bytecomp-tests.el=0A+++=20= b/test/lisp/emacs-lisp/bytecomp-tests.el=0A@@=20-1302,6=20+1302,30=20@@=20= bytecomp-tests--with-temp-file=0A=20=20=20=20=20=20=20=20(let=20((elc=20= (concat=20,file-name-var=20".elc")))=0A=20=20=20=20=20=20=20=20=20=20(if=20= (file-exists-p=20elc)=20(delete-file=20elc))))))=0A=20=0A+(defun=20= bytecomp-tests--log-from-compilation=20(source)=0A+=20=20"Compile=20the=20= string=20SOURCE=20and=20return=20the=20compilation=20log=20output."=0A+=20= =20(let=20((text-quoting-style=20'grave)=0A+=20=20=20=20=20=20=20=20= (byte-compile-log-buffer=20(generate-new-buffer=20"=20*Compile-Log*")))=0A= +=20=20=20=20(with-current-buffer=20byte-compile-log-buffer=0A+=20=20=20=20= =20=20(let=20((inhibit-read-only=20t))=20(erase-buffer)))=0A+=20=20=20=20= (bytecomp-tests--with-temp-file=20el-file=0A+=20=20=20=20=20=20= (write-region=20source=20nil=20el-file)=0A+=20=20=20=20=20=20= (byte-compile-file=20el-file))=0A+=20=20=20=20(with-current-buffer=20= byte-compile-log-buffer=0A+=20=20=20=20=20=20(buffer-string))))=0A+=0A= +(ert-deftest=20bytecomp-tests--lexical-binding-cookie=20()=0A+=20=20= (cl-flet=20((cookie-warning=20(source)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(string-search=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= "file=20has=20no=20`lexical-binding'=20directive=20on=20its=20first=20= line"=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (bytecomp-tests--log-from-compilation=20source))))=0A+=20=20=20=20(let=20= ((some-code=20"(defun=20my-fun=20()=2012)\n"))=0A+=20=20=20=20=20=20= (should-not=20(cookie-warning=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(concat=20";;;=20-*-lexical-binding:t-*-\n"=20= some-code)))=0A+=20=20=20=20=20=20(should-not=20(cookie-warning=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(concat=20";;;=20= -*-lexical-binding:nil-*-\n"=20some-code)))=0A+=20=20=20=20=20=20(should=20= (cookie-warning=20some-code)))))=0A+=0A=20(ert-deftest=20= bytecomp-tests--unescaped-char-literals=20()=0A=20=20=20"Check=20that=20= byte=20compiling=20warns=20about=20unescaped=20character=0A=20literals=20= (Bug#20852)."=0A@@=20-1310,7=20+1334,9=20@@=20= bytecomp-tests--unescaped-char-literals=0A=20=20=20=20=20=20=20=20=20= (byte-compile-debug=20t)=0A=20=20=20=20=20=20=20=20=20= (text-quoting-style=20'grave))=0A=20=20=20=20=20= (bytecomp-tests--with-temp-file=20source=0A-=20=20=20=20=20=20= (write-region=20"(list=20?)=20?(=20?;=20?\"=20?[=20?])"=20nil=20source)=0A= +=20=20=20=20=20=20(write-region=20(concat=20";;;=20= -*-lexical-binding:t-*-\n"=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20"(list=20?)=20?(=20?;=20?\"=20?[=20= ?])")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20nil=20= source)=0A=20=20=20=20=20=20=20(bytecomp-tests--with-temp-file=20= destination=0A=20=20=20=20=20=20=20=20=20(let*=20= ((byte-compile-dest-file-function=20(lambda=20(_)=20destination))=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(err=20(should-error=20= (byte-compile-file=20source))))=0A@@=20-1322,7=20+1348,9=20@@=20= bytecomp-tests--unescaped-char-literals=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20"`?\\]'=20expected!")))))))=0A=20=20=20=20=20;;=20But=20don't=20warn=20= in=20subsequent=20compilations=20(Bug#36068).=0A=20=20=20=20=20= (bytecomp-tests--with-temp-file=20source=0A-=20=20=20=20=20=20= (write-region=20"(list=201=202=203)"=20nil=20source)=0A+=20=20=20=20=20=20= (write-region=20(concat=20";;;=20-*-lexical-binding:t-*-\n"=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= "(list=201=202=203)")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20nil=20source)=0A=20=20=20=20=20=20=20= (bytecomp-tests--with-temp-file=20destination=0A=20=20=20=20=20=20=20=20=20= (let=20((byte-compile-dest-file-function=20(lambda=20(_)=20= destination)))=0A=20=20=20=20=20=20=20=20=20=20=20(should=20= (byte-compile-file=20source)))))))=0A@@=20-1330,6=20+1358,7=20@@=20= bytecomp-tests--unescaped-char-literals=0A=20(ert-deftest=20= bytecomp-tests-function-put=20()=0A=20=20=20"Check=20`function-put'=20= operates=20during=20compilation."=0A=20=20=20= (bytecomp-tests--with-temp-file=20source=0A+=20=20=20=20(insert=20=20= ";;;=20-*-lexical-binding:t-*-\n")=0A=20=20=20=20=20(dolist=20(form=20= '((function-put=20'bytecomp-tests--foo=20'foo=201)=0A=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20(function-put=20= 'bytecomp-tests--foo=20'bar=202)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(defmacro=20bytecomp-tests--foobar=20()=0A@@=20= -1636,7=20+1665,8=20@@=20bytecomp-tests--not-writable-directory=0A=20=20=20= =20=20=20=20=20=20=20=20=20(byte-compile-error-on-warn=20t))=0A=20=20=20=20= =20=20=20(unwind-protect=0A=20=20=20=20=20=20=20=20=20=20=20(progn=0A-=20= =20=20=20=20=20=20=20=20=20=20=20(write-region=20""=20nil=20input-file=20= nil=20nil=20nil=20'excl)=0A+=20=20=20=20=20=20=20=20=20=20=20=20= (write-region=20";;;=20-*-lexical-binding:t-*-\n"=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20nil=20= input-file=20nil=20nil=20nil=20'excl)=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20(write-region=20""=20nil=20output-file=20nil=20nil=20nil=20'excl)=0A= =20=20=20=20=20=20=20=20=20=20=20=20=20(set-file-modes=20input-file=20= #o400)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(set-file-modes=20= output-file=20#o200)=0A@@=20-1700,7=20+1730,8=20@@=20= bytecomp-tests--target-file-no-directory=0A=20=20=20=20=20(let*=20= ((default-directory=20directory)=0A=20=20=20=20=20=20=20=20=20=20=20=20= (byte-compile-dest-file-function=20(lambda=20(_)=20"test.elc"))=0A=20=20=20= =20=20=20=20=20=20=20=20=20(byte-compile-error-on-warn=20t))=0A-=20=20=20= =20=20=20(write-region=20""=20nil=20"test.el"=20nil=20nil=20nil=20'excl)=0A= +=20=20=20=20=20=20(write-region=20=20";;;=20-*-lexical-binding:t-*-\n"=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20nil=20= "test.el"=20nil=20nil=20nil=20'excl)=0A=20=20=20=20=20=20=20(should=20= (byte-compile-file=20"test.el"))=0A=20=20=20=20=20=20=20(should=20= (file-regular-p=20"test.elc"))=0A=20=20=20=20=20=20=20(should=20= (cl-plusp=20(file-attribute-size=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_1B23E174-97EC-4B15-B787-A6600272D218-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 07:56:10 2023 Received: (at 66636) by debbugs.gnu.org; 19 Oct 2023 11:56:10 +0000 Received: from localhost ([127.0.0.1]:35984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtRdK-0004e5-9C for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:56:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtRdH-0004dg-NC for 66636@debbugs.gnu.org; Thu, 19 Oct 2023 07:56:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtRck-00066a-FU; Thu, 19 Oct 2023 07:55:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IdgUxT1Rhzu4kIAnuFjZU3zy4zurJqYvJ7zolng3jLA=; b=Q3IsGGA472U6JLBAqNvG 6vHdLIbGBhsL2sAohxxjVGQ1b+c1KB+ulCjUrC4TVp6bzYaDlguZH9X1P7FmBtIQFpYwHEuk+Fm0Q nB6aLVKiKnRUvm9h+u27L+FVKLsEbOt057I6DtPuwr6QznzFv2rqOLzPwYxWnjJWgBqzwEbv0xDq6 4fuucL+kaVjjFIxhYZQ4x7BAbwWgadk6bLMi5JozDYoImUlPKwiONDc6IGo6zZRKSQcCbGI9opHXD 93hvNQhYd4KH2mDrNFDlRCDwzxbQJ7ggd7dsSfFVKIzzNmFGJN0OBvmtlyO7iwfaTasxNk2JpMV2R apofAyihunwqzw==; Date: Thu, 19 Oct 2023 14:55:02 +0300 Message-Id: <83sf66u8rt.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier In-Reply-To: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 19 Oct 2023 13:48:21 +0200) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Thu, 19 Oct 2023 13:48:21 +0200 > > The warning about a missing lexical-binding cookie rather belongs in the compiler than checkdoc, because it's not about documentation or style but code generation and ability to detect errors, both which are hindered by a missing cookie. > > Moving the warning to the compiler also makes it more widely seen. Adding Stefan, in case he has an opinion and/or comments. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 10:13:03 2023 Received: (at 66636) by debbugs.gnu.org; 19 Oct 2023 14:13:03 +0000 Received: from localhost ([127.0.0.1]:37377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtTlm-00068w-Sg for submit@debbugs.gnu.org; Thu, 19 Oct 2023 10:13:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtTlk-00068P-2t for 66636@debbugs.gnu.org; Thu, 19 Oct 2023 10:13:01 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1A0B3100151; Thu, 19 Oct 2023 10:12:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697724746; bh=06dabul+I0W+576+D7f9c+0f53bduDOUr0UfqJWdhlQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ed8cSvOJZ69B3xAvKAYBTuWIjODSJfLA0NBjUEsuzJZYUylFQsb5dS1hPXVPyf7f4 tmb19wmZ0A4NJVQStZobNnXXqFRE+havFIa2kmbQrWIlnjossQq6V7MMPVS6OSB6z1 B6Rg5V3t/Yg7Wvq/ORWrVq/TbFdWhmmTUx9ZQDvnKjc0cZxcN3oz9PF/LAgo50LJwT Pv/KhEUIzBeAZVKyQo+Qq6UvXnhU3c96IvadGnWvlq94zuOgLBAMy7EXeKJX25DPhQ YcTQsVel6+rI/HYVRAkV+xvd89fyEL7VD8WS5vD6W7/j2uxiPCtaN+7At3VecZjz2L nJxh7D3uGrKRA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E57531000A3; Thu, 19 Oct 2023 10:12:26 -0400 (EDT) Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BA63312031C; Thu, 19 Oct 2023 10:12:26 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <83sf66u8rt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Oct 2023 14:55:02 +0300") Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <83sf66u8rt.fsf@gnu.org> Date: Thu, 19 Oct 2023 10:12:25 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.155 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= , 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The warning about a missing lexical-binding cookie rather belongs in the >> compiler than checkdoc, because it's not about documentation or style but >> code generation and ability to detect errors, both which are hindered by >> a missing cookie. >> >> Moving the warning to the compiler also makes it more widely seen. I think it's a great idea. I hadn't noticed this warning in checkdoc, else I would have probably suggested the same. The patch looks good too (and the resulting simplicity, to me, is a good hint that it's a better place to put this warning). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 19 13:41:07 2023 Received: (at 66636) by debbugs.gnu.org; 19 Oct 2023 17:41:07 +0000 Received: from localhost ([127.0.0.1]:37718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtX19-00044F-IO for submit@debbugs.gnu.org; Thu, 19 Oct 2023 13:41:07 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:43421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtX17-00043a-Aj for 66636@debbugs.gnu.org; Thu, 19 Oct 2023 13:41:06 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c51682fddeso11941681fa.1 for <66636@debbugs.gnu.org>; Thu, 19 Oct 2023 10:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697737232; x=1698342032; darn=debbugs.gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=SvHkYJfqCupUH72oU6KcVJjKDrZGKR6ukBktisbQm4E=; b=aMOmBCrGUNXHqqfcMR/Ws27vq4bsNFfwi+izOjG+EsdT9pXVL8kPXMpGlylIQITc1+ gTvJ/kW4j88c4u6KUWn+JPvrqV7U5wm+CqKhaVTV3s4DjaS+H5FvZS53WjPMvWFx90Pg X4fuC02HwgZ2TDyyPvFO7U0L2ESj00+CqGSUc/raSukMckmLcDP3RRKT3RH9EGg1oT9K BkdjkrR05+0g96SP9S17hF6tBmFmi7EcoIT9+z6hHt0wrz2zfrSorBbZt4elgZGrC797 eljoFwK+rvbdkMEbP+qG7+3TrtNlsxKX5QeOTEX4++ERvzC9M1z14fIh6HHB+508W7J4 q66Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697737232; x=1698342032; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SvHkYJfqCupUH72oU6KcVJjKDrZGKR6ukBktisbQm4E=; b=w0ssa5KE5flCAuHdof98J4T7R1NzXcGvEVMoDtzHXL9e3TtSjwjQwEZwSCCyThwSc6 NHY/WNi3A9kpbvyDzUIr1SzMEnHepjWpQcMTAEZtX5J9YonCILcVoGdszCHvaDrTgFsG mSplWPquSdniBrMlPS5eu7MNngB6e2QGd2RJ+34V71fWHTK52b7lqOGUKy/dmjBmttTy IGfkHZVoJDoQ1U9ccVT+TiV3WsyZqDxW/HoPKG/dnb2V3Wv1jSALhyJ4Wb5R9KpTrtkM QM1k/pqK+TeOOwOHAlgqr36PSdpBtP2CPN5Y9+y4vWy1eaC2x/hWjejqifLR6ESQo8UJ G1oA== X-Gm-Message-State: AOJu0YwnrD4MYwopZExp7OJddZS/srO70Q699W5UziSvbYNwjpLNCnAU mi/3jpo2BIDqsBrSxS1C3Huzsrq3re8WLMy6DbQ= X-Google-Smtp-Source: AGHT+IH06Nz9WJGYnTsyouxWvJBqTfOB7UEEf0CylJrofk7nRyRlasLiPqPn1Dn6ShnlFQJHUjwz2CLANWiPrQJaQi0= X-Received: by 2002:a19:ac4c:0:b0:503:2567:c42f with SMTP id r12-20020a19ac4c000000b005032567c42fmr804072lfc.0.1697737232154; Thu, 19 Oct 2023 10:40:32 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 Oct 2023 10:40:31 -0700 From: Stefan Kangas In-Reply-To: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> MIME-Version: 1.0 Date: Thu, 19 Oct 2023 10:40:31 -0700 Message-ID: Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , 66636@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > The warning about a missing lexical-binding cookie rather belongs in > the compiler than checkdoc, because it's not about documentation or > style but code generation and ability to detect errors, both which are > hindered by a missing cookie. > > Moving the warning to the compiler also makes it more widely seen. Yes, that makes much more sense. Thanks for doing that. The patch looks good too. > + ;;; My little pony mode -*- lexical-binding: t -*- If we want this to conform with the format required by package.el, this should be: ;;; pony.el --- My little pony mode -*- lexical-binding: t -*- Or would that distract from the main point? > +Lexical binding avoids some name conflicts and allows the compiler > +to detect more mistakes and generate more efficient code. On a side note, it would be good to also highlight this in the relevant sections of the manual. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 02:10:30 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 06:10:30 +0000 Received: from localhost ([127.0.0.1]:38487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtiiL-0002DS-Ri for submit@debbugs.gnu.org; Fri, 20 Oct 2023 02:10:30 -0400 Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:45333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtiiJ-0002DB-DT for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 02:10:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697782193; bh=ORb6OCp/cKPsWWoITh6c9IB9B1ldWKA4vI14DYTBDD8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=JdP87VllsVBVjZ3iSqdoracjWRKra3YaUKjYMDdt3UOkG8/CSEP84b6yOf46f7QQvC/agOh926I77UxzGdVPOPlqFCdBxR43wwraQGqwTOiMo6miaYUHQXhVKa/CuSTO6k+8ASm4g8dkpBWQxT/BddbmXqTwymScgBAKCqTo3YsfdPrHYJZIlTqojWwxPZ5VSNh890nOD8Qmozi4Jg1gfqsGqGo0rhtpxguG4bpHFpT9JtXnEfe2URKkOVfc2exoh7VVKfuDQzSTA8JeUEeHpMCKfbjZ4SMdLbGqUN9n+Y7Knmsn6D/QFya5K77DzP+ce2trFohMpNBqtFWP/ToPCQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697782193; bh=7/5Hu5ifsByJg1KYM4lJkVTE9UgtfYW+myAEBt4i0n9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mTducIfyzjwawNqfARCKsd53f73gFaM4wQMM1W6F7OlcQj6+R1KCyJa+wXrzFKgAWVRgAVooZILa45QURXvZMFawsMY5M0wNRu4V8qotlk0Xq3rKLLSs+radGFsGtQuOWk4KuuUcWGFcI6aYxWwDsC/ts4nF94IZpbO/OZqkWADFpl738dS8b8gWldveFrReVOAiakpwGGne+3J/HCPvbzqjGZfYGhPe+DjbT/4Fd+Oc85lNvLQS+dVik/KqeASOcbjcQIFRgZSQTXwZea5YVXwUWtDPFdqZImcUXKe+oGLs37BlUj3Sm8xHgvUPlN3u3bmQKnO+sjOc9ftOWa6OMA== X-YMail-OSG: UCJWtGMVM1lfn_UwRUn99_TfUAZN.I6Vs5Kh.extrYOp8_s72zNsV1DFsEDqJik r7YQsPgad5cpl49RkMI5VkahDKJ5Xjaab26OLg39bWk4HUOruX0DxCyawOPtveTo_v.2PQic6N6I cRYXXUThCmUPxPqeHr6gigJZQr1fJjA_e1Bmx4kCSHwXu70YIP7piVvBfQWVdvMcOkO8RdiRzpaI aKRXAteqpJOKQ342k.onv5mkp6hmQRuT5qTLIOkLskglWWhuYMfpYvl8zw261g6LfGbl4JTIWJs. RpITaKCcX4dHBhnVLsdO19eZbmt5Xboh_03NU0xJkASza1IE_Lab9o9FxYC23vOBCmPNLzOJxl2f aA2jbmcH0PEm70LuOLcRB95nTncvWuXz.Uk4N9Z.Y9zcsTG9._sAud_JkIR6symzRNIp2tylSMcl yeEZHd5Aq367SNw9u6x4eHkNs_gmuKol3nZVqICGeKJOQdhlSpxsKJVutPFGM52h_m18eXF1Erx3 8MGakuB9qEvPYlqeT5_pQaXesOV8GPombDC95bVGTcOZUz6.tb_.4fHCvaqQ8P5FofT4E33GbscD zvw9yhvJxMAzGUbM7_XhMSfmHX8TewJtt1TRkeCmPMBwMHvqTU8JwnLM_C.QYYyKrFeCPIC4nbZg KjwyLgmX1Z0sHc9Ae6lBxF..wmrpSyNm4QQ1r87rhrQq9O.ilCpAXbqOtrBRMMqGYSLVkl6c.2mX 1nkvpDO5_l39qS9lS9_3d8C5fcbgRUq5fR6fczyLCjU0B2Ah6vUFQyg6CM1Ulcy2uFurtwDL9DLs XMO3a.OrwW1HBIUYqSrH_b9G0vDHOzoUSSHPUr1EZeR_w4f2hPAMqu.JbGhLTcwzMXMH_O7FXxfx Xn1iw3rO4vA0WO7xT6W8Ma4lB2_BZjLG8Lg2cFVVNZ1lowxxOHlGsoJFbnS7r.BtzmooeTN6dsBP PTKPs5K6jZUd5wRIhv40Q8EqY8XQ6SguFjerQePqs1VbIDahCkP04DnNaei7g_uLCqCPVFryP3QK N.6V6hHP8VJ0uHuWIXwJuS_u0Sx.jY9_6QIudGibEh0KLLEKZMlAKI_kEPk9uhhYGM18MvqmYgPk A8AlgJX6c_D7hM.n6WQxX_i9U_xxe_Ww2GsabIpm9PMKEfNEYiZSYLhaGpUOCroT.w354CFZzdxZ .W3DJvzGE8CIvvqll29lczY074_4gWYyHIihZrgll85aIFMYM1m_ztJmNje9noMEeCh4kLr3jhLd .doW.dQDUlg1NZ3TDIyu5nIQJ9qAC4a5Ur0xmSiXxMBQJRUi.HIu22eAwOAh2LxvGhnK4oifvIAo _QqZOkqm_B6ct0vqsOjdrWnikO9zikge85CJvtuXpT5v4.tMlMbH27r2rRhlzzYHJKhk01dYBZXW qAFKAWEoUnZM0M6d0EvqHOBBTH7ZMUcO..n25NoUQQOxdhSISWhMhycGoJ3Ot5AfFfXI5fO6aqci H0Ydtv5PAPZsVDm2slC8YtN4eyw.hUJ4bryp6AoIWElFfDe4CpStrZ1G9v.gNoQ4kpKET2yJw5pp 9BKCl9fDRpvOY9S.B9lP9HdeZchz.u.lwAvrWPtw52vb0zzQpaLxowvI8TjezFZPc7NqMGVmQl5G I3vQH8PjGQOqeB_G37Cz.s_sBx4eO73ngcn40qpA.qhlwMJ6RdT0b4iSbkGBszAlIU2JZjmPnAsR 01V8M4sMuRihuSpd4c0hM.vJBqBf4uR4qkHdvYQEQHPi.F5vkvx8Qgtwx2qp5e1w_6JmPnucPRMt i4lUfQyQcsIRxnPp9nUOaIBVaajEwUPWUZLmCv._xUdjcGFRJaEBkjUYpYCMmAuMoNvq9mdp9hk6 kRHzOItsq3WsBSXXsEuHDeuhYh5zwDBOgweR.XAa_p7wVuuZBi_3n57YQNJ3MdDA5YQINIg5ZL.R AW3wQaysdWuDCR5im5vhrrqzoiG4YZRZgHh0hL2Gm6BX4ThQgnoi7I0Rcm7bqCZ5Od4IYKlFF9HF 0nq60B6Lb0hVATsL8OOqYcbIdOlMkJnmCQftPrzllKJZcQ9Lj0LK8F3BIUbChjozf8L1W8XOMIO. dFsB_qLuYUvsvRDE5qWcV75mv.GJQUpTyNgZlbTm8_7.T8vgewXrDP3ajLROwPZLgqifb3XsqNqU HsCtgYkX.ZmrJcHXUYKIwWOabP_8ld8KrD3khGPV58tDj6C6x2bI3DJK2e0BtlSVO6fKd_x_DHCX sQ7TExyTlf6EoRNUo8mBeaB5MeuJSxWoeILQNdcAb.BIuMYPKdo.e_C7VMMp0iPQzeBFR X-Sonic-MF: X-Sonic-ID: 5a704dd5-b85c-4bc1-a6f9-b302006d14b2 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Fri, 20 Oct 2023 06:09:53 +0000 Received: by hermes--production-sg3-57f7997989-bg88w (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4609caa728e9161f8c31035be48d1580; Fri, 20 Oct 2023 06:09:50 +0000 (UTC) From: Po Lu To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Thu, 19 Oct 2023 13:48:21 +0200") References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> Date: Fri, 20 Oct 2023 14:09:45 +0800 Message-ID: <87ttql4yfq.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 875 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 66636 Cc: 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) Mattias Engdeg=C3=A5rd writes: > The warning about a missing lexical-binding cookie rather belongs in > the compiler than checkdoc, because it's not about documentation or > style but code generation and ability to detect errors, both which are > hindered by a missing cookie. > > Moving the warning to the compiler also makes it more widely seen. So long as this warning is only displayed within code part of Emacs itself, there are no valid objections to such a change. But you have instead elected to generate warnings whenever such files are byte-compiled. There exist many packages which do not enable lexical binding, whose authors have studiously elected not to: most of Drew Adams' for example. So this is tantamount to punitive action against their users, in the form of an unsightly warning each time such packages are installed. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 03:02:25 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 07:02:25 +0000 Received: from localhost ([127.0.0.1]:38523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjWb-0003ql-7w for submit@debbugs.gnu.org; Fri, 20 Oct 2023 03:02:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjWY-0003qW-UO for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 03:02:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjW2-0006JT-8t; Fri, 20 Oct 2023 03:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HB3mMDNLCsD/H2xUbKl49CwB284y+Mtw0AGg2baBqko=; b=UBn22ydr+jx2wH4sjd5A 98y4nl46cibFe1z4i+Ezn069CbGhUQjVdd2+Vpm/p0nKw2yPXp9yNra/A8htIrUeD6m+PQvoGmHLq Zx2mFSStiKuvVqvdxYKk6idxwFcnMZFYllnrv/CpdK51QN+uHtXjGSXM7VKEQzY8WmKjombwNBtgQ xcwon5No0x3Tbx0rAmKYWdObHeo7IgrMW7LF+Hr2wjBhssv0Dr5BHTTsXMTTgPmZVAa6F5hM2TMtk i5t6r4P0xaiKfvFOqeVfB941O/WSAp658A7b9yVWBU4+Yb6GTTM04eTIFp3V8dRA00TU3FiGuCsNl h3y7SYvNaGAOdQ==; Date: Fri, 20 Oct 2023 10:01:44 +0300 Message-Id: <83wmvhsron.fsf@gnu.org> From: Eli Zaretskii To: Po Lu , Stefan Monnier In-Reply-To: <87ttql4yfq.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: mattias.engdegard@gmail.com, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66636@debbugs.gnu.org > Date: Fri, 20 Oct 2023 14:09:45 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Mattias EngdegÃ¥rd writes: > > > The warning about a missing lexical-binding cookie rather belongs in > > the compiler than checkdoc, because it's not about documentation or > > style but code generation and ability to detect errors, both which are > > hindered by a missing cookie. > > > > Moving the warning to the compiler also makes it more widely seen. > > So long as this warning is only displayed within code part of Emacs > itself, there are no valid objections to such a change. > > But you have instead elected to generate warnings whenever such files > are byte-compiled. There exist many packages which do not enable > lexical binding, whose authors have studiously elected not to: most of > Drew Adams' for example. So this is tantamount to punitive action > against their users, in the form of an unsightly warning each time such > packages are installed. Cannot such packages disable this warning in file-local variables? From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 03:14:06 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 07:14:06 +0000 Received: from localhost ([127.0.0.1]:38529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjhu-0004Gd-Ge for submit@debbugs.gnu.org; Fri, 20 Oct 2023 03:14:06 -0400 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:40887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjhp-0004Fu-Ez for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 03:14:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697786008; bh=MpDPAFGQvOGEXjEw/JS/1TnPCikj/eeaPGUlGPoypcc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=G9NM/3K5c9aC9hB9CGlVJVfac8bc2nPF+OV91e+9Vy3E59uhrHS1OHRKo8IfDWl/kNKJwjkR1JYqoQ/vae5MfQyKmkTe1kAsiFRVw1f3g3xEngqZSeasIpXrxkSoVdhKa5TcugErr8//Iz9XRsydhmjxlu3XP9Xm5yQDhpPWS/Lbe+2imMBNemT8ds2E08Qsm4qAKtM1IZOsUP5+NE+orjhyOeVKCL2vnOSa5NnaXeqpB9neoW10LRGVFLVaYxtmkm/vzNob1l66kTWThqk5Xbs8A3fXkTBi315cDQhmg8s32WV52Q+LjM0sipXG7JyDIJttZUMqmSM2+5hhJ4orHQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697786008; bh=4rYOAt5PpJc0Gc5yIYZFh7TzSJin+j4F7GgfEWqIFVw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=qHHem3MWGJ3yPFyfWhVMceMc1z6pKNqBSwKjOX7XM/P7JJIb8rtxLH/TmEUy4E+RMK18YRzITpeQ6UObbwclbzHrQsUlSPbHm+EcX8MwKAfWMmD1efnSvMsUbZ70AW2IHMTbdxWhaf/MeVR576a2jrpSO3AljoeB4eMpWT8NMtDOqdf6dcaGGN5uQZGu49eVKCmRVbn60g9pWVwCjhl61sIfITJ/QxibSzCCsa7H1+hq5ZVKlEXn9eiuQyE32W+2x69sSOcYq8rHGaTDSqQdJmAYIF7ZqRys6fe8UwlMYz9x7VNgm04HcA0BMuctD5nLXJgheNhyoCKHRx9e6E7VhA== X-YMail-OSG: .DhYlDgVM1lLm1nDqEbPJyLAGzZn6emdAUOgYuZDjrVqePzM8RadsZlYy1XJlEX PC1j4Fr86g2.E0zSbdKL5XktP91Jc75o.GiYkqZHPx7vTq5oJZ30v1E8aCeiAHRYZNnpqc5FsgD6 amNGjW3W7m7JhY_aSNp9TdK0Z_jDks5W0Bn_cagyP389CAli4CgPQoggYo.byxrF4Vwt4r_tK_WO wViC96rTyVbSzVxUtFZe9fDibYhxbwldvVgpZstf3LpNzdNvIGtH2W9Td3Jfya00ItCIfkIM2NrQ MVu5eoj3MiOvoz3Yo7txR65SFMtxX7DI.LPhBz59L3QtZGolOz3v2Xnnrm3CiYQSQwWsCzxuOTiM kbPPxk15JcaCBL830cdNpxAWSRQGhJBstGZZLBseJiRoY37MXAonSElpHXFkMmt8Yd.9loNRh3_Z sMmEXdV1Ys5qdH544Q1A7w_dWu3izxFLtzaoA_L33v4nxqxmDLwI26TXAqcrNuRYCA7e5RG0eZMY v6Sk1OUFWQ8DyVFFadFMwar5_YS_8JNMk4Bn95Y19ukuJqdMY3z_m3uhwhAC7Up5ildd2oRQnFuw qMdprYvQ3bUtq5ae3zUiEzWT4PQBvzMfHM4xG_6sIYqjQaC7NGfxmNxZjD1soRbirRApLcnEWtK_ .8qxcAv4ZRz3ik0Sp_uZzUxrapZVp5qExJSe0ba5U5ACaUk1hrvn1U1EZUrNhe8q0TmQ5qz9kDei mWo9s1Ycz.8GoStubSWMuYhSKF7Wee1x0dFdyewo2RZp2gmdfc0JR3X1SHFl7rZj9mrmyoiNFbqR PtV4Dqsk1HRPUrZjzRF3ZoWspOPO9yhU6Capj.Mu0dYWHVh1Se27SmpJfyxfc8eylD.A5NR7DnxT LmUM4lLQu1X9n6ouV_pml7zdzMM5Glwkb190x9UfAino2cXppRQU.MWHRkbDP8Eh6lQSoyom9dDa IZzhTUlZ9EhEcwH0hoeCboPoz1oDyUvKVYEzHwH8Y37x1lLlIAWrkoudv_TlFIxbU_Tl4qnJ5QaP x6nskDOi2mBhmqKjYQb0rVqHfHKTOlO1Y5D4ifT3XltEI6TGQgsNizCFhl3D.VzVJG7K8EMHN33w HRcLkxogxCpyM74n6Ib8ghEcpsNhvxVAfD8t_dKE6BbADq8IguTtshEWUfpVSRwg4hgeC4lBF3JZ 2h7sGrI70ZHvkEWW_ZIrvRJ.xpmhDuI9szSe.t_OrUaP1DN9wSKEvG46g4eiJ5kW_18b6JPsU0z_ 4NgLg7AOKHFycQI1p3CMDBTyrYwtvkoMxEZWqUKFovkJvnSBt056Dxgzh_6Prr49w8aQvczW.oiz hogxMT8cwC0cZBxH8x1WiP_70BG8G7BWtoeOvHYCv1zY.Peh6G0ZfJVWiSayQNfMNGlr.sbSIcTN S9dBty9mzFFmAv0Icd4D4QlnGUJCaOiPa0lk19DbEZ7X3dg_.oBWHKQLH6sqmFrjNp7dsXeWaNw9 dfIEawEiLsO9yAF1GNGlB7GkgeKqfkHGKuX_7uXEXa8_mDI90NXQDw5Spq8zXYSRI4DfHqvHawlq Oq.0yLHpt66PWhl4DxYf6LZUNfq7KtKqFo4lC4giDiuPGgqWqmspz4e3_vyZmU7L_j9IfSxl216A _0aNiWEoNmUe2BdgExh3ClKD8JV3zcl677zQt0ojfIZVlsUHTd3dPbxLjH1gYBWCRXkNmbcPXdKY vByDW_BW9jYUiLErEbuB1pSW.CAjTWoiB001H7CQGgOfpzfdCpDdWvxmYpMyIrSJW_EAHZgX20Dz 8FhBb33CkctVrtySNTokgaWyklWMji4htSSK.IKqCbwYzVO_9HDZhBiO5K.luagTgIC7da2Jwk40 QM6RMP9B6AhuGuOs0.xsIRCWLcczo3yUVcumWZzcykK0pFc8LmBfPAxDrpXYzJ08Cdilbyiwhap6 UbhXmuGVzQ4VD.iojMPN9oQ5Wt0tY9YJHkrOttxP8E7wEvDodKBNvLZr0LlPHOVZO0I6XrkNT2eq b8t8mzr793tAKkmrNi990cr5D5YtkADKRvTMEmo7MgF2s2dCJmbxIm2EgQXkzqqrZ1VU3duf3N9r JvzOgGj_BfSxSYkZGiuHWv4EvGLPhqWJwHqux9Ns.eNjAHytLddYpNLVVsYIEFuxERRRCG5bR6nV jaFkbl2Lsl3s66jA6Z1c3oW2IlJY6LHi20HYZ7Bcqp3Y6_Uck7dwMLq5i.BMPu_.Mbqf3DObYa9B yUZBprQPSEVbymDRoXcNiK1hFg.7.vl193ZwkIFALK5zZdU5AMBFBKuRNtGncZuOAcdY- X-Sonic-MF: X-Sonic-ID: f83a7ae7-f69a-41e4-9580-c2a3597687e9 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Fri, 20 Oct 2023 07:13:28 +0000 Received: by hermes--production-sg3-57f7997989-fcsf4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2d0525da230fb6f509d9959b8c4fab0b; Fri, 20 Oct 2023 07:13:22 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <83wmvhsron.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Oct 2023 10:01:44 +0300") References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83wmvhsron.fsf@gnu.org> Date: Fri, 20 Oct 2023 15:13:15 +0800 Message-ID: <87lebx4vhw.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1339 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 66636 Cc: mattias.engdegard@gmail.com, Stefan Monnier , 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) Eli Zaretskii writes: >> Cc: 66636@debbugs.gnu.org >> Date: Fri, 20 Oct 2023 14:09:45 +0800 >> From: Po Lu via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Mattias Engdeg=C3=A5rd writes: >>=20 >> > The warning about a missing lexical-binding cookie rather belongs in >> > the compiler than checkdoc, because it's not about documentation or >> > style but code generation and ability to detect errors, both which are >> > hindered by a missing cookie. >> > >> > Moving the warning to the compiler also makes it more widely seen. >>=20 >> So long as this warning is only displayed within code part of Emacs >> itself, there are no valid objections to such a change. >>=20 >> But you have instead elected to generate warnings whenever such files >> are byte-compiled. There exist many packages which do not enable >> lexical binding, whose authors have studiously elected not to: most of >> Drew Adams' for example. So this is tantamount to punitive action >> against their users, in the form of an unsightly warning each time such >> packages are installed. > > Cannot such packages disable this warning in file-local variables? I don't think so, at least insomuch as byte-compile-warnings doesn't function as a file-local variable. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 03:22:25 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 07:22:25 +0000 Received: from localhost ([127.0.0.1]:38541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjpx-0004UW-4K for submit@debbugs.gnu.org; Fri, 20 Oct 2023 03:22:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjpm-0004U9-Dl for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 03:22:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjpE-0003fB-Fb; Fri, 20 Oct 2023 03:21:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5Dwz1r5+5G44UoF6dq874G3ClR50vYytzPR6y0cLENM=; b=aRzrIjPnJZ0KHVC9btBZ tkHio14ZW7OfdB76CyUZ0eam36gL1NyxKv2IkzHqfPFZfiJ0G3aaR7O9n6dlEvR1Y+5Y73ywINpAy IePOUvrMJctvssxkZdHdEY85D5XtEqY40fdPGpdqyF9gvFBx9Vc1/xgEoBFzls6Yhm5YqH/tmH7m0 87tnzke4HQAXybgMJzWtW0Gyaoy4ki6aUSsvHHdO/TcLA9LIv/T9l/fgkNBA9x0tlwv6sOHOlFXQJ QORUK+Kgz2+O5wIcQB0JtZGKeVYy2aLsuIBe0GmKql2l86ZAVl2cvDMKRo0SXpYML6QkMMnXrohb+ LMjdiGqxekUcdw==; Date: Fri, 20 Oct 2023 10:21:32 +0300 Message-Id: <83ttqlsqrn.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87lebx4vhw.fsf@yahoo.com> (message from Po Lu on Fri, 20 Oct 2023 15:13:15 +0800) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83wmvhsron.fsf@gnu.org> <87lebx4vhw.fsf@yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66636 Cc: mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: Stefan Monnier , mattias.engdegard@gmail.com, > 66636@debbugs.gnu.org > Date: Fri, 20 Oct 2023 15:13:15 +0800 > > Eli Zaretskii writes: > > >> Cc: 66636@debbugs.gnu.org > >> Date: Fri, 20 Oct 2023 14:09:45 +0800 > >> From: Po Lu via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Mattias EngdegÃ¥rd writes: > >> > >> > The warning about a missing lexical-binding cookie rather belongs in > >> > the compiler than checkdoc, because it's not about documentation or > >> > style but code generation and ability to detect errors, both which are > >> > hindered by a missing cookie. > >> > > >> > Moving the warning to the compiler also makes it more widely seen. > >> > >> So long as this warning is only displayed within code part of Emacs > >> itself, there are no valid objections to such a change. > >> > >> But you have instead elected to generate warnings whenever such files > >> are byte-compiled. There exist many packages which do not enable > >> lexical binding, whose authors have studiously elected not to: most of > >> Drew Adams' for example. So this is tantamount to punitive action > >> against their users, in the form of an unsightly warning each time such > >> packages are installed. > > > > Cannot such packages disable this warning in file-local variables? > > I don't think so, at least insomuch as byte-compile-warnings doesn't > function as a file-local variable. Then maybe we should allow that for this new warning (and potentially also other warnings). From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 06:15:58 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 10:15:58 +0000 Received: from localhost ([127.0.0.1]:38748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtmXt-0001iM-Rq for submit@debbugs.gnu.org; Fri, 20 Oct 2023 06:15:58 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:44527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtmXp-0001i5-PI for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 06:15:56 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c503dbe50dso10103991fa.1 for <66636@debbugs.gnu.org>; Fri, 20 Oct 2023 03:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697796920; x=1698401720; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=vlnIoxhRV+y1WwSQdfLX1QQI6+tzxHDT/usgEh6/gQY=; b=OjLnVtYseEPROzTG2cX1AEI+jIBCQ1ITM6a0SE1LQTbgjiDx9VWHA2qeNAuOUbmh7N 6gTVfkWrAzVppuJfWtd0ceR581WwXzHuKX4lof4wAx6AIvf01ALgIfcPtUJqoKiewqla hKcr8y5RacrcBcRZLgZbK0VyDs90XPUissK1g5E8BSEWVD3gxLYy6zBAOcM76W154uQh 1AUXYbV2nyMflrnDuBhSS6lear2ram8IXKytsErGQRcmaPsPAsTWjutdrBr19iSVXPC6 JWWh7vLZOx7l9g4JxnKAQH8nLqyTHgUotwp58OKEXxNSXy19tz9MiQd1RD3dT9wTt39Z bKGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697796920; x=1698401720; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vlnIoxhRV+y1WwSQdfLX1QQI6+tzxHDT/usgEh6/gQY=; b=qedzQ//2RkTuMXx+x8fe8C/C0amQ+eRb8Ucyw8+LCuNrwbSniUtG87cKJDH5Rf0Epv ppDdwRFuQfO5AFbdCFXngN8Z1oc/v+0QMszA2vDjorf7ROTygcFnBOjMkpokRl/JjyuM UEvnNU0OqMc/RIjlUZIcJzXcbdy3jhae3oW63kFznoejDDxuuh3U/4TeQCdbCuUwN/NZ yIehTBeBvv3PbuTLGYFxsETmqJtTCVljC6rcogWA8UjYFmWj2AgcrW116pMvzO5aPEah 4o0F8hqnDXojdr6WDNKX0nA+UWwf5+3SmT7mAiM0Bn5HnXTRL24YHrX/YvKIjxqCLPND 1HZA== X-Gm-Message-State: AOJu0YyTAh1WTSyBaNwuwZ02ysDjNC1vA/UoqW/ZOY3gSEpuKxHUJstx oVqIgIGL2KPkQ8QzKBWH8Ck= X-Google-Smtp-Source: AGHT+IEvaVncTxH170BRaZmXE7h6w1OgbGJElk2rh99U14T/GtEtrFEFcFZ3JHPuwx5R9tHdrJTokA== X-Received: by 2002:a2e:7208:0:b0:2c5:2445:36af with SMTP id n8-20020a2e7208000000b002c5244536afmr997807ljc.50.1697796920344; Fri, 20 Oct 2023 03:15:20 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id bx17-20020a05651c199100b002c509ecf7efsm301939ljb.133.2023.10.20.03.15.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Oct 2023 03:15:19 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 20 Oct 2023 12:15:18 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636 Cc: 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 19 okt. 2023 kl. 19.40 skrev Stefan Kangas : >> + ;;; My little pony mode -*- lexical-binding: t -*- >=20 > If we want this to conform with the format required by package.el, = this > should be: >=20 > ;;; pony.el --- My little pony mode -*- lexical-binding: t -*- >=20 > Or would that distract from the main point? Indeed the example was chosen to avoid anything irrelevant. If anything = should go it would be the pony, but I put it there to remind the user = that it's fine to include something else that obviously isn't parsed. Something too formal-looking might give the impression of compulsory = and/or machine-readable structure. (I always found this traditional first line to be somewhat of an uneasy = composite: too often it forces unnatural brevity on the description, or = becomes so long that it wraps. I'd favour dedicating the first line to = the -*- cookie alone.) > On a side note, it would be good to also highlight this in the = relevant > sections of the manual. Yes, the manual needs updating in some respects. I'll do this separately = to keep the text as coherent as possible. Thank you for the kind review! From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 09:39:14 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 13:39:14 +0000 Received: from localhost ([127.0.0.1]:38967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtpib-0005A1-Ug for submit@debbugs.gnu.org; Fri, 20 Oct 2023 09:39:14 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtpiW-00059k-RQ for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 09:39:12 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 64D1E100187; Fri, 20 Oct 2023 09:38:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697809114; bh=SEEJ9sMQyCt0MXpHStOApY+8V8lP1ZPLLM0boNTczUc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Oa5waosqqfGHDCfQLjopJHwEuKzRlL93qgCIfzNjV9ohAB/ABLk0TFT13LcZiHBlp a0NRJuB+KiAel6rTelh6sDNUl8wfD/gBEgDSjdqSONQzwi90kwxptw+Tyfb/0pQCtQ nCCwThsV5V5ESmAamoYeXwILnKK5jma69Cviswnfwd6jkqKT7sJiKXzasVUgPCAJ3v XopPBFPQ+Xi/uuceRsf9LUWChNrBbdALenXQGHQiRgjbDfEU19WdPhG+hrk3c6291K +koKdLEL+W2mK13SqZGBYruutQlw5G9iUG92HO6xXdXZ8OYqwC7/Za4Ctw8sqGPWvP /OUxUDBP2Y/OQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 44B061000A3; Fri, 20 Oct 2023 09:38:34 -0400 (EDT) Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1A9E21201BB; Fri, 20 Oct 2023 09:38:34 -0400 (EDT) From: Stefan Monnier To: Po Lu Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <87ttql4yfq.fsf@yahoo.com> (Po Lu's message of "Fri, 20 Oct 2023 14:09:45 +0800") Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> Date: Fri, 20 Oct 2023 09:38:33 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.154 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= , 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The warning about a missing lexical-binding cookie rather belongs in >> the compiler than checkdoc, because it's not about documentation or >> style but code generation and ability to detect errors, both which are >> hindered by a missing cookie. >> >> Moving the warning to the compiler also makes it more widely seen. > > So long as this warning is only displayed within code part of Emacs > itself, there are no valid objections to such a change. > > But you have instead elected to generate warnings whenever such files > are byte-compiled. There exist many packages which do not enable > lexical binding, whose authors have studiously elected not to: most of > Drew Adams' for example. So this is tantamount to punitive action > against their users, in the form of an unsightly warning each time such > packages are installed. No, it's just asking those authors to make the result of their studious work explicit with -*- lexical-binding: nil -*- -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 12:28:25 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 16:28:25 +0000 Received: from localhost ([127.0.0.1]:41346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtsMK-0005BC-UK for submit@debbugs.gnu.org; Fri, 20 Oct 2023 12:28:25 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:6832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtsMG-0005B0-6h for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 12:28:22 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39KD8AFb020829; Fri, 20 Oct 2023 16:27:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=meEUckAxv5FtYXY8wDboWDfSoqRxNTXmGAfCPCtm/K4=; b=bRl9RZrVYhVRog1+1ShjuonjKlMBtuftt28YBnMd79guRHr2P3AIn0tlmm1SKjGh/sNk rCkkGLdJuxsXvbJyHlsNlkqhrgvaDeKe737D6bvZxtny215Co01DFi5xEj90Xg+qNCVj Jr3gXMRSMQXcDAjCn37fp2Nv3uB1wdCPSBMNzN2QN7zSbXiscB8JMxcgR0nLbHUyX4tZ fFefrtECZRhaa6NZXDY/Fsj7ask4qhgpgEH6Y9bONDEl3SJf0WJMpRvACCsDrTtEoK1J nb9C0tpt1jhSQuxHrJasQp8JFNAvXAE2RTbprI7W8lPw+J3TTx44owsjJ/KxcpW9eQhc LA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tubwc27n0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Oct 2023 16:27:51 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39KEkxgw013119; Fri, 20 Oct 2023 16:27:50 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tubw68fqp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Oct 2023 16:27:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSSS2ZDMnx2jqoqY8/UNcjHl5NAr0W1IZ6sah7BYqxNZqsL6z2Hz+MVnNcWBznd8mKLns1dvvu3baz5DxVclgL+NWENE+sSqnKoRex1E2vrPwUN2+mVmU6FlsLpXfdcQHicNamIe7PrE9L/A3Kiik5wurPvQXlTkrLHsobLppPP5N1gqs8Bs6D4oK0ZVMmySZXvTh29tj/Tv9/Eiytbp9k5o8MmhoJTOUKDplWDJxMOQWQhywc2khzrZIQ9ELj6FWd7yyO/rLzBicj+8GqUgzAdJ+fXmSi54jw3r+MKDg4CNdMH7eRoRaR5bUDl1z6cTFh/sbZHn/tyMCptrFTun9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=meEUckAxv5FtYXY8wDboWDfSoqRxNTXmGAfCPCtm/K4=; b=fOuTlt9cFeniMNxfeXEmhTdQ0sJ2SsbsksF8GoF/b46SHTcctieW0s0n6YrtwEJKKFEFE8yEKqO2x0Ngc8cpVbK5qo2CVOJBEShkjeJ/miQbJ+B/WY1WddqD9VuXPjPy+Nm0m4Noepzz9ZOoSIeErkabWZmFQq+owxSmOq4tGl+BBrH32f2/jYTQcwXHE5Oz4MKU8I1xwzqcLjeXTQDAAFoQ81acxgMI88jGfOS7L4YHqDDdCuOi2PBkNeIynwvjH/ZOJUbEfdqhw2xWBKM3u3nPi4suwNVVJ15o3uF+jbH1lQ/zzyhHUBOqE3rHgz9azv4hngxOpAwAjPtCcoW7hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=meEUckAxv5FtYXY8wDboWDfSoqRxNTXmGAfCPCtm/K4=; b=xyUkVm9ZroruEBYdZMnKwSPqskCoFkvpmT7NFHSqC4hTCUPOocFZf1nZ6liuXkeUHVL3ap1fXdgdf+e3ERORnMLXIWNZt3Soy6qDShrfamq/QtRgjNjE5mhfYeIzYNOry0HaNkkqpMp4iAaN7ED47U9kkEsPS3UgNBd9/PEUcgQ= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by IA1PR10MB7446.namprd10.prod.outlook.com (2603:10b6:208:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.46; Fri, 20 Oct 2023 16:27:48 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::adae:506b:e9a0:529f]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::adae:506b:e9a0:529f%6]) with mapi id 15.20.6907.025; Fri, 20 Oct 2023 16:27:48 +0000 From: Drew Adams To: Po Lu , =?utf-8?B?TWF0dGlhcyBFbmdkZWfDpXJk?= Subject: RE: [External] : bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Thread-Topic: [External] : bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Thread-Index: AQHaAxw5NJ8Yw3aFxE+TRwhGN/DOdLBS2j5g Date: Fri, 20 Oct 2023 16:27:48 +0000 Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> In-Reply-To: <87ttql4yfq.fsf@yahoo.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|IA1PR10MB7446:EE_ x-ms-office365-filtering-correlation-id: d4c60915-542c-40fa-2b1f-08dbd1897f6f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y3P1WDmh2hY+A8gSwXIfaccUwegtAcKlQ0L4XuRC9D2lAsXELRH0OPQvh1yhLt4u1AwDj2qTJbxl5Zlie99kVbWrCJVutYnbdkMl544q2KviIyYYWvCzIzu+rkvv5R/FEMrjTaICZm7sa/56aFdvuj6/yaOjOhuV+wZXcnNyTWfOhrIHcB1sH7UEeQbEMfLxmZatjvcaZA2t0avYF0DSgUgyJvcCEx7mxuAUBwzcq6vpldLBqNHVMzPUu3HTYjaHSzrLLsr3PpNdQ7IQntsSj5c8/G6imrmIF7EDOZAQI1ToTdY10VsvWL++SYlwGm+TEam3uvd5V7zN5sM9Jt1iVCyw6JP6nNEgI/+XXScqXR0k/QokZItSpgSG7HqFG14pwlrSXR6JZqYNNuBdFhnyj9RJYc1rFsZuE6C9A3liK0G8GnVMZo/2vpeeq2ez1agHJFwPP/UHBFwdSov/bO6I4kbDy0d/XXduqvobKOprR8FhX+DHnFG+OuWaUFSEPhi2jbSBtrE1p9cGEQ0svuhae+Viph78hgMKkkviRcIe0233FpwnLoyw2k6FRSY0WhN+SzlIsC7iMjCdoVwv6uykyBugqNl0MaQuHbijLHhLtyKj86k8wW/gnWXk/jw6cQ0J x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(376002)(39860400002)(396003)(136003)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(38100700002)(26005)(9686003)(71200400001)(6506007)(7696005)(33656002)(122000001)(478600001)(110136005)(83380400001)(5660300002)(66556008)(66446008)(44832011)(41300700001)(8676002)(8936002)(52536014)(4326008)(66476007)(55016003)(2906002)(316002)(66946007)(38070700009)(86362001)(76116006)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?azNhUUtBeDRndlROOWlpSWxadjU1aFd1TGZJYUw3cUJyZHNITUhYNVI0cWg5?= =?utf-8?B?TW1kTkwydkhMeWNaMVhCZFlsbVNYRFc3L2IyY0toeTJ6TVJrcXlrM1ZDRmh4?= =?utf-8?B?cksyUHROQkZIb2YzbGU5eW9yWks4SUdac0tMdjFyazJybm1YaCtMdENBM2hp?= =?utf-8?B?bDRhWExHc1hnczdJbVZqMThWQzdRTUkzK2ZROHdjYmNpbnNuTklEU0prUVU5?= =?utf-8?B?ZFo5YTJZS1JjSnhIQ0NJZ2dEaXZqZXBFWGw1WDB4QUZoY3BZWldYdGNFNzZM?= =?utf-8?B?NVdySVFtWml6M0ZqR1J6RWNRTVk3VnJCcHpWM2RuMmRGMml5d2dyVGJIL0lu?= =?utf-8?B?cUZKdFc3UEVueEtTajJKZVJKdW9mL05maHgxMTlKWUtONUVWU29xQit4a1JW?= =?utf-8?B?Vm1zQXFGc1pQenVyQ0xlNnBUd2lLRjBMWHUrM3J2WDJwM3Q1dEwyNnRLcDBX?= =?utf-8?B?VTlyUk5DY0I1MGsyQlJzM3hLZEJzRXBsby82V0k0dWx5YWk1SVQ0UUVscjVo?= =?utf-8?B?TjNKc0FIQit1OHVVL2lPWlVPcWljaUIwQUxiNUZhMjlrclBLODlKd1NKR1lW?= =?utf-8?B?SlBRT0VISlorQjA2YmRhTncxNGNTS2NhNG5IYVdycDQ4SzNVZjVZSFpTdWRk?= =?utf-8?B?RTYrNWVoNU9sRmphTlVWanN3SjdEZ0tuWStnMkRwVUU4bXJld2xxK040Z0xB?= =?utf-8?B?UFpGeS9VVHJMdFNnaWtPOGRRdDlqMHlWb0oyS0JhUkpTNlpJbUp2a2FSZHRY?= =?utf-8?B?a0M0VWNUMFVWTkRlOU1mRmVxcWpKcE5EM1lKNG9MOHY4VkxoaTZjR0hBeDcw?= =?utf-8?B?OThnUHlrNWV4RTM1VWg1N3JOUWxTYytOQWNrUnZYSFYyOXVlaGk5YktMZHpr?= =?utf-8?B?Q0d2SFovN0lwSVJMNFhmRyt3blNvb0d0V1F6Y3lmNENKNmc1VTB4THpsMWoy?= =?utf-8?B?N3JBaEpBOXcrWEJrb3FHUlJFUDZLa0JzbTd1WmpENFNLQUdLR1hEdUZpbXpr?= =?utf-8?B?U1g5NGJmNDczN0djdEQ0bStWUFFodkxkWTFtOThGNjY0Q2dqOUtkeWZQUGhH?= =?utf-8?B?WlZmR0FrZS9Da1FHRlFPY01wMTZTWG1CcjFmeitpRXZ2NTMvWHNHZndrU3Jl?= =?utf-8?B?SXJIWjhGb29lYlI0Y1poVlJTcGJwODFMT2g4MURFVjlyc3pVY040Ulh4cEJW?= =?utf-8?B?WCtQZzRWaElsT1VzVnUwY0o4NzhRL1dwVWR3WmZtaTJaM1lRNXZLZ1g0b1M5?= =?utf-8?B?Ymt6cjhSL1p3Wi92VUVHL3l2c1gzUmowT0YzdkNzTzRSUjl2cGsvdkxqbWNh?= =?utf-8?B?Um4vVFJkNllMTWNEWWh0N1FzRG1WWEtaM3BtSWNqYTJ6cXVjazVhMkg1Q1B0?= =?utf-8?B?bFJ6QytLeHdBR2FyOWt0KzJRTWhBU1FXSVBSVmExRjhwOVNQZEVCaHc4OFl3?= =?utf-8?B?d1VMZ1EwUVBmU295cnpkdmVieGdTazJMbU9sVGJHUXpyY0RVU0tZTkQrSDBh?= =?utf-8?B?UlJUbEhZU0xiV2l4OHhmQTlKdlZ5Zmp1ZkJXemZEamEwbmM1Y1czWHV6NTNK?= =?utf-8?B?QnVBbS9HWlp4QXQ5aEI2cWhJN2NWTkR0Y2J2cU55eTR6eDRZQndiVWFVYlkr?= =?utf-8?B?QzRvVnNpYS8wSXFjVm14R0FqMnlyQTh4ZXlPSExjdHdUZmxhZFhyc1k5RHlP?= =?utf-8?B?bHpsWG9TUEJsYWUwMXFiQ0Ricml0ZTh6UkEzdXpzalh2MjhUdHRtOVJZNFpI?= =?utf-8?B?c3B0TFJXYzVDQ1Zhbk1rTlBvbEFpMTJRWjJmeDdpMG5RWW9jZnRpbVVGb0tB?= =?utf-8?B?Y2IrQlBtWkxMK2VReEQvOU5GRXRqM0hiRjZUNWZ6YjVwNGtUVGtQS3ZrT2Vv?= =?utf-8?B?VVp3WFBMMHVZSDQ0TFZnb2xFYzl6NXlNekduTnZFNnVjVUo2c2IxVm1mV0ZS?= =?utf-8?B?eHpoRTFSSzFUa0EwWTBxbUxFREU0VVVkRUYvNmdjb1RCKzRVTERCMGg1Mlk2?= =?utf-8?B?TjRTT2JuSi9SS1ZTaFFTUWpVelZFQytUUUp4czRXQkdTU3J6RnVrUXkwRzVN?= =?utf-8?B?MmkwUjBLT2VtY29IMjZxSkxTUkhHaWhRUmk2ay9qeHlldFVOYzE4ZHAzTWtW?= =?utf-8?Q?4EJJ6vN4zLoG4+YcyBfInIfUy?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fsX6Kwvj7a/yICeO2iv4qvQNt/37pJi+vEhySIDvbfWgr9QjF0l+Y7wWKyXftvbWe5d17uJnwBGOSaB7FzIsVCIrKJmdJZE6dEZitfrEAj8TdPUYP3Wjf2hgkPNJ72LtvQaVYcJ1UFv+zNvkZgaIDtuZ3nUgchtRYnvB+FIKI2NohZtHFCV9YuYOc9ZhZ1QkBCzppDL+zCGO3xMtuIpVw5Bf4tZJ1iw+xYm9lPTKfHqHSwcocG2Q9cR9AESMa4Bcb1RyVQOX8WOBusWE2uL7sKVADRxCCEvIRiyZfMwxRqMkK8RaZ9QRpRQr+DHht7dtTSaXBnf4o+ZAEW6RCX36tUS6P7cfBIDkurNIKSTumeXBcEg70MvpngH4p8FY+DUDBb0hiKhQliZMbd29SnPHJpsjnkYtPNmkVUmTa6noluhssWQAZcO9ucVkhhZQUVClV6QFoeZHfn+SHZHrcwHsRX7CvOiAcmpHRgrcXdMqUNS/fo5sVbuwXlCkFT4ssZpeGW7FGO0I9ZQgYmAFioVMoJzJPBqpjdRIJWnWh0zjuMZfaqu1XxKKdt9Or9mRqcdhyul8QNBzTSHlFM+s0kjIZIYpxbeqeq4XaEjImFVui/nMrGdOWV0LlxHvMV6wi+1cU9vJ/i/e2fusFXYoIzzvFatvCs2GggfACzQadoSolPzfIgJXEEoo43oBU1dsoBsKyootkqADeNpXuu+AoCsnCko7lLh6a8+o7r74snBG3bcrED7Mb7sloCcCFopbXfFlOE0WRfcAlqSmLxlMXYigKDEysRRhK+jJ+3/dJ9QBF2OHoy28Bv7mxy5Y/cgXdWrD X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4c60915-542c-40fa-2b1f-08dbd1897f6f X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2023 16:27:48.1619 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6eiQH7WvjBXKCfpaGN3uuaLLqexhxMHztrl+p1c/NAr1EmC2KCJG39yaHz+W17jxH8dmfkvX7gWoYpfACuL6KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7446 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-20_10,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=842 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310200137 X-Proofpoint-GUID: DMuvDetP16ji4ATNUdjjpbXRlW5YkarM X-Proofpoint-ORIG-GUID: DMuvDetP16ji4ATNUdjjpbXRlW5YkarM X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66636 Cc: "66636@debbugs.gnu.org" <66636@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBUaGVyZSBleGlzdCBtYW55IHBhY2thZ2VzIHdoaWNoIGRvIG5vdCBlbmFibGUNCj4gbGV4aWNh bCBiaW5kaW5nLCB3aG9zZSBhdXRob3JzIGhhdmUgc3R1ZGlvdXNseQ0KPiBlbGVjdGVkIG5vdCB0 bzogbW9zdCBvZiBEcmV3IEFkYW1zJyBmb3IgZXhhbXBsZS4NCg0KT25seSBiZWNhdXNlIHRoZXkg YXJlIG9sZCBvciBpbnRlbmRlZCB0bw0Kc3VwcG9ydCBhbHNvIG9sZCBFbWFjcyByZWxlYXNlcy4N Cg0KSSdtIG9uIHJlY29yZCBmcm9tIERheSBPbmUgYXMgX2Zhdm9yaW5nXw0KdGhlIGFwcHJvYWNo IG9mIENvbW1vbiBMaXNwIChhbmQgbm93DQpFbGlzcCkgb2YgbGV4aWNhbCBiaW5kaW5nIGJ5IGRl ZmF1bHQgYW5kDQpkeW5hbWljIGJpbmRpbmcgZm9yIHZhcmlhYmxlIGRlY2xhcmVkIGFzDQpzcGVj aWFsLg0KDQo+IFNvIHRoaXMgaXMgdGFudGFtb3VudCB0byBwdW5pdGl2ZSBhY3Rpb24NCj4gYWdh aW5zdCB0aGVpciB1c2VycywgaW4gdGhlIGZvcm0gb2YgYW4NCj4gdW5zaWdodGx5IHdhcm5pbmcg ZWFjaCB0aW1lIHN1Y2gNCj4gcGFja2FnZXMgYXJlIGluc3RhbGxlZC4NCg0KSSBjYW4ndCBzcGVh ayBmb3IgYW55b25lIGVsc2UsIG9idmlvdXNseSwNCmJ1dCBmb3IgbXkgcGFydCBzdWNoIHdhcm5p bmdzIGRvbid0DQpwYXJ0aWN1bGFybHkgYm90aGVyIG1lIGZvciBteSBsaWJyYXJpZXMuDQoNCk9u IHRoZSBvdGhlciBoYW5kLCBpdCdzIG5vdCBjbGVhciB0byBtZQ0Kd2h5IHdlIHdvdWxkIGhhdmUg d2FybmluZ3Mgb3RoZXIgdGhhbiBmb3INCmJ5dGUtY29tcGlsaW5nLiAgKEkganVzdCBoYXZlbid0 IGJlZW4NCmZvbGxvd2luZyB0aGlzIC0gdGhlcmUgbWlnaHQgYmUgYSBnb29kDQpyZWFzb247IGR1 bm5vLikNCg0KVGhlIG9uZSB0aGluZyB0aGF0IGRvZXMgYm90aGVyIG1lIGFib3V0DQp0aGUgY2hh bmdlIHRvIHdoYXQgSSBwcmVmZXIgKGxleGljYWwgYnkNCmRlZmF1bHQpIGlzIHRoZSBvdXRyaWdo dCBfcmVtb3ZhbF8gb2YNCmBsZXhpY2FsLWxldFsqXScuICBUaGlzIGlzIHJlYWxseSBhDQpib3Ro ZXIuICBDb2RlIGNhbiBiZSBjb21wbGV4LCBhbmQgZm9yIGENCmxpYnJhcnkgdGhhdCBoYXMgc2V2 ZXJhbCB1c2VzIG9mIHRoaXMNCm1hY3JvIGl0J3Mgbm90IG5lY2Vzc2FyaWx5IHNpbXBsZSB0bw0K bW9kaWZ5IGl0IHRvIHVzZSBvbmx5IChsZXhpY2FsKSBgbGV0WypdJy4NCg0KSU1ITywgaXQgc2hv dWxkIGhhdmUgYmVlbiAoc3RpbGwgc2hvdWxkDQpiZSkgcG9zc2libGUgdG8ga2VlcCBzdXBwb3J0 IGZvcg0KYGxleGljYWwtbGV0WypdJyBhcm91bmQgZm9yIG11Y2ggbG9uZ2VyDQotIG1heWJlIGZv cmV2ZXIuICBJdCBzaG91bGQgYmUgZW5vdWdoDQp0byB0ZWxsIHVzZXJzIG5vdCB0byB1c2UgaXQg Zm9yIG5ldyBjb2RlLA0KYW5kIHdoeS4NCl9fXw0KDQpJbiBfZ2VuZXJhbF8sIEknbSBub3QgY3Jh enkgYWJvdXQgRW1hY3MNCnJlbW92aW5nIHRoaW5ncywgbm8gbWF0dGVyIGhvdyBvbGQgb3INCmRl cHJlY2F0ZWQuICBJZiB0aGVpciBjb2RlIHBhdGggaXNuJ3QNCnVzZWQgaXQgc2hvdWxkIGJlIG5v IGJvdGhlciwgZXNwZWNpYWxseQ0KaWYgaXQncyByZWxhdGl2ZWx5IHNlcGFyYXRlIGZyb20gb3Ro ZXINCmNvZGUgcGF0aHMuDQoNCkRlcHJlY2F0aW9uIGFsb25lIGdlbmVyYWxseSBtZWFucyAoMSkN CnRoZSB0aGluZyBpcyBzdGlsbCBzdXBwb3J0ZWQgYnV0ICgyKQ0KaXQncyBub3QgZW5oYW5jZWQu ICBBbmQgaXQgd291bGQgYmUNCnRvbGVyYWJsZSBpZiBkZXByZWNhdGlvbiBldmVuIG1lYW50IG5v DQpidWcgZml4ZXMuDQoNCkFuIG92ZXJlYWdlci1iZWF2ZXIgaW1wZXR1cyB0byBfcmVtb3ZlXw0K ZmVhdHVyZXMgaXMgZ2VuZXJhbGx5IG1pc2d1aWRlZCwgSU1PLg0KQnV0IHllYWgsIEknbSBub3Qg bWFpbnRhaW5pbmcgRW1hY3MsIHNvDQp0aGlzIGlzIGVhc3kgZm9yIG1lIHRvIHNheS4gIChKdXN0 IG9uZQ0Kb3Bpbmlvbi4pDQo= From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 13:40:44 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 17:40:44 +0000 Received: from localhost ([127.0.0.1]:41400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qttUJ-0007Zl-OT for submit@debbugs.gnu.org; Fri, 20 Oct 2023 13:40:44 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:51447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qttUD-0007ZP-CJ for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 13:40:42 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c50cd16f3bso15723361fa.2 for <66636@debbugs.gnu.org>; Fri, 20 Oct 2023 10:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697823604; x=1698428404; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=g6GKiLGHnlTcLscTsluhUOKAOiG0+ohqt3hyCQ4Src8=; b=jZkkJw2Di7AQSOsTSx+zhb27C9N8DvftIdwtO9fslSOIEa/Cx4uJx+Lx8vsLzKIgSy h1Oj/gn6fwOT1h8Laz6GiyUBn3oY8WLwI7rahCnQU4/GuuZdZJQfy7zYHFg2rZRmf13v tHo7cDhmeziMALQyGT0kqxjXn6F+NjVSNGQyU0oaXq+AmSv9CukQJW7MLvYGLIJlkb2J lMc+VB2ifHZ16/pDI5W1P9Jg0mHXuPhYHxHixCano7Mx2D0kkVKIXjnJKpStVGJSQmBf WDO6L3ASgvyYEpbmJL5wD152h5dnZlcvjlK2qrKNVa4gt3sAVbW15xRyWbnoxNlDCuaH TpoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697823604; x=1698428404; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=g6GKiLGHnlTcLscTsluhUOKAOiG0+ohqt3hyCQ4Src8=; b=QN1vlFmDQ50K8ffgnH/DQwSWtM3zKc2QX0xphcedIQYYkHuM3BcfH06+CJG/ETLjup iPaFiBK3X+BrIXSvR7ssVDWu8Rv3CJTnW+xGG4S5ggTqLDV+mBoJ6I94TK6USyrK+t/3 h949jjsHHhKJE3Hw5drkNwRl9PWJY4XIGODION5iVyygKoJipN1syXCyTKm4nB4+YOyV rPnJok19oE+CuO57rrIvarAWpxLvXgignz3kdhJn0hFpOp6f9crt+Ggly58B8dMRk8Lr 8C/rw5fqQ/va3X5ujbmwJ2MUzA1ZMwzL0M85Dz0QzhsskSUVHBLxRXPyiy3bCHG0jkLI 9DUw== X-Gm-Message-State: AOJu0YyAg/Sxmq0aYPuULimUsImhR0iR1luRiM7frCgp4aM5fakQZK6n sm5rfYS1l8pkKcT9XiH1dJg= X-Google-Smtp-Source: AGHT+IFTzst1Z+NaeuylPsaqtw16AnOLL+LVngNdXzQ01y58Iyzw55kgmIxeMQi7VoAv6gcs4QrD8Q== X-Received: by 2002:a2e:9bd6:0:b0:2c5:c31:eeac with SMTP id w22-20020a2e9bd6000000b002c50c31eeacmr1883275ljj.15.1697823603786; Fri, 20 Oct 2023 10:40:03 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id f12-20020a05651c02cc00b002c50717cacfsm462947ljo.51.2023.10.20.10.40.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Oct 2023 10:40:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 20 Oct 2023 19:40:02 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> To: Stefan Monnier X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636 Cc: Po Lu , Eli Zaretskii , Stefan Kangas , 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 20 okt. 2023 kl. 15.38 skrev Stefan Monnier : > No, it's just asking those authors to make the result of their = studious > work explicit with >=20 > -*- lexical-binding: nil -*- Right, and our sympathies are not so much for people dead set on writing = new dynbound code as for users saddled with dusty decks. Looks like there are no serious objections so the changes will be pushed = soon, probably some time tomorrow. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 15:28:33 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 19:28:33 +0000 Received: from localhost ([127.0.0.1]:41481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtvAe-0002h8-PW for submit@debbugs.gnu.org; Fri, 20 Oct 2023 15:28:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtvAc-0002gt-6x for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 15:28:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtvA4-0004qo-U5; Fri, 20 Oct 2023 15:27:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=I0tTTJ0f9vANVCHmZ+OyS5/71BT3kXwNtFJDPxuCEHw=; b=Xt9wuLiYnDZikyHSDLVR gjPpNBqd3xu32zRLm+7hs25PSOlBkmuZQ9s75R3UV9ESZoe4o8vIkxKpN0j9Cc8A1QMaRZam3fLYG D+U4FDgfjbNO/syz8LU2ca9e/kfZ70XUPCrlB92tsRFz9stABHZfbZexRCwTS3Kk4jQp0SNRWxa19 +4/xlhqZbx6l7Tjh48UOGXwZYFNoLrMLK/5DKdbypdbLZv/N4QZCIIu/3dZqy2B4H2yCa14xsfAv4 aPlqfSdQL8v68/vMwQDX1SkXv3MpQxXpZ/OPYETzoJ8pyDMUnCJU1DJcPpxrf/AVWJgh2LAMe4kwS xOnE5d0hBaqlkA==; Date: Fri, 20 Oct 2023 22:27:32 +0300 Message-Id: <83lebxrt5n.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Fri, 20 Oct 2023 19:40:02 +0200) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, monnier@iro.umontreal.ca, 66636@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Fri, 20 Oct 2023 19:40:02 +0200 > Cc: Po Lu , > 66636@debbugs.gnu.org, > Stefan Kangas , > Eli Zaretskii > > Looks like there are no serious objections so the changes will be pushed soon, probably some time tomorrow. Really? Is that what you deduced from the messages posted about this change? Did you see what Po Lu and I said? What is your response to that? From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 15:45:02 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 19:45:02 +0000 Received: from localhost ([127.0.0.1]:41502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtvQb-0003CG-Fy for submit@debbugs.gnu.org; Fri, 20 Oct 2023 15:45:02 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:52319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtvQW-0003Bi-6O for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 15:44:59 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c523ac38fbso17824131fa.0 for <66636@debbugs.gnu.org>; Fri, 20 Oct 2023 12:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697831063; x=1698435863; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=qnAGHJJsSKQrm3lR8X0C4KV9/oE2t/mcb3fqasVLCsw=; b=BPxkQTl24tYAyxaH4sWXAvK7TlVBJ/gwmvE4HSEjKlVDZr7SOo1xYmlHzJc7x1lH58 23k5ge6rhH7WQop+GTR/DEb2wLPv+IOt/iJGI+FzK6wGppg5VMbzv7GGzxtr2dTUiyid NOAAiRKHidd/g5BfjrpScgcWxDOCdWEGgAKpsxMNgxgUPZ4Ke6OR9YS3Q7iERcGz6yWe Zt1mGIbLTsYTUR6WCj36eF/Gfx5DhrIvBFVjtALw/+T+TGfTiov2wgOMEc/H8krR5fiK 9Q6XPJYf9YCPJQC7CWGngyml7S6NXOi3eNxN1kKF+jFz/WhfARU0ZlNqQU+vbVIxJ3R2 mgfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697831063; x=1698435863; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qnAGHJJsSKQrm3lR8X0C4KV9/oE2t/mcb3fqasVLCsw=; b=DT0BoIwadFBrLZRG2mr92pgfj+aZZ8DfuOvyIPED+tJ8zjgazmfU8wh4gCu851e9JL gV2O8U8Y4lAqFdBw4Q/9V5kR84yN8N8mZAPPkaPiVrsvLiOQdeaGBWmqeX7WKuIld++b 988Si2MDaaJSKjyduRfg895KvaBuYhlh4dphgLI/MJ/Tcy+ASht1W0PaBEihtIvAYiQ3 Jdf8Ow+ZbcpJchj8Hbdt10tXgGDR3j3pfwpK3SEBdTm2G40GtM7EvC/RymGTrJAvo4Tr 4xfIKlZUcl3R60pbO5/DDHTKf5Y0gEbF2hzpyvwmXyD9gbp0RDqp5vpX5g6dhPNOeUFF k7ng== X-Gm-Message-State: AOJu0Yz+0niY4BFgxWPdRcJFHE8UpomOe956lrG7xZGzNz53f7JaWRCQ ns6PsXWppJNnzemSu5nmyfrmFsUjRj5NZMNEkeQ= X-Google-Smtp-Source: AGHT+IFbavapT9ME0uxed60CPSitgbnLv8sYxYLYqFSmoBRN2aB/CgS/KWBo9BFb+l7QndN3KFK5lW+cmHNJA/+UoXo= X-Received: by 2002:a05:651c:506:b0:2c1:375a:b37c with SMTP id o6-20020a05651c050600b002c1375ab37cmr2068612ljp.40.1697831062466; Fri, 20 Oct 2023 12:44:22 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Oct 2023 12:44:21 -0700 From: Stefan Kangas In-Reply-To: <83ttqlsqrn.fsf@gnu.org> References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83wmvhsron.fsf@gnu.org> <87lebx4vhw.fsf@yahoo.com> <83ttqlsqrn.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 20 Oct 2023 12:44:21 -0700 Message-ID: Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler To: Eli Zaretskii , Po Lu Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636 Cc: mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I don't think so, at least insomuch as byte-compile-warnings doesn't >> function as a file-local variable. > > Then maybe we should allow that for this new warning (and potentially > also other warnings). If adding file local variables is an acceptable work-around, then adding this to the .el file should be acceptable too: ;;; -*- lexical-binding:nil -*- And that already works with the proposed patch. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 16:56:04 2023 Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 20:56:04 +0000 Received: from localhost ([127.0.0.1]:41735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtwXM-0005on-B0 for submit@debbugs.gnu.org; Fri, 20 Oct 2023 16:56:04 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:61547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtwXJ-0005oH-KG for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 16:56:03 -0400 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so18962761fa.2 for <66636@debbugs.gnu.org>; Fri, 20 Oct 2023 13:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697835328; x=1698440128; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=JlgjT9ao0V/pqx/8e35V4+kmfQMkMC+KSlSk99V0tnA=; b=Zfmm/2+jRTTWpU8MTDa2+8/++igAq1Z6VlIdfcu+JNvKPqlNM8k2iJHx4ueJx362F6 JQI5jwqxolCH2RCdZnmToqHhvhsXXjAI9Oir2Wuw7QvEmTLvltMh3vgFFhHRVLrRlcwF dHPXwOo3qnQDambcxw5J7Ap24xeHYtiQ7oJZ7NSU5+o9ykefyVHm74Zes1bxekEea6aj IbWt+OMjAiBczrYkFShO1fk1jv5mmuC7t6mbzdC1xfyibT8MxYrrUTbLkqON7UxSM8+z Fjsymj7a5m+Y61O+P1TzRhbWOVMLeLrKZn59gCXfv/VAFkU0i7H1vHH6kk+Zbm4y4cbR oy2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697835328; x=1698440128; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JlgjT9ao0V/pqx/8e35V4+kmfQMkMC+KSlSk99V0tnA=; b=bO8rC+z/FSYgRTZTxwz6EDfmpZplj3hh9AOmrgBat8tW2CSdd9Wz+Nn/Ru9yVrBIwq X6x+KZu+h3JJHzNRKzTRUkrKwNeMiFoXLoVMs0cLL9ATdmoN8qO700l3jtVIpue68fnJ l1H9E8qKzaPDxmHUVpRsWBdZRN4be4AZdPMj9DmtlCRFAO2pTLmQz3FHA89O96ndLo02 acJFng8fXwEXZRxWgu+lzWMgPDqivWfShv+HQr7edNNv8ktVhqOPAjdEx6+JHwqy/CFa hCuj1KO+SeVrx4l9dYm1XnVsxL4ZSJoFc/Bh6ARnQP33ZHDqR2n9sOQEWMuiq/DlcD9U +UUA== X-Gm-Message-State: AOJu0Yy+RTgdFPae6V81Ghs/AHK9PfcPuEn9+5Sj/aldfxco2FXi+9TP WIWKacCmnpNgClc7oqpO4ngPXvoNMnPkgsI0XQw= X-Google-Smtp-Source: AGHT+IG+geT59LNAYnnWiP/qa2+ezehkeDT+T9UJmhLfif+CLt8GUIJ9Jphng6zSchucb7V+2JgTaJ2yqGieFuOS24Y= X-Received: by 2002:a2e:96d6:0:b0:2bc:efa4:2c32 with SMTP id d22-20020a2e96d6000000b002bcefa42c32mr2333459ljj.37.1697835328064; Fri, 20 Oct 2023 13:55:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Oct 2023 13:55:27 -0700 From: Stefan Kangas In-Reply-To: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> MIME-Version: 1.0 Date: Fri, 20 Oct 2023 13:55:27 -0700 Message-ID: Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636 Cc: 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > (I always found this traditional first line to be somewhat of an > uneasy composite: too often it forces unnatural brevity on the > description, or becomes so long that it wraps. I'd favour dedicating > the first line to the -*- cookie alone.) I mostly agree, but removing the traditional file name is another reasonable way to make the line a bit less unwieldy. I'd be even more inclined to make a change like that, myself. Going on a tangent here, but I always assumed that the file name on the first line was there for hysterical raisins, going back to the good old days when people had to resort to sharing ELisp hacks on Usenet. These days, with GNU ELPA and git repositories, there is no risk for any confusion about the name of a file. I might be wrong though. Perhaps it was always redundant? From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 05:54:37 2023 Received: (at 66636) by debbugs.gnu.org; 21 Oct 2023 09:54:38 +0000 Received: from localhost ([127.0.0.1]:42243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu8gn-0007uk-Is for submit@debbugs.gnu.org; Sat, 21 Oct 2023 05:54:37 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:44347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu8gj-0007uV-OF for 66636@debbugs.gnu.org; Sat, 21 Oct 2023 05:54:36 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5046bf37ec1so2130686e87.1 for <66636@debbugs.gnu.org>; Sat, 21 Oct 2023 02:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697882040; x=1698486840; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=N0HxKEINUQxLFJB/QnoSAoURB/xxTbvaWURpxogokUU=; b=ZC8wZUW0uXAHWageS+RUZnP4kckhEW9oSA9YQ1yg+dkKQ2AfQ+nrlrvEtMoiSKvrpp y/7w0WMzE8rpXv1dcbDOxEiKDlOR8tC9ZhkYPiXeLnTmIBrZHSkp9Yt5FtvfYw+zAoS+ I+YLJGY4jwVn0G+TmEV33z+GK8cXtDy6dDX1iqHwXgjjYDFgfQllkmIMvVZzv0bzALQv PJ9lzgZN2mZNEDADBTHh8yS+vcdFNyU97cFnQi5VhCXjxeyn0+wqQeoHTceS9uJMv9iD 8Pi/OvTNVbLvZ4a3jDdj6hbZSHbFQOy71DdQHX4r9b67mcXSWCGjTOPfBxZ7Rwnml8pb KhGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697882040; x=1698486840; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N0HxKEINUQxLFJB/QnoSAoURB/xxTbvaWURpxogokUU=; b=xSYic+3VwRIy1C962kQF4qKock32Yrh8/XYfl5Cmha3mDy6iDTMm+0ZiWUj1rOWUVQ W+Fhk1OqY3RTz5qWmHeksZcBFKukcOfuDnWItXctt6f7mjwdOHFarLZnu2+qmfE4ihhr GCMtayPoqDbWTdt6Fr8gPx1vZ4fHOBIgFF+LMhdbb8GgMl+kVtV121dllZyvxTQ5ipyt ohqvDgCJtLvGkvUYI2+7dcjLQvnoj8pLp2LdBGS9vbYHFyMglUFHesMR8i+5tfVtxefr 1V894jl0nPog5/Y+mATt+slwdSWLJiHThyMzOEhVzUlVwrkVUVEbhHP2o1WMGBysnUjo vX7Q== X-Gm-Message-State: AOJu0YxwrWv+0UBiq7cKPg4FpP/bwBO9msZ1bKVVXRk5UdKAYdhqecv1 z27xyQ506aRaekSJLq9zTmY= X-Google-Smtp-Source: AGHT+IHlKMEfljkYDZW8WGopoMLEPmaVeHOxX0xgeDJ8CrxLMkixR8sYqQ1M9lTas4/RlFP77mjkdw== X-Received: by 2002:a19:434d:0:b0:503:655:12e7 with SMTP id m13-20020a19434d000000b00503065512e7mr2920287lfj.62.1697882039852; Sat, 21 Oct 2023 02:53:59 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id v21-20020ac258f5000000b004f86d3e52c0sm794208lfo.4.2023.10.21.02.53.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Oct 2023 02:53:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83lebxrt5n.fsf@gnu.org> Date: Sat, 21 Oct 2023 11:53:58 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, monnier@iro.umontreal.ca, 66636@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 20 okt. 2023 kl. 21.27 skrev Eli Zaretskii : > Did you see what Po Lu and I said? Not sure what he was trying to say, but it looks like a = misunderstanding. I'll try to clarify matters here. Please tell me if you still have = concerns. We certainly care about users of legacy code. The warning is intended as = a soft nudge to encourage users to convert their code to lexical = binding, which is quite straightforward most of the time. When it's not, or when the user simply doesn't have the time or = expertise to perform the conversion, it's just a matter of inserting = `-*- lexical-binding: nil -*-`. Doing so will both silence the warning = and buy the user some reprieve. A lot of reprieve, in fact. This should probably be pointed out in the NEWS entry as well. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 07:18:25 2023 Received: (at 66636) by debbugs.gnu.org; 21 Oct 2023 11:18:25 +0000 Received: from localhost ([127.0.0.1]:42377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9zt-00055e-3Q for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9zq-00055P-EQ for 66636@debbugs.gnu.org; Sat, 21 Oct 2023 07:18:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu9zJ-0002QU-3O; Sat, 21 Oct 2023 07:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GZTVXhTcYk1sQCFws/lpzyvrbk/aDjIDFkActJHMfqU=; b=hp7JbFCM/AUOfS/Gg7Zu rLdC4vdvxslEpX27Yp7BELT5F9yIvOAHySqNgFcrgTIYenXQRXK+P90g+YinI4zYiPYXlKTWsVm5g sfqdCcE2OzvMwpDBjlkdVSyMygsvReUlDo/2mjA02PBgKnu6dlXMEWIvn/i+ogDmDPOb3Bf/AJb8/ 89DCs6o28czZkid7itN2sCMlKTF0jedg61kTgUdcpkrYo/yOZEi6iN1Pc8HPviWuZ6bPS4ew6HItC dBZ/m/muG5oZLZBrFI6qm0/MuBmgXfg2W7tVQ4LTGz5ahFKROzVcSXWmNfGiUsee9+NmCHelHXocF B6xf9dzo6K2mfQ==; Date: Sat, 21 Oct 2023 14:17:45 +0300 Message-Id: <831qdorzqe.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 21 Oct 2023 11:53:58 +0200) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, monnier@iro.umontreal.ca, 66636@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Sat, 21 Oct 2023 11:53:58 +0200 > Cc: monnier@iro.umontreal.ca, > luangruo@yahoo.com, > 66636@debbugs.gnu.org, > stefankangas@gmail.com > > We certainly care about users of legacy code. The warning is intended as a soft nudge to encourage users to convert their code to lexical binding, which is quite straightforward most of the time. > > When it's not, or when the user simply doesn't have the time or expertise to perform the conversion, it's just a matter of inserting `-*- lexical-binding: nil -*-`. Doing so will both silence the warning and buy the user some reprieve. A lot of reprieve, in fact. > > This should probably be pointed out in the NEWS entry as well. If specifying lexical-binding:nil in the first line is the solution for those who want to keep dynamically-bound code, then yes, it should be definitely in NEWS, and probably also in the ELisp manual. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 09:18:03 2023 Received: (at 66636-done) by debbugs.gnu.org; 21 Oct 2023 13:18:03 +0000 Received: from localhost ([127.0.0.1]:42558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quBrf-0008Mq-3F for submit@debbugs.gnu.org; Sat, 21 Oct 2023 09:18:03 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:42006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quBra-0008MJ-7S for 66636-done@debbugs.gnu.org; Sat, 21 Oct 2023 09:18:00 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c3e23a818bso20428251fa.0 for <66636-done@debbugs.gnu.org>; Sat, 21 Oct 2023 06:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697894244; x=1698499044; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=kqI06zuiqHQT/61DAwgGN3Xn5wAZeQq9bMvwsiGGiHA=; b=hg6NaXNRZwwjcYsXbf9//VqCPRIUg5Daa+WfBEr9DnMhWdiLyLJ8DTon/wZEnYM9rg 8fBxGg6l/cNkTOugtk17VuFXncfLZBFPbCTAnQ6aY1AHWMVRG/2Jxq17DYr7ml/NBH1L ThUYhTx1YR4RK2rulpvcNYU7BqUBaKx3LnJtxogdN4ygp+inRxbYIsH18fcutt46y+nR rFrWX1/Qr9jB3eeZiOnYd/uibuH1DKI1Bx3aT9zLTVQ7ZTXI2LRoRcFT4GB5SMzlJv+1 d+jYZCXxRxR466ch3zA0mhBkSNS3oT1vbEaPHNew7eNUT9EMiCRkdzm+r6ZYNFMX0c0g k9Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697894244; x=1698499044; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kqI06zuiqHQT/61DAwgGN3Xn5wAZeQq9bMvwsiGGiHA=; b=gZTnUfyddiDEL+tBCUjkYbck7POfK6nd0/BX9DBi5wgmuoFRqkmIfuT/y+onerkZBa FUiY3PkQO8FW3iZnvuPv8ryQD3uL3BFKLUWpNxzftA99ZJ5re+a/BMQw1m/Wip/2d2Gn k2CBx9BiZur2LKBTcDP4/DujBrQCSQNI33ulxds5yjn5zeCa6yX2oaNEyDamRcynsq7f EOyg7Eeq6JhxQt/jQElVTNmY1jBc9JECjq26y6OY7bCw06nvi+yfbk1iioF9KD7mB10+ HuMmTLMMWAUbulT5EOoyhIQvkz21rctvhnQ/ST8Ar/YYIkt/3lhm5YC7tNWj5zxiMiRq /+jQ== X-Gm-Message-State: AOJu0YwMUT1NENJmm1en/s9EYNGbFxDHjx4s3ncN25/1NE8RmPPvRm+O RAcTfiLcN87ucckWE3a+Fn4= X-Google-Smtp-Source: AGHT+IGxTU9Nd122/AmvNPkfdxXTLnwcxEb+Gisv2e5rJcccWiaeVrqm+lYnu+DMkHW0ixxvn6/Miw== X-Received: by 2002:a2e:a4c9:0:b0:2bf:fa16:3aa3 with SMTP id p9-20020a2ea4c9000000b002bffa163aa3mr2226712ljm.25.1697894244245; Sat, 21 Oct 2023 06:17:24 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id e22-20020a2e9856000000b002b736576a10sm822447ljj.137.2023.10.21.06.17.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Oct 2023 06:17:23 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <831qdorzqe.fsf@gnu.org> Date: Sat, 21 Oct 2023 15:17:22 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66636-done Cc: Po Lu , Stefan Monnier , 66636-done@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 21 okt. 2023 kl. 13.17 skrev Eli Zaretskii : > If specifying lexical-binding:nil in the first line is the solution > for those who want to keep dynamically-bound code, then yes, it should > be definitely in NEWS, and probably also in the ELisp manual. Agreed on both points. The patch has been pushed with that change to = NEWS, and Elisp manual revisions are upcoming. We are a bit behind on = lexical-binding in the manual so it could do with some more work. Thanks to everyone who commented! From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 10:43:37 2023 Received: (at 66636) by debbugs.gnu.org; 21 Oct 2023 14:43:37 +0000 Received: from localhost ([127.0.0.1]:44835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quDCT-0005z2-D3 for submit@debbugs.gnu.org; Sat, 21 Oct 2023 10:43:37 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:61738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quDCR-0005yu-CT for 66636@debbugs.gnu.org; Sat, 21 Oct 2023 10:43:36 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39LDJCQ2032716; Sat, 21 Oct 2023 14:43:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=VSx5E7ZPYKmMb6F8KGPRRGW7RmRI5xq7QBt8sw+gydQ=; b=ht6n42h/jjZZElvKVyfvFvjwJUCzYufLNFvA1oyp5tcWZOXZUjOyTtRMsKJgZvbnV5te 3dsMDyF1Y1NSOgTTMtyQJK6bSi0wNA4zQrus7ZCmiXFADXGKFZ7OrOOyMz7DEu/W21H0 y1Aw9WTxbw/pVN5ERMqFCbcHaGJ1pC6MTFBP0U65GhzI+7wGRWKdslh7EGAP8tU44JlA 41J1lzxY51ssO/FIB+Bxo148ljiNGe7xuaWr4HtuW4l8Yb4UfSXyKLr+PNVvrhn2oBBo KBzDzMuwVlK1L2pH8YXeffWPkOChsWPcNNPF3U92+pLrErt7QpJuYY1JUK6FArSijLtK IA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tv5e30pct-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Oct 2023 14:43:06 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39LAU8wM034616; Sat, 21 Oct 2023 14:43:05 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2100.outbound.protection.outlook.com [104.47.70.100]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tv532dh6n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Oct 2023 14:43:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayja1AnybU9w01ZfKX3TZrCxa6JI396C9TLquMezxP/HO3Lhm1L0b80h9fV9mKsiwooZSHvQHOOziFdZ3H1u992cUG3Kd/2Dm1zY3OQocIN5x+xT2ZWtKUSdr6K1gEepb+y6hQPnAp4KFmrc9Oa3sDfXpOGqYN0fG2asrRNozISP2b7W5aM6ArgH6/UKv7oinE7j7eGFTPD8pTaL55RwgpNcEjMAWggF1JRx6MZiKhQZoWwhmJGl+67BZwM1wzWjf2YtWWggXPNuZUmSwemWexJCojJMJUIkfJWiJp552WNvbJLRrutp/EZsVwsdvJUqY3H9VRaM0gm/lAPSIT5MQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VSx5E7ZPYKmMb6F8KGPRRGW7RmRI5xq7QBt8sw+gydQ=; b=d5ogb5gfnmLyiOOtOpq4ltG6Je3eB6DRBKfa+USjtfZZd5Vgt6r1sf2WBB5XkbkouOk/jgBnrI6fg/39o+Wg3j5T8/lq1zHajdm7nfIBBPWdzTw9WhGqtZC23RuNMzhmcfVxUwL1VQpbvoQvr3sE0YE8ZqST10/URhJU9GhU7CsV9mEgAfZt9Mh+uacd3sgkqitvSWhkDe+4/urNGvBwA5XLtme8P+99jbQkKHckWU99V9Bgn09dN1+hxCkyq550d5ovCCG7oNsq+8TuuJFQc94hSfj1edoa4MkdC2UHJ5S5lrqLWzvthMzQ/kcnyVX1+5P2VPQVMayKdm69/MlvuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VSx5E7ZPYKmMb6F8KGPRRGW7RmRI5xq7QBt8sw+gydQ=; b=Z3aTZOQ20X+rd536sG+60O+rbH9iLY6ub0+Z2HvnAFDQMI1D4DRRvMnrHDgufucexKyXfj0uf+Z6KHISE3Hh3kEgdaHf8p7xrP15gnGH7wSdSxuwsTi6Al8TvreuvsZB0VYNqzEk9+ZGxrTUJK6BghWxTAvcaYFdeDTw1cRCmKI= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BLAPR10MB5284.namprd10.prod.outlook.com (2603:10b6:208:333::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Sat, 21 Oct 2023 14:42:57 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::adae:506b:e9a0:529f]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::adae:506b:e9a0:529f%6]) with mapi id 15.20.6907.025; Sat, 21 Oct 2023 14:42:57 +0000 From: Drew Adams To: Eli Zaretskii , =?utf-8?B?TWF0dGlhcyBFbmdkZWfDpXJk?= Subject: RE: [External] : bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Thread-Topic: [External] : bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Thread-Index: AQHaBBBylWChoI4NcEyVx3L8CdlG77BUT92Q Date: Sat, 21 Oct 2023 14:42:56 +0000 Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> In-Reply-To: <831qdorzqe.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|BLAPR10MB5284:EE_ x-ms-office365-filtering-correlation-id: 1d57fb43-6d89-41cd-43eb-08dbd24403c1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nK3UGj95J6/d34ooSpjfWd/HycA2y0fTpzD5Cg+1PvnolhHJ3bD1cC1RPg25vn/ri9Rwz3c9kR4kXnN6eUUEdN7mYcrd9mwYFp+VY2fY/3Qz+AwDOW4fTlWs0U/1ykiscIDKvK35FhvY6twnh4SwtI4UwU/5g7RbMVzaEHEQqGpHs0x3kTJkd0zy4a4/kxpr79BV8BbAmqaqT4qbZ5C1M+bhFFIEeq2QLELQTX9P8XuFqhAjOLJZDMCcp1M/QzH/SipI5Oa5CtBmqTCyK7QvlUNsDzlwDd5DG53eo6bAXkOKdzFmRuWWXydfsdBGHT59lrmw3Ii/yRzjMckTxfSyAElAil55upkSSlOpbB8C5hkeJUx1ETOzxxfyYcVhbqaDu+Khy5KDVWS4O+705f0aJ/4v6NLgJ5UkBWF6/BgkhrJ31mWWY/nyEq4IRvjxSY3k6iOr73IVVPx3d8d5vUWExWijkAKGc79X79+BcWfJgIZOehIl42eg00qhqjeulru/d/7atRxuDlVSHlKK/T/gyRBVa2pfk8ZKX2gtDharWTxESy0nN8vJ339Q/Z4gePiT8SFGkylJqckCIj6FT6pby1s/WtcKlgFyybmD79dOaW0T9dIOEfX+ViBll8KWIgpl x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(396003)(366004)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(41300700001)(4744005)(2906002)(478600001)(5660300002)(8676002)(8936002)(4326008)(52536014)(44832011)(110136005)(66946007)(64756008)(54906003)(66446008)(66556008)(66476007)(316002)(76116006)(86362001)(38070700009)(33656002)(122000001)(38100700002)(26005)(55016003)(71200400001)(9686003)(7696005)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NlQzbHFFcERzTlZ3bU9jaVRaZ3RHS1EzN2ZIWnZhTlIwSEpnRFQ1bjR1NkRq?= =?utf-8?B?eVpBa3Y5UUQ4OFkxNlZPbm90ekVsUTNkb0xOOG5jOHQ2YjR3MzV6MW15RmE0?= =?utf-8?B?RkJpRnU0dmdqTVZ3T3NuTkNhODRqclFtdGpvS2ZYQXh4VzAwbmxBUHFPbitN?= =?utf-8?B?RUxyV2lGbjByd3lKNE9RU1FibzVKaERZNk41b2JaZk90SkVlTlpzckVnNlBF?= =?utf-8?B?OVRmWkRGa3hNcFpISWphR05PQ3YxYWc0azhROFpiNFZXNjhKNUpmZ3JaVDFy?= =?utf-8?B?RWlDTXJsZS9WQ2wwa2V0UHZ2VUp5dE11TklTTXloNldKMllpV0ZlZ1pEODB0?= =?utf-8?B?NmRINTBVbFJsNUpoRDJmd2NPTHFzS21qSGZpUTdJQWZGdTVjVm9yMjAvS2p2?= =?utf-8?B?MzJSMG5yOHpxdnJyenhQeW5NRGhsaWpVUjJFTlUveGY4UjhZVEZqVzBpOTU0?= =?utf-8?B?cys2VjZDMDJPL1dJaHVNcE5JZWZabXpMdnc3SjRSR09ab25zNnM3N2E2Q3V2?= =?utf-8?B?SXpQQXVNNXFoZ3YrbHpPYkVvN1lCSGcxOGV5YVBYZWJoR2dRZVN5bGFKejd0?= =?utf-8?B?TkJseFhoUkNNK0t3K1pkWWg1YXFBdzNWekZaV3Z1eEV6NURXYlpFTkJXRldB?= =?utf-8?B?OGt5R0V3V3JZMnlSWmFPR3c2RitlWWlaNEJzOGRUTWRGb3VOazVtRTJnZWNH?= =?utf-8?B?b3lUMCtvbjh5MXJhV09helc4RnJneExCNS9nRHRDcWpEeGM1cFJPY21HSEcy?= =?utf-8?B?dzQvRGpqaFdzOWNQQUl4SSszeUZIdEo5MitkSUNhWUdKMkRPcmdTcWRwVU5E?= =?utf-8?B?Uk10bUxYS0dOSVdnL2FUdU1nWWg3aFlhV1dvQzZLUEtHVWhwQzZoS0FKV1FN?= =?utf-8?B?c1VQQnpVTHJ2YTZuTTZjOFdqWDFHL25OVU42MDM3WkxKRFVQVnZFREdoeW1m?= =?utf-8?B?SmFoS3lEbCs0bWpGZE4wOEJSTmpoRWdWZzIreWtmaElOUWp6MFlzSWxlbktM?= =?utf-8?B?NmVsbXhlWGJzUUlidnVibFBLcENEbjhLQ1B4Mk42alZJUFBUbVdNcCtSSHBC?= =?utf-8?B?clZXYjRzYWV3ZysrS3FNYTdMaW85aWwrR3hDN1FCR2ZwTHgxdXpKelNDMEtw?= =?utf-8?B?enY3c1paeUxLSHlwbWxhVDJTcTFMd0krYTNObHNyZ3J1ZlJQbVIrZUN1Z2V6?= =?utf-8?B?aXY3N210b1Mvak8yeUNPUkVIWTVRb2dhZVk2VWV2TzFocVd5VEY2N08zQzB0?= =?utf-8?B?eTEremc5Qm5CTEMzczZxQ1hJRmdzcndtRWx1cENLU2pwbTlpTUt4RHQ5NUhD?= =?utf-8?B?bGlYT1E3ZWI2TnZVbHJuazd3V2ZyNk14dmNoUy95d3JId2dJeTRCa3p6cjc2?= =?utf-8?B?dmk0eFd3bXh4WTdRYWRobUxlcnBKcXBxYW84aHpoRXFTWGZpU1hNYWVaZzN4?= =?utf-8?B?Y05TK1ZVQlkrRkRGQk55TEZMUXE2N3haRlNxMGt2VEtFRlpBc3pUTlgzN1VF?= =?utf-8?B?TUZxWmt1YkVQQlBDaGF5czJlMWtpK3pVdlBZd3JZTE4wMWJrbU15OHkrelpC?= =?utf-8?B?c0VibS84N2NSLzNSbXY4KzF3b3BZWWs0M1BHL3NURVFJQlB2OHhtSjErbkdR?= =?utf-8?B?VjBmSzBqUzRHRFUyZXQycHIrSzJsSjVYRTRaL0kzQ1JGK0QwcmVmaFd4UkV4?= =?utf-8?B?a2NXZWJJcURiZmMwcjlncmQ2STBMMTJmeXhUbG9JeTNRSktpY0UyenJkNFBp?= =?utf-8?B?cUxBVlJiN3R0Y2x6eWFna0dGTk1CMUhQNExQNDlFNzlnSnpTUE1PZG1IZUdW?= =?utf-8?B?RjZTbWdQUWZ5ZnF4Zi9icnlLT2NuRUJYT3ArRVZOV2ozTkZSYnZaNy9FQUNJ?= =?utf-8?B?MGNsVWQxcHg0elNmR3ZTSDdodFVoNkhBWVV2U2ZvNk9CYzNxNEhwd3BlSnph?= =?utf-8?B?bHdTcE9UblBCUFhSTFZpRzJ0eTA4cnc5WlZVcnBXS0M5a0s4R0xBVS9kSVlF?= =?utf-8?B?UkxXMDlyYUEySUFWL0NROC8zUktkODV2MHFNbS85VE5mUlVYN3FyYmt2emZm?= =?utf-8?B?RGI0Y25lbWZYSUhMU09wRkF2bHREU0QxUGNLbHlyNTRPNjBsSEszcGkrWVJl?= =?utf-8?Q?9JGE8wynok7ys17hB3IhCsbUT?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2BAImaxA51XHH9m9hRd1TNNl2cgFHDlg8QXP6QYC4ocvgos5fE1fkV0KHHKa4RBaxfEiSHguuFq1pyayBS9FO+ELd8rR12T8tZi7bckpp1qSaiPNQuVWIt1Ya5LX3ZTAgkxC6xtaT2kwpGJ7xOOOYFDIdQTdIU9fb62meWazYazr2oxQkp61r83fo0JEi2/2ThZuI8BAvtp2Tb8oDFz34jEd62AozddMEpMsnz2ouXX306mz5Ym36cjczQeuOcYOHl0X10aOuunK+vh/iF20dIg6U2OR4E7eFecaht09WR9dEJMgUiaS3MMXLwTdXOPqzoT0e5PRGbq1FAEBonE4qOOY7tI+nJLSeQiVIVwgmBgGcE7RhiPx4Z5zoO1v/V7MenJJGeq/CNMYXO8Ma9PT9xpP/gsVa7v0c40FfgAJ00ksd/sVYaiyu9NZXS95kaZNezBRrLfcA3rwbglXoDliy6jzhIKzZvxPx2reygHbeCLuo431zFEapTEhuus3ibPwcMrxiVGbKUrv6cKNRENlCkWbZ6qvss1QE1BV4F5AjHRbz7xPNPuRtMaRjtP+ml9tha0Eov0hf4FlpsaypfVeETA3Sz7d99xc/7/pKxk+II1jXSPNAOkIKYYEFzfKHcsScpWoOZmxSCHd9+NUnIfhHRUZxN9ra7MTS4j64c4o521tYqpncoa81wfzBQq8gWja7+zjFr+5Vs2Kvv5jgLveIi1ToN3306IyAGgnxH++xm2/xyC8qbt2W+ZDPbhNCnHDZXyK6mRyHVz6epXDAMSvUB7TNhnltwlMY88VIASnLHxm4dE16T0p3luI2OAcFO6V6Rfs6p59XYSJhLrir1Xb8KefUEF5lbBzAlgLLiP6l6KwywWaDpmBFnzeMOUUJaqP X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d57fb43-6d89-41cd-43eb-08dbd24403c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2023 14:42:56.5382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RoI0wLjLHYh9n3QhRGmkh6MIYVyPs/V4QuUPJ4+IbQJSkil+fRCo/YAynsttsNbrbPRfLDaWTkEp/l7SgDQN7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5284 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-21_07,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=565 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310210135 X-Proofpoint-GUID: thUmE7pI025BxJ9jVLtyXVkDjp7Vdf_H X-Proofpoint-ORIG-GUID: thUmE7pI025BxJ9jVLtyXVkDjp7Vdf_H X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66636 Cc: "luangruo@yahoo.com" , "monnier@iro.umontreal.ca" , "66636@debbugs.gnu.org" <66636@debbugs.gnu.org>, "stefankangas@gmail.com" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBJZiBzcGVjaWZ5aW5nIGxleGljYWwtYmluZGluZzpuaWwgaW4gdGhlIGZpcnN0IGxpbmUgaXMg dGhlIHNvbHV0aW9uDQo+IGZvciB0aG9zZSB3aG8gd2FudCB0byBrZWVwIGR5bmFtaWNhbGx5LWJv dW5kIGNvZGUsIHRoZW4geWVzLCBpdCBzaG91bGQNCj4gYmUgZGVmaW5pdGVseSBpbiBORVdTLCBh bmQgcHJvYmFibHkgYWxzbyBpbiB0aGUgRUxpc3AgbWFudWFsLg0KDQpZZXMsIGl0IHNob3VsZCBi ZSBkb2N1bWVudGVkLCBidXQgbm90IGp1c3QgYXMNCmEgc2ltcGxlIHNvbHV0aW9uLCBiZWNhdXNl IGl0J3Mgbm90Lg0KDQpGV0lXOiBJdCdzIG5vdCBhIHNvbHV0aW9uIGZvciBjb2RlIHRoYXQgdXNl cw0KYGxleGljYWwtbGV0WypdJy4gIFRoYXQncyBzaW1wbHkgYmVlbiByZW1vdmVkDQpub3cgZnJv bSBFbWFjcywgdW5mb3J0dW5hdGVseS4gIEl0J3Mgbm90IGFzDQpzaW1wbGUgYXMganVzdCBzZXR0 aW5nIGBsZXhpY2FsLWJpbmRpbmcnIHRvIG5pbA0KYW5kIHJlcGxhY2luZyBvY2N1cnJlbmNlcyBv ZiBgbGV4aWNhbC1iaW5kaW5nJw0Kd2l0aCBgbGV0WypdJy4NCg0KQW5kIGl0J3Mgbm90IGV2ZW4g c2ltcGxlIHRvIHRyeSB0byBpbmNsdWRlIHRoZQ0KbWFjcm9zIGZvciBgbGV4aWNhbC1sZXRbKl0n IGluIHlvdXIgY29kZSBhcyBhDQp0ZW1wb3Jhcnkgc3RvcC1nYXAuICBEaXRjaGluZyBgbGV4aWNh bC1sZXRbKl0nDQpjYW4gcmVhbGx5IGJyZWFrIHRoaW5ncy4gIEp1c3Qgc2F5aW5nLi4uDQo= From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 11:45:34 2023 Received: (at 66636) by debbugs.gnu.org; 21 Oct 2023 15:45:34 +0000 Received: from localhost ([127.0.0.1]:44924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quEAQ-0002Fo-HW for submit@debbugs.gnu.org; Sat, 21 Oct 2023 11:45:34 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quEAN-0002FW-RE for 66636@debbugs.gnu.org; Sat, 21 Oct 2023 11:45:33 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8318D441379; Sat, 21 Oct 2023 11:44:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697903097; bh=yIXN4u8WBGnTKetgSX6J/7q8V9AgbjewMBaYRnIUXcY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Sf3f7MAvaqtjan1RhAL1iKycxL+feXStRKSrbGXzje3nhnxOnj2IkiBtBX9AE/9Gl VOxZEIlMBRPPFfYvCJjY7z54TSx5/bFYG0PwpeBj+i9EGP5OtHaR4TVAT/yBNy16R8 LHWbRwGHi20jAANDQZbZLYzOgHy3+vWZ3iC5/JaT7Ahbd1v+wQjHt9Hg77UnoyvPYO DcJXhDu6SHvcKnA3+AhpUv74deQeaUqduGJvNQ7qFokgR03NhPSIyDKB4zJQYvZN7j 9ZBoglSvWyZCYb+lyszulkEEH4wIRRExE8LLt9pyJ3tDT8YpbO64mpSh7ei+3JUTne d9Kz09NpS4cbA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1561B441376; Sat, 21 Oct 2023 11:44:57 -0400 (EDT) Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9BEB1120397; Sat, 21 Oct 2023 11:44:56 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <831qdorzqe.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Oct 2023 14:17:45 +0300") Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> Date: Sat, 21 Oct 2023 11:44:55 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, Mattias =?windows-1252?Q?Engdeg=E5rd?= , stefankangas@gmail.com, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > If specifying lexical-binding:nil in the first line is the solution > for those who want to keep dynamically-bound code, then yes, it should > be definitely in NEWS, and probably also in the ELisp manual. FWIW, I think this would be a disservice to them (and to ourselves). In 99% of the cases it's just as easy to make the code work with `lexical-binding:t`. We do want to allow people to silence the warning with `lexical-binding:nil`, but we don't want to encourage it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 12:09:11 2023 Received: (at 66636) by debbugs.gnu.org; 21 Oct 2023 16:09:12 +0000 Received: from localhost ([127.0.0.1]:44933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quEXH-00033K-Ki for submit@debbugs.gnu.org; Sat, 21 Oct 2023 12:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quEXC-00032m-DW for 66636@debbugs.gnu.org; Sat, 21 Oct 2023 12:09:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quEWe-00034L-FR; Sat, 21 Oct 2023 12:08:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=TmqM6s+TDFoUJHSAGxlLDABaRrPbeW7obdNiMTC0e2k=; b=DI7wPKOrEAjRhy9OyNb4 VD7mZRS6zvSqixWJMvMZA3g7ghOiD/DMHMrZnUdqEHzdL6gqVWsS7KQb037am7N3BEEJy7WfLIGsS kWgXcZrdwwUTWaYLa5bCzhP5Ga+yi1aKbGGI/OWxjTynLWktmb1Qa76oEMQUoXrWpX1+jflLdeZbo CT6bR5HhfcYdHxWHaDWx4OO8WyH0/TPV/mz0h7mx37ciUU5EmWlLJXSTSInhrJl4C7WIlolIkek2x 8LX0f5dsJLPVUnRNwrFHP04Xp640KuKtwScZnE5qRyw9V+dVajoE0HVPUnGiRWiFb6IXGomMLcHjY UVH/VfIBzyCmmQ==; Date: Sat, 21 Oct 2023 19:08:28 +0300 Message-Id: <83edhoq7pf.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 21 Oct 2023 11:44:55 -0400) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, mattias.engdegard@gmail.com, stefankangas@gmail.com, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Mattias Engdegård , > luangruo@yahoo.com, > 66636@debbugs.gnu.org, stefankangas@gmail.com > Date: Sat, 21 Oct 2023 11:44:55 -0400 > > > If specifying lexical-binding:nil in the first line is the solution > > for those who want to keep dynamically-bound code, then yes, it should > > be definitely in NEWS, and probably also in the ELisp manual. > > FWIW, I think this would be a disservice to them (and to ourselves). What will? > We do want to allow people to silence the warning with > `lexical-binding:nil`, but we don't want to encourage it. NEWS is not about encouraging anything, it is about fire escape. The manual encourages (or discourages) certain practices, but NEWS is about something else. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 20:16:36 2023 Received: (at 66636) by debbugs.gnu.org; 22 Oct 2023 00:16:36 +0000 Received: from localhost ([127.0.0.1]:45231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quM8u-0007Pg-7J for submit@debbugs.gnu.org; Sat, 21 Oct 2023 20:16:36 -0400 Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:34369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quM8o-0007P6-O0 for 66636@debbugs.gnu.org; Sat, 21 Oct 2023 20:16:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697933753; bh=mu6zkcasXuSghSQmIRZeZxC5gOjTufP0YRteyXSOG0I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=mByX8FLqXWPeVlQ6MoPeNwkPHfde8ekoDZXtEO1LG5VJDvYJ60JRtJbATk3mngVkkaO+6Dv5UgfgjxEHrzEk3NJj0tkuYZuK0/wFG3b4hwPz3HkQ+5eRgGsqhRV580Lwl7IN0NneEFSkHhEKSPS0f0H8Ch2cDfmKXfksA/PyI45TJWSakfe0fzRsyR/f/GhsSUqgWW2Mucpai+ujecIvgpQUmwbfpVwgX1bGyJRUFrKHXsq9ASXvyhbRgB8Bgaa4oA7iL8Jx6llMuENAIrA5036KBeG0Z4AzDISYjNLioWvXDlNW2B/NYvP9YXqP4G20VKDeoP7Lj7cy6zXa0JDLnQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697933753; bh=sP3JQYi1b/9Vo6sBqmAEqNDwKR7u3aykgynV5iakm4w=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=p88EaeaIPISXS37Mplrd4pirYSYc0/0xDDXG+5qJieulaQWV70VF6ybl0qvE6ZftWHVPGL0+Io0jS+bD6g/J2dtPUMOfQEiubjkM97aWnMRxm0f5t9Ng13xi1WVAh+Rih2Y1A1qldGebwLZZxeo9Bk0y82MLc5P2wXZU4Szv1LETdmPERyQaDdRBUNlTm97Z1LPKzeb9tH/H8xwEwT27kXP61tcypnWNBGvIkSy7K+c+QNWf5UAagfL/obFGIls2q06MdVOfHc8MSQuJJrzDhAEK0oeoc6BRbiEyr4OEGIZ6BUcwn3nPSnAzAg4dR3xk+86Aciu9/W6r8a7mLMSZQw== X-YMail-OSG: __zkmBEVM1kseOgPCzln3.ajIPWrNYfDENZuI6ZcX4oEEBKWeVBqpMMxizySKqu SVgx7KWpw_NFoSg2EH6oRGcLXM7FLR2eHGa.rFVgJRLUwMwD7M7.2XWDZgoPUd40yNUAMjW0urDD LXpzfOe.Sv_zWGP8CTKvMmjwP8PO.cqOAm7niITbBfalmovOmQDX7xIXlgx8rkTMbnbyRLiW4lXS tbG5Y274KqHC3ue1.knwFwBZLDvWOiLV4IgP3iwisqnh3Cbx58QlhPjcVsI5b2gi_yoCXpTnakQL cQSe.5t7NOUdrcwzwqZ2napG1j64XihrHFTDWC_GtGXF0lXiU6Zm1ejrcEjHxTAvDT5doj3GqvB. rUvyWluJ2unZKMWZZ.wZPoInI2LpJ5M5DAM8lJIW3e2bYswWjmvugQs4BOIL3h46xfteQVFCroyJ wWByKA61AUoa5DZgurdtS2uwHfR9DdnZv4Ot5jb4wVdwe0xPkFksWGLOfefLsbZzsC_1L2ayvWd2 C660EQOYED5_0QPL_ud0plzeWrDwbRHyKFqIURV6MskYuBqYnOT9BhJfKHhBQp51nG70zjc7P.Tn H7B4l_tCMoIl46O.nUzzQ4AZ.h_bIILgvxhsMkbAvK_awK8f4ij5S9ZhH3NIb1qV1NoupeQC2L78 hw9Z6VlvxMmTbryRukQl6CNgq5tnSeTbzFUL8DwWgNuRocQV4RHiz0ZywQtCNy9FKOuSvFS8bAlF 3IjbRhNHbo0P2r2kc1gAWqEv6SOX9JMljA_K1kmD210Ozb6pgIWF6VRv2jjr9djnTjS34osV4X06 dDe2s2XvATQaTd4LW9YxI153jiSy87eNitZusEKBtIwU_zVM5fFfTosU9rHJVdDw0PvthCU0ftvJ R_SdsS5q8n3jPYxgiia8QIvtLMD75jD.CRULhapjxqxuTZsezQu64GXjRjE53gReZGeK3XuYfePS 2ZfSdg8raVqIc1ezVNd7DhaCr2Z6PY6OEU8OAoAYM5_wIyif5r.T_hDmA2X4NQnEX.kixbnpWLze CyNhIU7m836ovgq_rawELnK1XzWiOfNfgrU3X0PBa2bedILY7YyqDWqAuTO3DEJzD_UAkVYN4Y5h PxafIgyVo1H._8PhL3Icj6nnLcwxSY5NagWhB_u6NLibuYEDqHIbuwb7UyFwo8K62h4BadlwXcFb sHs3FgjjmAF447WcTL2ZXUM433YjfnEjxVNskmllDvmzTmKHgdNAYw5z87OBUQod0mWmQkW7z4H0 A3pOAC2eYoX_F5hfN5jJUAoEW1HeUzN9uXuy2JhD4xaCwPKI4eT_Ajm0S0ceIbKGnK8PHTKFnR4k UJwJXSwei7yivFbxDju8NbwhHz9mS_THWq.Qj176X8wEROr.OvDwQ_7ar97Ym4oRDT4uIYqV6GOz w2.Re0pcLo74Myjp62nIURH6cxVb0EX5Nv_9C.Q3XJHsWEqe.CSAa1Rwb97EI_oAVn4z.S3VGdlB yfz0rO0YpbphmaQ8j_CmpPH3vkbFqACacHLwmjGnMHvtnCHOtddLCS7GAuOZyHsF7ftObX327GZZ Ib7YeKXDzxFZHgqRjb4qah2e3XeIQk5bYLk0J7KPitdGUcxL_3SEcvA1ndTHBkDvk.YLxOo7f1gb AR3zPEPNHyQTMPvkDTKbdaANO_WCSwEkbtB2JmelVSIUKPBRY8tVBtIRyZvwp61xJZMg4byzmIyG tV9BwfPn.gsx4JIc.tvAsj47dPUBuqTF9uvykjfRg8tQ0XzQOrqgqx2b.9gkirprpMYEoZ1dQ8vJ htg305YSkX3zTIG6N9f2PsmE2NcRVVnFl2awubXx8sLbdO7FM9GFfSsjWRzlCmDJ2ZB8dJJ64FYm mHDWpxdF4_g7vpvLLQwaJJCjxp1Anw3ucrCW4CrknzgswN3J0Z5okcUfGmNxO9IFzEbe8__COkY0 JaZH3eibjdJ8YHudHqsZsltvqBqF1UWgYDFrc3KLMKuoyjiMocadj7Zopi47GC2948M9kQKrz0Q7 EV7a9YNjOXRJQEA3d4efDgvilQ9dGyCuGsA6uP5bXFMJjT9Sdp9Ii8fuSEya6svDXuzY9L1fLcw5 twMLvEPXOH6HN.wt0ZoFR1vHV6.ltJWv0AYKkVLAnFWHsu5dixhafCQvWR6yyEPz3cGIg8Sqi70X qlswT_1T6vA0ToTKCgRn2n38qwL2Dc_.LVdeP1w5K2i2iIgvK5qiGzCB9UbqGHVrqetUXyy0yOBE 7TGujLlFyXZ5mU75oahw37o7YF9foI9.rTZJVLuvc_V3cVkQKsA19E.svYBMio2wc X-Sonic-MF: X-Sonic-ID: fdbb1e73-5428-410a-b4f6-c604e22e0fbf Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sun, 22 Oct 2023 00:15:53 +0000 Received: by hermes--production-sg3-57f7997989-mcz6s (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3ade880eed95384d62b039367a0d99ec; Sun, 22 Oct 2023 00:15:45 +0000 (UTC) From: Po Lu To: Stefan Monnier Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: (Stefan Monnier's message of "Sat, 21 Oct 2023 11:44:55 -0400") References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> Date: Sun, 22 Oct 2023 08:15:38 +0800 Message-ID: <87edhn342d.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 478 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 66636 Cc: Eli Zaretskii , Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 66636@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) Stefan Monnier writes: > FWIW, I think this would be a disservice to them (and to ourselves). > In 99% of the cases it's just as easy to make the code work with > `lexical-binding:t`. I think we want to encourage whatever relieves users of the most work, not what comports best with some abstract conception of desirability. Since the number of package developers does not exceed the number of users installing packages, which goes without saying. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 00:13:33 2023 Received: (at 66636) by debbugs.gnu.org; 22 Oct 2023 04:13:33 +0000 Received: from localhost ([127.0.0.1]:45310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quPqE-0006dS-8K for submit@debbugs.gnu.org; Sun, 22 Oct 2023 00:13:33 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quPqB-0006dD-RT for 66636@debbugs.gnu.org; Sun, 22 Oct 2023 00:13:28 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4B470805D6; Sun, 22 Oct 2023 00:12:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697947973; bh=ew75i04GvAud/nwc8WxlQ/U4+ZFr+iAVnnUMpzghw6Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QyZKXgb5+hfnchhFF13ystZcdyPq9ARDu76UhLKV4Mhvs9lJ8e5Yklqh2i4PArZ1G oRLUk4b6InWk6XOFWqCAgvUih+hq+3Mpl+ulxbsDq/Ezm8Wt6zXVABE8AFpYDjR8jF RV8Cj/N9AJMUKyURabb7eX8D2PWV4aopLr+08RBWT7x4WQncChndsuwoiw22Ym+QYz ALAOCnCboKzlUrZSawzPsyISdv15ol0aZ1sxedU2uZ82/vMNtNcvRZ/M3MBQtiAYyW xsgMdlCRI4kTqaTUvbKTLBHOUPjO7f4/EdeXZsAncy/rDEYAEsKks03VZGVx1jHDik 677Hxy9ucYiHA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 21771800C6; Sun, 22 Oct 2023 00:12:53 -0400 (EDT) Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE94E1201E3; Sun, 22 Oct 2023 00:12:52 -0400 (EDT) From: Stefan Monnier To: Po Lu Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <87edhn342d.fsf@yahoo.com> (Po Lu's message of "Sun, 22 Oct 2023 08:15:38 +0800") Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> <87edhn342d.fsf@yahoo.com> Date: Sun, 22 Oct 2023 00:12:51 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: Eli Zaretskii , Mattias =?windows-1252?Q?Engdeg=E5rd?= , 66636@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> FWIW, I think this would be a disservice to them (and to ourselves). >> In 99% of the cases it's just as easy to make the code work with >> `lexical-binding:t`. > I think we want to encourage whatever relieves users of the most work, > not what comports best with some abstract conception of desirability. For users it should make no difference, they don't need to do anything (other than avert their eyes from the warning, maybe). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 01:16:42 2023 Received: (at 66636) by debbugs.gnu.org; 22 Oct 2023 05:16:42 +0000 Received: from localhost ([127.0.0.1]:45377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quQpN-0000S2-Ow for submit@debbugs.gnu.org; Sun, 22 Oct 2023 01:16:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quQpL-0000Rn-N4 for 66636@debbugs.gnu.org; Sun, 22 Oct 2023 01:16:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quQoo-0008Ql-66; Sun, 22 Oct 2023 01:16:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oIL8Rs1p6+VeFJiijiVY19EQ9vtNqrHQ74trdBL9S8Y=; b=aBq13df07NqYbLPfjl2n 4gpGGs87PgaRTp5VqpbyTy2sjsikkkpuU3wuyAgd5re2Ojek07VWiXAjRyD/j3fU6zUAnEGMlWrK6 ytyhHn3Q7g5EAU8UKdliW3Kkhvm+3SJrUAhgNEIXpgP3+/EZm36wIdr9ZMjhqHj/J7oSdD9GJlDkQ 8w2BE7oVuc3m9FarvrSzjWj26C+VjvHflhkVw5kGxwyHtD0D9enkky/tIA69aEqzu6aB06l6y8KS2 BtYSEVHwlExH4WubkZmXLblu0GYTugv8chiaXBLPXwp9qsu3y0JiJ+Tj/7FXyPRNSPV0Lu/2Dbw/X 0h7/R7Kwgtc76A==; Date: Sun, 22 Oct 2023 08:16:04 +0300 Message-Id: <83y1fvp78r.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 22 Oct 2023 00:12:51 -0400) Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> <87edhn342d.fsf@yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, mattias.engdegard@gmail.com, stefankangas@gmail.com, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , Mattias Engdegård > , 66636@debbugs.gnu.org, > stefankangas@gmail.com > Date: Sun, 22 Oct 2023 00:12:51 -0400 > > >> FWIW, I think this would be a disservice to them (and to ourselves). > >> In 99% of the cases it's just as easy to make the code work with > >> `lexical-binding:t`. > > I think we want to encourage whatever relieves users of the most work, > > not what comports best with some abstract conception of desirability. > > For users it should make no difference, they don't need to do anything > (other than avert their eyes from the warning, maybe). You interpret "users" in what I wrote too narrowly, I think. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 22 01:29:26 2023 Received: (at 66636) by debbugs.gnu.org; 22 Oct 2023 05:29:26 +0000 Received: from localhost ([127.0.0.1]:45387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quR1i-0000tJ-Dt for submit@debbugs.gnu.org; Sun, 22 Oct 2023 01:29:26 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quR1c-0000sz-RG for 66636@debbugs.gnu.org; Sun, 22 Oct 2023 01:29:24 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0589E100169; Sun, 22 Oct 2023 01:28:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1697952525; bh=D1lZ22bzD9NuJyBHjAXBmaTpLHUWV2nLsC7HNVeuFlE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DTDYhSM08xmY7C01VF7t5QFjxW7QCsNbjor0TVaPNDb2sXED8KNpokPJ0Ex+Qyd3n jTqgBQkEh8rvb2tV3G0DXzy/96WP8Eb/VvW2YqrJS7COB/fCJ59hJEzzesNOGk2Fwn dA2+8xR42XLPRPPtObww9c0YipEpJp5+gbpAOoHIR69YoV9FE+79UiuMDFuInxs3Lz JKX/Au1mJVCkZ3yg0RPVfu9PZ+WZLI1/AD7BQOqWgKnShsEcL9vEaD/ooa+VarUkpS 81pGBL5BFG+hoQck7R8n3SpUCHUfSSjk9VOHVrI/pM0DkTUVPRfgyX7WspV65Sub5o cUU52Tfn+Xt+Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DE02410006B; Sun, 22 Oct 2023 01:28:45 -0400 (EDT) Received: from pastel (unknown [45.72.216.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A944C1202E0; Sun, 22 Oct 2023 01:28:45 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler In-Reply-To: <83y1fvp78r.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Oct 2023 08:16:04 +0300") Message-ID: References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83lebxrt5n.fsf@gnu.org> <831qdorzqe.fsf@gnu.org> <87edhn342d.fsf@yahoo.com> <83y1fvp78r.fsf@gnu.org> Date: Sun, 22 Oct 2023 01:28:44 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66636 Cc: luangruo@yahoo.com, mattias.engdegard@gmail.com, stefankangas@gmail.com, 66636@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> >> FWIW, I think this would be a disservice to them (and to ourselves). >> >> In 99% of the cases it's just as easy to make the code work with >> >> `lexical-binding:t`. >> > I think we want to encourage whatever relieves users of the most work, >> > not what comports best with some abstract conception of desirability. >> >> For users it should make no difference, they don't need to do anything >> (other than avert their eyes from the warning, maybe). > > You interpret "users" in what I wrote too narrowly, I think. My reply is to Po Lu who seemed to use "users" in the sense of "non developers" (indeed, this use surprised me as well). Stefan From unknown Mon Aug 18 15:38:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Nov 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator