GNU bug report logs - #66635
30.0.50; customize-icon State button doesn't work (never did)

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Thu, 19 Oct 2023 11:20:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Fixed in version 29.2

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 66635 <at> debbugs.gnu.org
Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did)
Date: Thu, 19 Oct 2023 08:53:50 -0300
[Message part 1 (text/plain, inline)]
tags 66635 patch
quit


I attach a patch to address the more important issues for now.  That is,
at least have a working State button and rudimentary state checking.

Setting and Saving icon specifications through the State button should
work now, by adding the custom-icon-action function.

And while trying to fix the state messages in Custom, I found that the
arguments for plist-get were transposed in icons--merge-spec, so I
suspect that function never worked either.

There are a lot of things to improve here (I discovered the issues while
looking at Bug#57113), but I hope this patch is good enough for this bug
report.
[0001-Fix-State-button-for-customize-icon-Bug-66635.patch (text/x-patch, attachment)]

This bug report was last modified 1 year and 291 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.