GNU bug report logs - #66635
30.0.50; customize-icon State button doesn't work (never did)

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Thu, 19 Oct 2023 11:20:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Fixed in version 29.2

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: stefankangas <at> gmail.com, 66635 <at> debbugs.gnu.org
Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did)
Date: Sat, 21 Oct 2023 14:19:32 +0300
> Date: Sat, 21 Oct 2023 07:18:31 -0300
> Cc: stefankangas <at> gmail.com, 66635 <at> debbugs.gnu.org
> From: Mauro Aranda <maurooaranda <at> gmail.com>
> 
> On 21/10/23 04:35, Eli Zaretskii wrote:
>  > How well is the fix tested?  Did you test it with several icons
>  > introduced in Emacs 29 in various modes?  If not, would you please
>  > test those and see the changes work well enough there to be
>  > appropriate for a bug-fix release?
> 
> I just tested with the button icon, the only one suggested after
> running emacs -Q.  I tested making modifications in the buffer, and that
> the two options (three if not started with -Q) work and do what's
> intended.  Namely:
> - Undo Editions took me back to the STANDARD state.
> - Setting for the session modified the specs for the session and
> correctly displayed the SET state.
> - Saving the setting saved a spec that in a new session (without emacs
> -Q) causes:
> M-x describe-icon RET button
> to show the button customized.  The value I changed for that was from
> LARGE BLUE CIRCLE to LARGE RED SQUARE
> 
> It's important to note that saving the setting shows the SET state
> (rather than the SAVED state), but that's in a FIXME right before
> custom-icon-state.
> 
> I'll do some more testing with the icons defined in outline.el,
> tab-bar.el and warnings.el.  Additionally I'll try to test if
> Customizing an icon interacts good enough with a Theme customizations.
> I'll do that and report back.

Thanks.




This bug report was last modified 1 year and 291 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.