From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Oct 2023 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66635@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16977143583173 (code B ref -1); Thu, 19 Oct 2023 11:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Oct 2023 11:19:18 +0000 Received: from localhost ([127.0.0.1]:35934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtR3e-0000p6-9U for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:19:18 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtR3a-0000ok-Hd for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:19:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtR34-0001wz-Lr for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 07:18:42 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtR32-0006fj-M7 for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 07:18:42 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-27d17f5457fso522743a91.0 for ; Thu, 19 Oct 2023 04:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697714318; x=1698319118; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=F/r8VY9g+084Q+WJtbmzmFpra+A38OJiAQsLJnAloRw=; b=EBhhOGxN/hxf1LG5EuwpBjTjD1sAsA+49K/lwb7NzK96URRpSK/OL0Aw/GC3WbclI/ 8QW2P3siTH0h7AUD05Lqr9xCYjQPLgdeuLnnmLQgUkwGiPeHTAHpnjmdS9KXS5fkmrtH JJQrVDLR35vOSJC7MMbKtiD5k/LADsugj6FRk0pMJLn2vUjcppC4sR1FT+18DYnxJsI0 rgNYzyS5SylE4gxrzcdDpeg/aH7ni/QgJmkeT7EGdOjWpXmkj8a+KUJB7NXvJqB5Z/Tx eY9fz3mCz7eg5HamQmQqdkjaEAWV3DVor4UzQz5OhkxzLS/34il48tmv0lW4KsKUP2P5 v9eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697714318; x=1698319118; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=F/r8VY9g+084Q+WJtbmzmFpra+A38OJiAQsLJnAloRw=; b=bsV7eJAX3gbs4a4BHKoydiTCPjKmFLC6HHloRwCOsALtxT8aJ9D25BmGwySOylT98u lTztMH+W2tqxttTB1cpuEfPASKAkGnifPn6whbCDsEQPpBIOMwUfgWjcIyHhthLKDetU LIrH4jXjqEnlvl1m8hiWFhzv2zEW5uPp4BoQrKAKg2brIpsoWrO/5mxYduZkyJsJEOdz bSqaTwtD4Hxjw2PuPk55i6rL24kBwcmytDnXHbx9JiHoJN6AdcSDgFVi86s7t5qya6bM pr/ViT/+fzEJUM2I8krEo0i9PbkiIheBKOpPmBFPBoh1DOKfYw4kP0yNLa92udt3bHQU khRQ== X-Gm-Message-State: AOJu0YzZ4o7IzKUzFE2YHdlYRZkWMnf3MycRKx9cwOxQThc7/iS4veeB HaZVMWOQl6perHw/pSyfcHIp0Dxav1JF+Q== X-Google-Smtp-Source: AGHT+IGs3Ff/LJsIUoOy0sML5uYmly7QATnpnjPPVjaOwZQVa6VEPdOlBK3S7SD2H+fNWHmKVFCMQQ== X-Received: by 2002:a17:90a:17ef:b0:277:3afc:f27 with SMTP id q102-20020a17090a17ef00b002773afc0f27mr2342516pja.1.1697714318181; Thu, 19 Oct 2023 04:18:38 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id x89-20020a17090a6c6200b0027d06ddc06bsm1533288pjj.33.2023.10.19.04.18.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 04:18:37 -0700 (PDT) Message-ID: Date: Thu, 19 Oct 2023 08:18:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Mauro Aranda Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=maurooaranda@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) emacs -Q M-x customize-icon RET button Edit something.  For example, under the Text Only choice, make the string look like: "-button-" instead of "button". Observe that Custom says: "EDITED, ..." Go to the State button and hit RET.  Nothing happens. Click it.  Nothing happens. Expectation is that a menu pops up to set the icon settings. And without -Q, to save the settings. In GNU Emacs 30.0.50 (build 7, x86_64-pc-linux-gnu, GTK+ Version  3.24.33, cairo version 1.16.0) of 2023-10-19 built on tbb-desktop Repository revision: 0fd7f785e76c9f2eea1baa40aed6ee327f68a993 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201001 System Description: Ubuntu 22.04.3 LTS Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: es_AR.UTF-8   value of $LC_NUMERIC: es_AR.UTF-8   value of $LC_TIME: es_AR.UTF-8   value of $LANG: en_US.UTF-8   value of $XMODIFIERS: @im=ibus   locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect:   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   tool-bar-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   minibuffer-regexp-mode: t   line-number-mode: t   indent-tabs-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 37643 10434) (symbols 48 5213 0) (strings 32 13209 1857)  (string-bytes 1 374142) (vectors 16 10299)  (vector-slots 8 156471 14182) (floats 8 21 23) (intervals 56 223 0)  (buffers 992 10)) From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Oct 2023 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169771647017574 (code B ref 66635); Thu, 19 Oct 2023 11:55:02 +0000 Received: (at 66635) by debbugs.gnu.org; 19 Oct 2023 11:54:30 +0000 Received: from localhost ([127.0.0.1]:35967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtRbi-0004ZN-76 for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:54:30 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:51678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtRbf-0004Yp-Ty; Thu, 19 Oct 2023 07:54:28 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-27d4372322aso4090691a91.3; Thu, 19 Oct 2023 04:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697716435; x=1698321235; darn=debbugs.gnu.org; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Ez+4sUyWT+4rc/BMN9EPjfU4wHfsusYdLTHDbULUnlY=; b=OLpNM39rMvxTzhFWyTnsGK/SAJ6OKrZSJvnD25/TPR8NxxMZ2F50XTd0rUsPnhbSRK F7A4S976Vm0lHXqLS1pw0VLo6RdEWxkt9fpPiK6/bQYSkqi737XboenzWWUs3j4fjDMK Ql6iSf95IjBD9tEvJcRu2Et9TOCOkMdQTc7Tjqu39mS1qecZjXBKcluzpUBq6QXfnPNo 67IQ4ke0wC4oZ6tqp+r/BPymvxl/fidJXmnKAnfPc5Nqfs/95rFArkstVVJhFEDCX32Y Al5hsrSTjCpdF6NpobPW1V3Osm5Zf4r8XnfI2WK4ZNTWCvfzXPwjbmS+lzNCJBVq+z5e /p+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697716435; x=1698321235; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ez+4sUyWT+4rc/BMN9EPjfU4wHfsusYdLTHDbULUnlY=; b=xSuo5Q4/05Y1VNFGmbkJdLH3Da7DWvFC0ivaDq/PCgdL4AgipaxmNBIJf1VURyJBkb C7J41k34MtGI4nBJBF2W/TI0u7DACNmbcciICnMh4lIzmlYfRqBe1VtjAYnb3tEGl3Fy uHTwSHVlX7UzINMmym9eN8fpZWe5M16NQPdgpwDEREmU2+/WLxGQopBxGBJi/51jpMH3 ldpD9moz5NhAKth19vRJrvN4q4tnRr6Vq2bQmQlDhlDCK9Ru2q5sTYymuZkQZc4/D16Z jCYLkQGVb0ayVAPhf5RIIuMaiPFS+6BzDQ8ovIHo04dxoFE393AqlBj7KP82a+vLSYKx Lcng== X-Gm-Message-State: AOJu0YziO5IbHXk/dCKfIIdiOCnxWpS/WautTPsmq2uq+q0YGrNFai7y Rl3KrRl6/dzCDXequdyWeyKHIXenztlCVQ== X-Google-Smtp-Source: AGHT+IGA6fyLO0xrJez0e5NPbZKtrCjdCH8S6NFyzXYn6YLw5/zC3YFb8Rej7kzisR7cKIcKLyWVVg== X-Received: by 2002:a17:90b:48cf:b0:27d:37bb:12c0 with SMTP id li15-20020a17090b48cf00b0027d37bb12c0mr1776482pjb.36.1697716434536; Thu, 19 Oct 2023 04:53:54 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id my7-20020a17090b4c8700b0027b13db9729sm1466174pjb.21.2023.10.19.04.53.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 04:53:53 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Xnuo0DbsVlXnpOq7m1kIafqX" Message-ID: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> Date: Thu, 19 Oct 2023 08:53:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Mauro Aranda References: In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Xnuo0DbsVlXnpOq7m1kIafqX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit tags 66635 patch quit I attach a patch to address the more important issues for now. That is, at least have a working State button and rudimentary state checking. Setting and Saving icon specifications through the State button should work now, by adding the custom-icon-action function. And while trying to fix the state messages in Custom, I found that the arguments for plist-get were transposed in icons--merge-spec, so I suspect that function never worked either. There are a lot of things to improve here (I discovered the issues while looking at Bug#57113), but I hope this patch is good enough for this bug report. --------------Xnuo0DbsVlXnpOq7m1kIafqX Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-State-button-for-customize-icon-Bug-66635.patch" Content-Disposition: attachment; filename="0001-Fix-State-button-for-customize-icon-Bug-66635.patch" Content-Transfer-Encoding: base64 RnJvbSBhYjRmYWJmNDg2NjVkZGMxNDJhZDk1YTI2ODk4ZWI2MjA3Y2QyYmRjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFRodSwgMTkgT2N0IDIwMjMgMDg6NDY6MzUgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggU3RhdGUgYnV0dG9uIGZvciBjdXN0b21pemUtaWNvbiAoQnVnIzY2NjM1 KQoKKiBsaXNwL2N1cy1lZGl0LmVsIChjdXN0b20taWNvbi1hY3Rpb24pOiBOZXcgZnVuY3Rp b24uCihjdXN0b20taWNvbik6IFVzZSBpdCBhcyB0aGUgOmFjdGlvbi4gIE90aGVyd2lzZSwg Y2xpY2tpbmcgdGhlIFN0YXRlCmJ1dHRvbiBpcyBhIG5vb3AuICBSZW1vdmUgaXJyZWxldmFu dCBzdHVmZiBmcm9tIHRoZSBkb2NzdHJpbmcgYW5kCmNvbW1lbnQgb3V0IHNvbWUgY29weS1w YXN0YS4KKGN1c3RvbS1pY29uLWV4dGVuZGVkLW1lbnUpOiBOZXcgdmFyaWFibGUsIHRoZSBt ZW51IHRvIHNob3cgdXBvbgo6YWN0aW9uLgooY3VzdG9tLWljb24tc2V0KTogUmVhbGx5IHJl ZHJhdyB0aGUgd2lkZ2V0IHdpdGggdGhlIG5ldyBzZXR0aW5ncy4KQ29tbWVudCBvdXQgc3Ry YW5nZSBjYWxsIHRvIGN1c3RvbS12YXJpYWJsZS1iYWNrdXAtdmFsdWUuCihjdXN0b20taWNv bi1zYXZlKTogTmV3IGZ1bmN0aW9uLgoKKiBsaXNwL2VtYWNzLWxpc3AvaWNvbnMuZWwgKGlj b25zLS1tZXJnZS1zcGVjKTogRml4IGNhbGwgdG8gcGxpc3QtZ2V0CmFuZCBhdm9pZCBpbmZs b29wLgotLS0KIGxpc3AvY3VzLWVkaXQuZWwgICAgICAgICB8IDcxICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0KIGxpc3AvZW1hY3MtbGlzcC9pY29ucy5lbCB8 ICA2ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtZWRpdC5lbCBiL2xpc3AvY3VzLWVkaXQu ZWwKaW5kZXggNzA2ZTA4ZDU2NTcuLjk1M2I4YjhiODBmIDEwMDY0NAotLS0gYS9saXNwL2N1 cy1lZGl0LmVsCisrKyBiL2xpc3AvY3VzLWVkaXQuZWwKQEAgLTUzNjYsMTEgKzUzNjYsNiBA QCAnY3VzdG9tLWljb24KIDpoaWRkZW4tc3RhdGVzIHNob3VsZCBiZSBhIGxpc3Qgb2Ygd2lk Z2V0IHN0YXRlcyBmb3Igd2hpY2ggdGhlCiAgIHdpZGdldCdzIGluaXRpYWwgY29udGVudHMg YXJlIHRvIGJlIGhpZGRlbi4KIAotOmN1c3RvbS1mb3JtIHNob3VsZCBiZSBhIHN5bWJvbCBk ZXNjcmliaW5nIGhvdyB0byBkaXNwbGF5IGFuZAotICBlZGl0IHRoZSB2YXJpYWJsZS0tLWVp dGhlciBgZWRpdCcgKHVzaW5nIGVkaXQgd2lkZ2V0cyksCi0gIGBsaXNwJyAoYXMgYSBMaXNw IHNleHApLCBvciBgbWlzbWF0Y2gnIChzaG91bGQgbm90IGhhcHBlbik7Ci0gIGlmIG5pbCwg dXNlIHRoZSByZXR1cm4gdmFsdWUgb2YgYGN1c3RvbS12YXJpYWJsZS1kZWZhdWx0LWZvcm0n LgotCiA6c2hvd24tdmFsdWUsIGlmIG5vbi1uaWwsIHNob3VsZCBiZSBhIGxpc3Qgd2hvc2Ug YGNhcicgaXMgdGhlCiAgIHZhcmlhYmxlIHZhbHVlIHRvIGRpc3BsYXkgaW4gcGxhY2Ugb2Yg dGhlIGN1cnJlbnQgdmFsdWUuCiAKQEAgLTUzODMsMTEgKzUzNzgsMzQgQEAgJ2N1c3RvbS1p Y29uCiAgIDpjdXN0b20tY2F0ZWdvcnkgJ29wdGlvbgogICA6Y3VzdG9tLXN0YXRlIG5pbAog ICA6Y3VzdG9tLWZvcm0gbmlsCi0gIDp2YWx1ZS1jcmVhdGUgJ2N1c3RvbS1pY29uLXZhbHVl LWNyZWF0ZQorICA6dmFsdWUtY3JlYXRlICMnY3VzdG9tLWljb24tdmFsdWUtY3JlYXRlCiAg IDpoaWRkZW4tc3RhdGVzICcoc3RhbmRhcmQpCi0gIDpjdXN0b20tc2V0ICdjdXN0b20taWNv bi1zZXQKLSAgOmN1c3RvbS1yZXNldC1jdXJyZW50ICdjdXN0b20tcmVkcmF3Ci0gIDpjdXN0 b20tcmVzZXQtc2F2ZWQgJ2N1c3RvbS12YXJpYWJsZS1yZXNldC1zYXZlZCkKKyAgOmFjdGlv biAjJ2N1c3RvbS1pY29uLWFjdGlvbgorICA6Y3VzdG9tLXNldCAjJ2N1c3RvbS1pY29uLXNl dAorICA6Y3VzdG9tLXJlc2V0LWN1cnJlbnQgIydjdXN0b20tcmVkcmF3KQorICA7OyBOb3Qg aW1wbGVtZW50ZWQgeWV0LgorICA7OyA6Y3VzdG9tLXJlc2V0LXNhdmVkICdjdXN0b20taWNv bi1yZXNldC1zYXZlZCkKKworKGRlZnZhciBjdXN0b20taWNvbi1leHRlbmRlZC1tZW51Cisg IChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkpKQorICAgIChkZWZpbmUta2V5LWFm dGVyIG1hcCBbY3VzdG9tLWljb24tc2V0XQorICAgICAgJyhtZW51LWl0ZW0gIlNldCBmb3Ig Q3VycmVudCBTZXNzaW9uIiBjdXN0b20taWNvbi1zZXQKKyAgICAgICAgICAgICAgICAgIDpl bmFibGUgKGVxICh3aWRnZXQtZ2V0IGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgOmN1c3RvbS1z dGF0ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdtb2RpZmllZCkpKQorICAg ICh3aGVuIChvciBjdXN0b20tZmlsZSBpbml0LWZpbGUtdXNlcikKKyAgICAgIChkZWZpbmUt a2V5LWFmdGVyIG1hcCBbY3VzdG9tLWljb24tc2F2ZV0KKyAgICAgICAgJyhtZW51LWl0ZW0g IlNhdmUgZm9yIEZ1dHVyZSBTZXNzaW9ucyIgY3VzdG9tLWljb24tc2F2ZQorICAgICAgICAg ICAgICAgICAgICA6ZW5hYmxlIChtZW1xCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICh3aWRnZXQtZ2V0IGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgOmN1c3RvbS1zdGF0ZSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJyhtb2RpZmllZCBzZXQgY2hhbmdlZCkpKSkp CisgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWFwIFtjdXN0b20tcmVkcmF3XQorICAgICAgJyht ZW51LWl0ZW0gIlVuZG8gRWRpdHMiIGN1c3RvbS1yZWRyYXcKKyAgICAgICAgICAgICAgICAg IDplbmFibGUgKG1lbXEKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aWRnZXQtZ2V0 IGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgOmN1c3RvbS1zdGF0ZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICcobW9kaWZpZWQgY2hhbmdlZCkpKSkKKyAgICBtYXApCisgICJBIG1l bnUgZm9yIGBjdXN0b20taWNvbicgd2lkZ2V0cy4KK1VzZWQgaW4gYGN1c3RvbS1pY29uLWFj dGlvbicgdG8gc2hvdyBhIG1lbnUgdG8gdGhlIHVzZXIuIikKIAogKGRlZnVuIGN1c3RvbS1p Y29uLXZhbHVlLWNyZWF0ZSAod2lkZ2V0KQogICAiSGVyZSBpcyB3aGVyZSB5b3UgZWRpdCB0 aGUgaWNvbidzIHNwZWNpZmljYXRpb24uIgpAQCAtNTUxNyw2ICs1NTM1LDI0IEBAIGN1c3Rv bS1pY29uLXZhbHVlLWNyZWF0ZQogCSAgKGN1c3RvbS1hZGQtcGFyZW50LWxpbmtzIHdpZGdl dCkpCiAJKGN1c3RvbS1hZGQtc2VlLWFsc28gd2lkZ2V0KSkpKSkKIAorKGRlZnVuIGN1c3Rv bS1pY29uLWFjdGlvbiAod2lkZ2V0ICZvcHRpb25hbCBldmVudCkKKyAgIlNob3cgdGhlIG1l bnUgZm9yIGBjdXN0b20taWNvbicgV0lER0VULgorT3B0aW9uYWwgRVZFTlQgaXMgdGhlIGxv Y2F0aW9uIGZvciB0aGUgbWVudS4iCisgIChpZiAoZXEgKHdpZGdldC1nZXQgd2lkZ2V0IDpj dXN0b20tc3RhdGUpICdoaWRkZW4pCisgICAgICAoY3VzdG9tLXRvZ2dsZS1oaWRlIHdpZGdl dCkKKyAgICAodW5sZXNzIChlcSAod2lkZ2V0LWdldCB3aWRnZXQgOmN1c3RvbS1zdGF0ZSkg J21vZGlmaWVkKQorICAgICAgKGN1c3RvbS1pY29uLXN0YXRlLXNldCB3aWRnZXQpKQorICAg IChjdXN0b20tcmVkcmF3LW1hZ2ljIHdpZGdldCkKKyAgICAobGV0KiAoKGNvbXBsZXRpb24t aWdub3JlLWNhc2UgdCkKKyAgICAgICAgICAgKGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgd2lk Z2V0KQorICAgICAgICAgICAoYW5zd2VyICh3aWRnZXQtY2hvb3NlIChjb25jYXQgIk9wZXJh dGlvbiBvbiAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo Y3VzdG9tLXVubGlzcGlmeS10YWctbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh3aWRnZXQtZ2V0IHdpZGdldCA6dmFsdWUpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjdXN0b20taWNvbi1leHRlbmRlZC1tZW51Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXZlbnQpKSkKKyAgICAgICh3aGVu IGFuc3dlcgorICAgICAgICAoZnVuY2FsbCBhbnN3ZXIgd2lkZ2V0KSkpKSkKKwogKGRlZnVu IGN1c3RvbS10b2dnbGUtaGlkZS1pY29uICh2aXNpYmlsaXR5LXdpZGdldCAmcmVzdCBfaWdu b3JlKQogICAiVG9nZ2xlIHRoZSB2aXNpYmlsaXR5IG9mIGEgYGN1c3RvbS1pY29uJyBwYXJl bnQgd2lkZ2V0LgogQnkgZGVmYXVsdCwgdGhpcyBzaWduYWxzIGFuIGVycm9yIGlmIHRoZSBw YXJlbnQgaGFzIHVuc2F2ZWQKQEAgLTU1NTMsMTAgKzU1ODksMjEgQEAgY3VzdG9tLWljb24t c2V0CiAgICAgICAodXNlci1lcnJvciAiQ2Fubm90IHVwZGF0ZSBoaWRkZW4gaWNvbiIpKQog CiAgICAgKHNldHEgdmFsIChjdXN0b20tLWljb25zLXdpZGdldC12YWx1ZSBjaGlsZCkpCi0g ICAgKHVubGVzcyAoZXF1YWwgdmFsIChpY29uLWNvbXBsZXRlLXNwZWMgc3ltYm9sKSkKLSAg ICAgIChjdXN0b20tdmFyaWFibGUtYmFja3VwLXZhbHVlIHdpZGdldCkpCisgICAgOzsgRklY TUU6IFdoYXQgd2FzIHRoZSBpbnRlbnRpb24gaGVyZT8KKyAgICA7OyAodW5sZXNzIChlcXVh bCB2YWwgKGljb24tY29tcGxldGUtc3BlYyBzeW1ib2wpKQorICAgIDs7ICAgKGN1c3RvbS12 YXJpYWJsZS1iYWNrdXAtdmFsdWUgd2lkZ2V0KSkKICAgICAoY3VzdG9tLXB1c2gtdGhlbWUg J3RoZW1lLWljb24gc3ltYm9sICd1c2VyICdzZXQgdmFsKQotICAgIChjdXN0b20tcmVkcmF3 LW1hZ2ljIHdpZGdldCkpKQorICAgIChjdXN0b20tcmVkcmF3IHdpZGdldCkpKQorCisoZGVm dW4gY3VzdG9tLWljb24tc2F2ZSAod2lkZ2V0KQorICAiU2F2ZSB2YWx1ZSBvZiBpY29uIGVk aXRlZCBieSB3aWRnZXQgV0lER0VULiIKKyAgKGN1c3RvbS1zZXQtaWNvbnMgKGNvbnMgKHdp ZGdldC12YWx1ZSB3aWRnZXQpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAoY3VzdG9tLS1pY29ucy13aWRnZXQtdmFsdWUK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyICh3aWRnZXQtZ2V0IHdpZGdldCA6 Y2hpbGRyZW4pKSkpKSkKKyAgKGN1c3RvbS1zYXZlLWFsbCkKKyAgKGN1c3RvbS1pY29uLXN0 YXRlLXNldCB3aWRnZXQpCisgIChjdXN0b20tcmVkcmF3LW1hZ2ljIHdpZGdldCkpCiAKIDs7 OyMjI2F1dG9sb2FkCiAoZGVmdW4gY3VzdG9taXplLWljb24gKGljb24pCmRpZmYgLS1naXQg YS9saXNwL2VtYWNzLWxpc3AvaWNvbnMuZWwgYi9saXNwL2VtYWNzLWxpc3AvaWNvbnMuZWwK aW5kZXggY2IwOGMxYTZiODEuLjlhNmQyNjI0M2M3IDEwMDY0NAotLS0gYS9saXNwL2VtYWNz LWxpc3AvaWNvbnMuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2ljb25zLmVsCkBAIC0xODEs OSArMTgxLDkgQEAgaWNvbnMtLW1lcmdlLXNwZWMKICAgICAgICAgKGxldCAoKHBhcmVudC1r ZXl3b3JkcyAoaWNvbi1zcGVjLWtleXdvcmRzIGVsZW0pKQogICAgICAgICAgICAgICAoY3Vy cmVudC1rZXl3b3JkcyAoaWNvbi1zcGVjLWtleXdvcmRzIGN1cnJlbnQpKSkKICAgICAgICAg ICAod2hpbGUgcGFyZW50LWtleXdvcmRzCi0gICAgICAgICAgICAodW5sZXNzIChwbGlzdC1n ZXQgKGNhciBwYXJlbnQta2V5d29yZHMpIGN1cnJlbnQta2V5d29yZHMpCi0gICAgICAgICAg ICAgIChuY29uYyBjdXJyZW50ICh0YWtlIDIgcGFyZW50LWtleXdvcmRzKSkKLSAgICAgICAg ICAgICAgKHNldHEgcGFyZW50LWtleXdvcmRzIChjZGRyIHBhcmVudC1rZXl3b3JkcykpKSkp KSkpCisgICAgICAgICAgICAodW5sZXNzIChwbGlzdC1nZXQgY3VycmVudC1rZXl3b3JkcyAo Y2FyIHBhcmVudC1rZXl3b3JkcykpCisgICAgICAgICAgICAgIChuY29uYyBjdXJyZW50ICh0 YWtlIDIgcGFyZW50LWtleXdvcmRzKSkpCisgICAgICAgICAgICAoc2V0cSBwYXJlbnQta2V5 d29yZHMgKGNkZHIgcGFyZW50LWtleXdvcmRzKSkpKSkpKQogICBtZXJnZWQpCiAKIChjbC1k ZWZtZXRob2QgaWNvbnMtLWNyZWF0ZSAoKF90eXBlIChlcWwgJ2ltYWdlKSkgaWNvbiBrZXl3 b3JkcykKLS0gCjIuMzQuMQoK --------------Xnuo0DbsVlXnpOq7m1kIafqX-- From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Oct 2023 21:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mauro Aranda , 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169783612523690 (code B ref 66635); Fri, 20 Oct 2023 21:09:02 +0000 Received: (at 66635) by debbugs.gnu.org; 20 Oct 2023 21:08:45 +0000 Received: from localhost ([127.0.0.1]:41752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtwjc-0006A0-DQ for submit@debbugs.gnu.org; Fri, 20 Oct 2023 17:08:44 -0400 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:52456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtwjX-00069l-N1 for 66635@debbugs.gnu.org; Fri, 20 Oct 2023 17:08:42 -0400 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2c523ac38fbso18880881fa.0 for <66635@debbugs.gnu.org>; Fri, 20 Oct 2023 14:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697836086; x=1698440886; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=TyfXXNwaeKy/k+nI9NrpsLZB0ns7KxFwgY7mX3KMfX0=; b=ZpZoQeSCUGM7gKiPj+fTZlwDlLRKNCAdGdhUxhHn6Vj497cGlNEpRQtpXqYZo+r76u 0Wqdf3ELEXuiPFZv/pChLxSgbOGC3ZeraeX6BPaFzyxc6XKbU0x+tGZb2mUuDSdLbA17 foHGTHDy8TfBsiFIOIThCiHLNWP0nyU6YXJjWfGkF065rYpBsmr9rTDagpIeK4aHwdDW 4cRI4j5CInRBQjepvYRUDcWXQNQQwg4MFO/+K2N73Gxdp88Scvfvbx3sTgSSjem83n1X 1hlYOkYowZQpD8mSYwSCf/dEXyivFc7mkgf2GxqNoz4z87RezdZ5S4dojYozt/TU0A6d uJ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697836086; x=1698440886; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TyfXXNwaeKy/k+nI9NrpsLZB0ns7KxFwgY7mX3KMfX0=; b=qNhHX3BG5VlRSiTQmrSRnPbjk65ZcpbeQ7UgU2M4T4k6aGoOwPw5txx7HRRgZHvYQ/ eTSXYyFEh/UZin6knv5q2P8D/qymwg6L4H0Gv0Q8cMxp6Cg4U2nIY06Zl3RexgHFlaMR fobgh6ueXTDs0E5nE0ueYodIDjYe28Q1OYul/C2XiWBT8p93b5t8hL4mJv08ufvzHMio mbC5EJqpWsMznX/znrI1MoOQPTpyiEYDxIF3IUgAN3iEpqR2LEUO7A4wSh8a2GGPcZsc 7DPlEoRKSt8JgNyHD1an7onfKNFIPtubNwoS/WgUZ/q3hnazQDBW+wj57M//keVY5ig6 v/GA== X-Gm-Message-State: AOJu0YwOSlAG6GA6GWQrJ4YHU3dDDZN73fji7b6O6qomHK8X1TGMNrLY tt8O/zvb5k0mzgz7rV7mThfOs6SRltobapBcoOg= X-Google-Smtp-Source: AGHT+IFTePhU68HsUjWVcQePIOs9/Y0fttp31/qZ0+ip7v3oFLsQeeDsNtRljAWXHxve/cWaGrmF4OZEsRla6v5LpQU= X-Received: by 2002:a2e:7004:0:b0:2c4:ff4c:64b0 with SMTP id l4-20020a2e7004000000b002c4ff4c64b0mr2056476ljc.50.1697836085667; Fri, 20 Oct 2023 14:08:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Oct 2023 14:08:05 -0700 From: Stefan Kangas In-Reply-To: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> MIME-Version: 1.0 Date: Fri, 20 Oct 2023 14:08:05 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > I attach a patch to address the more important issues for now. That is, > at least have a working State button and rudimentary state checking. > > Setting and Saving icon specifications through the State button should > work now, by adding the custom-icon-action function. Thanks for working on this. Do you propose this patch for emacs-29? It seems quite intrusive on the face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no risk of regressions if this stuff never worked in the first place. Or is that wrong? > From ab4fabf48665ddc142ad95a26898eb6207cd2bdc Mon Sep 17 00:00:00 2001 > From: Mauro Aranda > Date: Thu, 19 Oct 2023 08:46:35 -0300 > Subject: [PATCH] Fix State button for customize-icon (Bug#66635) > > * lisp/cus-edit.el (custom-icon-action): New function. > (custom-icon): Use it as the :action. Otherwise, clicking the State > button is a noop. Remove irrelevant stuff from the docstring and > comment out some copy-pasta. > (custom-icon-extended-menu): New variable, the menu to show upon > :action. > (custom-icon-set): Really redraw the widget with the new settings. > Comment out strange call to custom-variable-backup-value. > (custom-icon-save): New function. > > * lisp/emacs-lisp/icons.el (icons--merge-spec): Fix call to plist-get > and avoid infloop. > --- > lisp/cus-edit.el | 71 +++++++++++++++++++++++++++++++++------- > lisp/emacs-lisp/icons.el | 6 ++-- > 2 files changed, 62 insertions(+), 15 deletions(-) > > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > index 706e08d5657..953b8b8b80f 100644 > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -5366,11 +5366,6 @@ 'custom-icon > :hidden-states should be a list of widget states for which the > widget's initial contents are to be hidden. > > -:custom-form should be a symbol describing how to display and > - edit the variable---either `edit' (using edit widgets), > - `lisp' (as a Lisp sexp), or `mismatch' (should not happen); > - if nil, use the return value of `custom-variable-default-form'. > - > :shown-value, if non-nil, should be a list whose `car' is the > variable value to display in place of the current value. > > @@ -5383,11 +5378,34 @@ 'custom-icon > :custom-category 'option > :custom-state nil > :custom-form nil > - :value-create 'custom-icon-value-create > + :value-create #'custom-icon-value-create > :hidden-states '(standard) > - :custom-set 'custom-icon-set > - :custom-reset-current 'custom-redraw > - :custom-reset-saved 'custom-variable-reset-saved) > + :action #'custom-icon-action > + :custom-set #'custom-icon-set > + :custom-reset-current #'custom-redraw) > + ;; Not implemented yet. > + ;; :custom-reset-saved 'custom-icon-reset-saved) > + > +(defvar custom-icon-extended-menu > + (let ((map (make-sparse-keymap))) > + (define-key-after map [custom-icon-set] > + '(menu-item "Set for Current Session" custom-icon-set > + :enable (eq (widget-get custom-actioned-widget :custom-state) > + 'modified))) > + (when (or custom-file init-file-user) > + (define-key-after map [custom-icon-save] > + '(menu-item "Save for Future Sessions" custom-icon-save > + :enable (memq > + (widget-get custom-actioned-widget :custom-state) > + '(modified set changed))))) > + (define-key-after map [custom-redraw] > + '(menu-item "Undo Edits" custom-redraw > + :enable (memq > + (widget-get custom-actioned-widget :custom-state) > + '(modified changed)))) > + map) > + "A menu for `custom-icon' widgets. > +Used in `custom-icon-action' to show a menu to the user.") > > (defun custom-icon-value-create (widget) > "Here is where you edit the icon's specification." > @@ -5517,6 +5535,24 @@ custom-icon-value-create > (custom-add-parent-links widget)) > (custom-add-see-also widget))))) > > +(defun custom-icon-action (widget &optional event) > + "Show the menu for `custom-icon' WIDGET. > +Optional EVENT is the location for the menu." > + (if (eq (widget-get widget :custom-state) 'hidden) > + (custom-toggle-hide widget) > + (unless (eq (widget-get widget :custom-state) 'modified) > + (custom-icon-state-set widget)) > + (custom-redraw-magic widget) > + (let* ((completion-ignore-case t) > + (custom-actioned-widget widget) > + (answer (widget-choose (concat "Operation on " > + (custom-unlispify-tag-name > + (widget-get widget :value))) > + custom-icon-extended-menu > + event))) > + (when answer > + (funcall answer widget))))) > + > (defun custom-toggle-hide-icon (visibility-widget &rest _ignore) > "Toggle the visibility of a `custom-icon' parent widget. > By default, this signals an error if the parent has unsaved > @@ -5553,10 +5589,21 @@ custom-icon-set > (user-error "Cannot update hidden icon")) > > (setq val (custom--icons-widget-value child)) > - (unless (equal val (icon-complete-spec symbol)) > - (custom-variable-backup-value widget)) > + ;; FIXME: What was the intention here? > + ;; (unless (equal val (icon-complete-spec symbol)) > + ;; (custom-variable-backup-value widget)) Is there any reason to not just remove this outright? It'd still be there in git history, in the unlikely event that we should need it again. > (custom-push-theme 'theme-icon symbol 'user 'set val) > - (custom-redraw-magic widget))) > + (custom-redraw widget))) > + > +(defun custom-icon-save (widget) > + "Save value of icon edited by widget WIDGET." > + (custom-set-icons (cons (widget-value widget) > + (list > + (custom--icons-widget-value > + (car (widget-get widget :children)))))) > + (custom-save-all) > + (custom-icon-state-set widget) > + (custom-redraw-magic widget)) > > ;;;###autoload > (defun customize-icon (icon) > diff --git a/lisp/emacs-lisp/icons.el b/lisp/emacs-lisp/icons.el > index cb08c1a6b81..9a6d26243c7 100644 > --- a/lisp/emacs-lisp/icons.el > +++ b/lisp/emacs-lisp/icons.el > @@ -181,9 +181,9 @@ icons--merge-spec > (let ((parent-keywords (icon-spec-keywords elem)) > (current-keywords (icon-spec-keywords current))) > (while parent-keywords > - (unless (plist-get (car parent-keywords) current-keywords) > - (nconc current (take 2 parent-keywords)) > - (setq parent-keywords (cddr parent-keywords)))))))) > + (unless (plist-get current-keywords (car parent-keywords)) > + (nconc current (take 2 parent-keywords))) > + (setq parent-keywords (cddr parent-keywords))))))) > merged) > > (cl-defmethod icons--create ((_type (eql 'image)) icon keywords) > -- > 2.34.1 From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 00:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169784773825587 (code B ref 66635); Sat, 21 Oct 2023 00:23:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 00:22:18 +0000 Received: from localhost ([127.0.0.1]:41890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtzkv-0006ed-6p for submit@debbugs.gnu.org; Fri, 20 Oct 2023 20:22:18 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:42090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtzkp-0006eL-6I for 66635@debbugs.gnu.org; Fri, 20 Oct 2023 20:22:15 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1c9e95aa02dso11014005ad.0 for <66635@debbugs.gnu.org>; Fri, 20 Oct 2023 17:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697847698; x=1698452498; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H20uKSqmZVcWjiKZkyu/fsW0YqxuWwEWCduznTXaOeM=; b=gG+bwXImbw2U0w/mVg02ZgBLJtdh1eQmPpVFXNc4L/eeUIRMUvNGN/QngsK9mQhxK0 aFJS5OxNJylkETPAXrdzssNUiFBleV4vK3fbNMpYYd35NJBcZaB22wEnVZSzV/+5hz1F da+nCBtSbDTDcdJKRb4OSMeiziBUKA1B1LmG+VQLyLmUkv6f4vLuVAKwYXJvuvdXlNSa 2LZqInwlWOumFIpXo3y/y1GVnHTd98zLAH7gAsJnZZDmdp39mAAbV+Zq+kSEbfDc08vr dtjGTrQVY5pWUCzVE6OpfguJtfPGnEIGHfpWj2rjKFPCNPUSYMZft/TOAhyuBmxLQu81 n+Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697847698; x=1698452498; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H20uKSqmZVcWjiKZkyu/fsW0YqxuWwEWCduznTXaOeM=; b=oiU7267vsetB0enYchmOlqpNZJ18eVlfdgKZfsGG5bU/5K1IZdmPaoUH13pv5slEGO FV7erletJG1Qy/XWIhyVY3N6mIUJ6y3UOuU6mMCWE4SlTDTmaYXJlqPTrQ/bg4HZT1AN Pm+W9YM90kZx23NJAMP71fU038+N0oh0WNQnUPt33/8Z1Skb3H/rl9TK+rR8YBdwk8tb 19LkelafpmVWaQxe7wzEZaB24d/BXIDdZGCvzUR93PeHBMy+njKHIinAciSln+ks1nKk GXQhSwWkmMsfcpKnwma9ydzH3tJGOr0yYqTsWq86LHNAjsMKULOvq/nU0gLCp9IMD3ut EtWQ== X-Gm-Message-State: AOJu0YzA5P2xo6kxqmJ14jkOmYGwKUBxFQryIQMOo9dtFthsdjt6iwD5 IGMIaPtCpa/rEY9oXcQTtCI= X-Google-Smtp-Source: AGHT+IHs6zQg+cYkMuvKaBHaERsuPk80oaKKt7KqmH5SH7CUiUNOctCny8k1N1JaK3SebywVNWP9JQ== X-Received: by 2002:a17:903:2447:b0:1c5:ecfc:2650 with SMTP id l7-20020a170903244700b001c5ecfc2650mr8796856pls.14.1697847697532; Fri, 20 Oct 2023 17:21:37 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id n18-20020a170902d2d200b001c737950e4dsm2083145plc.2.2023.10.20.17.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Oct 2023 17:21:37 -0700 (PDT) Message-ID: <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> Date: Fri, 20 Oct 2023 21:21:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 20/10/23 18:08, Stefan Kangas wrote: > Mauro Aranda writes: > >> I attach a patch to address the more important issues for now.  That is, >> at least have a working State button and rudimentary state checking. >> >> Setting and Saving icon specifications through the State button should >> work now, by adding the custom-icon-action function. > > > Thanks for working on this. > > Do you propose this patch for emacs-29?  It seems quite intrusive on the > face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no > risk of regressions if this stuff never worked in the first place.  Or > is that wrong? I'm not aware of all things you and Eli have to take into account when deciding whether a patch is good for emacs-29.  I know the non-intrusive or localized, and the safe part.  This patch is certainly neither, but it's the minimum (OK, maybe not the bare minimum) to make customizing icons work for an user.  I think that's a good reason for the patch to go into emacs-29, but I won't be insisting on it, specially if it is a burden, considering 29.1.90 pretest is out. It could be made less intrusive without the change to icons--merge-spec, but I don't think it'd be wise to do that. >> From ab4fabf48665ddc142ad95a26898eb6207cd2bdc Mon Sep 17 00:00:00 2001 >> From: Mauro Aranda >> Date: Thu, 19 Oct 2023 08:46:35 -0300 >> Subject: [PATCH] Fix State button for customize-icon (Bug#66635) >> >> * lisp/cus-edit.el (custom-icon-action): New function. >> (custom-icon): Use it as the :action.  Otherwise, clicking the State >> button is a noop.  Remove irrelevant stuff from the docstring and >> comment out some copy-pasta. >> (custom-icon-extended-menu): New variable, the menu to show upon >> :action. >> (custom-icon-set): Really redraw the widget with the new settings. >> Comment out strange call to custom-variable-backup-value. >> (custom-icon-save): New function. >> >> * lisp/emacs-lisp/icons.el (icons--merge-spec): Fix call to plist-get >> and avoid infloop. >> --- >>  lisp/cus-edit.el         | 71 +++++++++++++++++++++++++++++++++------- >>  lisp/emacs-lisp/icons.el |  6 ++-- >>  2 files changed, 62 insertions(+), 15 deletions(-) >> >> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el >> index 706e08d5657..953b8b8b80f 100644 >> --- a/lisp/cus-edit.el >> +++ b/lisp/cus-edit.el >> @@ -5366,11 +5366,6 @@ 'custom-icon >>  :hidden-states should be a list of widget states for which the >>    widget's initial contents are to be hidden. >> >> -:custom-form should be a symbol describing how to display and >> -  edit the variable---either `edit' (using edit widgets), >> -  `lisp' (as a Lisp sexp), or `mismatch' (should not happen); >> -  if nil, use the return value of `custom-variable-default-form'. >> - >>  :shown-value, if non-nil, should be a list whose `car' is the >>    variable value to display in place of the current value. >> >> @@ -5383,11 +5378,34 @@ 'custom-icon >>    :custom-category 'option >>    :custom-state nil >>    :custom-form nil >> -  :value-create 'custom-icon-value-create >> +  :value-create #'custom-icon-value-create >>    :hidden-states '(standard) >> -  :custom-set 'custom-icon-set >> -  :custom-reset-current 'custom-redraw >> -  :custom-reset-saved 'custom-variable-reset-saved) >> +  :action #'custom-icon-action >> +  :custom-set #'custom-icon-set >> +  :custom-reset-current #'custom-redraw) >> +  ;; Not implemented yet. >> +  ;; :custom-reset-saved 'custom-icon-reset-saved) >> + >> +(defvar custom-icon-extended-menu >> +  (let ((map (make-sparse-keymap))) >> +    (define-key-after map [custom-icon-set] >> +      '(menu-item "Set for Current Session" custom-icon-set >> +                  :enable (eq (widget-get custom-actioned-widget :custom-state) >> +                              'modified))) >> +    (when (or custom-file init-file-user) >> +      (define-key-after map [custom-icon-save] >> +        '(menu-item "Save for Future Sessions" custom-icon-save >> +                    :enable (memq >> +                             (widget-get custom-actioned-widget :custom-state) >> +                             '(modified set changed))))) >> +    (define-key-after map [custom-redraw] >> +      '(menu-item "Undo Edits" custom-redraw >> +                  :enable (memq >> +                           (widget-get custom-actioned-widget :custom-state) >> +                           '(modified changed)))) >> +    map) >> +  "A menu for `custom-icon' widgets. >> +Used in `custom-icon-action' to show a menu to the user.") >> >>  (defun custom-icon-value-create (widget) >>    "Here is where you edit the icon's specification." >> @@ -5517,6 +5535,24 @@ custom-icon-value-create >>        (custom-add-parent-links widget)) >>      (custom-add-see-also widget))))) >> >> +(defun custom-icon-action (widget &optional event) >> +  "Show the menu for `custom-icon' WIDGET. >> +Optional EVENT is the location for the menu." >> +  (if (eq (widget-get widget :custom-state) 'hidden) >> +      (custom-toggle-hide widget) >> +    (unless (eq (widget-get widget :custom-state) 'modified) >> +      (custom-icon-state-set widget)) >> +    (custom-redraw-magic widget) >> +    (let* ((completion-ignore-case t) >> +           (custom-actioned-widget widget) >> +           (answer (widget-choose (concat "Operation on " >> + (custom-unlispify-tag-name >> +                                           (widget-get widget :value))) >> + custom-icon-extended-menu >> +                                  event))) >> +      (when answer >> +        (funcall answer widget))))) >> + >>  (defun custom-toggle-hide-icon (visibility-widget &rest _ignore) >>    "Toggle the visibility of a `custom-icon' parent widget. >>  By default, this signals an error if the parent has unsaved >> @@ -5553,10 +5589,21 @@ custom-icon-set >>        (user-error "Cannot update hidden icon")) >> >>      (setq val (custom--icons-widget-value child)) >> -    (unless (equal val (icon-complete-spec symbol)) >> -      (custom-variable-backup-value widget)) >> +    ;; FIXME: What was the intention here? >> +    ;; (unless (equal val (icon-complete-spec symbol)) >> +    ;;   (custom-variable-backup-value widget)) > > Is there any reason to not just remove this outright? > > It'd still be there in git history, in the unlikely event that we should > need it again. I just couldn't tell what was the intention.  Maybe the intention was to make a backup just like we do for variables, for later getting the backed up value again, like custom-variable-reset-value does.  In that case, the comment may help to remind someone (and certainly me if I ever get the time) to implement something like that.  Since I'm not certain what's the intention, I had no way of justifying the removal, so I opted to comment it out.  I won't object if you prefer otherwise. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 07:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mauro Aranda Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169787375725980 (code B ref 66635); Sat, 21 Oct 2023 07:36:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 07:35:57 +0000 Received: from localhost ([127.0.0.1]:42115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu6WX-0006kt-PS for submit@debbugs.gnu.org; Sat, 21 Oct 2023 03:35:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu6WS-0006gh-O8 for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 03:35:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu6Vu-00052s-2Y; Sat, 21 Oct 2023 03:35:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ruOGFWHye9Rm4xEcyGiGP6Z8sNIBnme4PVXEV7CY7cE=; b=Wk7uN5mwvNI6TnVGgrWF lRsb6dCehUISrPghz8YaEEdNy3Es9XEY8MlTE/3R0B+d2e3ayobnTYOjXWJav4Amd8Ev2C15k5fAD 6jEyrqjzCLChp3FNYToMq2SEtPmgeWwoMDXXe2AFVQNjmtsPSxPgaiGYsqdFmPB6vaTl0FgTj8Uat Ezd2suEvrxyE2Bs1pu0+1Pd9r+NDfcD28xyppCf4viYgwr7OMz/gRE24FWfxfw9tkIns2XDkvHyi9 2KqAyZ9EgJdiqegmEIj2696IeaC3HbmMC/Kl69KTcW19WiGEpo18JUdfvLU3UoLuAfHjAGsuO2oha ECv7xtUZ5eSc7w==; Date: Sat, 21 Oct 2023 10:35:09 +0300 Message-Id: <83cyx8sa1e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> (message from Mauro Aranda on Fri, 20 Oct 2023 21:21:34 -0300) References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 20 Oct 2023 21:21:34 -0300 > From: Mauro Aranda > > On 20/10/23 18:08, Stefan Kangas wrote: > > Mauro Aranda writes: > > > >> I attach a patch to address the more important issues for now.  That is, > >> at least have a working State button and rudimentary state checking. > >> > >> Setting and Saving icon specifications through the State button should > >> work now, by adding the custom-icon-action function. > > > > > > Thanks for working on this. > > > > Do you propose this patch for emacs-29?  It seems quite intrusive on the > > face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no > > risk of regressions if this stuff never worked in the first place.  Or > > is that wrong? > > I'm not aware of all things you and Eli have to take into account when > deciding whether a patch is good for emacs-29.  I know the non-intrusive > or localized, and the safe part.  This patch is certainly neither, but > it's the minimum (OK, maybe not the bare minimum) to make customizing > icons work for an user.  I think that's a good reason for the patch to > go into emacs-29, but I won't be insisting on it, specially if it is a > burden, considering 29.1.90 pretest is out. icons.el is a new package in Emacs 29, so maybe such changes in it to fix a serious problem are okay even at this stage. How well is the fix tested? Did you test it with several icons introduced in Emacs 29 in various modes? If not, would you please test those and see the changes work well enough there to be appropriate for a bug-fix release? Thanks. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 10:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.16978835511286 (code B ref 66635); Sat, 21 Oct 2023 10:20:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 10:19:11 +0000 Received: from localhost ([127.0.0.1]:42273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu94Z-0000Kg-Cj for submit@debbugs.gnu.org; Sat, 21 Oct 2023 06:19:11 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:49536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu94W-0000KP-UP for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 06:19:10 -0400 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1ca3a54d2c4so13653205ad.3 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 03:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697883515; x=1698488315; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rGuloe/xFgi4JXSyicqNl22+ISzy36roXfMaHGb/Nvs=; b=Uo9TSyhb3iLgD2sYj12lnC29b8M7n5jNwL8iMf/GvUnCCzciy+QnSoN1N6DPiwPOSf baCPN2NK5rBR50w1pWnPcE9WV1i3f4vCsnTLV7Szj/kcXDUt+u2EgtRdVd0ZyceSlslN XeOb9tbeg5kikfJmybxc0TSZsLucfoY2IfJte0GC3J55B0lrzl5ELXtgFByMVjLXQUpG 1Vt35s5AGfLGuk7NDxrr4fNnieJTKMRQD9mXflUPAXeFQyW3xEqY22VyfHlxHcIguUCJ UoAm2/GEmeG78V5j+TSOfA0+OjcceccPv4cqmWpIyYi93Sw3OSvJ0d5gsegFd7Isje36 /Gsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697883515; x=1698488315; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rGuloe/xFgi4JXSyicqNl22+ISzy36roXfMaHGb/Nvs=; b=RpXGrmQbe4QxbxkvkiSstG2kqmGfR1VdztVB7hnHtVQaiNjKYMaDIt0D4YXOHO1Inu KZozqREuadqTBn67lWMa6Vq6jKNT5iPnSUtv7wyVWmGTpLYyrCQA8Uohvt3e0D2uI8a0 OudgCJeA1DHYnDlYwwcVTsBOcWku9bnVq2m5SD/A3tbxFsyLBL553PkVp4tBBCHYNT3O IPfHC4XHAuqOYnRl+t7dnj3kXzAXQlb76fwQfVv85E8ynLxSlr7ZQssX2iJkyn+pyTB2 UxNPpiC8VQ2MKWl8QHK3B2cYsXc/0pKNauIYybiTh4UJU4fX8W/QkTZlsZ9DbJwvrItJ o7OA== X-Gm-Message-State: AOJu0Yw/un6gEtVBCwDITi79JSB97G7H2crKXhcS9iNqVSB5yeTkIn+N hyvvwU41S/s6zBoppnNNId8= X-Google-Smtp-Source: AGHT+IEJfHmeGcndv9jOts35iTJTaHlcGN2Hiaq6/PzZITeNk7pL/uDR4U/atFvGgJFH2xVPz4Na+A== X-Received: by 2002:a17:903:18d:b0:1ca:87ea:2fcf with SMTP id z13-20020a170903018d00b001ca87ea2fcfmr5088080plg.25.1697883515081; Sat, 21 Oct 2023 03:18:35 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id h13-20020a170902680d00b001c0de73564dsm2951758plk.205.2023.10.21.03.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Oct 2023 03:18:34 -0700 (PDT) Message-ID: Date: Sat, 21 Oct 2023 07:18:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> From: Mauro Aranda In-Reply-To: <83cyx8sa1e.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 21/10/23 04:35, Eli Zaretskii wrote: >> Date: Fri, 20 Oct 2023 21:21:34 -0300 >> From: Mauro Aranda >> >> On 20/10/23 18:08, Stefan Kangas wrote: >>  > Mauro Aranda writes: >>  > >>  >> I attach a patch to address the more important issues for now.  That is, >>  >> at least have a working State button and rudimentary state checking. >>  >> >>  >> Setting and Saving icon specifications through the State button should >>  >> work now, by adding the custom-icon-action function. >>  > >>  > >>  > Thanks for working on this. >>  > >>  > Do you propose this patch for emacs-29?  It seems quite intrusive on the >>  > face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no >>  > risk of regressions if this stuff never worked in the first place.  Or >>  > is that wrong? >> >> I'm not aware of all things you and Eli have to take into account when >> deciding whether a patch is good for emacs-29.  I know the non-intrusive >> or localized, and the safe part.  This patch is certainly neither, but >> it's the minimum (OK, maybe not the bare minimum) to make customizing >> icons work for an user.  I think that's a good reason for the patch to >> go into emacs-29, but I won't be insisting on it, specially if it is a >> burden, considering 29.1.90 pretest is out. > > icons.el is a new package in Emacs 29, so maybe such changes in it to > fix a serious problem are okay even at this stage. Great, thanks. > How well is the fix tested?  Did you test it with several icons > introduced in Emacs 29 in various modes?  If not, would you please > test those and see the changes work well enough there to be > appropriate for a bug-fix release? I just tested with the button icon, the only one suggested after running emacs -Q.  I tested making modifications in the buffer, and that the two options (three if not started with -Q) work and do what's intended.  Namely: - Undo Editions took me back to the STANDARD state. - Setting for the session modified the specs for the session and correctly displayed the SET state. - Saving the setting saved a spec that in a new session (without emacs -Q) causes: M-x describe-icon RET button to show the button customized.  The value I changed for that was from LARGE BLUE CIRCLE to LARGE RED SQUARE It's important to note that saving the setting shows the SET state (rather than the SAVED state), but that's in a FIXME right before custom-icon-state. I'll do some more testing with the icons defined in outline.el, tab-bar.el and warnings.el.  Additionally I'll try to test if Customizing an icon interacts good enough with a Theme customizations. I'll do that and report back. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169788665118763 (code B ref 66635); Sat, 21 Oct 2023 11:11:01 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 11:10:51 +0000 Received: from localhost ([127.0.0.1]:42363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9sZ-0004sZ-Dz for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:10:51 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:56533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9sW-0004sL-R5 for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 07:10:49 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6b709048f32so1398341b3a.0 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 04:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697886615; x=1698491415; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=prgS7GZcw9+JDX2EGDmpMU3VpKMz4CruTcYrwy/ASXg=; b=OVCAokCdm9sV+FuwDbfVQlZJwaF7vhpkyVYR4aTwDHUX6c192uhfCCPgHda89LRQY4 gfLIFu2F9ITdK0nuTCPp/hilUASeLeNLmb0sxI6IaxWi3mKbdwb0izXPHwFLcSS5vwp5 88KYwsShHHrsSyHZZG57CnBCa94o1xyJCdrPna6u0+AaP1dPa7pDLUia1FyBb2w1O0hy LVAzAsik0f+z1x/csld94tfmbQAkc6weLFULF6vQaJjYOkOnyjQUaQLWq6ZuNnItTYmO jD0EEgJ0jVu0L43IsN1S8qsHrVWv9t8qObPBZo/wCXrZlzoBhpV6QfwZIO6iVeOTVBSA vELA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697886615; x=1698491415; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=prgS7GZcw9+JDX2EGDmpMU3VpKMz4CruTcYrwy/ASXg=; b=aGcwjoXnLZxTRMqtN9G73NvBITVqjCAz6Xzsbyt44FXlHMxWYPMSDqHphfMLfTabSZ a5Lj89Z3XZ0qRLdV6wKPtdA+mrgeo4npxsCujQ3hdte8ZCpukSEwQqvg8mgG7vDgKbL1 SliIYUHLUWdFYxcaSRMsskG2Pizjs7Z+VFToEs9CsnflFL80bcdIHaaKxm4YylZbOnlz pGqHWCS1YkVPGk80ar+xQcImHE6C/fYN2peOuGCLvRwrMwKGtjUFBWhpZ8UxzyiN5WwL UdbXTmcusGNsO74JRX6Yi/1ONfsWrOsuB3mbtPBXDptfl18VLAOiqIprnFM2xRlTQ4QN 18Mw== X-Gm-Message-State: AOJu0YwONpDpNcTjjW7jPTma/7hSPwSZ4S6VwyDb2QqPEWdJ4+LjU6M+ KRGFWZtOOt3G45TXqW8Bv8E= X-Google-Smtp-Source: AGHT+IEk2XR1nlZXcFLfMEbGEgdnzO2faRDpLskih7xi+REDMwQociVpYzpao00f/S7hgnw30wrB/g== X-Received: by 2002:aa7:9622:0:b0:68e:42c9:74e0 with SMTP id r2-20020aa79622000000b0068e42c974e0mr3661698pfg.3.1697886614756; Sat, 21 Oct 2023 04:10:14 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id g5-20020aa79dc5000000b006bd2bbbaf49sm3062062pfq.122.2023.10.21.04.10.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Oct 2023 04:10:14 -0700 (PDT) Message-ID: <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> Date: Sat, 21 Oct 2023 08:09:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Mauro Aranda References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 21/10/23 07:18, Mauro Aranda wrote: > On 21/10/23 04:35, Eli Zaretskii wrote: > > How well is the fix tested? Did you test it with several icons > > introduced in Emacs 29 in various modes? If not, would you please > > test those and see the changes work well enough there to be > > appropriate for a bug-fix release? > > I just tested with the button icon, the only one suggested after > running emacs -Q. I tested making modifications in the buffer, and that > the two options (three if not started with -Q) work and do what's > intended. Namely: > - Undo Editions took me back to the STANDARD state. > - Setting for the session modified the specs for the session and > correctly displayed the SET state. > - Saving the setting saved a spec that in a new session (without emacs > -Q) causes: > M-x describe-icon RET button > to show the button customized. The value I changed for that was from > LARGE BLUE CIRCLE to LARGE RED SQUARE > > It's important to note that saving the setting shows the SET state > (rather than the SAVED state), but that's in a FIXME right before > custom-icon-state. > > I'll do some more testing with the icons defined in outline.el, > tab-bar.el and warnings.el. Additionally I'll try to test if > Customizing an icon interacts good enough with a Theme customizations. > I'll do that and report back. I checked outline.el icons and everything seems to work OK. Tested in some buffer with outline-mode, including the NEWS file. Savings get loaded correctly. Similarly with warning-suppress icon. With tab-bar.el I tried other images, and works fine too. It didn't get updated immediately, but after some time and user interaction, it showed the new image. I don't use tab-bar-mode so maybe there's something to do to make it update. Then I created a foo theme to customize icons and pon starting emacs and customizing the icons the state was THEMED, and after customizing them my customizations were respected. So that works fine too. One thing I found, but not related to my patch (and see below for others) is that I had to require 'cus-edit to make custom-theme-set-icons available. That might not be optimal. To sum it up, after testing more thoroughly, I haven't yet found any trouble with my patch, which improves considerably icons customization. More work needs to be done (expanding state checking, reverting customizations, improving help in the custom buffer, adding support in customize-create-theme, showing the image that would get used, etc), but those should be separate bug reports, I think. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 11:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mauro Aranda , Eli Zaretskii Cc: 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169788711019591 (code B ref 66635); Sat, 21 Oct 2023 11:19:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 11:18:30 +0000 Received: from localhost ([127.0.0.1]:42380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9zy-00055v-Ig for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:18:30 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:54528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9zt-00055S-NB for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 07:18:29 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c514cbbe7eso23496041fa.1 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 04:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697887072; x=1698491872; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ezfaeDbjIkgrD2odqAYF9aRaS0f0F3hX0QqkjfVt3Hc=; b=EyND/02rfqnhjXO2ZdACpDDHiJma8Iq4+CBMFkFfBPNJy68BY/LN8ev4oTSrvgfbBY azBxIaPENWdSjwRYbwpqzazpSFLpueCqeb/09lFRL4vdM55rJIVHn7aJABBrdogGXX9S wokszQqWv0QI+LvZjKoomBdR7qv/oV9PjpCdq0Xg1EyHuLXde1BPmb8Mn/we51ycc4sl GLTmf0jx+1ksPpcgiQD/lFxk3UqgUqxdtZ7ICU+YN+ZrMirZLxjJ5Iw0c6o3DFJd1LjE PCpgSVv0r9aFPgQV6APoti5xi5672kPR49qxtgq7QYePjjvOurJWRXDmL7vVwqsnel/J Bt3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697887072; x=1698491872; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ezfaeDbjIkgrD2odqAYF9aRaS0f0F3hX0QqkjfVt3Hc=; b=AghUkwvJ7ORgRuXfsVAlsWIdQ2lPaOu1tuEw7/x4WBLv/07zIC1G9UH0kOG8jNpGA6 b03paHq4GbBBZL05hYQrPiANd72dEcL86GEuGTYicsCFYrdbxXv1lzPpmMRISA3Hj1UJ +vtE2ZJRrsdw1vRniPl5GLmYlwgufxI3Vtg6cyuXE68RzIU2YT4Lh210CQ0AKLA/DxbX APs8Kl3riHiVryx+cttK12fC8dBlAOuS0DSo+e6Ecc1GqeoRoI2zlmFlg8AD5/JxTmZx AJ/ZsWPE5FdgU1LVvVhNJEJatNfSM67HkZPoxVtYfkwyQBMd4Xy3rKt9qRbkn4QPNqRC n46w== X-Gm-Message-State: AOJu0Yy5UVpBVHR7pNLTUJhGSGJg2YNxvp/aeeGrB/BPDCqoAhEPK3wI VVzbj4gOS5jXYQeOQm959hr/cu9MC7mpBQuo0abyJTQO3fND+w== X-Google-Smtp-Source: AGHT+IGBmyA4bD0PyZiDyqB8TxiE0HmtNC2ThlI1AUXzk7efXW4CAV3g/SUmr0M6qCxesmqCKIqEJnc55UqDdGkIJRo= X-Received: by 2002:a2e:81d7:0:b0:2c5:3a9:7467 with SMTP id s23-20020a2e81d7000000b002c503a97467mr3197346ljg.8.1697887071710; Sat, 21 Oct 2023 04:17:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 21 Oct 2023 04:17:51 -0700 From: Stefan Kangas In-Reply-To: <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> MIME-Version: 1.0 Date: Sat, 21 Oct 2023 04:17:51 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > To sum it up, after testing more thoroughly, I haven't yet found any > trouble with my patch, which improves considerably icons customization. > More work needs to be done (expanding state checking, reverting > customizations, improving help in the custom buffer, adding support in > customize-create-theme, showing the image that would get used, etc), but > those should be separate bug reports, I think. Thanks for working on this. Eli, do you see any reason for not installing this on emacs-29? From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 11:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mauro Aranda Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169788721719789 (code B ref 66635); Sat, 21 Oct 2023 11:21:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 11:20:17 +0000 Received: from localhost ([127.0.0.1]:42386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quA1d-000590-0a for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:20:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quA1Y-00058g-1X for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 07:20:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quA11-000378-04; Sat, 21 Oct 2023 07:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uP9ZiwXgXmJUupGeL+As2VihVoneFOzEWrPhj/yA3Sw=; b=hv7eKuMJlsl3qL0j/oXn fJgu8z2rHHn4tJU53hno8Li6S84Wog9pI5nyaZr11adHMalMLGmaXAgN7HK39OGMjdejqzz5mxjX2 nvndgDjDFAgra9XSb7qND6uw9z8wKCfXKgY/MAHzHTis3xyGFzAaXxGVGrYV7Nc9tIWIpLQZPqna1 xsya0S7eghHLcZ9yYUIDJO3IuzgwxmfdQ2RL3sOoxIOHglNoBXqVp9+KJ5QZfBcEmDgoVbPFUqOsT XzKgeMWWtbfkoBSgLFd8fa92ICW+6L24ENASNlqk1x37ayks/ooedEh1UGnsP56X53tTErDuy5tWC b0s1/C/kxQs+hw==; Date: Sat, 21 Oct 2023 14:19:32 +0300 Message-Id: <83y1fwql2z.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Mauro Aranda on Sat, 21 Oct 2023 07:18:31 -0300) References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 21 Oct 2023 07:18:31 -0300 > Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org > From: Mauro Aranda > > On 21/10/23 04:35, Eli Zaretskii wrote: > > How well is the fix tested?  Did you test it with several icons > > introduced in Emacs 29 in various modes?  If not, would you please > > test those and see the changes work well enough there to be > > appropriate for a bug-fix release? > > I just tested with the button icon, the only one suggested after > running emacs -Q.  I tested making modifications in the buffer, and that > the two options (three if not started with -Q) work and do what's > intended.  Namely: > - Undo Editions took me back to the STANDARD state. > - Setting for the session modified the specs for the session and > correctly displayed the SET state. > - Saving the setting saved a spec that in a new session (without emacs > -Q) causes: > M-x describe-icon RET button > to show the button customized.  The value I changed for that was from > LARGE BLUE CIRCLE to LARGE RED SQUARE > > It's important to note that saving the setting shows the SET state > (rather than the SAVED state), but that's in a FIXME right before > custom-icon-state. > > I'll do some more testing with the icons defined in outline.el, > tab-bar.el and warnings.el.  Additionally I'll try to test if > Customizing an icon interacts good enough with a Theme customizations. > I'll do that and report back. Thanks. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 11:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: maurooaranda@gmail.com, 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169788804631658 (code B ref 66635); Sat, 21 Oct 2023 11:35:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 11:34:06 +0000 Received: from localhost ([127.0.0.1]:42405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quAF4-0008EY-C9 for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:34:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quAF2-0008E0-3J for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 07:34:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quAEU-0001gx-OO; Sat, 21 Oct 2023 07:33:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5XZr0KkG/CcVDmH5xOWnzBj0U0gv07XJKNqh8cq2oFU=; b=nBLv5dwGvvez bS9RpUvJogWw6GA30qTacOVyBSrkkFEkIFt/V9yQbfB00zin30wjVgsf8XepthkWKbZwsH9KBCdFG DhTedXIXpcZsLu3iMjFhA0f9xXVbqLI+ipENE/InwGquANzJo3p07e6kLkgRom/O6EF1HdbqZ7KPI 6TQqty3eKu6TotaQUneeNlk1BKvj9kmDwkwbJ+ejkFCgtlt51fHyeQuVSJUx9DjjfLlWXiC35jbSU 4iXje8GJnJmcJADUXsq53gN0ahhpI4M6rORuUUvd+f0yciMbWH8meeC4+uZufv9660Pf7kUB/H7Hu wg0l9lpAuubV36gwYedcZA==; Date: Sat, 21 Oct 2023 14:33:27 +0300 Message-Id: <83v8b0qkfs.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Sat, 21 Oct 2023 04:17:51 -0700) References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sat, 21 Oct 2023 04:17:51 -0700 > Cc: 66635@debbugs.gnu.org > > Mauro Aranda writes: > > > To sum it up, after testing more thoroughly, I haven't yet found any > > trouble with my patch, which improves considerably icons customization. > > More work needs to be done (expanding state checking, reverting > > customizations, improving help in the custom buffer, adding support in > > customize-create-theme, showing the image that would get used, etc), but > > those should be separate bug reports, I think. > > Thanks for working on this. > > Eli, do you see any reason for not installing this on emacs-29? I think this is OK for emacs-29, thanks. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: maurooaranda@gmail.com, 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.16978891261601 (code B ref 66635); Sat, 21 Oct 2023 11:53:01 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 11:52:06 +0000 Received: from localhost ([127.0.0.1]:42427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quAWQ-0000Ph-UT for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:52:06 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:45240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quAWL-0000P1-Vd for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 07:52:01 -0400 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c50cf61f6dso26672971fa.2 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 04:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697889084; x=1698493884; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=1tmBqWnhsHda2q+2NZK35gmxJNpgZHRcfxXNY7i6B8Q=; b=OI6bcM49Iof+6WDfZoiilCDYvtBpovxeKSqC8TRC6M7qqkUNDRQiFz9aAqFW4Yasor qjx6tC9FvnT7CPSOA6ivWr4VzVEGy7bdO6PBQcRl6GXffAds6v7ddv0h1V7lygn5Hadw wxmXJZfQJrAGzmmTTR77TWTQ1we8gbzG/Xaka6Qof6+IWzCi2cQZ1jVTQQw+cC/mD511 ez9Icyon5uTlXQSkG8r+erdUl9+lI4dGWAqB9cM2T3MJm8eBKr0Jm7Kw+3Xb3ZIExY1z Qh+CtisuZ+deszDJ8pyu0twd8zWS6ZG1QSf6VdD7kdALLxfw+wn8q1wBAmfBZ5+ogM1A lIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697889084; x=1698493884; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1tmBqWnhsHda2q+2NZK35gmxJNpgZHRcfxXNY7i6B8Q=; b=LSJqP8ZF8ETLNdsUsELxI9iR+rAZMnOK8hDN9O4AkVk1kvhwCJAy4SRPYrNDh5UH64 RHVgG3kn/eKb95Zes/eiNlOaJpQgKdT5rPbA6tMKu36pgafFTxjos8eyE/1cnDkCBSKQ yYszUUoksZg1kd0yBdSxLfqP2xO1D0OHNJ4Hjls//WZsLW+RRIqsCEBrNK8dCZZ67wGx LPv7q1X1qiNUeOgPq5NkYzAXheZhu2wed3/N7zyVHVeqTqMPD819EypbDLmiI9RB8lbT UlyqBkRuhaG55NW90T6ywIJi4BcrGp1ZTm5bBOAsu4bHMCeI0N64uz/yX1jYlik8ze0O XXyw== X-Gm-Message-State: AOJu0YyOHTGAkNaRi3UWpgEGdeB16ze7U6pOOSPSWeiAqtbczsyBV5ck GdWZh2gP0T5AZ4/K2uMlzdUYG6e/iGSoYAZt6uM= X-Google-Smtp-Source: AGHT+IERI75CDL+No17j+WCsMVc28rPeDQFcUUP47KfZakPBOnqNvAg+ZPoJ424YEfC8TC5qD8xGR8wYJJkA6cwZH1c= X-Received: by 2002:a2e:86c7:0:b0:2c5:1602:53f6 with SMTP id n7-20020a2e86c7000000b002c5160253f6mr3197558ljj.34.1697889084096; Sat, 21 Oct 2023 04:51:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 21 Oct 2023 04:51:23 -0700 From: Stefan Kangas In-Reply-To: <83v8b0qkfs.fsf@gnu.org> References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> <83v8b0qkfs.fsf@gnu.org> MIME-Version: 1.0 Date: Sat, 21 Oct 2023 04:51:23 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think this is OK for emacs-29, thanks. Thanks. Mauro, could you send the latest version of the patch? I believe the one you sent before has a typo. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , Eli Zaretskii Cc: 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169789138116179 (code B ref 66635); Sat, 21 Oct 2023 12:30:02 +0000 Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 12:29:41 +0000 Received: from localhost ([127.0.0.1]:42499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quB6n-0004Cq-D2 for submit@debbugs.gnu.org; Sat, 21 Oct 2023 08:29:41 -0400 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:51615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quB6i-0004CZ-Jg for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 08:29:36 -0400 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1e9fbb7d88eso1314251fac.3 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 05:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697891338; x=1698496138; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=IZxAX5MEuwS4Oibr/KjdcNMQdEGDqgeekhNrB9N6AT0=; b=LWl3ky9AEjp72wyBIGi7V9NBtWIbLZIN+nRiEjLo7A8AjZb1IdvpynKhW9NFD1GGq9 npUmppBqGVQCEtZEtMv0ngOK81Uv25193ZaWCYbIiYrIN0krypmqfgAldUdBjY9f/tet qOsJt9cR7mmrMwBr/r6btppL23+zQq/bx/AZn625ieQls4nwSy9nk+jebOchTUzDHz9b gEYjo9JfEOY0C50YvO5yXrDoRH1nsMCfu86scpRLLAn0OABzSm/qF4rQj1jdHB+03ILc WRxIYX4OuUOvZDaNvdYBpl5FTs35JbYs7Ppd8FCrUFu2lW4uI9t7eVDeKAN9uUMl3cvX EQOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697891338; x=1698496138; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IZxAX5MEuwS4Oibr/KjdcNMQdEGDqgeekhNrB9N6AT0=; b=o5xWCpAq7o/mkFu7ig6UBz+3EmIrR28/4Rryl9x7WjXyyxXqJWzSV+N+PfY5JpgDv7 8Q38wfNCJsQpb9CBvjNjyo3EH8fA4Fq7zXjsT8UecEaj6O+aK4vSJDhU3MuX9D8pZalA UneKTE+rNSLLSSPPAUf2BN9E8xoc40IOFBOtA+Bo8EIm48+it+o8RkS1z1jrAI4QgQv5 t8vl+G30aHCha+aopL6LGDMtwu23kzKIpsSKWyPiK1hs+K9oRxZu1LRWtRSUGVnMu7GY piY9W22mS/MssVV+kVbeYFGYS0z9qB7Hgq6+EhdC76Z7q92opguBB4jEl2cXp2Fhh0vK 0uQQ== X-Gm-Message-State: AOJu0YwtTKhN5T3Fl3m3sQqm7MHEC19/nzO74zIScc++PPiJFEHdhOFt pJ56gzdRSWL6FCN7f03JckE= X-Google-Smtp-Source: AGHT+IELeBq7mV6QC9jaCrHiNogZoWiPHRfskezmLq5h5Fz8/4op3KoMgGHKerMGyjXyWfxkBsvVXA== X-Received: by 2002:a05:6871:2312:b0:1e9:a434:58a5 with SMTP id sf18-20020a056871231200b001e9a43458a5mr4808848oab.46.1697891337065; Sat, 21 Oct 2023 05:28:57 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id f15-20020a63f10f000000b005af7ee01ab4sm3091710pgi.6.2023.10.21.05.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Oct 2023 05:28:56 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Te2FXRW7IzYAZQh03b3j6s0V" Message-ID: Date: Sat, 21 Oct 2023 09:28:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> <83v8b0qkfs.fsf@gnu.org> From: Mauro Aranda In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Te2FXRW7IzYAZQh03b3j6s0V Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/10/23 08:51, Stefan Kangas wrote: > Eli Zaretskii writes: > >> I think this is OK for emacs-29, thanks. > > Thanks. > > Mauro, could you send the latest version of the patch? I believe the > one you sent before has a typo. Hmm, I didn't find the typo. But it's hard for me to catch typos of my own. Sending the patch again anyway, but let me know if you spot it. --------------Te2FXRW7IzYAZQh03b3j6s0V Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-State-button-for-customize-icon-Bug-66635.patch" Content-Disposition: attachment; filename="0001-Fix-State-button-for-customize-icon-Bug-66635.patch" Content-Transfer-Encoding: base64 RnJvbSBhYjRmYWJmNDg2NjVkZGMxNDJhZDk1YTI2ODk4ZWI2MjA3Y2QyYmRjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFRodSwgMTkgT2N0IDIwMjMgMDg6NDY6MzUgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggU3RhdGUgYnV0dG9uIGZvciBjdXN0b21pemUtaWNvbiAoQnVnIzY2NjM1 KQoKKiBsaXNwL2N1cy1lZGl0LmVsIChjdXN0b20taWNvbi1hY3Rpb24pOiBOZXcgZnVuY3Rp b24uCihjdXN0b20taWNvbik6IFVzZSBpdCBhcyB0aGUgOmFjdGlvbi4gIE90aGVyd2lzZSwg Y2xpY2tpbmcgdGhlIFN0YXRlCmJ1dHRvbiBpcyBhIG5vb3AuICBSZW1vdmUgaXJyZWxldmFu dCBzdHVmZiBmcm9tIHRoZSBkb2NzdHJpbmcgYW5kCmNvbW1lbnQgb3V0IHNvbWUgY29weS1w YXN0YS4KKGN1c3RvbS1pY29uLWV4dGVuZGVkLW1lbnUpOiBOZXcgdmFyaWFibGUsIHRoZSBt ZW51IHRvIHNob3cgdXBvbgo6YWN0aW9uLgooY3VzdG9tLWljb24tc2V0KTogUmVhbGx5IHJl ZHJhdyB0aGUgd2lkZ2V0IHdpdGggdGhlIG5ldyBzZXR0aW5ncy4KQ29tbWVudCBvdXQgc3Ry YW5nZSBjYWxsIHRvIGN1c3RvbS12YXJpYWJsZS1iYWNrdXAtdmFsdWUuCihjdXN0b20taWNv bi1zYXZlKTogTmV3IGZ1bmN0aW9uLgoKKiBsaXNwL2VtYWNzLWxpc3AvaWNvbnMuZWwgKGlj b25zLS1tZXJnZS1zcGVjKTogRml4IGNhbGwgdG8gcGxpc3QtZ2V0CmFuZCBhdm9pZCBpbmZs b29wLgotLS0KIGxpc3AvY3VzLWVkaXQuZWwgICAgICAgICB8IDcxICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0KIGxpc3AvZW1hY3MtbGlzcC9pY29ucy5lbCB8 ICA2ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtZWRpdC5lbCBiL2xpc3AvY3VzLWVkaXQu ZWwKaW5kZXggNzA2ZTA4ZDU2NTcuLjk1M2I4YjhiODBmIDEwMDY0NAotLS0gYS9saXNwL2N1 cy1lZGl0LmVsCisrKyBiL2xpc3AvY3VzLWVkaXQuZWwKQEAgLTUzNjYsMTEgKzUzNjYsNiBA QCAnY3VzdG9tLWljb24KIDpoaWRkZW4tc3RhdGVzIHNob3VsZCBiZSBhIGxpc3Qgb2Ygd2lk Z2V0IHN0YXRlcyBmb3Igd2hpY2ggdGhlCiAgIHdpZGdldCdzIGluaXRpYWwgY29udGVudHMg YXJlIHRvIGJlIGhpZGRlbi4KIAotOmN1c3RvbS1mb3JtIHNob3VsZCBiZSBhIHN5bWJvbCBk ZXNjcmliaW5nIGhvdyB0byBkaXNwbGF5IGFuZAotICBlZGl0IHRoZSB2YXJpYWJsZS0tLWVp dGhlciBgZWRpdCcgKHVzaW5nIGVkaXQgd2lkZ2V0cyksCi0gIGBsaXNwJyAoYXMgYSBMaXNw IHNleHApLCBvciBgbWlzbWF0Y2gnIChzaG91bGQgbm90IGhhcHBlbik7Ci0gIGlmIG5pbCwg dXNlIHRoZSByZXR1cm4gdmFsdWUgb2YgYGN1c3RvbS12YXJpYWJsZS1kZWZhdWx0LWZvcm0n LgotCiA6c2hvd24tdmFsdWUsIGlmIG5vbi1uaWwsIHNob3VsZCBiZSBhIGxpc3Qgd2hvc2Ug YGNhcicgaXMgdGhlCiAgIHZhcmlhYmxlIHZhbHVlIHRvIGRpc3BsYXkgaW4gcGxhY2Ugb2Yg dGhlIGN1cnJlbnQgdmFsdWUuCiAKQEAgLTUzODMsMTEgKzUzNzgsMzQgQEAgJ2N1c3RvbS1p Y29uCiAgIDpjdXN0b20tY2F0ZWdvcnkgJ29wdGlvbgogICA6Y3VzdG9tLXN0YXRlIG5pbAog ICA6Y3VzdG9tLWZvcm0gbmlsCi0gIDp2YWx1ZS1jcmVhdGUgJ2N1c3RvbS1pY29uLXZhbHVl LWNyZWF0ZQorICA6dmFsdWUtY3JlYXRlICMnY3VzdG9tLWljb24tdmFsdWUtY3JlYXRlCiAg IDpoaWRkZW4tc3RhdGVzICcoc3RhbmRhcmQpCi0gIDpjdXN0b20tc2V0ICdjdXN0b20taWNv bi1zZXQKLSAgOmN1c3RvbS1yZXNldC1jdXJyZW50ICdjdXN0b20tcmVkcmF3Ci0gIDpjdXN0 b20tcmVzZXQtc2F2ZWQgJ2N1c3RvbS12YXJpYWJsZS1yZXNldC1zYXZlZCkKKyAgOmFjdGlv biAjJ2N1c3RvbS1pY29uLWFjdGlvbgorICA6Y3VzdG9tLXNldCAjJ2N1c3RvbS1pY29uLXNl dAorICA6Y3VzdG9tLXJlc2V0LWN1cnJlbnQgIydjdXN0b20tcmVkcmF3KQorICA7OyBOb3Qg aW1wbGVtZW50ZWQgeWV0LgorICA7OyA6Y3VzdG9tLXJlc2V0LXNhdmVkICdjdXN0b20taWNv bi1yZXNldC1zYXZlZCkKKworKGRlZnZhciBjdXN0b20taWNvbi1leHRlbmRlZC1tZW51Cisg IChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkpKQorICAgIChkZWZpbmUta2V5LWFm dGVyIG1hcCBbY3VzdG9tLWljb24tc2V0XQorICAgICAgJyhtZW51LWl0ZW0gIlNldCBmb3Ig Q3VycmVudCBTZXNzaW9uIiBjdXN0b20taWNvbi1zZXQKKyAgICAgICAgICAgICAgICAgIDpl bmFibGUgKGVxICh3aWRnZXQtZ2V0IGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgOmN1c3RvbS1z dGF0ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdtb2RpZmllZCkpKQorICAg ICh3aGVuIChvciBjdXN0b20tZmlsZSBpbml0LWZpbGUtdXNlcikKKyAgICAgIChkZWZpbmUt a2V5LWFmdGVyIG1hcCBbY3VzdG9tLWljb24tc2F2ZV0KKyAgICAgICAgJyhtZW51LWl0ZW0g IlNhdmUgZm9yIEZ1dHVyZSBTZXNzaW9ucyIgY3VzdG9tLWljb24tc2F2ZQorICAgICAgICAg ICAgICAgICAgICA6ZW5hYmxlIChtZW1xCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICh3aWRnZXQtZ2V0IGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgOmN1c3RvbS1zdGF0ZSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJyhtb2RpZmllZCBzZXQgY2hhbmdlZCkpKSkp CisgICAgKGRlZmluZS1rZXktYWZ0ZXIgbWFwIFtjdXN0b20tcmVkcmF3XQorICAgICAgJyht ZW51LWl0ZW0gIlVuZG8gRWRpdHMiIGN1c3RvbS1yZWRyYXcKKyAgICAgICAgICAgICAgICAg IDplbmFibGUgKG1lbXEKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aWRnZXQtZ2V0 IGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgOmN1c3RvbS1zdGF0ZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICcobW9kaWZpZWQgY2hhbmdlZCkpKSkKKyAgICBtYXApCisgICJBIG1l bnUgZm9yIGBjdXN0b20taWNvbicgd2lkZ2V0cy4KK1VzZWQgaW4gYGN1c3RvbS1pY29uLWFj dGlvbicgdG8gc2hvdyBhIG1lbnUgdG8gdGhlIHVzZXIuIikKIAogKGRlZnVuIGN1c3RvbS1p Y29uLXZhbHVlLWNyZWF0ZSAod2lkZ2V0KQogICAiSGVyZSBpcyB3aGVyZSB5b3UgZWRpdCB0 aGUgaWNvbidzIHNwZWNpZmljYXRpb24uIgpAQCAtNTUxNyw2ICs1NTM1LDI0IEBAIGN1c3Rv bS1pY29uLXZhbHVlLWNyZWF0ZQogCSAgKGN1c3RvbS1hZGQtcGFyZW50LWxpbmtzIHdpZGdl dCkpCiAJKGN1c3RvbS1hZGQtc2VlLWFsc28gd2lkZ2V0KSkpKSkKIAorKGRlZnVuIGN1c3Rv bS1pY29uLWFjdGlvbiAod2lkZ2V0ICZvcHRpb25hbCBldmVudCkKKyAgIlNob3cgdGhlIG1l bnUgZm9yIGBjdXN0b20taWNvbicgV0lER0VULgorT3B0aW9uYWwgRVZFTlQgaXMgdGhlIGxv Y2F0aW9uIGZvciB0aGUgbWVudS4iCisgIChpZiAoZXEgKHdpZGdldC1nZXQgd2lkZ2V0IDpj dXN0b20tc3RhdGUpICdoaWRkZW4pCisgICAgICAoY3VzdG9tLXRvZ2dsZS1oaWRlIHdpZGdl dCkKKyAgICAodW5sZXNzIChlcSAod2lkZ2V0LWdldCB3aWRnZXQgOmN1c3RvbS1zdGF0ZSkg J21vZGlmaWVkKQorICAgICAgKGN1c3RvbS1pY29uLXN0YXRlLXNldCB3aWRnZXQpKQorICAg IChjdXN0b20tcmVkcmF3LW1hZ2ljIHdpZGdldCkKKyAgICAobGV0KiAoKGNvbXBsZXRpb24t aWdub3JlLWNhc2UgdCkKKyAgICAgICAgICAgKGN1c3RvbS1hY3Rpb25lZC13aWRnZXQgd2lk Z2V0KQorICAgICAgICAgICAoYW5zd2VyICh3aWRnZXQtY2hvb3NlIChjb25jYXQgIk9wZXJh dGlvbiBvbiAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo Y3VzdG9tLXVubGlzcGlmeS10YWctbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh3aWRnZXQtZ2V0IHdpZGdldCA6dmFsdWUpKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjdXN0b20taWNvbi1leHRlbmRlZC1tZW51Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXZlbnQpKSkKKyAgICAgICh3aGVu IGFuc3dlcgorICAgICAgICAoZnVuY2FsbCBhbnN3ZXIgd2lkZ2V0KSkpKSkKKwogKGRlZnVu IGN1c3RvbS10b2dnbGUtaGlkZS1pY29uICh2aXNpYmlsaXR5LXdpZGdldCAmcmVzdCBfaWdu b3JlKQogICAiVG9nZ2xlIHRoZSB2aXNpYmlsaXR5IG9mIGEgYGN1c3RvbS1pY29uJyBwYXJl bnQgd2lkZ2V0LgogQnkgZGVmYXVsdCwgdGhpcyBzaWduYWxzIGFuIGVycm9yIGlmIHRoZSBw YXJlbnQgaGFzIHVuc2F2ZWQKQEAgLTU1NTMsMTAgKzU1ODksMjEgQEAgY3VzdG9tLWljb24t c2V0CiAgICAgICAodXNlci1lcnJvciAiQ2Fubm90IHVwZGF0ZSBoaWRkZW4gaWNvbiIpKQog CiAgICAgKHNldHEgdmFsIChjdXN0b20tLWljb25zLXdpZGdldC12YWx1ZSBjaGlsZCkpCi0g ICAgKHVubGVzcyAoZXF1YWwgdmFsIChpY29uLWNvbXBsZXRlLXNwZWMgc3ltYm9sKSkKLSAg ICAgIChjdXN0b20tdmFyaWFibGUtYmFja3VwLXZhbHVlIHdpZGdldCkpCisgICAgOzsgRklY TUU6IFdoYXQgd2FzIHRoZSBpbnRlbnRpb24gaGVyZT8KKyAgICA7OyAodW5sZXNzIChlcXVh bCB2YWwgKGljb24tY29tcGxldGUtc3BlYyBzeW1ib2wpKQorICAgIDs7ICAgKGN1c3RvbS12 YXJpYWJsZS1iYWNrdXAtdmFsdWUgd2lkZ2V0KSkKICAgICAoY3VzdG9tLXB1c2gtdGhlbWUg J3RoZW1lLWljb24gc3ltYm9sICd1c2VyICdzZXQgdmFsKQotICAgIChjdXN0b20tcmVkcmF3 LW1hZ2ljIHdpZGdldCkpKQorICAgIChjdXN0b20tcmVkcmF3IHdpZGdldCkpKQorCisoZGVm dW4gY3VzdG9tLWljb24tc2F2ZSAod2lkZ2V0KQorICAiU2F2ZSB2YWx1ZSBvZiBpY29uIGVk aXRlZCBieSB3aWRnZXQgV0lER0VULiIKKyAgKGN1c3RvbS1zZXQtaWNvbnMgKGNvbnMgKHdp ZGdldC12YWx1ZSB3aWRnZXQpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAoY3VzdG9tLS1pY29ucy13aWRnZXQtdmFsdWUK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FyICh3aWRnZXQtZ2V0IHdpZGdldCA6 Y2hpbGRyZW4pKSkpKSkKKyAgKGN1c3RvbS1zYXZlLWFsbCkKKyAgKGN1c3RvbS1pY29uLXN0 YXRlLXNldCB3aWRnZXQpCisgIChjdXN0b20tcmVkcmF3LW1hZ2ljIHdpZGdldCkpCiAKIDs7 OyMjI2F1dG9sb2FkCiAoZGVmdW4gY3VzdG9taXplLWljb24gKGljb24pCmRpZmYgLS1naXQg YS9saXNwL2VtYWNzLWxpc3AvaWNvbnMuZWwgYi9saXNwL2VtYWNzLWxpc3AvaWNvbnMuZWwK aW5kZXggY2IwOGMxYTZiODEuLjlhNmQyNjI0M2M3IDEwMDY0NAotLS0gYS9saXNwL2VtYWNz LWxpc3AvaWNvbnMuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2ljb25zLmVsCkBAIC0xODEs OSArMTgxLDkgQEAgaWNvbnMtLW1lcmdlLXNwZWMKICAgICAgICAgKGxldCAoKHBhcmVudC1r ZXl3b3JkcyAoaWNvbi1zcGVjLWtleXdvcmRzIGVsZW0pKQogICAgICAgICAgICAgICAoY3Vy cmVudC1rZXl3b3JkcyAoaWNvbi1zcGVjLWtleXdvcmRzIGN1cnJlbnQpKSkKICAgICAgICAg ICAod2hpbGUgcGFyZW50LWtleXdvcmRzCi0gICAgICAgICAgICAodW5sZXNzIChwbGlzdC1n ZXQgKGNhciBwYXJlbnQta2V5d29yZHMpIGN1cnJlbnQta2V5d29yZHMpCi0gICAgICAgICAg ICAgIChuY29uYyBjdXJyZW50ICh0YWtlIDIgcGFyZW50LWtleXdvcmRzKSkKLSAgICAgICAg ICAgICAgKHNldHEgcGFyZW50LWtleXdvcmRzIChjZGRyIHBhcmVudC1rZXl3b3JkcykpKSkp KSkpCisgICAgICAgICAgICAodW5sZXNzIChwbGlzdC1nZXQgY3VycmVudC1rZXl3b3JkcyAo Y2FyIHBhcmVudC1rZXl3b3JkcykpCisgICAgICAgICAgICAgIChuY29uYyBjdXJyZW50ICh0 YWtlIDIgcGFyZW50LWtleXdvcmRzKSkpCisgICAgICAgICAgICAoc2V0cSBwYXJlbnQta2V5 d29yZHMgKGNkZHIgcGFyZW50LWtleXdvcmRzKSkpKSkpKQogICBtZXJnZWQpCiAKIChjbC1k ZWZtZXRob2QgaWNvbnMtLWNyZWF0ZSAoKF90eXBlIChlcWwgJ2ltYWdlKSkgaWNvbiBrZXl3 b3JkcykKLS0gCjIuMzQuMQoK --------------Te2FXRW7IzYAZQh03b3j6s0V-- From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2023 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mauro Aranda , Eli Zaretskii Cc: 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169797659112271 (code B ref 66635); Sun, 22 Oct 2023 12:10:02 +0000 Received: (at 66635) by debbugs.gnu.org; 22 Oct 2023 12:09:51 +0000 Received: from localhost ([127.0.0.1]:45577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quXHC-0003Br-L4 for submit@debbugs.gnu.org; Sun, 22 Oct 2023 08:09:50 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:57436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quXH6-0003BV-1X for 66635@debbugs.gnu.org; Sun, 22 Oct 2023 08:09:48 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c504a5e1deso37690631fa.2 for <66635@debbugs.gnu.org>; Sun, 22 Oct 2023 05:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697976550; x=1698581350; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=18JwTQV9I2G/BsaJCTeXVcFyjQGiHrLn9A1lg9WNjGY=; b=aStuwUyIzDpQBLZlsCsVrkk2nbrAl3qHG8zRCw9MYDI5Wv5UFe78DO3C4WCaR8uhC7 Z3RsM2/YO8s0caUsG46KPlaG1aG6KixqJ9/1oH3irZI7gQF//zYbesf9gFpHaplWMiJL h1U8vlQLpyKDFkzLU/m6x4kkRIRfYfH5ePXnQm6I4KZ5A6VvngAokM3VEiLZ8UMcClyr N4DChDVnlQjaXDffijCWlAm8ywGgIXna+oeApzO8EEMwRDHVKQafPCeNYlkY9lhwZjG5 EcZLbbQ7Fyt0Z0xT7zHEYB8D57042dvdUz7r5MM1SwSpgn6mUVJ7GhAhwMuGSx1HbBLR bqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697976550; x=1698581350; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=18JwTQV9I2G/BsaJCTeXVcFyjQGiHrLn9A1lg9WNjGY=; b=mIWsMSvyoAoQP3vrAe5jthO/vrUbrI8wXklJF7Svxwe9LIM9McuXGyZUrCuG5fobmA Lu65CJegmL1kwzQXijosVlk1K3ICUj36zAaKkzboyuQOYsUuRnEkf7vD/wTOzCfHmACe ADD1JmOirqJYyBhqXJfBTkMjdurDx2uHIuPtUHp/4WPeX/5eSWxg+9tVKzexot79K4T+ MhBR1VmofESE5GiPoiu1dnTHohNoVT5zvWtJU6C6FyzsnQtJMY1soZbaF/v/TF731D7w twDW2K73CwsjHiTEwi6qb72eD+SnwygbSTuHWkbpzdxalH4J5498xfTidS6CMRQIixR3 FdHA== X-Gm-Message-State: AOJu0YzmglUCgiGOSGnVSIbKDLuaAhd+ObcN/kJ3C15lCfr+qUpOTnzb SSSS+/QJLO/85HZNsRBASkpvLC6+ND/wJoCOoVQ= X-Google-Smtp-Source: AGHT+IH1N1FkmW+I54KvbdjCRZIIYTaOdCVjwfMNWHIHJjpdQ3EewlFFz5gmt/q3rhkXYOugqoSNJmUbUaFQgAEX/R0= X-Received: by 2002:a05:651c:2117:b0:2bd:19c5:3950 with SMTP id a23-20020a05651c211700b002bd19c53950mr5435914ljq.33.1697976549419; Sun, 22 Oct 2023 05:09:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 22 Oct 2023 05:09:08 -0700 From: Stefan Kangas In-Reply-To: References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> <83v8b0qkfs.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 22 Oct 2023 05:09:08 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > + ;; Not implemented yet. > + ;; :custom-reset-saved 'custom-icon-reset-saved) ^^ ^ The closing paren shouldn't be commented out. From unknown Sat Sep 06 13:45:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2023 12:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , Eli Zaretskii Cc: 66635@debbugs.gnu.org Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169797880516887 (code B ref 66635); Sun, 22 Oct 2023 12:47:02 +0000 Received: (at 66635) by debbugs.gnu.org; 22 Oct 2023 12:46:45 +0000 Received: from localhost ([127.0.0.1]:45610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quXqv-0004OJ-3D for submit@debbugs.gnu.org; Sun, 22 Oct 2023 08:46:45 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:54612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quXqq-0004O1-IW for 66635@debbugs.gnu.org; Sun, 22 Oct 2023 08:46:43 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so1859585a12.1 for <66635@debbugs.gnu.org>; Sun, 22 Oct 2023 05:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697978766; x=1698583566; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V9htrGS3NvF0lJ3LoMMeyl5d0isQiAz3IBgwJEdkK9M=; b=jfA5WZ2iKJA+GXsetDmjM2xaEjNPpUUBLU1t7jm3WUaytARioqyqMIh+cg1oRfPkk/ Qm4kMRp0pRQhBcD/+2vlr2NN7UFDrIEcfjxcxnrEeBY+N/ZTXUmOiXdclnjLgt7pxyif JOKwnQM2d3y8wEmVYZpPGW/eqNeNzKG4pGjcXdiZeOlvbuNZkiuCljySc191KjXzVo1I KqiyNGzATQav37lJkJGGFc7MvCrt41JzPyj+9iyIdGXVLhUjACi7ID1jGVenoqWO5idL g+i0hrhJBPRnk3C3qJJochNF5gg9vp/DFnKDspQE/PoNg3QJOpBEHn+/dpLzAhJaxz3i /9qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697978766; x=1698583566; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V9htrGS3NvF0lJ3LoMMeyl5d0isQiAz3IBgwJEdkK9M=; b=TxlrOZXsUPH+QwZlsa/za5XS1XmYvULqRHkdPgxG5pmc36lpvv41QpzyFExW11IhrZ 71036b1010MrSfeD1NV45nNbJLwHU5t77rUSu3hZNbEdRhUh8pdpgiqkm1AeJIMdb0kD azMWtb2U9EuvBJqoyD7M4nqIVJEskqQWBTdCfle8M6cb/Bnb5w5EDvLnPLAoH3fV83ys Wg0LjXu9W4gSAIF3fM/+kRvq1pSNdZB6H72m0X2RrBaVg6qamxX2TdyaN+3z/qmVkzqs mDaBHjFzgXM1LlyI/lARWd2yS5mbSaI9zEAX2nfP1XPqmnhwa0c8ty69UyGg06gy8SVn HErA== X-Gm-Message-State: AOJu0Yzht2hjSnEA43B8rolO04fbpyZuXSeQz3QmsApINYvFH0tVVXiT jYnFHS0tAw/OcJvlOel7Xio= X-Google-Smtp-Source: AGHT+IHhC8FMii70y+0gPs5bHP07HIe2FA7GKTGB1RoQwUmThMDBBV7pry6AUCSntdny06V7xOAvxQ== X-Received: by 2002:a05:6a20:432a:b0:17b:3fe8:b4e1 with SMTP id h42-20020a056a20432a00b0017b3fe8b4e1mr8240125pzk.50.1697978766150; Sun, 22 Oct 2023 05:46:06 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id n9-20020aa79849000000b00682868714fdsm4676726pfq.95.2023.10.22.05.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Oct 2023 05:46:05 -0700 (PDT) Message-ID: Date: Sun, 22 Oct 2023 09:46:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> <83v8b0qkfs.fsf@gnu.org> From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 22/10/23 09:09, Stefan Kangas wrote: > Mauro Aranda writes: > >> + ;; Not implemented yet. >> + ;; :custom-reset-saved 'custom-icon-reset-saved) > ^^ ^ > > The closing paren shouldn't be commented out. > It's on the previous line. + :custom-reset-current #'custom-redraw) ^^ ^ + ;; Not implemented yet. + ;; :custom-reset-saved 'custom-icon-reset-saved) + BTW, I'm working on implementing the missing functions (there are others, apart from :custom-reset-saved). From unknown Sat Sep 06 13:45:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mauro Aranda Subject: bug#66635: closed (Re: bug#66635: 30.0.50; customize-icon State button doesn't work (never did)) Message-ID: References: X-Gnu-PR-Message: they-closed 66635 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 66635@debbugs.gnu.org Date: Sun, 22 Oct 2023 16:52:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1697993521-5970-1" This is a multi-part message in MIME format... ------------=_1697993521-5970-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66635: 30.0.50; customize-icon State button doesn't work (never did) which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66635@debbugs.gnu.org. --=20 66635: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66635 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1697993521-5970-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66635-done) by debbugs.gnu.org; 22 Oct 2023 16:51:58 +0000 Received: from localhost ([127.0.0.1]:47971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qubgE-0001Y3-05 for submit@debbugs.gnu.org; Sun, 22 Oct 2023 12:51:58 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:50252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qubg7-0001Xj-Rs for 66635-done@debbugs.gnu.org; Sun, 22 Oct 2023 12:51:56 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c5629fdbf8so29301591fa.0 for <66635-done@debbugs.gnu.org>; Sun, 22 Oct 2023 09:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697993477; x=1698598277; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=89hl3lM3l1US+WBPycUIQ6DE10HfDmJVJBaqqy/Hg+s=; b=iZsCLIbiM8VTPQxpdu6yxuC0e5eA+9rJ+8p8tPsZJnMhe3luW0uRYnnAnhBwlAXSeo yzztocb90KDgELXrn/xgv+3a2bPBbqG+kDHhz9Q0nqyCV1ySOjJXW0zC3PYvJHV4RcVG 2XHIn8EutVtQi8C+RPFCMtsJPAjRuhXT1c2LqXLgAUCyquPycqxUv3x9eNOOhknej70D Oqr5e3l+DqUdDnXRqsxeIkIkmlh8ogdB2tJ0OwYO+mhEpSjAnB4TrEPI4OSPyu2Y0FQP 1sqVqVbifTUD13SZCPub65OFUI8NXmEFfxQ3cC1k4arjPu7cSu0ucppeqE8xcUFutr3s 5rDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697993477; x=1698598277; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=89hl3lM3l1US+WBPycUIQ6DE10HfDmJVJBaqqy/Hg+s=; b=I6ahMR3kV6UEOpkrgpxw/DtNfje7t2RSmeAAfXAKLW2tGxPBvDfJ0bTalo7ghaM9yu 1RHNLEwNqdcR+LMlyc/X80O1JFQwvZKAydWeBGvh3tnngktEmXfuTRvylqZHrcA+LW+R Mcgvr0kDV4qNW8G3aW1zU8pu9ONQhzeUE12A5U4iTEyHG69X26J8p21i0R+IUSBfrN8L 8bLnU25eDhNrVt420RGNm6ZNLRSS/cbx+w2Yjla14Ef2Cm2ywJ2hOEPj6j2rhH85Cz21 06814rqF0FUjpMtY0TmTvzkyWRSvoM71BmeAGxDdWApEIfL5tKakHvJdyxGMXo7CgI3k hXmw== X-Gm-Message-State: AOJu0Yz7IHHNm4DD/sfHcJxV8+RsDcPxgXfGoJOgc7e3iPLkdZj75WGI 27xJHxk1nc8teLuJ2Lxs0kPUgXcqmK5v+xLPYYA= X-Google-Smtp-Source: AGHT+IGNSBzYpF81viDozbcNi1YdPBKAIKuhOtauJ68I/Jm0pMG7r3UdT+BvIvU+Edy76RI2FnSlVqZKtcov/LI29vc= X-Received: by 2002:a2e:9bd6:0:b0:2c5:c31:eeac with SMTP id w22-20020a2e9bd6000000b002c50c31eeacmr4720158ljj.15.1697993477103; Sun, 22 Oct 2023 09:51:17 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 22 Oct 2023 09:51:16 -0700 From: Stefan Kangas In-Reply-To: References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> <83v8b0qkfs.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 22 Oct 2023 09:51:16 -0700 Message-ID: Subject: Re: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) To: Mauro Aranda , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66635-done Cc: 66635-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 29.2 Mauro Aranda writes: > It's on the previous line. Oops, I missed that. Pushed to emacs-29, and I'm consequently closing this bug. [1: 5f60913208f]: 2023-10-22 18:39:52 +0200 Fix State button for customize-icon (Bug#66635) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f60913208f3fb2df9a2d3bda1655e01075bf446 ------------=_1697993521-5970-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Oct 2023 11:19:18 +0000 Received: from localhost ([127.0.0.1]:35934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtR3e-0000p6-9U for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:19:18 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtR3a-0000ok-Hd for submit@debbugs.gnu.org; Thu, 19 Oct 2023 07:19:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtR34-0001wz-Lr for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 07:18:42 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtR32-0006fj-M7 for bug-gnu-emacs@gnu.org; Thu, 19 Oct 2023 07:18:42 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-27d17f5457fso522743a91.0 for ; Thu, 19 Oct 2023 04:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697714318; x=1698319118; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=F/r8VY9g+084Q+WJtbmzmFpra+A38OJiAQsLJnAloRw=; b=EBhhOGxN/hxf1LG5EuwpBjTjD1sAsA+49K/lwb7NzK96URRpSK/OL0Aw/GC3WbclI/ 8QW2P3siTH0h7AUD05Lqr9xCYjQPLgdeuLnnmLQgUkwGiPeHTAHpnjmdS9KXS5fkmrtH JJQrVDLR35vOSJC7MMbKtiD5k/LADsugj6FRk0pMJLn2vUjcppC4sR1FT+18DYnxJsI0 rgNYzyS5SylE4gxrzcdDpeg/aH7ni/QgJmkeT7EGdOjWpXmkj8a+KUJB7NXvJqB5Z/Tx eY9fz3mCz7eg5HamQmQqdkjaEAWV3DVor4UzQz5OhkxzLS/34il48tmv0lW4KsKUP2P5 v9eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697714318; x=1698319118; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=F/r8VY9g+084Q+WJtbmzmFpra+A38OJiAQsLJnAloRw=; b=bsV7eJAX3gbs4a4BHKoydiTCPjKmFLC6HHloRwCOsALtxT8aJ9D25BmGwySOylT98u lTztMH+W2tqxttTB1cpuEfPASKAkGnifPn6whbCDsEQPpBIOMwUfgWjcIyHhthLKDetU LIrH4jXjqEnlvl1m8hiWFhzv2zEW5uPp4BoQrKAKg2brIpsoWrO/5mxYduZkyJsJEOdz bSqaTwtD4Hxjw2PuPk55i6rL24kBwcmytDnXHbx9JiHoJN6AdcSDgFVi86s7t5qya6bM pr/ViT/+fzEJUM2I8krEo0i9PbkiIheBKOpPmBFPBoh1DOKfYw4kP0yNLa92udt3bHQU khRQ== X-Gm-Message-State: AOJu0YzZ4o7IzKUzFE2YHdlYRZkWMnf3MycRKx9cwOxQThc7/iS4veeB HaZVMWOQl6perHw/pSyfcHIp0Dxav1JF+Q== X-Google-Smtp-Source: AGHT+IGs3Ff/LJsIUoOy0sML5uYmly7QATnpnjPPVjaOwZQVa6VEPdOlBK3S7SD2H+fNWHmKVFCMQQ== X-Received: by 2002:a17:90a:17ef:b0:277:3afc:f27 with SMTP id q102-20020a17090a17ef00b002773afc0f27mr2342516pja.1.1697714318181; Thu, 19 Oct 2023 04:18:38 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id x89-20020a17090a6c6200b0027d06ddc06bsm1533288pjj.33.2023.10.19.04.18.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 04:18:37 -0700 (PDT) Message-ID: Date: Thu, 19 Oct 2023 08:18:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; customize-icon State button doesn't work (never did) Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=maurooaranda@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) emacs -Q M-x customize-icon RET button Edit something.  For example, under the Text Only choice, make the string look like: "-button-" instead of "button". Observe that Custom says: "EDITED, ..." Go to the State button and hit RET.  Nothing happens. Click it.  Nothing happens. Expectation is that a menu pops up to set the icon settings. And without -Q, to save the settings. In GNU Emacs 30.0.50 (build 7, x86_64-pc-linux-gnu, GTK+ Version  3.24.33, cairo version 1.16.0) of 2023-10-19 built on tbb-desktop Repository revision: 0fd7f785e76c9f2eea1baa40aed6ee327f68a993 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201001 System Description: Ubuntu 22.04.3 LTS Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: es_AR.UTF-8   value of $LC_NUMERIC: es_AR.UTF-8   value of $LC_TIME: es_AR.UTF-8   value of $LANG: en_US.UTF-8   value of $XMODIFIERS: @im=ibus   locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect:   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   tool-bar-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   minibuffer-regexp-mode: t   line-number-mode: t   indent-tabs-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 37643 10434) (symbols 48 5213 0) (strings 32 13209 1857)  (string-bytes 1 374142) (vectors 16 10299)  (vector-slots 8 156471 14182) (floats 8 21 23) (intervals 56 223 0)  (buffers 992 10)) ------------=_1697993521-5970-1--