From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 17 18:10:39 2010 Received: (at submit) by debbugs.gnu.org; 17 Jul 2010 22:10:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OaFah-0007qu-A3 for submit@debbugs.gnu.org; Sat, 17 Jul 2010 18:10:39 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OaFaf-0007qb-D6 for submit@debbugs.gnu.org; Sat, 17 Jul 2010 18:10:38 -0400 Received: from lists.gnu.org ([199.232.76.165]:34100) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OaFav-0002uT-J9 for submit@debbugs.gnu.org; Sat, 17 Jul 2010 18:10:53 -0400 Received: from [140.186.70.92] (port=60400 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OaFar-0004MG-6D for bug-gnu-emacs@gnu.org; Sat, 17 Jul 2010 18:10:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OaFap-0003Xk-Qr for bug-gnu-emacs@gnu.org; Sat, 17 Jul 2010 18:10:48 -0400 Received: from mail-gx0-f169.google.com ([209.85.161.169]:46363) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OaFap-0003Xf-Lk for bug-gnu-emacs@gnu.org; Sat, 17 Jul 2010 18:10:47 -0400 Received: by gxk4 with SMTP id 4so2233452gxk.0 for ; Sat, 17 Jul 2010 15:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:user-agent:mime-version:content-type; bh=wrMXR2HWfkEDFAy4Vq4YGUjJDpLShDXqjV27J5qVEkA=; b=n2TcpT3gy5wHSxZRs7NEeRtEPysA63WSOJSUJ+HrkbbBNePcIzPQX1x6wbJd6dO8FQ P6Svv/GhZs51fxEMDgsPy0n/zm6CjvtxhtxOdZhzP9eupMfW0TdvX/atjpe5XcozBpik ExTt7TPhpvi6L3N191x+J4zDejcy6L2y8SZyg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; b=pm/l4fqa8Jy1c+SXwKS68g4MtHun7FxqX0BtShu4R6uH177rGp4Av5A31inilkDePb oV+nsHF1CY6HZj4HPIOpFafY/6gIwV8s+g+htEs8TObFVhpjx16QRycS6TboNs18g6tQ 12ZTNBF/xplR0BPL91Qzq+fwPBBwW/r3BYrhU= Received: by 10.150.75.21 with SMTP id x21mr3090824yba.155.1279404646996; Sat, 17 Jul 2010 15:10:46 -0700 (PDT) Received: from localhost (97-122-118-250.hlrn.qwest.net [97.122.118.250]) by mx.google.com with ESMTPS id m11sm3797420ybn.16.2010.07.17.15.10.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 17 Jul 2010 15:10:46 -0700 (PDT) From: Christoph To: bug-gnu-emacs@gnu.org Subject: #if 0 blocks in source code Date: Sat, 17 Jul 2010 16:10:42 -0600 Message-ID: <864ofxiwt9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) I noticed a couple of #if 0 blocks in keyboard.c, which have explicit comments that the code within the block is obsolete. A quick grep "#if 0" showed about 200 instances of disabled or obsolete code in files in the src directory. Should these instances be cleaned up? Christoph From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 22 08:31:31 2010 Received: (at 6663) by debbugs.gnu.org; 22 Jul 2010 12:31:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obuvy-00089b-5X for submit@debbugs.gnu.org; Thu, 22 Jul 2010 08:31:30 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obuvv-00089T-KH for 6663@debbugs.gnu.org; Thu, 22 Jul 2010 08:31:28 -0400 Received: by bwz7 with SMTP id 7so891564bwz.3 for <6663@debbugs.gnu.org>; Thu, 22 Jul 2010 05:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=2uN65pUH8VW1Mkz+XLfGHbi1W6jMoI29vCRgS8mCtMM=; b=MlA1nRsInUWzJWyBLYWZoHDN6cSIpqe37l2dorNSVXKH6rSfZ14VWVL8qVBYPdrBlc TkC2CTJ6LJ7l2t/iLw98a/6TssRMs3Cvih4t6EUwfdwk4KgR1ohyhWaABBrUJxKVSUgM BaynjdDdw74Rem+YQJEMNv+IAC8gmNd8g3kUk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=G9MhaasP5L053BrKPVWDBCwjqF9JoHeen4gWYWfxadJ37OoGX9VHm8XSWYbWllsohd gUPOX5QAyj26lMqFheU0mPmlWh30giN1Kg+dYe+zo4k/ngNV6+5gXIaoAl4xc1yWnpSx vx6oOI99qMYV79aZdbFxFgwrQoednBQgbTNZU= Received: by 10.204.128.144 with SMTP id k16mr1245709bks.171.1279801915971; Thu, 22 Jul 2010 05:31:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.180.136 with HTTP; Thu, 22 Jul 2010 05:31:34 -0700 (PDT) In-Reply-To: <864ofxiwt9.fsf@gmail.com> References: <864ofxiwt9.fsf@gmail.com> From: Juanma Barranquero Date: Thu, 22 Jul 2010 14:31:34 +0200 Message-ID: Subject: Re: bug#6663: #if 0 blocks in source code To: Christoph Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 6663 Cc: 6663@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Sun, Jul 18, 2010 at 00:10, Christoph wrote: > I noticed a couple of #if 0 blocks in keyboard.c, which have explicit com= ments > that the code within the block is obsolete. A quick grep "#if 0" showed > about 200 instances of disabled or obsolete code in files in the src dire= ctory. > > Should these instances be cleaned up? Not blindly, no. Some of these code is not obsolete, it's just that it has not been made to work yet (ISTR there's such code in parts of the w32 image support, for example, but I could be wrong). Some of it is indeed obsolete, but (I think) it was felt that having it around to see would preclude people reinventing tried-and-discarded ways. That was perhaps more relevant with CVS than Bazaar (or not, because we still don't have a web interface to easily see past versions, and relying on bzr blame is clumsy). In other words, IMHO the answer is that some of these #if 0 blocks could and should be removed, but you'll have to look at them, exercise good sense and perhaps ask. Which is why most of them has never been removed, I suppose :-) Though lately, Dan and Glenn have spearheaded a big cleanup, so times, they are a-changing. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 06 14:14:28 2013 Received: (at control) by debbugs.gnu.org; 6 Feb 2013 19:14:28 +0000 Received: from localhost ([127.0.0.1]:39804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3ARv-000638-Vv for submit@debbugs.gnu.org; Wed, 06 Feb 2013 14:14:28 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:48653) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3ARu-000631-6N for control@debbugs.gnu.org; Wed, 06 Feb 2013 14:14:26 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U3AQe-00083O-EO for control@debbugs.gnu.org; Wed, 06 Feb 2013 14:13:08 -0500 Date: Wed, 06 Feb 2013 14:13:08 -0500 Message-Id: Subject: control message for bug 6663 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) tag 6663 wontfix From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 06 14:14:20 2013 Received: (at 6663-done) by debbugs.gnu.org; 6 Feb 2013 19:14:21 +0000 Received: from localhost ([127.0.0.1]:39801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3ARo-00062o-Fs for submit@debbugs.gnu.org; Wed, 06 Feb 2013 14:14:20 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:48650) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3ARm-00062h-N6 for 6663-done@debbugs.gnu.org; Wed, 06 Feb 2013 14:14:19 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U3AQW-0007yW-FJ; Wed, 06 Feb 2013 14:13:00 -0500 From: Glenn Morris To: 6663-done@debbugs.gnu.org Subject: Re: bug#6663: #if 0 blocks in source code References: <864ofxiwt9.fsf@gmail.com> X-Spook: AIEWS event security North Korea Gazprom Adriatic X-Ran: q`K~z=`~7l!GT2NveXZ6j@7!UcH! X-Hue: blue X-Attribution: GM Date: Wed, 06 Feb 2013 14:13:00 -0500 In-Reply-To: (Juanma Barranquero's message of "Thu, 22 Jul 2010 14:31:34 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 6663-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Sorry, I see no value in keeping this report open. The #if 0s will either decay with time or they wont. Having a bug report about it won't change anything. Closing as wontfix. From unknown Thu Jun 19 14:08:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Mar 2013 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator