GNU bug report logs - #6663
#if 0 blocks in source code

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6663 in the body.
You can then email your comments to 6663 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: #if 0 blocks in source code
Date: Sat, 17 Jul 2010 16:10:42 -0600

I noticed a couple of #if 0 blocks in keyboard.c, which have explicit comments
that the code within the block is obsolete. A quick grep "#if 0" showed
about 200 instances of disabled or obsolete code in files in the src directory.

Should these instances be cleaned up?

Christoph

Message #8 received at 6663 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6663 <at> debbugs.gnu.org
Subject: Re: bug#6663: #if 0 blocks in source code
Date: Thu, 22 Jul 2010 14:31:34 +0200

On Sun, Jul 18, 2010 at 00:10, Christoph <cschol2112 <at> googlemail.com> wrote:

> I noticed a couple of #if 0 blocks in keyboard.c, which have explicit comments
> that the code within the block is obsolete. A quick grep "#if 0" showed
> about 200 instances of disabled or obsolete code in files in the src directory.
>
> Should these instances be cleaned up?

Not blindly, no.

Some of these code is not obsolete, it's just that it has not been
made to work yet (ISTR there's such code in parts of the w32 image
support, for example, but I could be wrong).

Some of it is indeed obsolete, but (I think) it was felt that having
it around to see would preclude people reinventing tried-and-discarded
ways. That was perhaps more relevant with CVS than Bazaar (or not,
because we still don't have a web interface to easily see past
versions, and relying on bzr blame is clumsy).

In other words, IMHO the answer is that some of these #if 0 blocks
could and should be removed, but you'll have to look at them, exercise
good sense and perhaps ask. Which is why most of them has never been
removed, I suppose :-)  Though lately, Dan and Glenn have spearheaded
a big cleanup, so times, they are a-changing.

    Juanma

Message #15 received at 6663-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 6663-done <at> debbugs.gnu.org
Subject: Re: bug#6663: #if 0 blocks in source code
Date: Wed, 06 Feb 2013 14:13:00 -0500

Sorry, I see no value in keeping this report open.
The #if 0s will either decay with time or they wont. Having a bug report
about it won't change anything.
Closing as wontfix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.