GNU bug report logs - #66618
[PATCH] etc: gitconfig: Remove the default email address to avoid mistakes.

Previous Next

Full log

View this message in rfc822 format

From: Clément Lassieur <clement <at> lassieur.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 66618 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes.
Date: Sun, 22 Oct 2023 22:55:12 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Simon,
>
> Simon Tournier <zimon.toutoune <at> gmail.com> writes:
>
>> Hi Maxim,
>>
>> On Thu, 19 Oct 2023 at 21:54, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:
>>
>>> One could argue it's also a misleading documentation.  It should say if
>>> a 'to' address is not specified *or* configured.  
>>
>> Well, personally I prefer: « Explicit is better than implicit. » and
>> « Errors should never pass silently.  Unless explicitly silenced. ».
>>
>> Here, the default
>>
>>      [sendemail]
>>             to = guix-patches <at> gnu.org
>>
>> makes something implicit – which is not necessary bad – but it hides
>> potential errors – which is not good.
>
> But that's true for any automation of git.  If we follow that logic we
> can remove the other git configurations because they may be surprising,
> and the send-email hook that notifies people, because that can again be
> surprising.

Some automation is fine (although maybe not necessary) because it's
about things we want to enforce (like signed commits).

> Obviously, I'd rather not go that slope.  The small cost in surprise is
> offset by removing manual work for myself and I'd expect/hope other
> committers.  Does that make sense?

I don't think there is a need for `--to` automation in Guix repo because
it's something the user can automate in their own ~/.gitconfig (with
`includeIf`[0]).

[0]: https://git-scm.com/docs/git-config#_conditional_includes

Clément

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.