From unknown Wed Jun 18 23:12:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66609 <66609@debbugs.gnu.org> To: bug#66609 <66609@debbugs.gnu.org> Subject: Status: [PATCH 0/1] services: admin: Export rottlog-configuration accessors. Reply-To: bug#66609 <66609@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:12:14 +0000 retitle 66609 [PATCH 0/1] services: admin: Export rottlog-configuration acc= essors. reassign 66609 guix-patches submitter 66609 Simon Tournier severity 66609 normal tag 66609 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 11:09:55 2023 Received: (at submit) by debbugs.gnu.org; 18 Oct 2023 15:09:55 +0000 Received: from localhost ([127.0.0.1]:34435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt8BG-0003aI-M4 for submit@debbugs.gnu.org; Wed, 18 Oct 2023 11:09:54 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt8BB-0003Zw-G3 for submit@debbugs.gnu.org; Wed, 18 Oct 2023 11:09:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qt8Ae-0004tG-27 for guix-patches@gnu.org; Wed, 18 Oct 2023 11:09:16 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qt8Ac-0006s0-JC for guix-patches@gnu.org; Wed, 18 Oct 2023 11:09:15 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2bbbe81185dso18792941fa.0 for ; Wed, 18 Oct 2023 08:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697641752; x=1698246552; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jogBxdV7pHz2gfvZNihmsonb7ki8c6/55lHvlnc/Vk8=; b=NklRqp3mI8gRJj9KWdYxlstqpRl7AEiEB0lYD3Dg/wsGK78I3LiOxaFnGmhuHc5IQC FRwBR3rD0LeEuAK04nhDN++9q24S2ge0Aos9c8UbCiFg2+68/3HZqfr6pyw7ImB9we8V vL/u/SBSHlrLWIKLwal4aOuT9une06mcQV0X8sRp48hBDrxjVOQGhhp99YNXkhEYXhwH cO8+3WdFLjCh0rN1O28tor+rtzsNXOGbM5ab1+vtbfw57ycdJ1TMCUxMHQNwpl0Di3rh Oi/NiRQ6GJZogfJQW8yX34gUsmPTWzoSvuCzQeyixE7pHbgfP7D8KvvBlSDBGRBxA8FR 66Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697641752; x=1698246552; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jogBxdV7pHz2gfvZNihmsonb7ki8c6/55lHvlnc/Vk8=; b=jBEU26dPwNVeI55YmfOtqCNV6O10aye9MeJzAITSWJyZ5SgX1rrPe0Z0p15Z6uXcBL o1F+IAGFCikylGGrd9HsMHEtvnEwggKkpDznDup0egWnbFGhnITxp5ovDhsIzT+vL7od cQUQStv/SXbF1/GzWz703ndv/D0s91H5jAgQHBD7jQ/Wj5STW3jELLgMJ86W5yglT5JF TWb3m3c7D1p8Pv1s8vou7cBQNhm+Nb4WcGHNULrOdyhiEP46mkfNAgXcG4fjv9PARa9B NV6lGWA0VBUo5p/JUfOmlxPAoNebkq+VQgwpggpCJwFOmEM/71a0DyHdv1QMbnHGWNhg QHZQ== X-Gm-Message-State: AOJu0Yz1KV7sf4V7TD7sIPMP2Qpetr3q8VxdCv6wEZzQkNDCLTf5cLfj 0axb5ppZ7pqVD1eGL1/PBTETt/vyymE= X-Google-Smtp-Source: AGHT+IFinVB3fUSW4rzj27zzr6kv055gmZyKjoME8Q/shCC0VHk/ni9I6qk8HOonJWmaJ83SU5g++Q== X-Received: by 2002:a05:651c:115:b0:2bc:d505:2bf3 with SMTP id a21-20020a05651c011500b002bcd5052bf3mr4312525ljb.1.1697641752011; Wed, 18 Oct 2023 08:09:12 -0700 (PDT) Received: from localhost.localdomain ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id r4-20020a05600c35c400b0040531f5c51asm1953260wmq.5.2023.10.18.08.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 08:09:09 -0700 (PDT) From: Simon Tournier To: guix-patches@gnu.org Subject: [PATCH 0/1] services: admin: Export rottlog-configuration accessors. Date: Wed, 18 Oct 2023 17:08:59 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Debbugs-CC: Yann Dupont Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::235; envelope-from=zimon.toutoune@gmail.com; helo=mail-lj1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, In some cases, people have a template configuration, and then another configuration with some specific ’log-rotation’ files. Then, they want to custom-merge these configurations. Therefore, they need to access field values of . For one trivial example: replace ’log-rotation’ of syslog defined with %rotated-files by some others – do not ask why. :-) --8<---------------cut here---------------start------------->8--- (use-modules (gnu services base) (gnu services admin) (srfi srfi-1)) (define config-template (rottlog-configuration)) (define some-logs (list (log-rotation (files '("/var/log/foo" "/var/log/bar" "/var/log/baz")) (frequency 'weekly) (options `("rotate 16" "sharedscripts" ,@%default-log-rotation-options))) (log-rotation (files '("/var/log/some-evil.log")) (options `("rotate 4" ,@%default-log-rotation-options))))) (define other-config (rottlog-configuration (rotations some-logs))) (define my-config (rottlog-configuration (inherit config-template) (rotations (filter (lambda (log) (not (lset= eq? (log-rotation-files log) %rotated-files))) (append-map rottlog-configuration-rotations (list other-config config-template)))))) --8<---------------cut here---------------end--------------->8--- Without this patch, it needs to rely on ’@@’ which is not nice. --8<---------------cut here---------------start------------->8--- (define rottlog-configuration-rotations (@@ (gnu services admin) rottlog-rotations)) --8<---------------cut here---------------end--------------->8--- Therefore, let export them! To stay consistent with the schema for naming, the accessors are renamed rottlog-configuration- Cheers, simon Simon Tournier (1): services: admin: Export rottlog-configuration accessors. gnu/services/admin.scm | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) base-commit: 202c97c4ce2e948266b8b6ee4d80631adbfba92b -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 11:10:53 2023 Received: (at 66609) by debbugs.gnu.org; 18 Oct 2023 15:10:53 +0000 Received: from localhost ([127.0.0.1]:34445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt8CD-0003ga-3h for submit@debbugs.gnu.org; Wed, 18 Oct 2023 11:10:53 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:39315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt8CA-0003gK-ML for 66609@debbugs.gnu.org; Wed, 18 Oct 2023 11:10:52 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3175e1bb38cso639040f8f.1 for <66609@debbugs.gnu.org>; Wed, 18 Oct 2023 08:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697641819; x=1698246619; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sP7OoyOBP/GnSXlxZ6XBnr9Uc8Mj9yzK3/j+z9HJInY=; b=TbiYuKjjtRDcnMebjDAfidGoBKU5HncHX6fWOcwMWANaBkqhZk7sVW1KHdcvxTijUi noIguqnQ+D4423i8VnOpNloWQTWaxu1A2+xMMc7YvoBpCwj8wT6ycOgCNpqKDN7VWPQu ZJVM5b98OhDCf58WIL1BKYhKUlExiUFiimjJ29rMj0qTgiBOESvMo3MZgF4GozGomhNv O+IKbA+43PvXBJqndXu+IXnFA1AepzNkKF2r1wA80D9TKrL0fI4L5zMdbdo8Xl+BLe76 MNEVj+I2ceGij6hZGnCtEUNeINS6XTgWeTfWaEkC4vrSUyvjJCdcUKpUcvqADRMMXr6J n4qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697641819; x=1698246619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sP7OoyOBP/GnSXlxZ6XBnr9Uc8Mj9yzK3/j+z9HJInY=; b=ldDfIycVNIeKUn4MQvBcHkytVgOGuv3Uz541NtOqb8xiU6obWo0rlZRhi+9vg4W494 KHRVIK/E913iCmBF9LmIQuh4gsSrKbcKY6PUbeEHLFVB3gdLaaVPuGqD5dUoutSIrJE7 2iav59Fy0igkj+da1A0QASm5LKcOPDnZotiZts9wCS34IqVrfIUD0/uCBDgi6sS31D5b Khnfc4H+G7U++TemUTdGIp5+aDHX0xzDA5U9FdFICI5HdyY099BLN8F7kQIbC5tSjheP FtlyltUvKlP4GQoUOs7oNBzrMYFFnccVq8AnYuKaaeFhNC9DTZ9ItlpSNBq0Z10HSHcR kH/g== X-Gm-Message-State: AOJu0YwtTubNbglO09Ujb2N6dK4PiG0nIgPFqAFziK2D0q/Poi8q1XXh XK/7c73QjYFl9yTgFmYTJcz03FShFbg= X-Google-Smtp-Source: AGHT+IHcNwA2i9E8TAXbJoyTSHLzBrj8uTlH5wKpNp6m6NIIbNZpz+VQMmdgQm53Nh/5La7U9OiOpw== X-Received: by 2002:adf:a112:0:b0:32d:a860:324e with SMTP id o18-20020adfa112000000b0032da860324emr4203221wro.3.1697641818497; Wed, 18 Oct 2023 08:10:18 -0700 (PDT) Received: from localhost.localdomain ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id j14-20020adfea4e000000b0032d81837433sm2368314wrn.30.2023.10.18.08.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 08:10:17 -0700 (PDT) From: Simon Tournier To: 66609@debbugs.gnu.org Subject: [PATCH 1/1] services: admin: Export rottlog-configuration accessors. Date: Wed, 18 Oct 2023 17:10:09 +0200 Message-Id: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66609 Cc: Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/admin.scm (): Rename accessors rottlog-rottlog to rottlog-configuration-rottlog, rottlog-rc-file to rottlog-configuration-rc-file, rottlog-rotations to rottlog-configuration-rotations, rottlog-jobs to rottlog-configuration-jobs. (rottlog-etc, rottlog-jobs-or-default, rottlog-service-type): Adjust accordingly. --- gnu/services/admin.scm | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/gnu/services/admin.scm b/gnu/services/admin.scm index 5cf74c6e4d..ce27f7f7d3 100644 --- a/gnu/services/admin.scm +++ b/gnu/services/admin.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2016-2023 Ludovic Courtès ;;; Copyright © 2020 Brice Waegeneire ;;; Copyright © 2023 Giacomo Leidi +;;; Copyright © 2023 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -52,6 +53,10 @@ (define-module (gnu services admin) rottlog-configuration rottlog-configuration? + rottlog-configuration-rottlog + rottlog-configuration-rc-file + rottlog-configuration-rotations + rottlog-configuration-jobs rottlog-service rottlog-service-type @@ -193,25 +198,25 @@ (define (default-jobs rottlog) (define-record-type* rottlog-configuration make-rottlog-configuration rottlog-configuration? - (rottlog rottlog-rottlog ;file-like + (rottlog rottlog-configuration-rottlog ;file-like (default rottlog)) - (rc-file rottlog-rc-file ;file-like + (rc-file rottlog-configuration-rc-file ;file-like (default (file-append rottlog "/etc/rc"))) - (rotations rottlog-rotations ;list of + (rotations rottlog-configuration-rotations ;list of (default %default-rotations)) - (jobs rottlog-jobs ;list of + (jobs rottlog-configuration-jobs ;list of (default #f))) (define (rottlog-etc config) `(("rottlog" ,(file-union "rottlog" - (cons `("rc" ,(rottlog-rc-file config)) + (cons `("rc" ,(rottlog-configuration-rc-file config)) (log-rotations->/etc-entries - (rottlog-rotations config))))))) + (rottlog-configuration-rotations config))))))) (define (rottlog-jobs-or-default config) - (or (rottlog-jobs config) - (default-jobs (rottlog-rottlog config)))) + (or (rottlog-configuration-jobs config) + (default-jobs (rottlog-configuration-rottlog config)))) (define rottlog-service-type (service-type @@ -226,12 +231,12 @@ (define rottlog-service-type ;; Add Rottlog to the global profile so users can access ;; the documentation. (service-extension profile-service-type - (compose list rottlog-rottlog)))) + (compose list rottlog-configuration-rottlog)))) (compose concatenate) (extend (lambda (config rotations) (rottlog-configuration (inherit config) - (rotations (append (rottlog-rotations config) + (rotations (append (rottlog-configuration-rotations config) rotations))))) (default-value (rottlog-configuration)))) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 11:45:20 2023 Received: (at 66609) by debbugs.gnu.org; 18 Oct 2023 15:45:20 +0000 Received: from localhost ([127.0.0.1]:34500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt8jY-0004wM-4O for submit@debbugs.gnu.org; Wed, 18 Oct 2023 11:45:20 -0400 Received: from smtpmciv2.myservices.hosting ([185.26.107.238]:45462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt8jS-0004w7-Va for 66609@debbugs.gnu.org; Wed, 18 Oct 2023 11:45:18 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv2.myservices.hosting (Postfix) with ESMTP id 161A320D9C; Wed, 18 Oct 2023 17:44:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 71F538009A; Wed, 18 Oct 2023 17:44:36 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jtlBios1YMbQ; Wed, 18 Oct 2023 17:44:36 +0200 (CEST) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id ED92780099; Wed, 18 Oct 2023 17:44:35 +0200 (CEST) Message-ID: <405466f7-f78d-437c-ac9f-bea54e22e91c@makinata.eu> Date: Wed, 18 Oct 2023 16:44:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Bruno Victal Subject: Re: [bug#66609] [PATCH 1/1] services: admin: Export rottlog-configuration accessors. To: Simon Tournier References: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com> Content-Language: en-US In-Reply-To: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66609 Cc: 66609@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, On 2023-10-18 16:10, Simon Tournier wrote: > * gnu/services/admin.scm (): Rename accessors > rottlog-rottlog to rottlog-configuration-rottlog, rottlog-rc-file to > rottlog-configuration-rc-file, rottlog-rotations to > rottlog-configuration-rotations, rottlog-jobs to rottlog-configuration-jobs. > (rottlog-etc, rottlog-jobs-or-default, rottlog-service-type): Adjust > accordingly. […] > +;;; Copyright © 2023 Simon Tournier The changes don't look original enough to warrant this IMO, other than that it LGTM. -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 20 18:22:31 2023 Received: (at 66609) by debbugs.gnu.org; 20 Oct 2023 22:22:31 +0000 Received: from localhost ([127.0.0.1]:41816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtxt1-000053-8q for submit@debbugs.gnu.org; Fri, 20 Oct 2023 18:22:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtxsz-0008WU-Is for 66609@debbugs.gnu.org; Fri, 20 Oct 2023 18:22:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtxsS-0006uj-Qj; Fri, 20 Oct 2023 18:21:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=GMl+asf/CQumdkoeDwcbw+fSwtgoPNV+K1RDgiEHWi8=; b=o9yAYbCFkgBNq9PB4s62 HFCPE/5+V58rqT/uEoaM4lnZE8qEkx9TgypWtMnyrcNa9ZaUfZ2H0g0sl3Q3KcbQIVBF2t1Nq1ctq wvLjGQaCM1pTuhDKOMcfMA/er/wrRo7VGvgKoRih2Za/hEqFQTXizB4r+ZvrS/Avxu22KIA15KCRV YdlPhD59OqJ9hYh0KKg9LIPVebR0CSleMoS3kjNmovxclQb6gZmqiLOk/hGEEx2KOFO+8abGPL6IE TbV4BlOLocp4PblMIlA7jsM4OHByNeqMnh1G77ohcrIHWgcxv/CMcLOLdpJzNxAG9nBlfvj3NHXHZ +sdXePls1CC1Rg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: [bug#66609] [PATCH 1/1] services: admin: Export rottlog-configuration accessors. In-Reply-To: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com> (Simon Tournier's message of "Wed, 18 Oct 2023 17:10:09 +0200") References: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com> Date: Sat, 21 Oct 2023 00:21:55 +0200 Message-ID: <87ttqlrl30.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66609 Cc: 66609@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Simon Tournier skribis: > * gnu/services/admin.scm (): Rename accessors > rottlog-rottlog to rottlog-configuration-rottlog, rottlog-rc-file to > rottlog-configuration-rc-file, rottlog-rotations to > rottlog-configuration-rotations, rottlog-jobs to rottlog-configuration-jo= bs. > (rottlog-etc, rottlog-jobs-or-default, rottlog-service-type): Adjust > accordingly. LGTM! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 14:14:32 2023 Received: (at 66609-done) by debbugs.gnu.org; 24 Oct 2023 18:14:32 +0000 Received: from localhost ([127.0.0.1]:56579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvLvD-0008Gw-PS for submit@debbugs.gnu.org; Tue, 24 Oct 2023 14:14:32 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:38944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvLuu-0008Fw-9c for 66609-done@debbugs.gnu.org; Tue, 24 Oct 2023 14:14:13 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-408423fc784so4505555e9.0 for <66609-done@debbugs.gnu.org>; Tue, 24 Oct 2023 11:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698171217; x=1698776017; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=RIVhy2ZT8ZUW+nk+Ze+x25TkOzpw8ijfFbFWWl3Lf2Q=; b=ROw3dBFgH0nYYLjI1qTcbOfANm1f1UOiG/SeMHxxTM2ciuKJnHBv7uu1bEp9Ea76s4 gUZ7lqSzeCjSfCqEEiYrJg4v3KeejKcxreuMZSAVWJx9Tuds9t5DAex738/b7XV1+s6J OfUR2QWaTGJdAyc1O+ZvbrQHe/LSMRH5IY2rDyZtyLuI/d3G7mfVyvMxRh62VbcAI9La 42vzcDLBnMK8jdu2gEtqUWfQ5kcgjpxOTkwqH0HZJ6dMUy3SeebJvIDSZXHeCvh2R8GF TMCF8z9manlpdarWKIqTVVAE/CxSAF8Ay3/0+DOSJNMBUZeLMwhhL7wx1roODKu3YLbn +RcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698171217; x=1698776017; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RIVhy2ZT8ZUW+nk+Ze+x25TkOzpw8ijfFbFWWl3Lf2Q=; b=dhIxV4PxJdm0PJpd2sxRW7QX3xTPXCEIjmL9jA08phPm8o5XuZH0KshFwUcCUekT89 5RGiwKmkwPPPCKgA/YtdKXwFsF7D+ua1D7d4uoIdUeAhQWhzbwZykSqtfgmFhEEpWt3c osnbqGR4IQKMaEvT7N/q1+rD4kEdjNl+AR5kgpLcVmKi13P7blHj7YFy88XizzSXHqIK ngzvItYn4oLBHDg4R2ItHzKZcTCQsNpSstja0dcZdAeEjoCKcsThbP1aoEY6Ife70pY7 I7ockMIVxYTQnnOc0Uys4edtAYajjVgzVy27soHoFrXzqyql5E+uEJfSWA28d0KSr5kN e8xg== X-Gm-Message-State: AOJu0Yzxy07wDjeWsIajPvB/gr8ka0j1S4Ryt+rtji3iaAGnFVxvWeza wLu4pM3ECTkJhpuZIhuZwM+ffzDoR70= X-Google-Smtp-Source: AGHT+IF1IMPK9SDLCosAfwkA1uXiYeiVkiMje8Z1LzHKLabxWz472eOkcpYw6DBf3jI72VGdSWRpUQ== X-Received: by 2002:a5d:6349:0:b0:32d:e435:92c4 with SMTP id b9-20020a5d6349000000b0032de43592c4mr9507973wrw.0.1698171216661; Tue, 24 Oct 2023 11:13:36 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id c14-20020adfe74e000000b0032d72f48555sm10402209wrn.36.2023.10.24.11.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 11:13:36 -0700 (PDT) From: Simon Tournier To: Bruno Victal , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#66609] [PATCH 1/1] services: admin: Export rottlog-configuration accessors. In-Reply-To: <405466f7-f78d-437c-ac9f-bea54e22e91c@makinata.eu> References: <68b1665bd37417da822cd5ca1156f03225aa0e2c.1697641168.git.zimon.toutoune@gmail.com> <405466f7-f78d-437c-ac9f-bea54e22e91c@makinata.eu> Date: Tue, 24 Oct 2023 18:56:13 +0200 Message-ID: <87edhkhscy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66609-done Cc: 66609-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Wed, 18 Oct 2023 at 16:44, Bruno Victal wrote: > The changes don't look original enough to warrant this IMO, other > than that it LGTM. Thanks Bruno and Ludo. Pushed as 7e4324575c. Closing. Cheers, simon From unknown Wed Jun 18 23:12:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Nov 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator