GNU bug report logs - #66606
[PATCH] gnu: Add reduce-csl.

Previous Next

Full log

Message #14 received at 66606 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Nigko Yerden <nigko.yerden <at> gmail.com>
Cc: 66606 <at> debbugs.gnu.org, efraim <at> flashner.co.il, bavier <at> posteo.net
Subject: [PATCH v3] gnu: Add reduce-csl.
Date: Fri, 7 Feb 2025 10:40:31 +0100

[Message part 1 (text/plain, inline)]

Hello,

Am Thu, Feb 06, 2025 at 09:40:11PM +0500 schrieb Nigko Yerden:
> I rewrote this old patch. New patch provides
> 1. Updated package revision number 6860 (was 6547).
> 2. Apparent reproducibility of the package.
> 3. 'check' build phase for running tests.
> 4. Unbundled libffi.

thanks for sending the new patch, and so quickly; I did not expect
unbundling of libffi to require so much work! And running tests is also
good.

I have moved the package from the maths to the algebra module (which is
more specific). The patch needs to be registered in local.mk.

I would also suggest to use the snapshot date and not the svn commit as
the version number, since it is more telling (and also appears "higher
up" in the file hierarchy on their site).
And maybe call the package just "reduce" instead of "reduce-csl"?
I wondered whether we should also compile with psl (using "--with-both"
instead of "--with-csl"); but I suppose that this would just create a
duplicate?

It is a bit surprising to first use "--without-autogen" and then call
autogen in a separate phase, but I tried to drop both, and this caused
an error.

The package compiles, and I could run reduce with a few of the examples
from their website.

Are you okay with the patch as attached, or would you prefer to handle
differently some changes I made?

Andreas

[0001-gnu-Add-reduce.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.