GNU bug report logs - #66605
[PATCH] etc: gitconfig: Run etc/teams.scm from correct environment.

Previous Next

Package: guix-patches;

Reported by: Clément Lassieur <clement <at> lassieur.org>

Date: Wed, 18 Oct 2023 12:07:02 UTC

Severity: normal

Tags: moreinfo, patch

Merged with 66616, 66617

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Clément Lassieur <clement <at> lassieur.org>
Subject: bug#66605: closed (Re: [bug#66605] [PATCH v5] teams: Adjust
 shebang to use 'guix repl'.)
Date: Mon, 23 Oct 2023 00:41:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#66605: [PATCH] etc: gitconfig: Run etc/teams.scm from correct environment.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66605 <at> debbugs.gnu.org.

-- 
66605: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66605
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 66605-done <at> debbugs.gnu.org
Subject: Re: [bug#66605] [PATCH v5] teams: Adjust shebang to use 'guix repl'.
Date: Sun, 22 Oct 2023 20:39:37 -0400
Hi,

Clément Lassieur <clement <at> lassieur.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> This ensures the correct Guix dependencies are always available for the
>> script.
>>
>> * etc/teams.scm.in: Rename to...
>> * etc/teams.scm: ... this.  Adjust shebang.
>> * .gitignore: No longer ignore it.
>> * configure.ac: Do not process it with AC_CONFIG_FILES.
>>
>> Fixes: https://issues.guix.gnu.org/66605
>> ---
>
> Sounds good to me!  Of course, please commit it as your own.
>
> Thank you very much,
> Clément

Done!  Thanks for the report!

-- 
Thanks,
Maxim

[Message part 3 (message/rfc822, inline)]
From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Cc: Clément Lassieur <clement <at> lassieur.org>
Subject: [PATCH] etc: gitconfig: Run etc/teams.scm from correct environment.
Date: Wed, 18 Oct 2023 14:05:19 +0200
* etc/git/gitconfig: Prepend "guix shell -D guix --pure ./pre-inst-env" to the
etc/teams.scm script so that any user that have git:send-email installed can
use it in the Guix checkout without changing their environment.
---
 etc/git/gitconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/git/gitconfig b/etc/git/gitconfig
index 907ad0180454..757360220155 100644
--- a/etc/git/gitconfig
+++ b/etc/git/gitconfig
@@ -14,5 +14,5 @@
 
 [sendemail]
         to = guix-patches <at> gnu.org
-        headerCmd = etc/teams.scm cc-members-header-cmd
+        headerCmd = guix shell -D guix --pure -- ./pre-inst-env etc/teams.scm cc-members-header-cmd
         thread = no

base-commit: 5498835bb38c0de57f284f0fa6b1178ecdcaf678
prerequisite-patch-id: d95e49e4fc059972fc5a7b2c92816df2228a0af1
prerequisite-patch-id: a0dca8c3175d6ce71c77e220c4ac98b6e97cef56
-- 
2.41.0




This bug report was last modified 1 year and 264 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.