GNU bug report logs - #66597
[PATCH] gnu: Add sdl2-gamecontrollerdb.

Previous Next

Full log

Message #8 received at 66597 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Cc: 66597 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add sdl2-gamecontrollerdb.
Date: Tue, 17 Oct 2023 22:04:16 +0200

Once more for the mailing list…

Am Dienstag, dem 17.10.2023 um 19:10 +0300 schrieb Evgeny Pisemsky:
> * gnu/packages/game-development.scm (sdl2-gamecontrollerdb): New
> variable.
> ---
>  gnu/packages/game-development.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> developm=
> ent.scm
> index eb1d74d1e1..3400ca03dc 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -29,6 +29,7 @@
>  ;;; Copyright =C2=A9 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
>  ;;; Copyright =C2=A9 2022 dan <i <at> dan.games>
>  ;;; Copyright =C2=A9 2023 John Kehayias
> <john.kehayias <at> protonmail.com>
> +;;; Copyright =C2=A9 2023 Evgeny Pisemsky <evgeny <at> pisemsky.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -56,6 +57,7 @@ (define-module (gnu packages game-development)
>    #:use-module (guix svn-download)
>    #:use-module (guix utils)
>    #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system copy)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system scons)
> @@ -3283,3 +3285,29 @@ (define-public bbcsdl
>  allowing you to write utilities and games, use sound and graphics,
> perform
>  calculations and create complete applications.")
>      (license license:zlib)))
This appears to be at the end of the file.  We typically prefer
somewhere in the middle (makes it harder to break the diffs),
especially if there's a topical fit.
> +
> +(define-public sdl2-gamecontrollerdb
> +  (let ((commit "6f3c4edcb5a2e2ed090ca8af40d2c0f00dcd77f6")
> +        (revision "0"))
> +    (package
> +      (name "sdl2-gamecontrollerdb")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url
> "https://github.com/gabomdq/SDL_GameControllerDB")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "1gciqc8qm2qgcjj5s9jpclznznsp6awl4ldrnj7g01chkcx0l6a3"))=
> ))
> +      (build-system copy-build-system)
> +      (arguments
> +       '(#:install-plan '(("gamecontrollerdb.txt"
> +                           "share/sdl2-gamecontrollerdb/"))))
Is this destination documented somewhere?  Or should we just do
"/share/sdl2/" instead?
> +      (home-page "https://github.com/gabomdq/SDL_GameControllerDB")
> +      (synopsis "SDL2 game controller database")
> +      (description
> +       "A community sourced database of game controller mappings to
> be used
> +with SDL2 Game Controller functionality.")
The description a full sentence.  Often, we simply cheat with "this
package provides…"
> +      (license license:zlib))))
> 
> base-commit: 018567adb7b2d31d0bd457983b755ec3063d08c6
> --=20
> 2.41.0
Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.