Subject: [bug#66586] [PATCH] gnu: lvm2: Remove systemd rule.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 23 Oct 2023 23:52:05 +0200

Hi!

Simon Tournier <[email-masked]> skribis:

> From: Yann Dupont <[email-masked]>
>
> Fixes <https://issues.guix.gnu.org/65177>.
> Reported by Adrien 'neox' Bourmault <[email-masked]>.
>
> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
> * gnu/local.mk: Register new patch.

One minor nit:

> +++ b/gnu/packages/patches/lvm2-no-systemd.patch
> @@ -0,0 +1,22 @@
> +Fixes <https://issues.guix.gnu.org/65177>.
> +
> +Since lvm2 2.03.14, the included udev rules use systemd-run to run vgchange
> +and activate the volume group.  lvm2 was updated recently from 2.03.11 to
> +2.03.21, then 2.03.22, and probably started exhibiting this behavior then.  It
> +removes the indirection through systemd-run and directly run vgchange.

I propose to change this paragraph so that it is self-contained, like:

  Run ‘vgchange’ directly instead of attempting to run it via
  ‘systemd-run’ as the udev rules included in lvm2 >= 2.03.14 do.

LGTM with a change along these lines!

Ludo’.