Subject: bug#66569: closed (Re: bug#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 25 Oct 2023 13:29:02 +0000

Your bug report

#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
66569: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66569
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#66569: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example
From: Eli Zaretskii <[email-masked]>
To: Matthew Woodcraft <[email-masked]>
Cc: [email-masked]
Date: Wed, 25 Oct 2023 16:27:38 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Matthew Woodcraft <[email-masked]>
> Date: Sun, 15 Oct 2023 20:00:37 +0100
> 
> The example in the eglot.texi "JSONRPC objects in Elisp" page has some
> mistakes:
> 
>  - the input is wrongly parenthesised for the intended output
> 
>  - the serialised JSON text shows some trailing commas which are not in
>    fact generated

Thanks, installed on the emacs-29 branch, and closing the bug.

Subject: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example
From: Matthew Woodcraft <[email-masked]>
To: [email-masked]
Date: Sun, 15 Oct 2023 20:00:37 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Tags: patch

The example in the eglot.texi "JSONRPC objects in Elisp" page has some
mistakes:

 - the input is wrongly parenthesised for the intended output

 - the serialised JSON text shows some trailing commas which are not in
   fact generated

>From a1a32a498e8c97775611cf04fc46d30d909e4200 Mon Sep 17 00:00:00 2001
From: Matthew Woodcraft <[email-masked]>
Date: Sun, 15 Oct 2023 19:50:26 +0100
Subject: [PATCH] Fix eglot.texi (JSONRPC objects in Elisp) example

* doc/misc/eglot.texi (JSONRPC objects in Elisp): Correct the example
---
 doc/misc/eglot.texi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/misc/eglot.texi b/doc/misc/eglot.texi
index 3c1d44cd363..9ffea80b641 100644
--- a/doc/misc/eglot.texi
+++ b/doc/misc/eglot.texi
@@ -1237,8 +1237,8 @@ JSONRPC objects in Elisp
 @lisp
 (:pylsp (:plugins (:jedi_completion (:include_params t
                                      :fuzzy t
-                                     :cache_for ["pandas" "numpy"]
-                   :pylint (:enabled :json-false))))
+                                     :cache_for ["pandas" "numpy"])
+                   :pylint (:enabled :json-false)))
  :gopls (:usePlaceholders t))
 @end lisp
 
@@ -1252,7 +1252,7 @@ JSONRPC objects in Elisp
       "jedi_completion": @{
         "include_params": true,
         "fuzzy": true,
-        "cache_for": [ "pandas", "numpy" ],
+        "cache_for": [ "pandas", "numpy" ]
       @},
       "pylint": @{
         "enabled": false
@@ -1260,8 +1260,8 @@ JSONRPC objects in Elisp
     @}
   @},
   "gopls": @{
-    "usePlaceholders":true
-  @},
+    "usePlaceholders": true
+  @}
 @}
 @end example
 
-- 
2.39.2